)]}'
{"cliff/commandmanager.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"dce5a8015d8d3fd68334c1cc9ed1a3366a300164","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                return i"},{"line_number":147,"context_line":"        return len(argv)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def add_command_group(self, group\u003dNone):"},{"line_number":150,"context_line":"        \"\"\"Adds another group of command entrypoints\"\"\""},{"line_number":151,"context_line":"        if group:"},{"line_number":152,"context_line":"            self.load_commands(group)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff570b3c_45e19b2a","line":149,"updated":"2020-06-09 08:40:38.000000000","message":"nit: why support None? Oo\n\nmore importantly, the words \u0027namespace\u0027 and \u0027group\u0027 seems to be used as synonyms. Maybe settle down on only one?","commit_id":"8477c4dbd0cf651b9b4ba4a4934de69d5942bfc2"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"00215cfbcce8edc1c8db2d58f91b553a74189f9e","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                return i"},{"line_number":147,"context_line":"        return len(argv)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def add_command_group(self, group\u003dNone):"},{"line_number":150,"context_line":"        \"\"\"Adds another group of command entrypoints\"\"\""},{"line_number":151,"context_line":"        if group:"},{"line_number":152,"context_line":"            self.load_commands(group)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff570b3c_3ff3cfe9","line":149,"in_reply_to":"ff570b3c_45e19b2a","updated":"2020-06-09 14:02:24.000000000","message":"There actually is a difference between them - it might become more clear in the next patch. But more to the point - this is a direct import of the code from osc-lib so that we can drop the subclass from there. Changing the interface would make that harder.","commit_id":"8477c4dbd0cf651b9b4ba4a4934de69d5942bfc2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"dce5a8015d8d3fd68334c1cc9ed1a3366a300164","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        group_list \u003d []"},{"line_number":161,"context_line":"        if group is not None:"},{"line_number":162,"context_line":"            for ep in pkg_resources.iter_entry_points(group):"},{"line_number":163,"context_line":"                cmd_name \u003d ("},{"line_number":164,"context_line":"                    ep.name.replace(\u0027_\u0027, \u0027 \u0027)"},{"line_number":165,"context_line":"                    if self.convert_underscores"},{"line_number":166,"context_line":"                    else ep.name"},{"line_number":167,"context_line":"                )"},{"line_number":168,"context_line":"                group_list.append(cmd_name)"},{"line_number":169,"context_line":"            return group_list"},{"line_number":170,"context_line":"        return list(self.commands.keys())"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff570b3c_051cc311","line":167,"range":{"start_line":163,"start_character":0,"end_line":167,"end_character":17},"updated":"2020-06-09 08:40:38.000000000","message":"This seems a repeating snipper, move to a helper function?","commit_id":"8477c4dbd0cf651b9b4ba4a4934de69d5942bfc2"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"00215cfbcce8edc1c8db2d58f91b553a74189f9e","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        group_list \u003d []"},{"line_number":161,"context_line":"        if group is not None:"},{"line_number":162,"context_line":"            for ep in pkg_resources.iter_entry_points(group):"},{"line_number":163,"context_line":"                cmd_name \u003d ("},{"line_number":164,"context_line":"                    ep.name.replace(\u0027_\u0027, \u0027 \u0027)"},{"line_number":165,"context_line":"                    if self.convert_underscores"},{"line_number":166,"context_line":"                    else ep.name"},{"line_number":167,"context_line":"                )"},{"line_number":168,"context_line":"                group_list.append(cmd_name)"},{"line_number":169,"context_line":"            return group_list"},{"line_number":170,"context_line":"        return list(self.commands.keys())"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff570b3c_9f001bae","line":167,"range":{"start_line":163,"start_character":0,"end_line":167,"end_character":17},"in_reply_to":"ff570b3c_051cc311","updated":"2020-06-09 14:02:24.000000000","message":"++","commit_id":"8477c4dbd0cf651b9b4ba4a4934de69d5942bfc2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"dce5a8015d8d3fd68334c1cc9ed1a3366a300164","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                )"},{"line_number":168,"context_line":"                group_list.append(cmd_name)"},{"line_number":169,"context_line":"            return group_list"},{"line_number":170,"context_line":"        return list(self.commands.keys())"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff570b3c_a5d0772d","line":170,"updated":"2020-06-09 08:40:38.000000000","message":"nit: keys() not needed","commit_id":"8477c4dbd0cf651b9b4ba4a4934de69d5942bfc2"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"00215cfbcce8edc1c8db2d58f91b553a74189f9e","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                )"},{"line_number":168,"context_line":"                group_list.append(cmd_name)"},{"line_number":169,"context_line":"            return group_list"},{"line_number":170,"context_line":"        return list(self.commands.keys())"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff570b3c_df2bb330","line":170,"in_reply_to":"ff570b3c_a5d0772d","updated":"2020-06-09 14:02:24.000000000","message":"Ooh, good point.","commit_id":"8477c4dbd0cf651b9b4ba4a4934de69d5942bfc2"}]}