)]}'
{"cliff/app.py":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"b3ef51f6a50f9937d40e7bf291ed8ecc9ce9214d","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        except KeyboardInterrupt:"},{"line_number":280,"context_line":"            return 130"},{"line_number":281,"context_line":"        result \u003d 1"},{"line_number":282,"context_line":"        try:"},{"line_number":283,"context_line":"            if self.interactive_mode:"},{"line_number":284,"context_line":"                result \u003d self.interact()"},{"line_number":285,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_32938251","line":282,"range":{"start_line":282,"start_character":8,"end_line":282,"end_character":11},"updated":"2020-09-08 17:46:56.000000000","message":"Since that would never be thrown by self.interact (it handles KeyboardInterrupt in a different way), I think this try should be only at the self.run_subcommand level.","commit_id":"c946c5a80ade8c9c652641410577f6cdc22d7a01"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"b3ef51f6a50f9937d40e7bf291ed8ecc9ce9214d","unresolved":false,"context_lines":[{"line_number":427,"context_line":"                    self.LOG.exception(err2)"},{"line_number":428,"context_line":"                else:"},{"line_number":429,"context_line":"                    self.LOG.error(\u0027Could not clean up: %s\u0027, err2)"},{"line_number":430,"context_line":"            del err"},{"line_number":431,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_72ab3a87","line":430,"range":{"start_line":430,"start_character":12,"end_line":430,"end_character":19},"updated":"2020-09-08 17:46:56.000000000","message":"nit: I don\u0027t think you need this del here since the execution flow for this method ends at this point","commit_id":"c946c5a80ade8c9c652641410577f6cdc22d7a01"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"a72cf01bed5ac2b5d71bd63572d9863feacae2a5","unresolved":false,"context_lines":[{"line_number":427,"context_line":"                    self.LOG.exception(err2)"},{"line_number":428,"context_line":"                else:"},{"line_number":429,"context_line":"                    self.LOG.error(\u0027Could not clean up: %s\u0027, err2)"},{"line_number":430,"context_line":"            del err"},{"line_number":431,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_8a75e59a","line":430,"range":{"start_line":430,"start_character":12,"end_line":430,"end_character":19},"in_reply_to":"9f560f44_72ab3a87","updated":"2020-09-09 14:51:43.000000000","message":"Storing an exception in a local variable tends to cause a reference loop that requires garbage collection, since the exception\u0027s traceback usually references the stack frame that contains the local variable. We delete it to break the reference loop and help ensure that as much of the heap as possible can be deleted by reference counting without resorting to garbage collection.","commit_id":"c946c5a80ade8c9c652641410577f6cdc22d7a01"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"c64998a86544782d9383a89e942aa3f98b3c7ac3","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                self.LOG.error(err)"},{"line_number":278,"context_line":"            return 1"},{"line_number":279,"context_line":"        except KeyboardInterrupt:"},{"line_number":280,"context_line":"            return 130"},{"line_number":281,"context_line":"        result \u003d 1"},{"line_number":282,"context_line":"        if self.interactive_mode:"},{"line_number":283,"context_line":"            result \u003d self.interact()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_f2e9ee19","line":280,"updated":"2020-09-09 21:04:35.000000000","message":"I wouldn\u0027t know what this magic number is without having read your commit message. Maybe put it into a module variable, since it\u0027s used in a couple of places?","commit_id":"fe7475d6c5b8ede7fb4e41ffc320f4cbbf5b1624"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"1e55adb5c2a3d5787856071bb839fb0c70ee50af","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                self.LOG.error(err)"},{"line_number":278,"context_line":"            return 1"},{"line_number":279,"context_line":"        except KeyboardInterrupt:"},{"line_number":280,"context_line":"            return 130"},{"line_number":281,"context_line":"        result \u003d 1"},{"line_number":282,"context_line":"        if self.interactive_mode:"},{"line_number":283,"context_line":"            result \u003d self.interact()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_5ec70146","line":280,"in_reply_to":"9f560f44_f2e9ee19","updated":"2020-09-10 02:01:07.000000000","message":"Ib97cbf2c9b108932c437a6d69a6ab629244702b3","commit_id":"fe7475d6c5b8ede7fb4e41ffc320f4cbbf5b1624"}]}