)]}'
{"id":"openstack%2Fcliff~755458","triplet_id":"openstack%2Fcliff~master~Ib1775a319e8ed953cb34e3c09809b8ca7a32b947","project":"openstack/cliff","branch":"master","topic":"setuptools","hashtags":[],"change_id":"Ib1775a319e8ed953cb34e3c09809b8ca7a32b947","subject":"List setuptools under install_requires","status":"MERGED","created":"2020-10-01 09:17:26.000000000","updated":"2021-01-18 23:44:14.000000000","submitted":"2020-11-09 14:05:48.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"755458-1604930748295-422172d5","meta_rev_id":"0a3b0add315a475e844cab90c4e8961eac012856","_number":755458,"virtual_id_number":755458,"owner":{"_account_id":32479,"name":"Louis Sautier","email":"sautier.louis@gmail.com","username":"sbraz"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-11-09 14:05:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-10-29 11:40:55.000000000","_account_id":32479,"name":"Louis Sautier","email":"sautier.louis@gmail.com","username":"sbraz"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":2,"date":"2020-11-06 11:15:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":2,"date":"2020-11-09 12:44:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":32479,"name":"Louis Sautier","email":"sautier.louis@gmail.com","username":"sbraz"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"all":[{"value":0,"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":1,"date":"2020-11-09 12:44:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":32479,"name":"Louis Sautier","email":"sautier.louis@gmail.com","username":"sbraz"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"_account_id":32479,"name":"Louis Sautier","email":"sautier.louis@gmail.com","username":"sbraz"}],"CC":[{"_account_id":32057,"name":"Michał Górny","email":"mgorny@gentoo.org","username":"mgorny"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-10-01 09:17:39.000000000","updated_by":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"reviewer":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"state":"REVIEWER"},{"updated":"2020-11-06 11:15:58.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2020-11-09 12:44:04.000000000","updated_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"},{"updated":"2020-11-09 14:05:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-01-18 23:44:14.000000000","updated_by":{"_account_id":32057,"name":"Michał Górny","email":"mgorny@gentoo.org","username":"mgorny"},"reviewer":{"_account_id":32057,"name":"Michał Górny","email":"mgorny@gentoo.org","username":"mgorny"},"state":"CC"}],"messages":[{"id":"bd65c05ff31e8e6074e0402912ee9d200552e5a6","author":{"_account_id":32479,"name":"Louis Sautier","email":"sautier.louis@gmail.com","username":"sbraz"},"date":"2020-10-01 09:17:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c7227e6b7c3e674084cc7249588c790e816c8079","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2020-10-01 09:17:39.000000000","message":"Patch Set 1:\n\nCongratulations, you\u0027ve proposed your first change in OpenDev.\n\nYour submission will now be tested automatically by Zuul, our gatekeeper,\nand reviewed by other friendly developers. They will give you feedback and\nmay require you to refine it.\n\nPeople seldom get their patch approved on the first try, so don\u0027t be\nconcerned if requested to make corrections. Feel free to modify your patch\nand resubmit a new change-set.\n\nPatches often take days (and sometimes weeks) to get reviewed, so be\npatient. Don\u0027t hesitate to ask for help, and answer questions about your\nwork promptly if you can. The more you get to know reviewers and get to be\nknown by them, the smoother the review and approval process will become. The\nfastest way to accomplish this is by reviewing other proposed changes\nyourself: anybody can do it, and it\u0027s a great way to learn the code base.\n\nThanks again for participating in OpenDev, we look forward to seeing you\naround.\n\nWorkflow Guide: https://docs.openstack.org/infra/manual/developers.html","accounts_in_message":[],"_revision_number":1},{"id":"932e527ca4922452f49e5dbb0bbc49e2dd5f31e9","author":{"_account_id":32479,"name":"Louis Sautier","email":"sautier.louis@gmail.com","username":"sbraz"},"date":"2020-10-01 09:18:05.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"600e9438e25757b0f19733166b3b9a1054011ce6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-01 10:46:32.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- test-release-openstack https://zuul.opendev.org/t/openstack/build/af3de75392eb465ba4c83b92952aadbc : SUCCESS in 2m 09s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/67f4e536485f448fb58397dcd18c38e4 : SUCCESS in 1h 21m 50s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f64d6ba7afee4a29838fbc91957603f2 : SUCCESS in 5m 09s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ea51d0f2afb540fa80035cb14feea33e : SUCCESS in 3m 45s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b46d7f0577f448ffabe153b890759869 : SUCCESS in 3m 53s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b6826a6de6e044ddbe24945ddcc9330a : SUCCESS in 3m 15s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8a2648ce1bbe4ea1b14a4d5b4c3c4bd1 : SUCCESS in 3m 16s\n- cliff-tox-py37-neutronclient-tip https://zuul.opendev.org/t/openstack/build/acc2e50689b3427898f1ee8ab4d4e637 : SUCCESS in 3m 38s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/5177945a3e244852b12cb676476ca134 : SUCCESS in 5m 18s","accounts_in_message":[],"_revision_number":2},{"id":"44a53dd2a2af3fa619ad65f159a9561e33d26769","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-10-29 11:34:11.000000000","message":"Patch Set 2:\n\nIs this truly necessary? Has this been discussed anywhere?","accounts_in_message":[],"_revision_number":2},{"id":"124eb0933eea02e6df3898801e760907558d09c0","author":{"_account_id":32479,"name":"Louis Sautier","email":"sautier.louis@gmail.com","username":"sbraz"},"date":"2020-10-29 11:40:55.000000000","message":"Patch Set 2:\n\nHi,\nI am not aware of it being discussed elsewhere but failing to list it can cause QA issues for Gentoo\u0027s Python build system.\n\nEven though setuptools is used to install the package, it should be listed in runtime dependencies as well, just in case someone uninstalls it.","accounts_in_message":[],"_revision_number":2},{"id":"fda5b841a10407376e547c31a771c3ddf7aeafa4","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-11-06 11:15:58.000000000","message":"Patch Set 2: Code-Review+2\n\nFair enough. Harmless enough","accounts_in_message":[],"_revision_number":2},{"id":"358ec2f9930327a432e3ab93214c9b28b6d156a9","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2020-11-09 12:44:04.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"589bbfafb4aea55892f319207777a1b74f5c16a8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-09 12:44:15.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"3e6a53239a26eb6e95ad7a1df756b307682a86af","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-09 14:05:48.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"8bb860adc70427d851c9037fc9834fda7eb02c1d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-09 14:05:48.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- test-release-openstack https://zuul.opendev.org/t/openstack/build/ad6f9537ec5748a0a6669b424a7608e2 : SUCCESS in 3m 15s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/724035270ffe4f73b6ab7d6c01c7c4f6 : SUCCESS in 1h 18m 19s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d42c4986752741c196f3326e1161d52b : SUCCESS in 4m 55s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/447245c2cbad43e9a7506285432f251f : SUCCESS in 3m 03s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/da269cc262e14adfa4d3006c8e02c620 : SUCCESS in 3m 54s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/34695f8677c64c59a079de2854b501f7 : SUCCESS in 3m 51s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e649898dc0274a929109a6d6fcb20a8d : SUCCESS in 3m 31s\n- cliff-tox-py37-neutronclient-tip https://zuul.opendev.org/t/openstack/build/32414234bb6946bd992dcdc9bff1308b : SUCCESS in 4m 39s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/50ddbea5c5ba4c3993e457428afa0d63 : SUCCESS in 4m 29s","accounts_in_message":[],"_revision_number":2},{"id":"e6a650ecace7def8690bae591a45fe7e86e2e089","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-09 14:19:06.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/90e08d9e5ce54c00bf82b4829d6b22d5 : SUCCESS in 1m 18s","accounts_in_message":[],"_revision_number":2},{"id":"0a3b0add315a475e844cab90c4e8961eac012856","author":{"_account_id":32057,"name":"Michał Górny","email":"mgorny@gentoo.org","username":"mgorny"},"date":"2021-01-18 23:44:14.000000000","message":"Patch Set 2:\n\nThis didn\u0027t fix the problem, actually -- setuptools is still missing in egg-info/requires.txt.  I think pbr is overwriting install_requires with whatever\u0027s in requirements.txt, so setuptools should be added there.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"105a18361c33ba90015df0b894b91c5cc2e06108","revisions":{"b80f01cf522d6ab2b886409800c7342a6cd5943c":{"kind":"REWORK","_number":1,"created":"2020-10-01 09:17:26.000000000","uploader":{"_account_id":32479,"name":"Louis Sautier","email":"sautier.louis@gmail.com","username":"sbraz"},"ref":"refs/changes/58/755458/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cliff","ref":"refs/changes/58/755458/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cliff refs/changes/58/755458/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cliff refs/changes/58/755458/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cliff refs/changes/58/755458/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cliff refs/changes/58/755458/1"}}},"commit":{"parents":[{"commit":"ff4ee455773cb3a66999495ee20ba015dee722c4","subject":"Merge \"Add Python3 wallaby unit tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cliff/commit/ff4ee455773cb3a66999495ee20ba015dee722c4"}]}],"author":{"name":"Louis Sautier","email":"sautier.louis@gmail.com","date":"2020-09-30 16:24:55.000000000","tz":120},"committer":{"name":"Louis Sautier","email":"sautier.louis@gmail.com","date":"2020-10-01 09:17:11.000000000","tz":120},"subject":"List setuptools under install_requires","message":"List setuptools under install_requires\n\npkg_resources is used at runtime, making setuptools a runtime dependency.\n\nChange-Id: Ib1775a319e8ed953cb34e3c09809b8ca7a32b947\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cliff/commit/b80f01cf522d6ab2b886409800c7342a6cd5943c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cliff/commit/b80f01cf522d6ab2b886409800c7342a6cd5943c"}]},"branch":"refs/heads/master"},"105a18361c33ba90015df0b894b91c5cc2e06108":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-10-01 09:18:05.000000000","uploader":{"_account_id":32479,"name":"Louis Sautier","email":"sautier.louis@gmail.com","username":"sbraz"},"ref":"refs/changes/58/755458/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cliff","ref":"refs/changes/58/755458/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cliff refs/changes/58/755458/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cliff refs/changes/58/755458/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cliff refs/changes/58/755458/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cliff refs/changes/58/755458/2"}}},"commit":{"parents":[{"commit":"ff4ee455773cb3a66999495ee20ba015dee722c4","subject":"Merge \"Add Python3 wallaby unit tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cliff/commit/ff4ee455773cb3a66999495ee20ba015dee722c4"}]}],"author":{"name":"Louis Sautier","email":"sautier.louis@gmail.com","date":"2020-09-30 16:24:55.000000000","tz":120},"committer":{"name":"Louis Sautier","email":"sautier.louis@gmail.com","date":"2020-10-01 09:17:36.000000000","tz":120},"subject":"List setuptools under install_requires","message":"List setuptools under install_requires\n\npkg_resources is used at runtime, making setuptools a runtime\ndependency.\n\nChange-Id: Ib1775a319e8ed953cb34e3c09809b8ca7a32b947\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cliff/commit/105a18361c33ba90015df0b894b91c5cc2e06108"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cliff/commit/105a18361c33ba90015df0b894b91c5cc2e06108"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}