)]}'
{"cliff/tests/test_help.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"20f58db5cd0cfd4bc00b8821b412cd9c81735c22","unresolved":true,"context_lines":[{"line_number":101,"context_line":"        help_text \u003d stdout.getvalue()"},{"line_number":102,"context_line":"        basecommand \u003d os.path.split(sys.argv[0])[1]"},{"line_number":103,"context_line":"        self.assertIn(\u0027usage: %s [--version]\u0027 % basecommand, help_text)"},{"line_number":104,"context_line":"        self.assertRegex(help_text, \u0027option.*:\\n  --version\u0027)"},{"line_number":105,"context_line":"        expected \u003d ("},{"line_number":106,"context_line":"            \u0027  one            Test command.\\n\u0027"},{"line_number":107,"context_line":"            \u0027  three word command  Test command.\\n\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1e499854_89fdad01","line":104,"updated":"2021-02-11 14:31:18.000000000","message":"Do we need to do anything special to apply this multi-line regex?","commit_id":"f85bf8d60d569c6bb95340ca608954a81a3e7088"},{"author":{"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},"change_message_id":"d1cf794401ecfffc0a6af12a7ce772e1fd27ead9","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        help_text \u003d stdout.getvalue()"},{"line_number":102,"context_line":"        basecommand \u003d os.path.split(sys.argv[0])[1]"},{"line_number":103,"context_line":"        self.assertIn(\u0027usage: %s [--version]\u0027 % basecommand, help_text)"},{"line_number":104,"context_line":"        self.assertRegex(help_text, \u0027option.*:\\n  --version\u0027)"},{"line_number":105,"context_line":"        expected \u003d ("},{"line_number":106,"context_line":"            \u0027  one            Test command.\\n\u0027"},{"line_number":107,"context_line":"            \u0027  three word command  Test command.\\n\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"e50c4a6f_37a8296e","line":104,"in_reply_to":"1e499854_89fdad01","updated":"2021-06-07 12:07:35.000000000","message":"I don\u0027t think so, it does pass CI successfully","commit_id":"f85bf8d60d569c6bb95340ca608954a81a3e7088"},{"author":{"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},"change_message_id":"1d46dc47406270a62381677f0b9ac2fd5171f06d","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        help_text \u003d stdout.getvalue()"},{"line_number":102,"context_line":"        basecommand \u003d os.path.split(sys.argv[0])[1]"},{"line_number":103,"context_line":"        self.assertIn(\u0027usage: %s [--version]\u0027 % basecommand, help_text)"},{"line_number":104,"context_line":"        self.assertRegex(help_text, \u0027option.*:\\n  --version\u0027)"},{"line_number":105,"context_line":"        expected \u003d ("},{"line_number":106,"context_line":"            \u0027  one            Test command.\\n\u0027"},{"line_number":107,"context_line":"            \u0027  three word command  Test command.\\n\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7770a568_5dc67c34","line":104,"in_reply_to":"39d0e203_0503a34b","updated":"2021-06-15 12:54:55.000000000","message":"I updated the regexp in PS2 to be less permissive.","commit_id":"f85bf8d60d569c6bb95340ca608954a81a3e7088"},{"author":{"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},"change_message_id":"73cd20637f64b6b69254a5683e6b8f4a51b65b98","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        help_text \u003d stdout.getvalue()"},{"line_number":102,"context_line":"        basecommand \u003d os.path.split(sys.argv[0])[1]"},{"line_number":103,"context_line":"        self.assertIn(\u0027usage: %s [--version]\u0027 % basecommand, help_text)"},{"line_number":104,"context_line":"        self.assertRegex(help_text, \u0027option.*:\\n  --version\u0027)"},{"line_number":105,"context_line":"        expected \u003d ("},{"line_number":106,"context_line":"            \u0027  one            Test command.\\n\u0027"},{"line_number":107,"context_line":"            \u0027  three word command  Test command.\\n\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"39d0e203_0503a34b","line":104,"in_reply_to":"77aa6f99_2e6e5825","updated":"2021-06-15 12:16:45.000000000","message":"It appears that when you add at least one \u0027\\n\u0027 in the regular expression it handles automatically multi-line regex, even though MULTILINE flag is not set (see \"test_both_2\" and \"test_multiline_2\" in [1]). I can\u0027t say if this is handled during compilation of the regex (i.e re.compile) inside assertRegex() method or later on.\n\n[1] http://paste.openstack.org/show/806620/","commit_id":"f85bf8d60d569c6bb95340ca608954a81a3e7088"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"40086b4be54a74c8f1428c72f187dcde9dc946ec","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        help_text \u003d stdout.getvalue()"},{"line_number":102,"context_line":"        basecommand \u003d os.path.split(sys.argv[0])[1]"},{"line_number":103,"context_line":"        self.assertIn(\u0027usage: %s [--version]\u0027 % basecommand, help_text)"},{"line_number":104,"context_line":"        self.assertRegex(help_text, \u0027option.*:\\n  --version\u0027)"},{"line_number":105,"context_line":"        expected \u003d ("},{"line_number":106,"context_line":"            \u0027  one            Test command.\\n\u0027"},{"line_number":107,"context_line":"            \u0027  three word command  Test command.\\n\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"77aa6f99_2e6e5825","line":104,"in_reply_to":"e50c4a6f_37a8296e","updated":"2021-06-07 14:05:47.000000000","message":"I\u0027m worried that the `.*` is overly permissive, and I don\u0027t see any sign that the library [1] handles multi-line regex patterns automatically. \n\nhttp://paste.openstack.org/show/806422/ is a sample test case where this wouldn\u0027t work, so I would like to understand why those results are different from these.\n\n[1] https://github.com/python/cpython/blob/main/Lib/unittest/case.py#L1305","commit_id":"f85bf8d60d569c6bb95340ca608954a81a3e7088"}]}
