)]}'
{"cliff/_argparse.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"6b6b3fdc2155180243815bb6375e812fa1dba1b3","unresolved":true,"context_lines":[{"line_number":15,"context_line":"import argparse as orig_argparse"},{"line_number":16,"context_line":"import warnings"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from autopage import argparse"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class _ArgumentContainerMixIn(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"c9d3196d_250b803d","line":18,"updated":"2021-07-08 17:58:26.000000000","message":"Does an application using cliff also need to make this change?","commit_id":"4085c328d5a94fa371d6130e4977c42faa5297ed"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"9597e54ebb85d4d1a2336e589491bea672340719","unresolved":true,"context_lines":[{"line_number":15,"context_line":"import argparse as orig_argparse"},{"line_number":16,"context_line":"import warnings"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from autopage import argparse"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class _ArgumentContainerMixIn(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"c5b217f4_f28d4f17","line":18,"in_reply_to":"c9d3196d_250b803d","updated":"2021-07-10 04:10:16.000000000","message":"No, it turns out that by importing it here everything that uses cliff automatically benefits because Command.get_parser() returns an ArgumentParser from this module.","commit_id":"4085c328d5a94fa371d6130e4977c42faa5297ed"}],"cliff/help.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"6b6b3fdc2155180243815bb6375e812fa1dba1b3","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        app \u003d self.default"},{"line_number":42,"context_line":"        pager \u003d autopage.argparse.help_pager(app.stdout)"},{"line_number":43,"context_line":"        color \u003d pager.to_terminal()"},{"line_number":44,"context_line":"        setattr(parser, \u0027_color\u0027, color)"},{"line_number":45,"context_line":"        with pager as out:"},{"line_number":46,"context_line":"            parser.print_help(out)"},{"line_number":47,"context_line":"            title_hl \u003d (\u0027\\033[4m\u0027, \u0027\\033[0m\u0027) if color else (\u0027\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7258d91b_e5873221","line":44,"updated":"2021-07-08 17:58:26.000000000","message":"What\u0027s going on with this private property?","commit_id":"4085c328d5a94fa371d6130e4977c42faa5297ed"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"9597e54ebb85d4d1a2336e589491bea672340719","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        app \u003d self.default"},{"line_number":42,"context_line":"        pager \u003d autopage.argparse.help_pager(app.stdout)"},{"line_number":43,"context_line":"        color \u003d pager.to_terminal()"},{"line_number":44,"context_line":"        setattr(parser, \u0027_color\u0027, color)"},{"line_number":45,"context_line":"        with pager as out:"},{"line_number":46,"context_line":"            parser.print_help(out)"},{"line_number":47,"context_line":"            title_hl \u003d (\u0027\\033[4m\u0027, \u0027\\033[0m\u0027) if color else (\u0027\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e694ab67_111d0323","line":44,"in_reply_to":"7258d91b_e5873221","updated":"2021-07-10 04:10:16.000000000","message":"So note that this is not a property that is defined by the stdlib argparse module.\n\nIt\u0027s one that autopage.argparse applies to the parser so it can keep track internally of whether it\u0027s safe to colourise the output (whether it\u0027s safe to depends on whether we are outputting to a terminal or not) in ColorHelpFormatter:\nhttps://github.com/zaneb/autopage/blob/main/autopage/argparse.py#L141-L142\n\nIf you use the built in _HelpAction, autopage.argparse handles this itself:\nhttps://github.com/zaneb/autopage/blob/main/autopage/argparse.py#L122-L124\n\nHowever, in this case we\u0027re writing our own HelpAction that does other stuff in addition to parser.print_help(), and so we end up having to duplicate some of the internal implementation from autopage because there\u0027s no way to just inherit it.","commit_id":"4085c328d5a94fa371d6130e4977c42faa5297ed"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"c1bb6de307e1e70539bb39a506fc038ddb13e573","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        app \u003d self.default"},{"line_number":42,"context_line":"        pager \u003d autopage.argparse.help_pager(app.stdout)"},{"line_number":43,"context_line":"        color \u003d pager.to_terminal()"},{"line_number":44,"context_line":"        setattr(parser, \u0027_color\u0027, color)"},{"line_number":45,"context_line":"        with pager as out:"},{"line_number":46,"context_line":"            parser.print_help(out)"},{"line_number":47,"context_line":"            title_hl \u003d (\u0027\\033[4m\u0027, \u0027\\033[0m\u0027) if color else (\u0027\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7c7940fd_0c61108b","line":44,"in_reply_to":"78597e96_180b648f","updated":"2021-07-13 02:24:54.000000000","message":"I made a new release with a public API for this.","commit_id":"4085c328d5a94fa371d6130e4977c42faa5297ed"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"386fab474ec31b3225761c3eff4612b32735a56e","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        app \u003d self.default"},{"line_number":42,"context_line":"        pager \u003d autopage.argparse.help_pager(app.stdout)"},{"line_number":43,"context_line":"        color \u003d pager.to_terminal()"},{"line_number":44,"context_line":"        setattr(parser, \u0027_color\u0027, color)"},{"line_number":45,"context_line":"        with pager as out:"},{"line_number":46,"context_line":"            parser.print_help(out)"},{"line_number":47,"context_line":"            title_hl \u003d (\u0027\\033[4m\u0027, \u0027\\033[0m\u0027) if color else (\u0027\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"78597e96_180b648f","line":44,"in_reply_to":"e694ab67_111d0323","updated":"2021-07-12 11:05:09.000000000","message":"A comment with those details would help future maintainers.","commit_id":"4085c328d5a94fa371d6130e4977c42faa5297ed"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"cb7e4719cc955f50a36a679884cfc209d78739f4","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    def __call__(self, parser, namespace, values, option_string\u003dNone):"},{"line_number":41,"context_line":"        app \u003d self.default"},{"line_number":42,"context_line":"        pager \u003d autopage.argparse.help_pager(app.stdout)"},{"line_number":43,"context_line":"        color \u003d pager.to_terminal()"},{"line_number":44,"context_line":"        autopage.argparse.use_color_for_parser(parser, color)"},{"line_number":45,"context_line":"        with pager as out:"},{"line_number":46,"context_line":"            parser.print_help(out)"}],"source_content_type":"text/x-python","patch_set":2,"id":"4b6aa456_3898a724","line":43,"updated":"2021-07-13 15:22:45.000000000","message":"Is `color` a bool? Would it make sense to call it `using_color` to express that?","commit_id":"8fa916e9169f507ce7b861f3d9df9a14734672d2"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"690dbeb708657bc63d9cea51d0a85b7cb0b94746","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    def __call__(self, parser, namespace, values, option_string\u003dNone):"},{"line_number":41,"context_line":"        app \u003d self.default"},{"line_number":42,"context_line":"        pager \u003d autopage.argparse.help_pager(app.stdout)"},{"line_number":43,"context_line":"        color \u003d pager.to_terminal()"},{"line_number":44,"context_line":"        autopage.argparse.use_color_for_parser(parser, color)"},{"line_number":45,"context_line":"        with pager as out:"},{"line_number":46,"context_line":"            parser.print_help(out)"}],"source_content_type":"text/x-python","patch_set":2,"id":"83124ef9_fa0758a1","line":43,"in_reply_to":"4b6aa456_3898a724","updated":"2021-07-13 16:15:52.000000000","message":"Yes, and probably yes.","commit_id":"8fa916e9169f507ce7b861f3d9df9a14734672d2"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"cb7e4719cc955f50a36a679884cfc209d78739f4","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        app \u003d self.default"},{"line_number":42,"context_line":"        pager \u003d autopage.argparse.help_pager(app.stdout)"},{"line_number":43,"context_line":"        color \u003d pager.to_terminal()"},{"line_number":44,"context_line":"        autopage.argparse.use_color_for_parser(parser, color)"},{"line_number":45,"context_line":"        with pager as out:"},{"line_number":46,"context_line":"            parser.print_help(out)"},{"line_number":47,"context_line":"            title_hl \u003d (\u0027\\033[4m\u0027, \u0027\\033[0m\u0027) if color else (\u0027\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ac759c82_95bb94ea","line":44,"updated":"2021-07-13 15:22:45.000000000","message":"The public API does make this clearer, thanks.","commit_id":"8fa916e9169f507ce7b861f3d9df9a14734672d2"}]}