)]}'
{"id":"openstack%2Fcliff~852177","triplet_id":"openstack%2Fcliff~master~I0a086a8349e2a72cae024857e148fddc3556c319","project":"openstack/cliff","branch":"master","attention_set":{},"removed_from_attention_set":{"32926":{"account":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"last_update":"2022-08-05 05:58:22.000000000","reason":"\u003cGERRIT_ACCOUNT_32926\u003e replied on the change","reason_account":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"}}},"hashtags":[],"change_id":"I0a086a8349e2a72cae024857e148fddc3556c319","subject":"Removing brackets around tested conditional","status":"MERGED","created":"2022-08-04 14:41:11.000000000","updated":"2022-08-05 05:58:22.000000000","submitted":"2022-08-04 18:00:46.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"852177","meta_rev_id":"ccffef84d2452a69748b4b5ee484e97ea7384e59","_number":852177,"virtual_id_number":852177,"owner":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-08-04 18:00:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2022-08-04 16:20:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2022-08-04 16:20:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"}],"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-08-04 16:20:49.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2022-08-04 16:35:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-08-05 05:49:01.000000000","updated_by":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"reviewer":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"state":"CC"}],"messages":[{"id":"50ebe2ada697a5abc9ba9940f36c60403237c3eb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"date":"2022-08-04 14:41:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1a299452bce7e82a98e5ea7e2632059b6125b067","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-08-04 16:20:49.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"e20ae1e934a6729e10b6adaee0938ea4d2516bde","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-04 16:35:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/3e1813a6796644f8b5dd8d228b8e1e35\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/6f9b834edc7343b9993d9e3cf706603f : SUCCESS in 1h 48m 38s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2562c139710b4df8891abccd42ccaa0c : SUCCESS in 2m 44s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/691b44412446490f8546be41bcf0ff36 : SUCCESS in 3m 15s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/57bf8cbf80d14e9893baeb4a31b660a8 : SUCCESS in 3m 04s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/6339a813c606429b999c36c90ab76da5 : SUCCESS in 2m 45s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/517a06c477aa4759b2d032bb973944d2 : SUCCESS in 3m 00s\n- cliff-tox-py38-neutronclient-tip https://zuul.opendev.org/t/openstack/build/9eedcc04bcc34c639d561a22966a25d3 : SUCCESS in 3m 15s\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/83a9209e68cc423986792adb5b51a5ab : SUCCESS in 4m 11s","accounts_in_message":[],"_revision_number":1},{"id":"f50ac823a8019cdd2b8fbf641ac35b2556d005ae","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-04 16:36:08.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"274dbfe5d6002f353478c3ffd0099c604fdeb027","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-04 18:00:46.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/eeb716f66247448191331896ada9ee22\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/bb2dadb565014a2085750b3a5bb51445 : SUCCESS in 1h 23m 42s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9929ac318c1d4123b97bbc577d45910a : SUCCESS in 3m 19s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/74a7b7ff6ca14483be6c4cbf7bb063c2 : SUCCESS in 3m 24s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ab34b23e193247738be1d0dc2cd1e414 : SUCCESS in 3m 30s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/db2c29bc2ea44677bfcce57c3aa48f16 : SUCCESS in 3m 57s\n- cliff-tox-py38-neutronclient-tip https://zuul.opendev.org/t/openstack/build/02d66c4a78cd4ed8a7061ad0ea89d72b : SUCCESS in 4m 02s\n- osc-tox-py38-tips https://zuul.opendev.org/t/openstack/build/c99f64eaea574bcb9bb17085584fb863 : SUCCESS in 5m 31s","accounts_in_message":[],"_revision_number":1},{"id":"7701ae3bf68e91eff38302fff387835f18a358e3","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-04 18:00:46.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"ae8eb4fbdb06b5c62d3abe4a22a0d1de5f1b4b39","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-04 18:01:49.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/5da1b69bde2e4bffab4c654ddfc147c1\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6548709b118a443fb03b7a0486d839de : SUCCESS in 41s","accounts_in_message":[],"_revision_number":1},{"id":"3e083944777c23971767c581c41c4cc41711d59f","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2022-08-05 05:49:01.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e8bd85d49ba7ab8d85b66cf2afd412721bef162a","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2022-08-05 05:49:36.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ccffef84d2452a69748b4b5ee484e97ea7384e59","author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"date":"2022-08-05 05:58:22.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"56b700afcab95080182687f945c62cc96f650e45","revisions":{"56b700afcab95080182687f945c62cc96f650e45":{"kind":"REWORK","_number":1,"created":"2022-08-04 14:41:11.000000000","uploader":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"ref":"refs/changes/77/852177/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cliff","ref":"refs/changes/77/852177/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cliff refs/changes/77/852177/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cliff refs/changes/77/852177/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cliff refs/changes/77/852177/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cliff refs/changes/77/852177/1"}}},"commit":{"parents":[{"commit":"a04a48f4f7dc72b1bcc95a5c6a550c7650e35ab3","subject":"Removing modindex link from docs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cliff/commit/a04a48f4f7dc72b1bcc95a5c6a550c7650e35ab3"}]}],"author":{"name":"Jiri Podivin","email":"jpodivin@redhat.com","date":"2022-08-04 14:32:44.000000000","tz":120},"committer":{"name":"Jiri Podivin","email":"jpodivin@redhat.com","date":"2022-08-04 14:32:44.000000000","tz":120},"subject":"Removing brackets around tested conditional","message":"Removing brackets around tested conditional\n\nWhile permissible syntactically, using brackets to wrap tested conditional is unnecessary\nand potentially confusing. As without inserted whitspace the code may look as a function\ncall, rather than a statement and expression.\n\nThe construct is also considered erroneous by linters.\n\nCloses-Bug: 1983593\n\nSigned-off-by: Jiri Podivin \u003cjpodivin@redhat.com\u003e\nChange-Id: I0a086a8349e2a72cae024857e148fddc3556c319\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cliff/commit/56b700afcab95080182687f945c62cc96f650e45"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cliff/commit/56b700afcab95080182687f945c62cc96f650e45"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[]}