)]}'
{"id":"openstack%2Fcliff~862494","triplet_id":"openstack%2Fcliff~stable%2Fwallaby~I0a086a8349e2a72cae024857e148fddc3556c319","project":"openstack/cliff","branch":"stable/wallaby","attention_set":{},"removed_from_attention_set":{"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2023-03-28 12:35:37.000000000","reason":"\u003cGERRIT_ACCOUNT_15334\u003e replied on the change","reason_account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},"2472":{"account":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"last_update":"2023-03-28 14:01:19.000000000","reason":"Change was submitted"},"16282":{"account":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"last_update":"2023-03-28 14:01:19.000000000","reason":"Change was submitted"},"32926":{"account":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"last_update":"2022-10-24 14:55:37.000000000","reason":"Removed by \u003cGERRIT_ACCOUNT_32926\u003e by clicking the attention icon","reason_account":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"}}},"hashtags":[],"change_id":"I0a086a8349e2a72cae024857e148fddc3556c319","subject":"Removing brackets around tested conditional","status":"MERGED","created":"2022-10-24 14:23:04.000000000","updated":"2023-03-28 14:02:24.000000000","submitted":"2023-03-28 14:01:19.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"862494","meta_rev_id":"edde0205a730b31d4a831986e1b63e111609b7b8","_number":862494,"virtual_id_number":862494,"owner":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-03-28 14:01:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":31581,"name":"Miguel Garcia","display_name":"Miguel Garcia","email":"migarcia@redhat.com","username":"mgarciac"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2023-03-28 12:35:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2023-03-21 14:00:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":31581,"name":"Miguel Garcia","display_name":"Miguel Garcia","email":"migarcia@redhat.com","username":"mgarciac"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2023-03-28 12:35:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":31581,"name":"Miguel Garcia","display_name":"Miguel Garcia","email":"migarcia@redhat.com","username":"mgarciac"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"}],"reviewers":{"REVIEWER":[{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":31581,"name":"Miguel Garcia","display_name":"Miguel Garcia","email":"migarcia@redhat.com","username":"mgarciac"},{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-10-24 14:23:04.000000000","updated_by":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"reviewer":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"state":"REVIEWER"},{"updated":"2022-10-24 14:49:55.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-03-21 14:00:17.000000000","updated_by":{"_account_id":31581,"name":"Miguel Garcia","display_name":"Miguel Garcia","email":"migarcia@redhat.com","username":"mgarciac"},"reviewer":{"_account_id":31581,"name":"Miguel Garcia","display_name":"Miguel Garcia","email":"migarcia@redhat.com","username":"mgarciac"},"state":"REVIEWER"},{"updated":"2023-03-28 11:48:31.000000000","updated_by":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2023-03-28 11:48:31.000000000","updated_by":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"reviewer":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"state":"REVIEWER"}],"messages":[{"id":"127915cda56bfd408f0b958a333dc823a66881c5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"date":"2022-10-24 14:23:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"660d5b1325cc7becf487c628824e78e9bea3af88","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-10-24 14:49:55.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/9b19e3dc7408411289e3b49c6c755dd5\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/19736655e0454e6f974ed6c5f6c116da : FAILURE in 26m 11s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5b53b4e1016a4c878f4fa36733bb3f3d : SUCCESS in 3m 09s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/93df0bb4328747608b77e09af799ba6d : SUCCESS in 3m 35s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ad2ac9f45e764605bcade94c5f21bf6f : SUCCESS in 3m 39s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/afbdb63372ef4689890c8192b2ebf904 : SUCCESS in 3m 44s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9c0821b1cf1d45ef97759b2c4c9cb36d : SUCCESS in 3m 41s","accounts_in_message":[],"_revision_number":1},{"id":"d463453c6195dd4d46e729dd8f98137c271be5a3","author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"date":"2022-12-15 16:14:06.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"a9f5ca4b98ec9087d518f1004fca62e024bdf0b1","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-15 17:56:18.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/01071924bd9247d8889d1dfa07551eb9\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/4f545f618f504cdba0227ebc0d1171ff : SUCCESS in 1h 40m 01s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/801dd84098c04ad0801934eb5aa5df04 : SUCCESS in 2m 05s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/140b90db3a954189b7a701c50a1705e5 : SUCCESS in 4m 02s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2e3ee973ccec48a4875b01273f037f85 : SUCCESS in 2m 44s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/c920e33a03c6458bb1095ed01b228c72 : SUCCESS in 3m 38s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ed12a05f0360419083e3efab2350a229 : SUCCESS in 2m 35s","accounts_in_message":[],"_revision_number":1},{"id":"8459adb0eb3129cebffec46c039fcc0166013f96","author":{"_account_id":31581,"name":"Miguel Garcia","display_name":"Miguel Garcia","email":"migarcia@redhat.com","username":"mgarciac"},"date":"2023-03-21 14:00:17.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"d4a29743592e721d087e00c410a38986e6bea13d","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-03-28 12:35:37.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"995cda50364094f503ae2c6b1785557946ac9096","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-28 12:36:04.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"9da589b3a2cafa3485b0cff35fdcd8795bec69ea","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-28 14:01:19.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a24967b68a244742b16b06c62a675380\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/7acbced09b7f46b5a1264ee58f69b9aa : SUCCESS in 1h 24m 18s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ea33c0d089e742dc97226a123c8820d0 : SUCCESS in 2m 35s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/389f2a2c96d244cb812852c78a923b26 : SUCCESS in 2m 54s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/765f29131a1a409f8e471d5d0e81d703 : SUCCESS in 2m 59s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/93944b40a0324952a1756ccee8c44bc3 : SUCCESS in 2m 41s","accounts_in_message":[],"_revision_number":1},{"id":"fb0b3dfc56c4372a8f8831cbc4079d6d754b0d88","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-28 14:01:19.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"edde0205a730b31d4a831986e1b63e111609b7b8","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-28 14:02:24.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/fe7cfb0fc46b4989ad244bc43af05f1d\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/88f0a5c246be453e87a81b93fb4f92b6 : SUCCESS in 44s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0dfc3377f19f8aa3cb8550685d5c891950e797ef","revisions":{"0dfc3377f19f8aa3cb8550685d5c891950e797ef":{"kind":"REWORK","_number":1,"created":"2022-10-24 14:23:04.000000000","uploader":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"ref":"refs/changes/94/862494/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cliff","ref":"refs/changes/94/862494/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cliff refs/changes/94/862494/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cliff refs/changes/94/862494/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cliff refs/changes/94/862494/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cliff refs/changes/94/862494/1"}}},"commit":{"parents":[{"commit":"e36a71b365b6058022272b27483fcba275c18aa5","subject":"Add conflict_handler parameter as attribut in Command class","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cliff/commit/e36a71b365b6058022272b27483fcba275c18aa5"}]}],"author":{"name":"Jiri Podivin","email":"jpodivin@redhat.com","date":"2022-08-04 14:32:44.000000000","tz":120},"committer":{"name":"Jon Schlueter","email":"jschluet@redhat.com","date":"2022-10-24 14:22:45.000000000","tz":-240},"subject":"Removing brackets around tested conditional","message":"Removing brackets around tested conditional\n\nWhile permissible syntactically, using brackets to wrap tested conditional is unnecessary\nand potentially confusing. As without inserted whitspace the code may look as a function\ncall, rather than a statement and expression.\n\nThe construct is also considered erroneous by linters.\n\nCloses-Bug: 1983593\n\nSigned-off-by: Jiri Podivin \u003cjpodivin@redhat.com\u003e\nChange-Id: I0a086a8349e2a72cae024857e148fddc3556c319\n(cherry picked from commit 56b700afcab95080182687f945c62cc96f650e45)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cliff/commit/0dfc3377f19f8aa3cb8550685d5c891950e797ef"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cliff/commit/0dfc3377f19f8aa3cb8550685d5c891950e797ef"}]},"branch":"refs/heads/stable/wallaby"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}