)]}'
{"cloudkittydashboard/dashboards/admin/hashmap/tables.py":[{"author":{"_account_id":18898,"name":"Pierre-Alexandre Bardina","email":"pa.bardina@gmail.com","username":"pabardina"},"change_message_id":"5aea53110c94391d9e1a067b5e02d3f22b756a2b","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                               for group in groups])"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    for datum in datums:"},{"line_number":203,"context_line":"        if datum.group_id in full_groups:"},{"line_number":204,"context_line":"            datum.group_name \u003d full_groups[datum.group_id]"},{"line_number":205,"context_line":"        else:"},{"line_number":206,"context_line":"            group \u003d client.hashmap.groups.get("}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_e8b463d2","line":203,"updated":"2016-09-06 13:38:03.000000000","message":"There was a bug in master branch... it was impossible to create a service mapping / threshold without a group. The fix is merged ( https://review.openstack.org/#/c/365672/ ). So, you should check here if you have a \"datum.group_id\" before your other checks.","commit_id":"21414cee4b4e1fa5405c16f60a43f0eb9f8d8c5b"},{"author":{"_account_id":18898,"name":"Pierre-Alexandre Bardina","email":"pa.bardina@gmail.com","username":"pabardina"},"change_message_id":"f8234b5627d76cd583cc556e39191169d9e8f513","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        client \u003d api.cloudkittyclient(self.request)"},{"line_number":242,"context_line":"        thresholds \u003d client.hashmap.thresholds.list("},{"line_number":243,"context_line":"            service_id\u003dself.request.service_id)"},{"line_number":244,"context_line":"        add_groupname(self.request, thresholds)"},{"line_number":245,"context_line":"        return api.identify(thresholds)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_44ca851b","line":244,"updated":"2016-09-01 15:17:28.000000000","message":"Group is optional when creating resources. It lacks a check if group is set or not, if not, an error will be raised","commit_id":"21414cee4b4e1fa5405c16f60a43f0eb9f8d8c5b"},{"author":{"_account_id":8358,"name":"zhangguoqing","email":"zhang.guoqing@99cloud.net","username":"zhangguoqing"},"change_message_id":"1c3f3818fe7f8e822cf3d8c4bae5d8c1587e6749","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        client \u003d api.cloudkittyclient(self.request)"},{"line_number":242,"context_line":"        thresholds \u003d client.hashmap.thresholds.list("},{"line_number":243,"context_line":"            service_id\u003dself.request.service_id)"},{"line_number":244,"context_line":"        add_groupname(self.request, thresholds)"},{"line_number":245,"context_line":"        return api.identify(thresholds)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_9a23ef57","line":244,"in_reply_to":"fa7ab95a_44ca851b","updated":"2016-09-02 01:50:37.000000000","message":"Yes, group is an optional, it maybe just in cloudkittyclient. If the group is not set, it will show \"Not available\". And I have try to create mappings and thresholds on dashboard, the group should always be gave, so everyone resource has a group name in fact. In my opinion, if a resource doesn\u0027t belong to a group, it is not any sense in hashmap rating module.\n\nIf you don\u0027t agree with me, could you guide me how to add the check? thank you. :)","commit_id":"21414cee4b4e1fa5405c16f60a43f0eb9f8d8c5b"},{"author":{"_account_id":18898,"name":"Pierre-Alexandre Bardina","email":"pa.bardina@gmail.com","username":"pabardina"},"change_message_id":"e6af43c39450b742b9260e3f8abed9d535a318a6","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                               for group in groups])"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    for datum in datums:"},{"line_number":203,"context_line":"        if datum.get(\u0027group_id\u0027, None):"},{"line_number":204,"context_line":"            if datum.group_id in full_groups:"},{"line_number":205,"context_line":"                datum.group_name \u003d full_groups[datum.group_id]"},{"line_number":206,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_7bf54d55","line":203,"range":{"start_line":203,"start_character":8,"end_line":203,"end_character":39},"updated":"2016-09-07 09:03:49.000000000","message":"You can\u0027t use \"get\" method like that. datum.get is not the classic \"get\" function of a dict. It\u0027s https://github.com/openstack/python-cloudkittyclient/blob/master/cloudkittyclient/openstack/common/apiclient/base.py#L498  \nYou can simply check \"if datum.group_id: \"","commit_id":"66acac3271fb90d892cd079a0115aba0b2f5142c"}]}
