)]}'
{"test-requirements.txt":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"0bc61382895b7cd4053ff2c1c3dc768f568ab102","unresolved":false,"context_lines":[{"line_number":4,"context_line":"hacking\u003e\u003d1.1.0,\u003c1.2.0 # Apache-2.0"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# Require Horizon"},{"line_number":7,"context_line":"horizon\u003e\u003d15.3.1"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"coverage\u003e\u003d3.6"},{"line_number":10,"context_line":"discover"}],"source_content_type":"text/plain","patch_set":1,"id":"9f560f44_8869ff8c","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":15},"updated":"2020-08-13 16:18:16.000000000","message":"If I am not wrong 15.3.1 is horizon stable/stein version[1]?\n[1] https://opendev.org/openstack/releases/src/branch/master/deliverables/stein/horizon.yaml#L44","commit_id":"9e9fb31c49d973eda563431a94abf7b9b61b4816"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"565e126adfabcd195bc45831924f72f38417b9f8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"hacking\u003e\u003d1.1.0,\u003c1.2.0 # Apache-2.0"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# Require Horizon"},{"line_number":7,"context_line":"horizon\u003e\u003d15.3.1"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"coverage\u003e\u003d3.6"},{"line_number":10,"context_line":"discover"}],"source_content_type":"text/plain","patch_set":1,"id":"9f560f44_a89163f4","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":15},"in_reply_to":"9f560f44_48f52783","updated":"2020-08-13 16:38:29.000000000","message":"ok, thanks for the info.\nOne more thing that I notice most of the plugins uses horizon in their \u0027requirement.txt\u0027[1].\nCan we do the same here as the same thing done for openstack/cloudkitty-dashboard master version?\nhttp://codesearch.openstack.org/?q\u003dhorizon%3E%3D\u0026i\u003dnope\u0026files\u003drequirements.txt\u0026repos\u003d","commit_id":"9e9fb31c49d973eda563431a94abf7b9b61b4816"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"c1f8e6c1f109f2847f4c949a7191fb38c2a4869b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"hacking\u003e\u003d1.1.0,\u003c1.2.0 # Apache-2.0"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# Require Horizon"},{"line_number":7,"context_line":"horizon\u003e\u003d15.3.1"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"coverage\u003e\u003d3.6"},{"line_number":10,"context_line":"discover"}],"source_content_type":"text/plain","patch_set":1,"id":"9f560f44_e82fdba4","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":15},"in_reply_to":"9f560f44_68758bcc","updated":"2020-08-13 16:42:34.000000000","message":"stable/ussuri (and thus master) have already switched to use requirements.txt in https://review.opendev.org/#/c/700839/\n\nIt feels odd to add a requirement to a stable release, but I guess that\u0027s the right thing to do?","commit_id":"9e9fb31c49d973eda563431a94abf7b9b61b4816"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a5f31c6a8abf2f112a61f000f88b3f4d1d236013","unresolved":false,"context_lines":[{"line_number":4,"context_line":"hacking\u003e\u003d1.1.0,\u003c1.2.0 # Apache-2.0"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# Require Horizon"},{"line_number":7,"context_line":"horizon\u003e\u003d15.3.1"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"coverage\u003e\u003d3.6"},{"line_number":10,"context_line":"discover"}],"source_content_type":"text/plain","patch_set":1,"id":"9f560f44_48f52783","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":15},"in_reply_to":"9f560f44_8869ff8c","updated":"2020-08-13 16:20:47.000000000","message":"It is the maximum version from Stein, yes. The idea was that that would be the absolute minimum version that could be installed. But then typical pip installation will grab the highest version available, limited by whatever is specified as a constraint (pip -c [path to stable/train upper-constraints.txt]). So it should always pick up the final release, and any updated stable releases, or horizon for stable/stein.","commit_id":"9e9fb31c49d973eda563431a94abf7b9b61b4816"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1cd96ce2868bf66be63e574b10ee7ebaafb5c7ca","unresolved":false,"context_lines":[{"line_number":4,"context_line":"hacking\u003e\u003d1.1.0,\u003c1.2.0 # Apache-2.0"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# Require Horizon"},{"line_number":7,"context_line":"horizon\u003e\u003d15.3.1"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"coverage\u003e\u003d3.6"},{"line_number":10,"context_line":"discover"}],"source_content_type":"text/plain","patch_set":1,"id":"9f560f44_68758bcc","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":15},"in_reply_to":"9f560f44_a89163f4","updated":"2020-08-13 16:40:15.000000000","message":"Yeah, I don\u0027t really know this project well enough, but I would assume horizon is more than just a test requirement for it. I would recommend reviewing whether that is actually the case, and if so, propose a follow up patch on master to switch it to requirements.txt.","commit_id":"9e9fb31c49d973eda563431a94abf7b9b61b4816"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"e342c3d510cb4b2ad3c86039aa592d7799070fdc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"hacking\u003e\u003d1.1.0,\u003c1.2.0 # Apache-2.0"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# Require Horizon"},{"line_number":7,"context_line":"horizon\u003e\u003d15.3.1"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"coverage\u003e\u003d3.6"},{"line_number":10,"context_line":"discover"}],"source_content_type":"text/plain","patch_set":1,"id":"9f560f44_114ce974","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":15},"in_reply_to":"9f560f44_e82fdba4","updated":"2020-08-14 23:38:31.000000000","message":"I guess, if we define the requirement for a library, we should set it to a closed and released version.","commit_id":"9e9fb31c49d973eda563431a94abf7b9b61b4816"}]}