)]}'
{"id":"openstack%2Fcloudkitty-dashboard~773680","triplet_id":"openstack%2Fcloudkitty-dashboard~master~I6aed92383a70f8dcf26c45155ef1d16169d40601","project":"openstack/cloudkitty-dashboard","branch":"master","topic":"bug/2008582","hashtags":[],"change_id":"I6aed92383a70f8dcf26c45155ef1d16169d40601","subject":"Unstack series on the \"Cost Per Service Per Hour\" graph","status":"MERGED","created":"2021-02-02 13:06:14.000000000","updated":"2021-02-18 15:46:58.000000000","submitted":"2021-02-18 15:45:10.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"773680-bug/2008582","meta_rev_id":"b45fa5e9adf61f52241821bed6200e3534f66e75","_number":773680,"virtual_id_number":773680,"owner":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-02-18 15:45:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"all":[{"value":2,"date":"2021-02-18 15:34:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-02-18 11:38:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"all":[{"value":1,"date":"2021-02-18 15:34:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"approved":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"all":[{"value":2,"date":"2021-02-18 15:34:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":32304,"name":"Jegor van Opdorp","email":"jegor@leaf.cloud","username":"jopdorp"}],"reviewers":{"REVIEWER":[{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},{"_account_id":32304,"name":"Jegor van Opdorp","email":"jegor@leaf.cloud","username":"jopdorp"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-02-02 13:11:04.000000000","updated_by":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"reviewer":{"_account_id":32304,"name":"Jegor van Opdorp","email":"jegor@leaf.cloud","username":"jopdorp"},"state":"REVIEWER"},{"updated":"2021-02-02 13:11:04.000000000","updated_by":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"reviewer":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"state":"REVIEWER"},{"updated":"2021-02-02 13:11:04.000000000","updated_by":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"reviewer":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"state":"REVIEWER"},{"updated":"2021-02-02 13:21:21.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f8f8ec865ccb403a645994cd87aa51d387398e02","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"date":"2021-02-02 13:06:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4d4b1c76d72b4a344dcf683082dbf7412f5061b8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"date":"2021-02-02 13:08:15.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"d0feda9d0512ff96cdbcd2cef1f107e2a72fa2ba","author":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"date":"2021-02-02 13:11:40.000000000","message":"Patch Set 2:\n\nPlease read https://storyboard.openstack.org/#!/story/2008582 for details.","accounts_in_message":[],"_revision_number":2},{"id":"00e2a857dc675f5ae03a20819ecb6207fdbf8e81","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-02 13:21:21.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/f0cc589d6df24107b270a2dcb388dfe3 : SUCCESS in 4m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/12d906303adc46e1ad3bff271f1277ab : SUCCESS in 3m 33s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/76e94ef3586e40a3a28d98cfc0bf26c0 : SUCCESS in 3m 47s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/fcde5cc2a7374bfe86426cc7449ac9e8 : SUCCESS in 4m 13s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b6b6f1c2ee714fad8feb3fccaaa53cda : SUCCESS in 5m 22s","accounts_in_message":[],"_revision_number":2},{"id":"3c5f5b520ed13dd82fd44642af11b3e2cb75b173","author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"date":"2021-02-02 13:35:39.000000000","message":"Patch Set 2: Code-Review+2 Review-Priority+1\n\nI agree. Stacking series can lead people to misunderstanding. I do see a problem, if we have too many VMs for instance to display there.  However, this is something that we can introduce later with a filter option for instance.","accounts_in_message":[],"_revision_number":2},{"id":"b9dd3a505ae0c965e627497b6d2d800cc5d34b6e","author":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"date":"2021-02-02 16:10:29.000000000","message":"Patch Set 2:\n\nThanks, Rafael. You are right - multiple series with similar values may overlap if areas are not stacked. Do you foresee any backlash from users that would not be happy with this change because they are used to the form this data had been presented to them? Would setting this graph to use the \u0027line\u0027 renderer instead make it more readable? (here is how the sample graph would look like with lines instead of areas: https://github.com/mkarpiarz/cloudkitty-playground/blob/cost-per-service-per-h-graph/images/cloudkittydashboard_cost_per_service_per_hour_graph_line_renderer.png)","accounts_in_message":[],"_revision_number":2},{"id":"128e6f036c9a6fb017bd0655f57b2328db645953","author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"date":"2021-02-02 17:15:50.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e Thanks, Rafael. You are right - multiple series with similar values may overlap if areas are not stacked. Do you foresee any backlash from users that would not be happy with this change because they are used to the form this data had been presented to them? Would setting this graph to use the \u0027line\u0027 renderer instead make it more readable? (here is how the sample graph would look like with lines instead of areas: https://github.com/mkarpiarz/cloudkitty-playground/blob/cost-per-service-per-h-graph/images/cloudkittydashboard_cost_per_service_per_hour_graph_line_renderer.png)\n\nI do prefer the line trending than the one we are currently using. \nI would not worry much about people complaining. The method you are proposing, specially with the line trends makes more sense to me. What we could do then, is to create a \"virtual\" trend that would aggregate all of the others. What do you think?","accounts_in_message":[],"_revision_number":2},{"id":"f95599cd8cb49b1710d1407a0cf52320cf52e6cc","author":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"date":"2021-02-02 17:24:24.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e \u003e Patch Set 2:\n\u003e \u003e \n\u003e \u003e Thanks, Rafael. You are right - multiple series with similar values may overlap if areas are not stacked. Do you foresee any backlash from users that would not be happy with this change because they are used to the form this data had been presented to them? Would setting this graph to use the \u0027line\u0027 renderer instead make it more readable? (here is how the sample graph would look like with lines instead of areas: https://github.com/mkarpiarz/cloudkitty-playground/blob/cost-per-service-per-h-graph/images/cloudkittydashboard_cost_per_service_per_hour_graph_line_renderer.png)\n\u003e \n\u003e I do prefer the line trending than the one we are currently using. \n\u003e I would not worry much about people complaining. The method you are proposing, specially with the line trends makes more sense to me. What we could do then, is to create a \"virtual\" trend that would aggregate all of the others. What do you think?\n\nYes, I\u0027ve been thinking about an extra series that would sum all points for each X. Though this might not be as simple as I think and is probably something for a different story. :)","accounts_in_message":[],"_revision_number":2},{"id":"8c7b7974c53ef4ef94e0cffcf5859a31553ba261","author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"date":"2021-02-08 10:19:46.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nPlease add a reno release note. Also, do you have a screenshot of what the graph looks like with this patch?","accounts_in_message":[],"_revision_number":2},{"id":"9b430c73bae86e192befb7dbb6cc6bebd9dc3ef5","author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"date":"2021-02-08 10:22:36.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2: Code-Review-1\n\u003e \n\u003e (1 comment)\n\u003e \n\u003e Please add a reno release note. Also, do you have a screenshot of what the graph looks like with this patch?\n\nNevermind about the screenshots, I thought I had seen them somewhere before… Found them again on Storyboard.","accounts_in_message":[],"_revision_number":2},{"id":"a307ffaa87d9c2b63bb6ab38c625b3b285754c9b","author":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"date":"2021-02-08 12:18:50.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2: Code-Review-1\n\u003e \n\u003e (1 comment)\n\u003e \n\u003e Please add a reno release note. Also, do you have a screenshot of what the graph looks like with this patch?\n\nThanks! You are right, Task ID here is different than the Story ID. I\u0027ll fix this in the next patch.\n\nAs for release notes, what type of note should it be? An \"update\" note, \"bug fix\" or \"other\"?","accounts_in_message":[],"_revision_number":2},{"id":"0164ed973ffae6a2e5252872a92cf45bab714c88","author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"date":"2021-02-08 12:58:00.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e \u003e Patch Set 2: Code-Review-1\n\u003e \u003e \n\u003e \u003e (1 comment)\n\u003e \u003e \n\u003e \u003e Please add a reno release note. Also, do you have a screenshot of what the graph looks like with this patch?\n\u003e \n\u003e Thanks! You are right, Task ID here is different than the Story ID. I\u0027ll fix this in the next patch.\n\u003e \n\u003e As for release notes, what type of note should it be? An \"update\" note, \"bug fix\" or \"other\"?\n\nI would write it under an upgrade note.","accounts_in_message":[],"_revision_number":2},{"id":"03001aff327b14a622c34794d5186749337f327c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"date":"2021-02-08 16:11:37.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"b1ac00a1e97cfe022ddc7acdb0bf1fb209c5eaf0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-08 16:24:05.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d0d61b0d8acd47a19948f8a8a8b72946 : SUCCESS in 3m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f4c20785249e4b4bb6c213b57e3d9317 : SUCCESS in 4m 22s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9b9c0dac94aa4564b6ac9607471b776a : SUCCESS in 3m 45s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/2608c4c7486544a98a57e9b8440160ef : SUCCESS in 4m 05s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/917220bb1bd249e99ba9f9cfd0511873 : SUCCESS in 4m 56s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/0a47316f9e8342fe81a903e58420660a : SUCCESS in 3m 06s","accounts_in_message":[],"_revision_number":3},{"id":"f9c96a5b4171e163d35ac87788938435b14347b1","author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"date":"2021-02-18 11:38:23.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"b2149e732d518beac76a5d21b9c39a7726d46edf","author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"date":"2021-02-18 15:34:18.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1 Review-Priority+2","accounts_in_message":[],"_revision_number":3},{"id":"dfd984597b55bd57c7982bc0ebd729befcf08900","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-18 15:34:41.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"10268d9b4a81c977d24f06328ebc3d48290c3061","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-18 15:45:02.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/5a1602518553461fbe51e75fa3708caf : SUCCESS in 4m 04s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/017fe7d7367d466a89fbbdca5975724c : SUCCESS in 4m 58s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0f8b34b6f90a4d21a667911b98918a32 : SUCCESS in 6m 31s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/113cbd1ef8d14f1bbbd0a4212f4e492a : SUCCESS in 6m 24s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/07f7f99a08c44aed91abb484009a0616 : SUCCESS in 4m 40s","accounts_in_message":[],"_revision_number":3},{"id":"882c64ed4a2d66fabd37b86c68e1356c6f5505cb","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-18 15:45:10.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"b45fa5e9adf61f52241821bed6200e3534f66e75","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-18 15:46:58.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f1468dfd09c2445aaf667b789f85d166 : SUCCESS in 1m 05s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b4a490bba4ee454a90210335a9a27970 : SUCCESS in 1m 09s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"1cf4c9534c35e797fea279f7d4e6ed2c33006af9","revisions":{"bea454fa6fc1fa3619b756ca9880a043c81b90d1":{"kind":"REWORK","_number":1,"created":"2021-02-02 13:06:14.000000000","uploader":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"ref":"refs/changes/80/773680/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cloudkitty-dashboard","ref":"refs/changes/80/773680/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cloudkitty-dashboard refs/changes/80/773680/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cloudkitty-dashboard refs/changes/80/773680/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cloudkitty-dashboard refs/changes/80/773680/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cloudkitty-dashboard refs/changes/80/773680/1"}}},"commit":{"parents":[{"commit":"3439344923f8fc7ff22c6daf5a834819af35ffa3","subject":"Imported Translations from Zanata","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty-dashboard/commit/3439344923f8fc7ff22c6daf5a834819af35ffa3"}]}],"author":{"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@vscaler.com","date":"2021-02-02 11:59:20.000000000","tz":0},"committer":{"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@vscaler.com","date":"2021-02-02 11:59:20.000000000","tz":0},"subject":"Unstack series on on the \"Cost Per Service Per Hour\" graph","message":"Unstack series on on the \"Cost Per Service Per Hour\" graph\n\nBy default series on the \"Cost Per Service Per Hour\" graph are stacked\ntogether which means:\n\n* all series have to have the same length, otherwise Rickshaw/D3 won\u0027t\n  be able to stack them up;\n* series are drawn one over another and since they are area graphs, this\n  gives false impression of scale (series other than the first one will\n  appear higher than what the scale on the Y axis suggests)\n\nThis change disables stacking of data series.\n\nTask: 2008582\nStory: 2008582\n\nChange-Id: I6aed92383a70f8dcf26c45155ef1d16169d40601\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty-dashboard/commit/bea454fa6fc1fa3619b756ca9880a043c81b90d1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty-dashboard/commit/bea454fa6fc1fa3619b756ca9880a043c81b90d1"}]},"branch":"refs/heads/master"},"76421e90f195ecbc255e5cddabc52e22175ba400":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-02-02 13:08:15.000000000","uploader":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"ref":"refs/changes/80/773680/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cloudkitty-dashboard","ref":"refs/changes/80/773680/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cloudkitty-dashboard refs/changes/80/773680/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cloudkitty-dashboard refs/changes/80/773680/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cloudkitty-dashboard refs/changes/80/773680/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cloudkitty-dashboard refs/changes/80/773680/2"}}},"commit":{"parents":[{"commit":"3439344923f8fc7ff22c6daf5a834819af35ffa3","subject":"Imported Translations from Zanata","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty-dashboard/commit/3439344923f8fc7ff22c6daf5a834819af35ffa3"}]}],"author":{"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@vscaler.com","date":"2021-02-02 11:59:20.000000000","tz":0},"committer":{"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@vscaler.com","date":"2021-02-02 13:07:30.000000000","tz":0},"subject":"Unstack series on the \"Cost Per Service Per Hour\" graph","message":"Unstack series on the \"Cost Per Service Per Hour\" graph\n\nBy default series on the \"Cost Per Service Per Hour\" graph are stacked\ntogether which means:\n\n* all series have to have the same length, otherwise Rickshaw/D3 won\u0027t\n  be able to stack them up;\n* series are drawn one over another and since they are area graphs, this\n  gives false impression of scale (series other than the first one will\n  appear higher than what the scale on the Y axis suggests)\n\nThis change disables stacking of data series.\n\nTask: 2008582\nStory: 2008582\n\nChange-Id: I6aed92383a70f8dcf26c45155ef1d16169d40601\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty-dashboard/commit/76421e90f195ecbc255e5cddabc52e22175ba400"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty-dashboard/commit/76421e90f195ecbc255e5cddabc52e22175ba400"}]},"branch":"refs/heads/master"},"1cf4c9534c35e797fea279f7d4e6ed2c33006af9":{"kind":"REWORK","_number":3,"created":"2021-02-08 16:11:37.000000000","uploader":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"ref":"refs/changes/80/773680/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cloudkitty-dashboard","ref":"refs/changes/80/773680/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cloudkitty-dashboard refs/changes/80/773680/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cloudkitty-dashboard refs/changes/80/773680/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cloudkitty-dashboard refs/changes/80/773680/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cloudkitty-dashboard refs/changes/80/773680/3"}}},"commit":{"parents":[{"commit":"3439344923f8fc7ff22c6daf5a834819af35ffa3","subject":"Imported Translations from Zanata","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty-dashboard/commit/3439344923f8fc7ff22c6daf5a834819af35ffa3"}]}],"author":{"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@vscaler.com","date":"2021-02-02 11:59:20.000000000","tz":0},"committer":{"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@vscaler.com","date":"2021-02-08 16:09:44.000000000","tz":0},"subject":"Unstack series on the \"Cost Per Service Per Hour\" graph","message":"Unstack series on the \"Cost Per Service Per Hour\" graph\n\nBy default series on the \"Cost Per Service Per Hour\" graph are stacked\ntogether which means:\n\n* all series have to have the same length, otherwise Rickshaw/D3 won\u0027t\n  be able to stack them up;\n* series are drawn one over another and since they are area graphs, this\n  gives false impression of scale (series other than the first one will\n  appear higher than what the scale on the Y axis suggests)\n\nThis change disables stacking of data series.\n\nStory: 2008582\nTask: 41735\n\nChange-Id: I6aed92383a70f8dcf26c45155ef1d16169d40601\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty-dashboard/commit/1cf4c9534c35e797fea279f7d4e6ed2c33006af9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty-dashboard/commit/1cf4c9534c35e797fea279f7d4e6ed2c33006af9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"}},{"label":"Review-Priority","status":"MAY","applied_by":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}