)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12015,"name":"François Magimel","email":"magimel.francois@gmail.com","username":"linkid"},"change_message_id":"cadf762b77cef3d7954461f92c40fa5a06c839a8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Spec: Adding a v2 API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This a spec proposing to add a v2 API to cloudkitty."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"See specs/stein/implementing_cloudkittys_v2_api_root.rst for details."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dfd5e7cf_5a9dc457","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":5},"updated":"2019-01-06 17:23:37.000000000","message":"You forgot the verb.","commit_id":"cfe3ba4d288f2dd825242bb673be4cc5c3da3cd7"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"4188354d207b46bd5b35aeaa9759b75af3fd1833","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Spec: Adding a v2 API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This a spec proposing to add a v2 API to cloudkitty."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"See specs/stein/implementing_cloudkittys_v2_api_root.rst for details."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_91d65d27","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":5},"in_reply_to":"dfd5e7cf_5a9dc457","updated":"2019-01-24 13:23:09.000000000","message":"Done","commit_id":"cfe3ba4d288f2dd825242bb673be4cc5c3da3cd7"},{"author":{"_account_id":12015,"name":"François Magimel","email":"magimel.francois@gmail.com","username":"linkid"},"change_message_id":"cadf762b77cef3d7954461f92c40fa5a06c839a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dfd5e7cf_faa11897","line":14,"updated":"2019-01-06 17:23:37.000000000","message":"I think it would be great to add in the footer the id of the story / task too, to link it in the storyboard.","commit_id":"cfe3ba4d288f2dd825242bb673be4cc5c3da3cd7"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"4188354d207b46bd5b35aeaa9759b75af3fd1833","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9fdfeff1_31b691fc","line":14,"in_reply_to":"dfd5e7cf_faa11897","updated":"2019-01-24 13:23:09.000000000","message":"Done","commit_id":"cfe3ba4d288f2dd825242bb673be4cc5c3da3cd7"}],"specs/stein/adding_a_v2_api_to_cloudkitty.rst":[{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"a16812627f0af541d217cc1703590c34c3471e18","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"In consequence to the previously evoked reasons, the CloudKitty development"},{"line_number":44,"context_line":"team proposes to implement a new API, which would be based on Flask/Werkzeug"},{"line_number":45,"context_line":"(and maybe Flask-RESTful, to be discussed)."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"This new API should make it easy to add a new endpoint, and would be a container"},{"line_number":48,"context_line":"to new features. Any new endpoint should be added to this API."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_61b4681e","line":45,"range":{"start_line":45,"start_character":11,"end_line":45,"end_character":41},"updated":"2018-11-14 16:53:21.000000000","message":"Where do you want to discuss this ? what will be the benefits to use Flask-RESTful ?","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"780271c0a0934ec3591bb63a631873020ab6b64f","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"In consequence to the previously evoked reasons, the CloudKitty development"},{"line_number":44,"context_line":"team proposes to implement a new API, which would be based on Flask/Werkzeug"},{"line_number":45,"context_line":"(and maybe Flask-RESTful, to be discussed)."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"This new API should make it easy to add a new endpoint, and would be a container"},{"line_number":48,"context_line":"to new features. Any new endpoint should be added to this API."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_a919fe76","line":45,"range":{"start_line":45,"start_character":11,"end_line":45,"end_character":41},"in_reply_to":"3f79a3b5_61b4681e","updated":"2018-11-15 09:52:18.000000000","message":"Well this seems to be a good place for discussion ;) It is not required, but It has several big advantages IMO:\n\n- It makes code easier to read + Routing is also eased. If we can have a one endpoint (like /rating/hashmap) mapped to one blueprint and each sub-endpoint (/rating/hashmap/services) mapped to a Flask-Restful resource, adding endpoints can be easy. Here\u0027s a working code sample I created with voluptuous input/output validation:\n\n```\nclass Example(flask_restful.Resource):\n\n    @api_utils.add_output_schema(GET_OUTPUT_EXAMPLE_SCHEMA)\n    def get(self):\n        policy.authorize(flask.request.context, \u0027example:get_example\u0027, {})\n        return {}\n\n    @api_utils.add_input_schema(POST_INPUT_EXAMPLE_SCHEMA)\n    def post(self, fruit\u003d\u0027banana\u0027):\n        policy.authorize(flask.request.context, \u0027example:submit_fruit\u0027, {})\n        if fruit not in [\u0027banana\u0027, \u0027strawberry\u0027]:\n            raise http_exceptions.Forbidden(\n                \u0027You submitted a forbidden fruit\u0027,\n            )\n\treturn {\n            \u0027msg\u0027: \u0027Your fruit is a \u0027 + fruit\n        }\n```\n\n- It kinda forces contributors (or at least greatly encourages them) to have a restful approach for the API, whereas Flask only leaves them too much freedom IMO.\n\nEDIT: hmm, I feel like this should be added to the spec","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"003ca4ba9ebb75dbe179daf6d56e81d842f35b57","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"In consequence to the previously evoked reasons, the CloudKitty development"},{"line_number":44,"context_line":"team proposes to implement a new API, which would be based on Flask/Werkzeug"},{"line_number":45,"context_line":"(and maybe Flask-RESTful, to be discussed)."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"This new API should make it easy to add a new endpoint, and would be a container"},{"line_number":48,"context_line":"to new features. Any new endpoint should be added to this API."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_960a0b1d","line":45,"range":{"start_line":45,"start_character":11,"end_line":45,"end_character":41},"in_reply_to":"3f79a3b5_a919fe76","updated":"2018-11-16 09:07:49.000000000","message":"Seems to me an obvious choice then :-D\n\nAnd yes, it may be interesting to add this to the spec as example","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"a16812627f0af541d217cc1703590c34c3471e18","unresolved":false,"context_lines":[{"line_number":50,"context_line":"This v2 API would only be compatible with the v2 storage, allowing new endpoints"},{"line_number":51,"context_line":"to completely exploit the capacities of the v2 storage, without having to handle"},{"line_number":52,"context_line":"backward compatibility. The v1 API is completely compatible with the v2 storage,"},{"line_number":53,"context_line":"so data would still be accessible through the v1 API, compatibilty with"},{"line_number":54,"context_line":"existing scripts etc... would be kept. The v2 API would be disabled when a v1"},{"line_number":55,"context_line":"storage backend is used."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_de3759fd","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":13},"updated":"2018-11-14 16:53:21.000000000","message":"In a spec, I\u0027d rather use \"will\" here instead of would","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"780271c0a0934ec3591bb63a631873020ab6b64f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"This v2 API would only be compatible with the v2 storage, allowing new endpoints"},{"line_number":51,"context_line":"to completely exploit the capacities of the v2 storage, without having to handle"},{"line_number":52,"context_line":"backward compatibility. The v1 API is completely compatible with the v2 storage,"},{"line_number":53,"context_line":"so data would still be accessible through the v1 API, compatibilty with"},{"line_number":54,"context_line":"existing scripts etc... would be kept. The v2 API would be disabled when a v1"},{"line_number":55,"context_line":"storage backend is used."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_492aaa78","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":13},"in_reply_to":"3f79a3b5_de3759fd","updated":"2018-11-15 09:52:18.000000000","message":"Agreed, I will remove the conditional form from the spec","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"a16812627f0af541d217cc1703590c34c3471e18","unresolved":false,"context_lines":[{"line_number":51,"context_line":"to completely exploit the capacities of the v2 storage, without having to handle"},{"line_number":52,"context_line":"backward compatibility. The v1 API is completely compatible with the v2 storage,"},{"line_number":53,"context_line":"so data would still be accessible through the v1 API, compatibilty with"},{"line_number":54,"context_line":"existing scripts etc... would be kept. The v2 API would be disabled when a v1"},{"line_number":55,"context_line":"storage backend is used."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"In order to limit the workload, not all v1 endpoints would be migrated at once."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_1ebb9174","line":54,"range":{"start_line":54,"start_character":50,"end_line":54,"end_character":55},"updated":"2018-11-14 16:53:21.000000000","message":"should ?","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"a16812627f0af541d217cc1703590c34c3471e18","unresolved":false,"context_lines":[{"line_number":58,"context_line":"The proposition would be to have one WSGI app per API version, and to"},{"line_number":59,"context_line":"distinguish between them through routing. this could be done with Werkzeug\u0027s"},{"line_number":60,"context_line":"``DispatcherMiddleware``: http://werkzeug.pocoo.org/docs/0.14/middlewares/#werkzeug.wsgi.DispatcherMiddleware."},{"line_number":61,"context_line":"In case a v1 storage backend is used, the v2 API would simply not be loaded."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"V1 endpoints would be migrated one after another, depending on the availability"},{"line_number":64,"context_line":"of the maintainers. Once the entire v1 API has been migrated, the v2 API will be"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_7ea96524","line":61,"range":{"start_line":61,"start_character":49,"end_line":61,"end_character":54},"updated":"2018-11-14 16:53:21.000000000","message":"In a spec, I\u0027d rather use \"should\" here to highlight the fact that the implementation SHOULD not load the v2 api","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"a16812627f0af541d217cc1703590c34c3471e18","unresolved":false,"context_lines":[{"line_number":60,"context_line":"``DispatcherMiddleware``: http://werkzeug.pocoo.org/docs/0.14/middlewares/#werkzeug.wsgi.DispatcherMiddleware."},{"line_number":61,"context_line":"In case a v1 storage backend is used, the v2 API would simply not be loaded."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"V1 endpoints would be migrated one after another, depending on the availability"},{"line_number":64,"context_line":"of the maintainers. Once the entire v1 API has been migrated, the v2 API will be"},{"line_number":65,"context_line":"marked as ``CURRENT``, and the v1 API will be marked as ``DEPRECATED``. Until"},{"line_number":66,"context_line":"that point is reached, v1 will be ``CURRENT`` and v2 will be ``EXPERIMENTAL``."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_6111c850","line":63,"range":{"start_line":63,"start_character":13,"end_line":63,"end_character":18},"updated":"2018-11-14 16:53:21.000000000","message":"Same as above, use \"will\" ... there\u0027s no reason to believe that we may revert this process","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"a16812627f0af541d217cc1703590c34c3471e18","unresolved":false,"context_lines":[{"line_number":64,"context_line":"of the maintainers. Once the entire v1 API has been migrated, the v2 API will be"},{"line_number":65,"context_line":"marked as ``CURRENT``, and the v1 API will be marked as ``DEPRECATED``. Until"},{"line_number":66,"context_line":"that point is reached, v1 will be ``CURRENT`` and v2 will be ``EXPERIMENTAL``."},{"line_number":67,"context_line":"Once the v2 API is stable and marked as the current API, il should be"},{"line_number":68,"context_line":"**microversioned** in order to have an indicator of its capabilities. A"},{"line_number":69,"context_line":"microversion increase would be indicating a new feature (new endpoint)."},{"line_number":70,"context_line":"However, API endpoints in OpenStack\u0027s service catalog would **not** be"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_a13040ec","line":67,"range":{"start_line":67,"start_character":57,"end_line":67,"end_character":59},"updated":"2018-11-14 16:53:21.000000000","message":"typo","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"a16812627f0af541d217cc1703590c34c3471e18","unresolved":false,"context_lines":[{"line_number":65,"context_line":"marked as ``CURRENT``, and the v1 API will be marked as ``DEPRECATED``. Until"},{"line_number":66,"context_line":"that point is reached, v1 will be ``CURRENT`` and v2 will be ``EXPERIMENTAL``."},{"line_number":67,"context_line":"Once the v2 API is stable and marked as the current API, il should be"},{"line_number":68,"context_line":"**microversioned** in order to have an indicator of its capabilities. A"},{"line_number":69,"context_line":"microversion increase would be indicating a new feature (new endpoint)."},{"line_number":70,"context_line":"However, API endpoints in OpenStack\u0027s service catalog would **not** be"},{"line_number":71,"context_line":"microversioned. The exact version of the API would be available at the API root"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_613f88b2","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":68},"updated":"2018-11-14 16:53:21.000000000","message":"How will you provide insight of new endpoint availability during the EXPERIMENTAL period ? I think we should also microversion the v2 api during the EXPERIMENTAL period to keep track of the associated bugs.\n\nWe may just use the git id but we have to specify how we\u0027ll do the version tracking","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"0e58d0519c8dee359b6445c4df96852c7a052e29","unresolved":false,"context_lines":[{"line_number":65,"context_line":"marked as ``CURRENT``, and the v1 API will be marked as ``DEPRECATED``. Until"},{"line_number":66,"context_line":"that point is reached, v1 will be ``CURRENT`` and v2 will be ``EXPERIMENTAL``."},{"line_number":67,"context_line":"Once the v2 API is stable and marked as the current API, il should be"},{"line_number":68,"context_line":"**microversioned** in order to have an indicator of its capabilities. A"},{"line_number":69,"context_line":"microversion increase would be indicating a new feature (new endpoint)."},{"line_number":70,"context_line":"However, API endpoints in OpenStack\u0027s service catalog would **not** be"},{"line_number":71,"context_line":"microversioned. The exact version of the API would be available at the API root"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_e5f5c453","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":68},"in_reply_to":"3f79a3b5_36fc570a","updated":"2018-11-16 15:49:34.000000000","message":"We can also microversion before v2 is completely done, and suffix vith `beta` .","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"003ca4ba9ebb75dbe179daf6d56e81d842f35b57","unresolved":false,"context_lines":[{"line_number":65,"context_line":"marked as ``CURRENT``, and the v1 API will be marked as ``DEPRECATED``. Until"},{"line_number":66,"context_line":"that point is reached, v1 will be ``CURRENT`` and v2 will be ``EXPERIMENTAL``."},{"line_number":67,"context_line":"Once the v2 API is stable and marked as the current API, il should be"},{"line_number":68,"context_line":"**microversioned** in order to have an indicator of its capabilities. A"},{"line_number":69,"context_line":"microversion increase would be indicating a new feature (new endpoint)."},{"line_number":70,"context_line":"However, API endpoints in OpenStack\u0027s service catalog would **not** be"},{"line_number":71,"context_line":"microversioned. The exact version of the API would be available at the API root"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_36fc570a","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":68},"in_reply_to":"3f79a3b5_49494a2d","updated":"2018-11-16 09:07:49.000000000","message":"Need to think a bit more about it, keep you posted","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"780271c0a0934ec3591bb63a631873020ab6b64f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"marked as ``CURRENT``, and the v1 API will be marked as ``DEPRECATED``. Until"},{"line_number":66,"context_line":"that point is reached, v1 will be ``CURRENT`` and v2 will be ``EXPERIMENTAL``."},{"line_number":67,"context_line":"Once the v2 API is stable and marked as the current API, il should be"},{"line_number":68,"context_line":"**microversioned** in order to have an indicator of its capabilities. A"},{"line_number":69,"context_line":"microversion increase would be indicating a new feature (new endpoint)."},{"line_number":70,"context_line":"However, API endpoints in OpenStack\u0027s service catalog would **not** be"},{"line_number":71,"context_line":"microversioned. The exact version of the API would be available at the API root"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_49494a2d","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":68},"in_reply_to":"3f79a3b5_613f88b2","updated":"2018-11-15 09:52:18.000000000","message":"For me, 2.0 should be the version of the v2 API staring at which v1 is not needed anymore. How about versioning with the UPDATED_AT field ?","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"a16812627f0af541d217cc1703590c34c3471e18","unresolved":false,"context_lines":[{"line_number":67,"context_line":"Once the v2 API is stable and marked as the current API, il should be"},{"line_number":68,"context_line":"**microversioned** in order to have an indicator of its capabilities. A"},{"line_number":69,"context_line":"microversion increase would be indicating a new feature (new endpoint)."},{"line_number":70,"context_line":"However, API endpoints in OpenStack\u0027s service catalog would **not** be"},{"line_number":71,"context_line":"microversioned. The exact version of the API would be available at the API root"},{"line_number":72,"context_line":"(``/``)."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Alternatives"},{"line_number":75,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_41892c6e","line":72,"range":{"start_line":70,"start_character":0,"end_line":72,"end_character":8},"updated":"2018-11-14 16:53:21.000000000","message":"I think this worth a discussion ... not really sure to agree with you on this","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"003ca4ba9ebb75dbe179daf6d56e81d842f35b57","unresolved":false,"context_lines":[{"line_number":67,"context_line":"Once the v2 API is stable and marked as the current API, il should be"},{"line_number":68,"context_line":"**microversioned** in order to have an indicator of its capabilities. A"},{"line_number":69,"context_line":"microversion increase would be indicating a new feature (new endpoint)."},{"line_number":70,"context_line":"However, API endpoints in OpenStack\u0027s service catalog would **not** be"},{"line_number":71,"context_line":"microversioned. The exact version of the API would be available at the API root"},{"line_number":72,"context_line":"(``/``)."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Alternatives"},{"line_number":75,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_5b26dece","line":72,"range":{"start_line":70,"start_character":0,"end_line":72,"end_character":8},"in_reply_to":"3f79a3b5_29faceba","updated":"2018-11-16 09:07:49.000000000","message":"Ok for me then","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"780271c0a0934ec3591bb63a631873020ab6b64f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"Once the v2 API is stable and marked as the current API, il should be"},{"line_number":68,"context_line":"**microversioned** in order to have an indicator of its capabilities. A"},{"line_number":69,"context_line":"microversion increase would be indicating a new feature (new endpoint)."},{"line_number":70,"context_line":"However, API endpoints in OpenStack\u0027s service catalog would **not** be"},{"line_number":71,"context_line":"microversioned. The exact version of the API would be available at the API root"},{"line_number":72,"context_line":"(``/``)."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Alternatives"},{"line_number":75,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_29faceba","line":72,"range":{"start_line":70,"start_character":0,"end_line":72,"end_character":8},"in_reply_to":"3f79a3b5_41892c6e","updated":"2018-11-15 09:52:18.000000000","message":"API wg discouraged microversioning in the service catalog (glance and other projects don\u0027t do it either). And it may be harder to implement.\n\nAPI versionning can be done through openstack releases, I think adding it to the endpoint/url will only lead to bugs and a lot of questions","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"a16812627f0af541d217cc1703590c34c3471e18","unresolved":false,"context_lines":[{"line_number":86,"context_line":"are routed) has no impact on the datamodel. Each v2 API endpoint will be the"},{"line_number":87,"context_line":"subject of a new spec. Potential data model impact will be detailed in these"},{"line_number":88,"context_line":"upcoming specs."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"REST API impact"},{"line_number":91,"context_line":"---------------"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_e1ef181a","line":89,"updated":"2018-11-14 16:53:21.000000000","message":"and configuration model impact ?","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"0b6063239de3af6f92bc7cd6980b1f4b63774637","unresolved":false,"context_lines":[{"line_number":86,"context_line":"are routed) has no impact on the datamodel. Each v2 API endpoint will be the"},{"line_number":87,"context_line":"subject of a new spec. Potential data model impact will be detailed in these"},{"line_number":88,"context_line":"upcoming specs."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"REST API impact"},{"line_number":91,"context_line":"---------------"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_256c1c9d","line":89,"in_reply_to":"3f79a3b5_76116f50","updated":"2018-11-16 15:10:23.000000000","message":"We keep pecan/v1 for now, so there won\u0027t be","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"003ca4ba9ebb75dbe179daf6d56e81d842f35b57","unresolved":false,"context_lines":[{"line_number":86,"context_line":"are routed) has no impact on the datamodel. Each v2 API endpoint will be the"},{"line_number":87,"context_line":"subject of a new spec. Potential data model impact will be detailed in these"},{"line_number":88,"context_line":"upcoming specs."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"REST API impact"},{"line_number":91,"context_line":"---------------"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_76116f50","line":89,"in_reply_to":"3f79a3b5_a91fbe09","updated":"2018-11-16 09:07:49.000000000","message":"Yes but will you have deprecated parameters ?","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"780271c0a0934ec3591bb63a631873020ab6b64f","unresolved":false,"context_lines":[{"line_number":86,"context_line":"are routed) has no impact on the datamodel. Each v2 API endpoint will be the"},{"line_number":87,"context_line":"subject of a new spec. Potential data model impact will be detailed in these"},{"line_number":88,"context_line":"upcoming specs."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"REST API impact"},{"line_number":91,"context_line":"---------------"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_a91fbe09","line":89,"in_reply_to":"3f79a3b5_e1ef181a","updated":"2018-11-15 09:52:18.000000000","message":"None. The v2 api is loaded or not depending on the storage version, there is no need for new options","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"003ca4ba9ebb75dbe179daf6d56e81d842f35b57","unresolved":false,"context_lines":[{"line_number":110,"context_line":"Other end user impact"},{"line_number":111,"context_line":"---------------------"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"None. However, ``python-cloudkittyclient`` will need to be comaptible with the"},{"line_number":114,"context_line":"new v2 endpoints."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Performance Impact"},{"line_number":117,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_d66723ec","line":114,"range":{"start_line":113,"start_character":0,"end_line":114,"end_character":17},"updated":"2018-11-16 09:07:49.000000000","message":"Oh I missed this one in my first review ... how do you plan to track the compatibility between the two components ? dedicated spec for the client when adding new endpoint ? or in CK spec with a specific task for the client (and dashboard) implementation ?\nI think I prefers the second option, to keep every thing in one place","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":12015,"name":"François Magimel","email":"magimel.francois@gmail.com","username":"linkid"},"change_message_id":"cadf762b77cef3d7954461f92c40fa5a06c839a8","unresolved":false,"context_lines":[{"line_number":110,"context_line":"Other end user impact"},{"line_number":111,"context_line":"---------------------"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"None. However, ``python-cloudkittyclient`` will need to be comaptible with the"},{"line_number":114,"context_line":"new v2 endpoints."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Performance Impact"},{"line_number":117,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dfd5e7cf_fa6b581c","line":114,"range":{"start_line":113,"start_character":0,"end_line":114,"end_character":17},"in_reply_to":"3f79a3b5_c5cd28ba","updated":"2019-01-06 17:23:37.000000000","message":"\u003e A story with one task per CloudKitty component + one spec for each\n\u003e endpoint seems enough. A patch on the client depending on the patch\n\u003e on the API should be mandatory. I don\u0027t know if we should make\n\u003e patches on the dashboard mandatory though, could be a bit much to\n\u003e ask. Thoughts ?\n\nI think it would be great to update the dashboard too, when a new endpoint is created. Or at least creating a task not to forget it.","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"0b6063239de3af6f92bc7cd6980b1f4b63774637","unresolved":false,"context_lines":[{"line_number":110,"context_line":"Other end user impact"},{"line_number":111,"context_line":"---------------------"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"None. However, ``python-cloudkittyclient`` will need to be comaptible with the"},{"line_number":114,"context_line":"new v2 endpoints."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Performance Impact"},{"line_number":117,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_c5cd28ba","line":114,"range":{"start_line":113,"start_character":0,"end_line":114,"end_character":17},"in_reply_to":"3f79a3b5_d66723ec","updated":"2018-11-16 15:10:23.000000000","message":"For me, a dedicated spec for the client is too much.\n\nA story with one task per CloudKitty component + one spec for each endpoint seems enough. A patch on the client depending on the patch on the API should be mandatory. I don\u0027t know if we should make patches on the dashboard mandatory though, could be a bit much to ask. Thoughts ?\n\nI will also add details about this on this spec.\n\nNOTE: typo on compatible\n\nEDIT: a patch on the tempest plugin should also be mandatory","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"a16812627f0af541d217cc1703590c34c3471e18","unresolved":false,"context_lines":[{"line_number":116,"context_line":"Performance Impact"},{"line_number":117,"context_line":"------------------"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"None"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Other deployer impact"},{"line_number":122,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_61db087a","line":119,"range":{"start_line":119,"start_character":0,"end_line":119,"end_character":4},"updated":"2018-11-14 16:53:21.000000000","message":"We hope to improve global performance by allowing paging, filtering, etc.","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"780271c0a0934ec3591bb63a631873020ab6b64f","unresolved":false,"context_lines":[{"line_number":116,"context_line":"Performance Impact"},{"line_number":117,"context_line":"------------------"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"None"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Other deployer impact"},{"line_number":122,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_6919a622","line":119,"range":{"start_line":119,"start_character":0,"end_line":119,"end_character":4},"in_reply_to":"3f79a3b5_61db087a","updated":"2018-11-15 09:52:18.000000000","message":"True, will add","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"a16812627f0af541d217cc1703590c34c3471e18","unresolved":false,"context_lines":[{"line_number":149,"context_line":"* Update the documentation: Update the developer documentation with an"},{"line_number":150,"context_line":"  explanantion about how to add an enpoint and generate the documentation of"},{"line_number":151,"context_line":"  the v2 API."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Dependencies"},{"line_number":154,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_41fa8cbb","line":152,"updated":"2018-11-14 16:53:21.000000000","message":"Should\u0027nt you choose one v1 api to migrate to complete this spec ? it would serve a reference/good practice for further development","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"003ca4ba9ebb75dbe179daf6d56e81d842f35b57","unresolved":false,"context_lines":[{"line_number":149,"context_line":"* Update the documentation: Update the developer documentation with an"},{"line_number":150,"context_line":"  explanantion about how to add an enpoint and generate the documentation of"},{"line_number":151,"context_line":"  the v2 API."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Dependencies"},{"line_number":154,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_b65e2712","line":152,"in_reply_to":"3f79a3b5_41fa8cbb","updated":"2018-11-16 09:07:49.000000000","message":"and this ? :-)","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"0b6063239de3af6f92bc7cd6980b1f4b63774637","unresolved":false,"context_lines":[{"line_number":149,"context_line":"* Update the documentation: Update the developer documentation with an"},{"line_number":150,"context_line":"  explanantion about how to add an enpoint and generate the documentation of"},{"line_number":151,"context_line":"  the v2 API."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Dependencies"},{"line_number":154,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_453ef888","line":152,"in_reply_to":"3f79a3b5_b65e2712","updated":"2018-11-16 15:10:23.000000000","message":"Either adding a v1 endpoint, or adding an example endpoint, like the one with the fruits above. Example would be removed as soon as the first v2 endpoint is implemented (probably an interface to the v2 storage).","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"0b6063239de3af6f92bc7cd6980b1f4b63774637","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"* Flask"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"* [optional] Flask-RESTful"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Testing"},{"line_number":161,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_a5582cfc","line":158,"range":{"start_line":158,"start_character":2,"end_line":158,"end_character":26},"updated":"2018-11-16 15:10:23.000000000","message":"I\u0027ll remove the [optional] tag.","commit_id":"9db77a58f7dc6de9b4816d24634b2a98fc901cb6"},{"author":{"_account_id":12015,"name":"François Magimel","email":"magimel.francois@gmail.com","username":"linkid"},"change_message_id":"cadf762b77cef3d7954461f92c40fa5a06c839a8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"2. For its current API, CloudKitty uses WSME + pecan. Code written using these"},{"line_number":33,"context_line":"   tools can be quite difficult to understand for new contributors. In addition"},{"line_number":34,"context_line":"   to that, pecan\u0027s development seems to have slowed down:"},{"line_number":35,"context_line":"   https://github.com/pecan/pecan/commits/master ."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"3. Semantics. A lot of endpoints are still using OpenStack-related terms"},{"line_number":38,"context_line":"   (tenant, service...)."}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfd5e7cf_1ac89c53","line":35,"range":{"start_line":35,"start_character":48,"end_line":35,"end_character":49},"updated":"2019-01-06 17:23:37.000000000","message":"Extra space.","commit_id":"cfe3ba4d288f2dd825242bb673be4cc5c3da3cd7"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"4188354d207b46bd5b35aeaa9759b75af3fd1833","unresolved":false,"context_lines":[{"line_number":32,"context_line":"2. For its current API, CloudKitty uses WSME + pecan. Code written using these"},{"line_number":33,"context_line":"   tools can be quite difficult to understand for new contributors. In addition"},{"line_number":34,"context_line":"   to that, pecan\u0027s development seems to have slowed down:"},{"line_number":35,"context_line":"   https://github.com/pecan/pecan/commits/master ."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"3. Semantics. A lot of endpoints are still using OpenStack-related terms"},{"line_number":38,"context_line":"   (tenant, service...)."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fdfeff1_f13b29ce","line":35,"range":{"start_line":35,"start_character":48,"end_line":35,"end_character":49},"in_reply_to":"dfd5e7cf_1ac89c53","updated":"2019-01-24 13:23:09.000000000","message":"When I remove the space, the dot at the end is interpreted as being part of the url, leading to 404s","commit_id":"cfe3ba4d288f2dd825242bb673be4cc5c3da3cd7"},{"author":{"_account_id":12015,"name":"François Magimel","email":"magimel.francois@gmail.com","username":"linkid"},"change_message_id":"cadf762b77cef3d7954461f92c40fa5a06c839a8","unresolved":false,"context_lines":[{"line_number":83,"context_line":"to completely exploit the capacities of the v2 storage, without having to handle"},{"line_number":84,"context_line":"backward compatibility. The v1 API is completely compatible with the v2 storage,"},{"line_number":85,"context_line":"so data will still be accessible through the v1 API, compatibilty with"},{"line_number":86,"context_line":"existing scripts etc... will be kept. The v2 API will be disabled when a v1"},{"line_number":87,"context_line":"storage backend is used."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"In order to limit the workload, not all v1 endpoints will be migrated at once."}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfd5e7cf_facfd854","line":86,"range":{"start_line":86,"start_character":20,"end_line":86,"end_character":23},"updated":"2019-01-06 17:23:37.000000000","message":"typo","commit_id":"cfe3ba4d288f2dd825242bb673be4cc5c3da3cd7"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"4188354d207b46bd5b35aeaa9759b75af3fd1833","unresolved":false,"context_lines":[{"line_number":83,"context_line":"to completely exploit the capacities of the v2 storage, without having to handle"},{"line_number":84,"context_line":"backward compatibility. The v1 API is completely compatible with the v2 storage,"},{"line_number":85,"context_line":"so data will still be accessible through the v1 API, compatibilty with"},{"line_number":86,"context_line":"existing scripts etc... will be kept. The v2 API will be disabled when a v1"},{"line_number":87,"context_line":"storage backend is used."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"In order to limit the workload, not all v1 endpoints will be migrated at once."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fdfeff1_3170d1a5","line":86,"range":{"start_line":86,"start_character":20,"end_line":86,"end_character":23},"in_reply_to":"dfd5e7cf_facfd854","updated":"2019-01-24 13:23:09.000000000","message":"Done","commit_id":"cfe3ba4d288f2dd825242bb673be4cc5c3da3cd7"},{"author":{"_account_id":12015,"name":"François Magimel","email":"magimel.francois@gmail.com","username":"linkid"},"change_message_id":"cadf762b77cef3d7954461f92c40fa5a06c839a8","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"In order to limit the workload, not all v1 endpoints will be migrated at once."},{"line_number":90,"context_line":"The proposition will be to have one WSGI app per API version, and to"},{"line_number":91,"context_line":"distinguish between them through routing. this could be done with Werkzeug\u0027s"},{"line_number":92,"context_line":"``DispatcherMiddleware``: http://werkzeug.pocoo.org/docs/0.14/middlewares/#werkzeug.wsgi.DispatcherMiddleware."},{"line_number":93,"context_line":"In case a v1 storage backend is used, the v2 API will simply not be loaded."},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfd5e7cf_dad694f2","line":91,"range":{"start_line":91,"start_character":42,"end_line":91,"end_character":43},"updated":"2019-01-06 17:23:37.000000000","message":"Uppercase letter","commit_id":"cfe3ba4d288f2dd825242bb673be4cc5c3da3cd7"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"4188354d207b46bd5b35aeaa9759b75af3fd1833","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"In order to limit the workload, not all v1 endpoints will be migrated at once."},{"line_number":90,"context_line":"The proposition will be to have one WSGI app per API version, and to"},{"line_number":91,"context_line":"distinguish between them through routing. this could be done with Werkzeug\u0027s"},{"line_number":92,"context_line":"``DispatcherMiddleware``: http://werkzeug.pocoo.org/docs/0.14/middlewares/#werkzeug.wsgi.DispatcherMiddleware."},{"line_number":93,"context_line":"In case a v1 storage backend is used, the v2 API will simply not be loaded."},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fdfeff1_517315b2","line":91,"range":{"start_line":91,"start_character":42,"end_line":91,"end_character":43},"in_reply_to":"dfd5e7cf_dad694f2","updated":"2019-01-24 13:23:09.000000000","message":"Done","commit_id":"cfe3ba4d288f2dd825242bb673be4cc5c3da3cd7"},{"author":{"_account_id":12015,"name":"François Magimel","email":"magimel.francois@gmail.com","username":"linkid"},"change_message_id":"cadf762b77cef3d7954461f92c40fa5a06c839a8","unresolved":false,"context_lines":[{"line_number":92,"context_line":"``DispatcherMiddleware``: http://werkzeug.pocoo.org/docs/0.14/middlewares/#werkzeug.wsgi.DispatcherMiddleware."},{"line_number":93,"context_line":"In case a v1 storage backend is used, the v2 API will simply not be loaded."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"V1 endpoints will be migrated one after another, depending on the availability"},{"line_number":96,"context_line":"of the maintainers. Once the entire v1 API has been migrated, the v2 API will be"},{"line_number":97,"context_line":"marked as ``CURRENT``, and the v1 API will be marked as ``DEPRECATED``. Until"},{"line_number":98,"context_line":"that point is reached, v1 will be ``CURRENT`` and v2 will be ``EXPERIMENTAL``."},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfd5e7cf_9a2facf5","line":96,"range":{"start_line":95,"start_character":47,"end_line":96,"end_character":18},"updated":"2019-01-06 17:23:37.000000000","message":"I don\u0027t think it\u0027s necessary to indicate that.","commit_id":"cfe3ba4d288f2dd825242bb673be4cc5c3da3cd7"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"4188354d207b46bd5b35aeaa9759b75af3fd1833","unresolved":false,"context_lines":[{"line_number":92,"context_line":"``DispatcherMiddleware``: http://werkzeug.pocoo.org/docs/0.14/middlewares/#werkzeug.wsgi.DispatcherMiddleware."},{"line_number":93,"context_line":"In case a v1 storage backend is used, the v2 API will simply not be loaded."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"V1 endpoints will be migrated one after another, depending on the availability"},{"line_number":96,"context_line":"of the maintainers. Once the entire v1 API has been migrated, the v2 API will be"},{"line_number":97,"context_line":"marked as ``CURRENT``, and the v1 API will be marked as ``DEPRECATED``. Until"},{"line_number":98,"context_line":"that point is reached, v1 will be ``CURRENT`` and v2 will be ``EXPERIMENTAL``."},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fdfeff1_f169e9bd","line":96,"range":{"start_line":95,"start_character":47,"end_line":96,"end_character":18},"in_reply_to":"dfd5e7cf_9a2facf5","updated":"2019-01-24 13:23:09.000000000","message":"Done","commit_id":"cfe3ba4d288f2dd825242bb673be4cc5c3da3cd7"},{"author":{"_account_id":12015,"name":"François Magimel","email":"magimel.francois@gmail.com","username":"linkid"},"change_message_id":"cadf762b77cef3d7954461f92c40fa5a06c839a8","unresolved":false,"context_lines":[{"line_number":128,"context_line":"(``/``)."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Versioning will be done using **semantic versioning** (https://semver.org/)."},{"line_number":131,"context_line":"Once all v1 endpoint have been migrated, and the v2 APi is considered stable,"},{"line_number":132,"context_line":"its version will be ``2.0``. Before that version, each version will be suffixed"},{"line_number":133,"context_line":"with ``-beta.version``."},{"line_number":134,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfd5e7cf_9a180cd4","line":131,"range":{"start_line":131,"start_character":54,"end_line":131,"end_character":55},"updated":"2019-01-06 17:23:37.000000000","message":"Uppercase letter","commit_id":"cfe3ba4d288f2dd825242bb673be4cc5c3da3cd7"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"4188354d207b46bd5b35aeaa9759b75af3fd1833","unresolved":false,"context_lines":[{"line_number":128,"context_line":"(``/``)."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Versioning will be done using **semantic versioning** (https://semver.org/)."},{"line_number":131,"context_line":"Once all v1 endpoint have been migrated, and the v2 APi is considered stable,"},{"line_number":132,"context_line":"its version will be ``2.0``. Before that version, each version will be suffixed"},{"line_number":133,"context_line":"with ``-beta.version``."},{"line_number":134,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fdfeff1_51f6b5fb","line":131,"range":{"start_line":131,"start_character":54,"end_line":131,"end_character":55},"in_reply_to":"dfd5e7cf_9a180cd4","updated":"2019-01-24 13:23:09.000000000","message":"Done","commit_id":"cfe3ba4d288f2dd825242bb673be4cc5c3da3cd7"},{"author":{"_account_id":12015,"name":"François Magimel","email":"magimel.francois@gmail.com","username":"linkid"},"change_message_id":"cadf762b77cef3d7954461f92c40fa5a06c839a8","unresolved":false,"context_lines":[{"line_number":137,"context_line":"Alternatives"},{"line_number":138,"context_line":"------------"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"* Migrate the whole v1 API to Flask and extend existing endpoints in order to"},{"line_number":141,"context_line":"  support the features listed above: This would imply to migrate the whole API"},{"line_number":142,"context_line":"  codebase at once, which can\u0027t be done. Also, this wouldn\u0027t address the"},{"line_number":143,"context_line":"  semantics problem."}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfd5e7cf_5a12a4b3","line":140,"range":{"start_line":140,"start_character":0,"end_line":140,"end_character":2},"updated":"2019-01-06 17:23:37.000000000","message":"A list is not needed for only one point, I think.","commit_id":"cfe3ba4d288f2dd825242bb673be4cc5c3da3cd7"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"4188354d207b46bd5b35aeaa9759b75af3fd1833","unresolved":false,"context_lines":[{"line_number":137,"context_line":"Alternatives"},{"line_number":138,"context_line":"------------"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"* Migrate the whole v1 API to Flask and extend existing endpoints in order to"},{"line_number":141,"context_line":"  support the features listed above: This would imply to migrate the whole API"},{"line_number":142,"context_line":"  codebase at once, which can\u0027t be done. Also, this wouldn\u0027t address the"},{"line_number":143,"context_line":"  semantics problem."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fdfeff1_f1dc8975","line":140,"range":{"start_line":140,"start_character":0,"end_line":140,"end_character":2},"in_reply_to":"dfd5e7cf_5a12a4b3","updated":"2019-01-24 13:23:09.000000000","message":"Done","commit_id":"cfe3ba4d288f2dd825242bb673be4cc5c3da3cd7"},{"author":{"_account_id":12015,"name":"François Magimel","email":"magimel.francois@gmail.com","username":"linkid"},"change_message_id":"cadf762b77cef3d7954461f92c40fa5a06c839a8","unresolved":false,"context_lines":[{"line_number":173,"context_line":"Other end user impact"},{"line_number":174,"context_line":"---------------------"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"None. However, ``python-cloudkittyclient`` will need to be comaptible with the"},{"line_number":177,"context_line":"new v2 endpoints."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfd5e7cf_7a78c8f7","line":176,"range":{"start_line":176,"start_character":62,"end_line":176,"end_character":64},"updated":"2019-01-06 17:23:37.000000000","message":"Typo","commit_id":"cfe3ba4d288f2dd825242bb673be4cc5c3da3cd7"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"4188354d207b46bd5b35aeaa9759b75af3fd1833","unresolved":false,"context_lines":[{"line_number":173,"context_line":"Other end user impact"},{"line_number":174,"context_line":"---------------------"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"None. However, ``python-cloudkittyclient`` will need to be comaptible with the"},{"line_number":177,"context_line":"new v2 endpoints."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fdfeff1_b191219c","line":176,"range":{"start_line":176,"start_character":62,"end_line":176,"end_character":64},"in_reply_to":"dfd5e7cf_7a78c8f7","updated":"2019-01-24 13:23:09.000000000","message":"Done","commit_id":"cfe3ba4d288f2dd825242bb673be4cc5c3da3cd7"},{"author":{"_account_id":12015,"name":"François Magimel","email":"magimel.francois@gmail.com","username":"linkid"},"change_message_id":"cadf762b77cef3d7954461f92c40fa5a06c839a8","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":"For developers, adding a new enpoint should be way easier."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"A depency on Flask (and maybe Flask-RESTful) will be added."},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"Implementation"},{"line_number":197,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfd5e7cf_1a697c24","line":194,"range":{"start_line":194,"start_character":2,"end_line":194,"end_character":9},"updated":"2019-01-06 17:23:37.000000000","message":"Typo","commit_id":"cfe3ba4d288f2dd825242bb673be4cc5c3da3cd7"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"4188354d207b46bd5b35aeaa9759b75af3fd1833","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":"For developers, adding a new enpoint should be way easier."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"A depency on Flask (and maybe Flask-RESTful) will be added."},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"Implementation"},{"line_number":197,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fdfeff1_31cc51bb","line":194,"range":{"start_line":194,"start_character":2,"end_line":194,"end_character":9},"in_reply_to":"dfd5e7cf_1a697c24","updated":"2019-01-24 13:23:09.000000000","message":"Done","commit_id":"cfe3ba4d288f2dd825242bb673be4cc5c3da3cd7"},{"author":{"_account_id":12015,"name":"François Magimel","email":"magimel.francois@gmail.com","username":"linkid"},"change_message_id":"cadf762b77cef3d7954461f92c40fa5a06c839a8","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Primary assignee:"},{"line_number":203,"context_line":"  lukapeschke/peschk_l"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Work Items"},{"line_number":206,"context_line":"----------"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfd5e7cf_bae390a4","line":204,"updated":"2019-01-06 17:23:37.000000000","message":"I think it could be great to add a gerrit topic in your spec too. Or is the story enough ?","commit_id":"cfe3ba4d288f2dd825242bb673be4cc5c3da3cd7"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"4188354d207b46bd5b35aeaa9759b75af3fd1833","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Primary assignee:"},{"line_number":203,"context_line":"  lukapeschke/peschk_l"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Work Items"},{"line_number":206,"context_line":"----------"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fdfeff1_d1e1452c","line":204,"in_reply_to":"dfd5e7cf_bae390a4","updated":"2019-01-24 13:23:09.000000000","message":"That\u0027s actually a good idea, will add.","commit_id":"cfe3ba4d288f2dd825242bb673be4cc5c3da3cd7"},{"author":{"_account_id":12015,"name":"François Magimel","email":"magimel.francois@gmail.com","username":"linkid"},"change_message_id":"cadf762b77cef3d7954461f92c40fa5a06c839a8","unresolved":false,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":"* Route the API with Werkzeug instead of Pecan"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"* Add an Example endpoint showing how to implement an endpoint, and how to"},{"line_number":213,"context_line":"  document it. This example endpoint should be removed as soon as the first"},{"line_number":214,"context_line":"  real endpoint is implemented."},{"line_number":215,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfd5e7cf_7ac68819","line":212,"updated":"2019-01-06 17:23:37.000000000","message":"Why do you want to add an example if you document the process to add one ?","commit_id":"cfe3ba4d288f2dd825242bb673be4cc5c3da3cd7"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"4188354d207b46bd5b35aeaa9759b75af3fd1833","unresolved":false,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":"* Route the API with Werkzeug instead of Pecan"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"* Add an Example endpoint showing how to implement an endpoint, and how to"},{"line_number":213,"context_line":"  document it. This example endpoint should be removed as soon as the first"},{"line_number":214,"context_line":"  real endpoint is implemented."},{"line_number":215,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fdfeff1_f14a4925","line":212,"in_reply_to":"dfd5e7cf_7ac68819","updated":"2019-01-24 13:23:09.000000000","message":"Because it is a nice addition to have when the first endpoint will be added (especially for sphinx syntax for the API doc generation).","commit_id":"cfe3ba4d288f2dd825242bb673be4cc5c3da3cd7"},{"author":{"_account_id":12015,"name":"François Magimel","email":"magimel.francois@gmail.com","username":"linkid"},"change_message_id":"cadf762b77cef3d7954461f92c40fa5a06c839a8","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"References"},{"line_number":242,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":243,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dfd5e7cf_5ad5c4b8","line":243,"updated":"2019-01-06 17:23:37.000000000","message":"Is there some doc used by the API WG ?","commit_id":"cfe3ba4d288f2dd825242bb673be4cc5c3da3cd7"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"4188354d207b46bd5b35aeaa9759b75af3fd1833","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"References"},{"line_number":242,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":243,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9fdfeff1_b11b6119","line":243,"in_reply_to":"dfd5e7cf_5ad5c4b8","updated":"2019-01-24 13:23:09.000000000","message":"We had a long chat, so it\u0027s mostly on IRC, but I\u0027ll add a ling to the wiki","commit_id":"cfe3ba4d288f2dd825242bb673be4cc5c3da3cd7"}]}
