)]}'
{"specs/stein/reworking_prometheus_collector.rst":[{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"162e14c394a8e27da1c4cddcabb7e07174d13906","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  The process is done post Prometheus service response causing"},{"line_number":30,"context_line":"  an overhead operational cost."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* The collector ignores **scope_key** configuration option,"},{"line_number":33,"context_line":"  disallowing scoping requests however it is the standard behaviour"},{"line_number":34,"context_line":"  to be found in other collectors of the project."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* The collector does not provide proper time windowing"},{"line_number":37,"context_line":"  as it requests **/query** endpoint of a Prometheus service"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_c03381f7","line":34,"range":{"start_line":32,"start_character":2,"end_line":34,"end_character":49},"updated":"2018-12-19 11:16:56.000000000","message":"You can add that this also is a problem for orchestration: if you deploy three processors, the exact same data will be collected three times and pushed three times to the storage backend, leading to false reports.","commit_id":"8d5d9a533246f096f6957dcdd3682d01ddc39c75"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"162e14c394a8e27da1c4cddcabb7e07174d13906","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  disallowing scoping requests however it is the standard behaviour"},{"line_number":34,"context_line":"  to be found in other collectors of the project."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* The collector does not provide proper time windowing"},{"line_number":37,"context_line":"  as it requests **/query** endpoint of a Prometheus service"},{"line_number":38,"context_line":"  instead of **/query_range** which is the correct endpoint to be used"},{"line_number":39,"context_line":"  in order to have fine-tuned time windowing over metric collection."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The collector also lacks several configuration options"},{"line_number":42,"context_line":"that are required to be available:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_209ef5b5","line":39,"range":{"start_line":36,"start_character":2,"end_line":39,"end_character":68},"updated":"2018-12-19 11:16:56.000000000","message":"Please use a positive tone: explain why it would be more logical to use /query_range","commit_id":"8d5d9a533246f096f6957dcdd3682d01ddc39c75"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"162e14c394a8e27da1c4cddcabb7e07174d13906","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  instead of **/query_range** which is the correct endpoint to be used"},{"line_number":39,"context_line":"  in order to have fine-tuned time windowing over metric collection."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The collector also lacks several configuration options"},{"line_number":42,"context_line":"that are required to be available:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* It lacks authentication configuration options to dial into"},{"line_number":45,"context_line":"  some secured Prometheus service."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_402f7156","line":42,"range":{"start_line":41,"start_character":0,"end_line":42,"end_character":34},"updated":"2018-12-19 11:16:56.000000000","message":"Positive tone: could you propose this as new useful features instead of lacking ones ?","commit_id":"8d5d9a533246f096f6957dcdd3682d01ddc39c75"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"162e14c394a8e27da1c4cddcabb7e07174d13906","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  authority file in order to authorize HTTPS requests"},{"line_number":49,"context_line":"  signed with custom certificate."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* It lacks an insecure configuration option to explicitly use HTTP insecure"},{"line_number":52,"context_line":"  requests to dial into some Prometheus service."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Proposed Change"},{"line_number":55,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_80f6e9d5","line":52,"range":{"start_line":51,"start_character":2,"end_line":52,"end_character":48},"updated":"2018-12-19 11:16:56.000000000","message":"\"insecure\" is generally used in order to make https requests with an untrusted certificate.","commit_id":"8d5d9a533246f096f6957dcdd3682d01ddc39c75"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"162e14c394a8e27da1c4cddcabb7e07174d13906","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"In **cloudkitty.conf**, under **[collector_prometheus]** section:"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"* Add a **prometheus_user** and a **prometheus_password** option"},{"line_number":60,"context_line":"  to provide credentials for authentication (both defaults: none)."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* Add a **cafile** option to allow custom certificate authority"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_e0c47d63","line":59,"range":{"start_line":59,"start_character":9,"end_line":59,"end_character":57},"updated":"2018-12-19 11:16:56.000000000","message":"If we choose this config option form (xxx_user and xxx_password), we need to update it in other components for consistency. I\u0027m OK with it though","commit_id":"8d5d9a533246f096f6957dcdd3682d01ddc39c75"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"162e14c394a8e27da1c4cddcabb7e07174d13906","unresolved":false,"context_lines":[{"line_number":62,"context_line":"* Add a **cafile** option to allow custom certificate authority"},{"line_number":63,"context_line":"  file (default: none)."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"* Add an **insecure** option to explicitly allow insecure HTTP request"},{"line_number":66,"context_line":"  (default: false). "},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* Add a **query_step** option to define query resolution in seconds"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_80bd89d3","line":65,"range":{"start_line":65,"start_character":58,"end_line":65,"end_character":63},"updated":"2018-12-19 11:16:56.000000000","message":"HTTPS","commit_id":"8d5d9a533246f096f6957dcdd3682d01ddc39c75"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"162e14c394a8e27da1c4cddcabb7e07174d13906","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  of range queries (default: 10)."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Possible deprecation of **extra_args/query** in **metrics.yml**"},{"line_number":73,"context_line":"for a defined metric (see Alternatives_ section)."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"In **metrics.yml**, for a defined metric, add an **aggregation_method** option"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_806b4953","line":73,"range":{"start_line":72,"start_character":0,"end_line":73,"end_character":49},"updated":"2018-12-19 11:16:56.000000000","message":"I\u0027m for a removal. Thoughts anyone ?","commit_id":"8d5d9a533246f096f6957dcdd3682d01ddc39c75"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"162e14c394a8e27da1c4cddcabb7e07174d13906","unresolved":false,"context_lines":[{"line_number":137,"context_line":"  This one will be configurable under **[collector_prometheus]/query_step**"},{"line_number":138,"context_line":"  key in **cloudkitty.conf**."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"* If **[collect]/scope_key** option is defined in **cloudkitty.conf**,"},{"line_number":141,"context_line":"  It will be added to filter every query with the corresponding **scope_id**."},{"line_number":142,"context_line":"  "},{"line_number":143,"context_line":"  e.g.:"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"  .. code-block:: YAML"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_008df926","line":142,"range":{"start_line":140,"start_character":0,"end_line":142,"end_character":2},"updated":"2018-12-19 11:16:56.000000000","message":"It is systematically defined. It defaults to \"project_id\"","commit_id":"8d5d9a533246f096f6957dcdd3682d01ddc39c75"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"162e14c394a8e27da1c4cddcabb7e07174d13906","unresolved":false,"context_lines":[{"line_number":227,"context_line":"Work Items"},{"line_number":228,"context_line":"----------"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"* Change configuration schema inside Prometheus collector."},{"line_number":231,"context_line":"* Change query building process accordingly inside Prometheus collector."},{"line_number":232,"context_line":"* Change query response formatting process inside Prometheus collector"},{"line_number":233,"context_line":"  due to **groupby** PromQL capabilities usage."},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"Dependencies"},{"line_number":236,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_e0c0fd2e","line":233,"range":{"start_line":230,"start_character":0,"end_line":233,"end_character":47},"updated":"2018-12-19 11:16:56.000000000","message":"IMO, these should be a single work item (or at least schema + query building process).\n\nNew features for https + auth support should be a new item though","commit_id":"8d5d9a533246f096f6957dcdd3682d01ddc39c75"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"58035c55d4956c8b76e400f6fcb49d5e9f1b33bf","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  file (default: none)."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* Add an **insecure** option to explicitly allow insecure HTTPS requests"},{"line_number":73,"context_line":"  (default: false). "},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"* Add a **query_step** option to define query resolution in seconds"},{"line_number":76,"context_line":"  of range queries (default: 10)."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_f60203b8","line":73,"range":{"start_line":73,"start_character":18,"end_line":73,"end_character":20},"updated":"2018-12-19 13:05:33.000000000","message":"whitespace","commit_id":"9d8b77e18375fafed8a75d6235cc2fd1fd49f5ac"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"58035c55d4956c8b76e400f6fcb49d5e9f1b33bf","unresolved":false,"context_lines":[{"line_number":101,"context_line":"      extra_args:"},{"line_number":102,"context_line":"        aggregation_method: max"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Instead of: (present state) "},{"line_number":105,"context_line":""},{"line_number":106,"context_line":".. code-block:: YAML"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_1608dfd4","line":104,"range":{"start_line":104,"start_character":27,"end_line":104,"end_character":28},"updated":"2018-12-19 13:05:33.000000000","message":"whitespace","commit_id":"9d8b77e18375fafed8a75d6235cc2fd1fd49f5ac"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"58035c55d4956c8b76e400f6fcb49d5e9f1b33bf","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"* **[collect]/scope_key** option value will be added to filter every query"},{"line_number":148,"context_line":"  with the corresponding **scope_id**."},{"line_number":149,"context_line":"  "},{"line_number":150,"context_line":"  e.g.:"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"  .. code-block:: YAML"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_b6f00bdd","line":149,"range":{"start_line":149,"start_character":0,"end_line":149,"end_character":2},"updated":"2018-12-19 13:05:33.000000000","message":"whitespace","commit_id":"9d8b77e18375fafed8a75d6235cc2fd1fd49f5ac"},{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"ce1556732af9c336404505aba4b9ba2816a6b9ac","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    # where scope_id equals \"foobar\"."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    max(max_over_time(volume_size{scope_id\u003dfoobar}[3600s])) by (id, scope_id, volume_size)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"* The collector will now use the **groupby** capabilities offered by PromQL"},{"line_number":161,"context_line":"  using the syntax **by (scope_key, metadata, groupby)** instead of deferring it"},{"line_number":162,"context_line":"  to the collector implementation."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_c7db9349","line":159,"updated":"2018-12-19 15:32:49.000000000","message":"Can you add a working example of an http query ? since the collector will not use PromQL, it seems more apropriate","commit_id":"03b746da196a45447cf61388b70f6f29e488956c"}]}
