)]}'
{"cloudkitty_tempest_plugin/services/client.py":[{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"569867bd9a38b8d05c0415195b7736a62d5f4c28","unresolved":false,"context_lines":[{"line_number":458,"context_line":""},{"line_number":459,"context_line":"    def __init__(self, credentials\u003dNone, service\u003dNone):"},{"line_number":460,"context_line":"        super(Manager, self).__init__(credentials)"},{"line_number":461,"context_line":"        self.rating_clients \u003d {"},{"line_number":462,"context_line":"            \u0027v1\u0027: RatingClientV1(self.auth_provider, **self.rating_params),"},{"line_number":463,"context_line":"            \u0027v2\u0027: RatingClientV2(self.auth_provider, **self.rating_params),"},{"line_number":464,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_d29f3563","line":461,"range":{"start_line":461,"start_character":7,"end_line":461,"end_character":27},"updated":"2019-10-11 08:47:27.000000000","message":"Please do not override class attributes with instance attributes. I\u0027m not sure that the \"rating_clients\" class attribute is required though ?","commit_id":"bc93fb6be7fb25abc66db4f1baefaa04f8ea267c"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"569867bd9a38b8d05c0415195b7736a62d5f4c28","unresolved":false,"context_lines":[{"line_number":445,"context_line":""},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"class Manager(manager.Manager):"},{"line_number":448,"context_line":"    rating_clients \u003d {"},{"line_number":449,"context_line":"        \u0027v1\u0027: RatingClientV1,"},{"line_number":450,"context_line":"        \u0027v2\u0027: RatingClientV2,"},{"line_number":451,"context_line":"    }"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    rating_params \u003d {"},{"line_number":454,"context_line":"        \u0027service\u0027: CONF.rating_plugin.service_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_02717f76","line":451,"range":{"start_line":448,"start_character":0,"end_line":451,"end_character":5},"updated":"2019-10-11 08:47:27.000000000","message":"Why is this required if you override this attribute in __init__ ?","commit_id":"1ca4f09c24687ccca07a1908ae058f9b298d4296"},{"author":{"_account_id":29503,"name":"Justin Ferrieu","email":"jferrieu@objectif-libre.com","username":"jferrieu"},"change_message_id":"763913edcb42956c13e35001440725ac772d0e95","unresolved":false,"context_lines":[{"line_number":445,"context_line":""},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"class Manager(manager.Manager):"},{"line_number":448,"context_line":"    rating_clients \u003d {"},{"line_number":449,"context_line":"        \u0027v1\u0027: RatingClientV1,"},{"line_number":450,"context_line":"        \u0027v2\u0027: RatingClientV2,"},{"line_number":451,"context_line":"    }"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    rating_params \u003d {"},{"line_number":454,"context_line":"        \u0027service\u0027: CONF.rating_plugin.service_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_02af3f2a","line":451,"range":{"start_line":448,"start_character":0,"end_line":451,"end_character":5},"in_reply_to":"3fa7e38b_02717f76","updated":"2019-10-11 09:25:30.000000000","message":"Inattention. You\u0027re right. Done.","commit_id":"1ca4f09c24687ccca07a1908ae058f9b298d4296"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"569867bd9a38b8d05c0415195b7736a62d5f4c28","unresolved":false,"context_lines":[{"line_number":466,"context_line":"    def get_rating_client(self, api_version\u003d\u0027v2\u0027):"},{"line_number":467,"context_line":"        if api_version not in self.rating_clients:"},{"line_number":468,"context_line":"            raise ValueError(\u0027API version must be one of the following: {}\u0027,"},{"line_number":469,"context_line":"                             self.rating_client.keys())"},{"line_number":470,"context_line":"        return self.rating_clients[api_version]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_820a4fcf","line":469,"range":{"start_line":469,"start_character":29,"end_line":469,"end_character":54},"updated":"2019-10-11 08:47:27.000000000","message":"Convert this to a list/tuple or fomatting will display a generator","commit_id":"1ca4f09c24687ccca07a1908ae058f9b298d4296"},{"author":{"_account_id":29503,"name":"Justin Ferrieu","email":"jferrieu@objectif-libre.com","username":"jferrieu"},"change_message_id":"763913edcb42956c13e35001440725ac772d0e95","unresolved":false,"context_lines":[{"line_number":466,"context_line":"    def get_rating_client(self, api_version\u003d\u0027v2\u0027):"},{"line_number":467,"context_line":"        if api_version not in self.rating_clients:"},{"line_number":468,"context_line":"            raise ValueError(\u0027API version must be one of the following: {}\u0027,"},{"line_number":469,"context_line":"                             self.rating_client.keys())"},{"line_number":470,"context_line":"        return self.rating_clients[api_version]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_c2a4c74d","line":469,"range":{"start_line":469,"start_character":29,"end_line":469,"end_character":54},"in_reply_to":"3fa7e38b_820a4fcf","updated":"2019-10-11 09:25:30.000000000","message":"Done","commit_id":"1ca4f09c24687ccca07a1908ae058f9b298d4296"}]}