)]}'
{"cloudkitty/tenant_fetcher/keystone.py":[{"author":{"_account_id":7042,"name":"Stéphane Albert","email":"sheeprine@nullplace.com","username":"sheeprine"},"change_message_id":"1aba6db5473250905171e53a9417c24229736612","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            return self._get_tenants_v3_auth()"},{"line_number":67,"context_line":"        else:"},{"line_number":68,"context_line":"            msg \u003d \"Keystone version you\u0027ve specified is not supported\""},{"line_number":69,"context_line":"            raise exceptions.VersionNotAvailable(msg)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def _get_tenants_v2_auth(self):"},{"line_number":72,"context_line":"        tenant_list \u003d self.admin_ks.tenants.list()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_6e289c9a","line":69,"updated":"2015-11-30 11:00:10.000000000","message":"This is way nicer! Thanks.","commit_id":"f30b9b8e4577c68691185fcced954e491799de3d"},{"author":{"_account_id":7042,"name":"Stéphane Albert","email":"sheeprine@nullplace.com","username":"sheeprine"},"change_message_id":"1aba6db5473250905171e53a9417c24229736612","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            msg \u003d \"Keystone version you\u0027ve specified is not supported\""},{"line_number":69,"context_line":"            raise exceptions.VersionNotAvailable(msg)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def _get_tenants_v2_auth(self):"},{"line_number":72,"context_line":"        tenant_list \u003d self.admin_ks.tenants.list()"},{"line_number":73,"context_line":"        my_user_id \u003d self.session.get_user_id()"},{"line_number":74,"context_line":"        for tenant in tenant_list[:]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_ee332c12","line":71,"updated":"2015-11-30 11:00:10.000000000","message":"Too bad it\u0027s duplicating code here.\nWe might try to have a function mapping like this.\n{\u0027v2\u0027: (\u0027tenants\u0027, \u0027roles_for_user\u0027),\n  \u0027v3\u0027: (\u0027projects\u0027, \u0027list\u0027)}\nthen we expand the tuple and do a mapping for the function:\ntenant_attr, role_func \u003d mapping[version]\n\ntenant_list \u003d getattr(self.admin_ks, tenant_attr).list()\nroles \u003d getattr(self.admin_ks.roles, role_func)(my_user_id, tenant)\n\nThis way we only get one piece of code for the two versions.","commit_id":"f30b9b8e4577c68691185fcced954e491799de3d"},{"author":{"_account_id":7042,"name":"Stéphane Albert","email":"sheeprine@nullplace.com","username":"sheeprine"},"change_message_id":"5c2d66dd66e53a8643913743d854b87129040260","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        keystone_version \u003d discover.normalize_version_number("},{"line_number":62,"context_line":"            CONF.keystone_fetcher.keystone_version)"},{"line_number":63,"context_line":"        auth_dispatch \u003d {\u0027v2\u0027: (\u0027tenant\u0027, \u0027tenants\u0027, \u0027roles_for_user\u0027),"},{"line_number":64,"context_line":"                         \u0027v3\u0027: (\u0027project\u0027, \u0027projects\u0027, \u0027list\u0027)}"},{"line_number":65,"context_line":"        if discover.version_match((2,), keystone_version):"},{"line_number":66,"context_line":"            return self._do_get_tenants(auth_dispatch[\u0027v2\u0027])"},{"line_number":67,"context_line":"        elif discover.version_match((3,), keystone_version):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_3d50e8d3","line":64,"updated":"2015-12-02 17:41:45.000000000","message":"Let\u0027s try this :\nauth_dispatch \u003d {(2,): (\u0027tenant\u0027, \u0027tenants\u0027, \u0027roles_for_user\u0027),\n                             (3,): (\u0027project\u0027, \u0027projects\u0027, \u0027list\u0027)}","commit_id":"7f9e0977b650f6f3fb18d6e9ced434561e1c1e59"},{"author":{"_account_id":7042,"name":"Stéphane Albert","email":"sheeprine@nullplace.com","username":"sheeprine"},"change_message_id":"5c2d66dd66e53a8643913743d854b87129040260","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        if discover.version_match((2,), keystone_version):"},{"line_number":66,"context_line":"            return self._do_get_tenants(auth_dispatch[\u0027v2\u0027])"},{"line_number":67,"context_line":"        elif discover.version_match((3,), keystone_version):"},{"line_number":68,"context_line":"            return self._do_get_tenants(auth_dispatch[\u0027v3\u0027])"},{"line_number":69,"context_line":"        else:"},{"line_number":70,"context_line":"            msg \u003d \"Keystone version you\u0027ve specified is not supported\""},{"line_number":71,"context_line":"            raise exceptions.VersionNotAvailable(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_1dd96422","line":68,"updated":"2015-12-02 17:41:45.000000000","message":"for auth_version, auth_version_mapping in six.iteritems(auth_dispatch):\n    if discover.version_match(auth_version, keystone_version):\n        return self._do_get_tenants(auth_version_mapping)\nmsg \u003d \"Keystone version you\u0027ve specified is not supported\"\nraise exceptions.VersionNotAvailable(msg)","commit_id":"7f9e0977b650f6f3fb18d6e9ced434561e1c1e59"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"39216e225a81619039977ff19472d2e93cc0ba6a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        keystone_version \u003d discover.normalize_version_number("},{"line_number":63,"context_line":"            CONF.keystone_fetcher.keystone_version)"},{"line_number":64,"context_line":"        auth_dispatch \u003d {(2,): (\u0027tenant\u0027, \u0027tenants\u0027, \u0027roles_for_user\u0027),"},{"line_number":65,"context_line":"                         (3,): (\u0027project\u0027, \u0027projects\u0027, \u0027list\u0027)}"},{"line_number":66,"context_line":"        for auth_version, auth_version_mapping in six.iteritems(auth_dispatch):"},{"line_number":67,"context_line":"            if discover.version_match(auth_version, keystone_version):"},{"line_number":68,"context_line":"                return self._do_get_tenants(auth_version_mapping)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a7e1126_2d7bb4f6","line":65,"range":{"start_line":65,"start_character":33,"end_line":65,"end_character":40},"updated":"2015-12-21 07:58:37.000000000","message":"keystone api v2 is deprecated, let\u0027s put v3 in front of the list","commit_id":"4e4ff6a5481fb09ec7e23f33f68581d3e1299076"},{"author":{"_account_id":13001,"name":"lixiangjun","email":"xiangjun.li@easystack.cn","username":"lixiangjun"},"change_message_id":"be4ab45f7690412835113c3c9db2ca7ebad29e84","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        keystone_version \u003d discover.normalize_version_number("},{"line_number":63,"context_line":"            CONF.keystone_fetcher.keystone_version)"},{"line_number":64,"context_line":"        auth_dispatch \u003d {(2,): (\u0027tenant\u0027, \u0027tenants\u0027, \u0027roles_for_user\u0027),"},{"line_number":65,"context_line":"                         (3,): (\u0027project\u0027, \u0027projects\u0027, \u0027list\u0027)}"},{"line_number":66,"context_line":"        for auth_version, auth_version_mapping in six.iteritems(auth_dispatch):"},{"line_number":67,"context_line":"            if discover.version_match(auth_version, keystone_version):"},{"line_number":68,"context_line":"                return self._do_get_tenants(auth_version_mapping)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_553b80d1","line":65,"range":{"start_line":65,"start_character":33,"end_line":65,"end_character":40},"in_reply_to":"3a7e1126_2d7bb4f6","updated":"2016-01-04 03:18:04.000000000","message":"You are right.","commit_id":"4e4ff6a5481fb09ec7e23f33f68581d3e1299076"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"39216e225a81619039977ff19472d2e93cc0ba6a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        for auth_version, auth_version_mapping in six.iteritems(auth_dispatch):"},{"line_number":67,"context_line":"            if discover.version_match(auth_version, keystone_version):"},{"line_number":68,"context_line":"                return self._do_get_tenants(auth_version_mapping)"},{"line_number":69,"context_line":"        msg \u003d \"Keystone version you\u0027ve specified is not supported\""},{"line_number":70,"context_line":"        raise exceptions.VersionNotAvailable(msg)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _do_get_tenants(self, auth_version_mapping):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a7e1126_0dea78ac","line":69,"updated":"2015-12-21 07:58:37.000000000","message":"this is not user provided arguments but our code, it is either succeed, or fail the ci then we must fix it. so I think the following two lines can be removed","commit_id":"4e4ff6a5481fb09ec7e23f33f68581d3e1299076"},{"author":{"_account_id":13001,"name":"lixiangjun","email":"xiangjun.li@easystack.cn","username":"lixiangjun"},"change_message_id":"be4ab45f7690412835113c3c9db2ca7ebad29e84","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        for auth_version, auth_version_mapping in six.iteritems(auth_dispatch):"},{"line_number":67,"context_line":"            if discover.version_match(auth_version, keystone_version):"},{"line_number":68,"context_line":"                return self._do_get_tenants(auth_version_mapping)"},{"line_number":69,"context_line":"        msg \u003d \"Keystone version you\u0027ve specified is not supported\""},{"line_number":70,"context_line":"        raise exceptions.VersionNotAvailable(msg)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _do_get_tenants(self, auth_version_mapping):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_5521404c","line":69,"in_reply_to":"3a7e1126_0dea78ac","updated":"2016-01-04 03:18:04.000000000","message":"About this, I don’t quite understand you. My understanding is that the following two lines would work if the value of CONF.keystone_fetcher.keystone_version user specified is not 2/2.xx or 3/3.xx","commit_id":"4e4ff6a5481fb09ec7e23f33f68581d3e1299076"},{"author":{"_account_id":7042,"name":"Stéphane Albert","email":"sheeprine@nullplace.com","username":"sheeprine"},"change_message_id":"0190908ebe55cbd749e68484257cae1b0c3ae46b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        for auth_version, auth_version_mapping in six.iteritems(auth_dispatch):"},{"line_number":67,"context_line":"            if discover.version_match(auth_version, keystone_version):"},{"line_number":68,"context_line":"                return self._do_get_tenants(auth_version_mapping)"},{"line_number":69,"context_line":"        msg \u003d \"Keystone version you\u0027ve specified is not supported\""},{"line_number":70,"context_line":"        raise exceptions.VersionNotAvailable(msg)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _do_get_tenants(self, auth_version_mapping):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_8e86bf11","line":69,"in_reply_to":"3a7e1126_0dea78ac","updated":"2016-01-04 09:43:27.000000000","message":"The keystone version is user provided. If the user sets keystone v4.0, we want to tell him he messed up.\nThat\u0027s why the exception is raised.","commit_id":"4e4ff6a5481fb09ec7e23f33f68581d3e1299076"}]}
