)]}'
{"cloudkitty/api/v1/controllers/report.py":[{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"d6cc711dae21432b925f7662632b4a73fd74ec83","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        # Use keystone token information by default but make it overridable and"},{"line_number":96,"context_line":"        # enforce it by policy engine"},{"line_number":97,"context_line":"        groupby \u003d [\u0027project_id\u0027]"},{"line_number":98,"context_line":"        group_filters \u003d {\u0027project_id\u0027: tenant_id} if tenant_id else None"},{"line_number":99,"context_line":"        total_resources \u003d storage.total("},{"line_number":100,"context_line":"            groupby\u003dgroupby,"},{"line_number":101,"context_line":"            begin\u003dbegin, end\u003dend,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_b025f3ad","line":98,"updated":"2018-08-17 15:00:36.000000000","message":"Note for v2 API:\n\nThe api should not use hardcoded parameter as tenant_id or project_id since we may use another fetcher than keystone in a non openstack deployment.","commit_id":"7775c6cd93b8c0ce70144731cbdfaed681f37cf9"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"473b519950062a141951c6891dbc2187acfcfd0e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        # Use keystone token information by default but make it overridable and"},{"line_number":96,"context_line":"        # enforce it by policy engine"},{"line_number":97,"context_line":"        groupby \u003d [\u0027project_id\u0027]"},{"line_number":98,"context_line":"        group_filters \u003d {\u0027project_id\u0027: tenant_id} if tenant_id else None"},{"line_number":99,"context_line":"        total_resources \u003d storage.total("},{"line_number":100,"context_line":"            groupby\u003dgroupby,"},{"line_number":101,"context_line":"            begin\u003dbegin, end\u003dend,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_29908e95","line":98,"in_reply_to":"3f79a3b5_b025f3ad","updated":"2018-08-18 11:38:03.000000000","message":"I completely agree. But we won\u0027t change the behaviour of the v1 API.","commit_id":"7775c6cd93b8c0ce70144731cbdfaed681f37cf9"}],"cloudkitty/api/v1/controllers/storage.py":[{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"d6cc711dae21432b925f7662632b4a73fd74ec83","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                        desc\u003ddesc,"},{"line_number":84,"context_line":"                        volume\u003ddata[\u0027vol\u0027][\u0027qty\u0027],"},{"line_number":85,"context_line":"                        rating\u003dprice)"},{"line_number":86,"context_line":"                    frame_tenant \u003d data[\u0027tenant_id\u0027]"},{"line_number":87,"context_line":"                    resources.append(resource)"},{"line_number":88,"context_line":"                dataframe \u003d storage_models.DataFrame("},{"line_number":89,"context_line":"                    begin\u003dck_utils.iso2dt(frame[\u0027period\u0027][\u0027begin\u0027]),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_327c831f","line":86,"range":{"start_line":86,"start_character":41,"end_line":86,"end_character":50},"updated":"2018-08-17 15:00:36.000000000","message":"here either there should not be hardcoded reference to tenant_id","commit_id":"7775c6cd93b8c0ce70144731cbdfaed681f37cf9"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"473b519950062a141951c6891dbc2187acfcfd0e","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                        desc\u003ddesc,"},{"line_number":84,"context_line":"                        volume\u003ddata[\u0027vol\u0027][\u0027qty\u0027],"},{"line_number":85,"context_line":"                        rating\u003dprice)"},{"line_number":86,"context_line":"                    frame_tenant \u003d data[\u0027tenant_id\u0027]"},{"line_number":87,"context_line":"                    resources.append(resource)"},{"line_number":88,"context_line":"                dataframe \u003d storage_models.DataFrame("},{"line_number":89,"context_line":"                    begin\u003dck_utils.iso2dt(frame[\u0027period\u0027][\u0027begin\u0027]),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_e9e7f645","line":86,"range":{"start_line":86,"start_character":41,"end_line":86,"end_character":50},"in_reply_to":"3f79a3b5_327c831f","updated":"2018-08-18 11:38:03.000000000","message":"Yes, will use \"scope_id\" instead.","commit_id":"7775c6cd93b8c0ce70144731cbdfaed681f37cf9"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"6a062cbccf3d4ed5acb28683d8776ef779d85009","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                        desc\u003ddesc,"},{"line_number":84,"context_line":"                        volume\u003ddata[\u0027vol\u0027][\u0027qty\u0027],"},{"line_number":85,"context_line":"                        rating\u003dprice)"},{"line_number":86,"context_line":"                    frame_tenant \u003d data[\u0027tenant_id\u0027]"},{"line_number":87,"context_line":"                    resources.append(resource)"},{"line_number":88,"context_line":"                dataframe \u003d storage_models.DataFrame("},{"line_number":89,"context_line":"                    begin\u003dck_utils.iso2dt(frame[\u0027period\u0027][\u0027begin\u0027]),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_b6f5c785","line":86,"range":{"start_line":86,"start_character":41,"end_line":86,"end_character":50},"in_reply_to":"3f79a3b5_6049a95e","updated":"2018-08-20 11:43:19.000000000","message":"Here, data is a part of the dataframes returned by the storage backend. So \u0027scope_id\u0027 will always be available, because it is provided to the \"push\" function of the storage backend.\n\nYour comment made me notice that this statement is missing an \"if frame_tenant is None\" :)","commit_id":"7775c6cd93b8c0ce70144731cbdfaed681f37cf9"},{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"dd6b691e38d5d255b6f77ab19aa36e05e46e10e1","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                        desc\u003ddesc,"},{"line_number":84,"context_line":"                        volume\u003ddata[\u0027vol\u0027][\u0027qty\u0027],"},{"line_number":85,"context_line":"                        rating\u003dprice)"},{"line_number":86,"context_line":"                    frame_tenant \u003d data[\u0027tenant_id\u0027]"},{"line_number":87,"context_line":"                    resources.append(resource)"},{"line_number":88,"context_line":"                dataframe \u003d storage_models.DataFrame("},{"line_number":89,"context_line":"                    begin\u003dck_utils.iso2dt(frame[\u0027period\u0027][\u0027begin\u0027]),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_6049a95e","line":86,"range":{"start_line":86,"start_character":41,"end_line":86,"end_character":50},"in_reply_to":"3f79a3b5_e9e7f645","updated":"2018-08-20 10:14:37.000000000","message":"The problem is that scope_id comes from the gnocchi collector parameter ... therefore it won\u0027t work with other collector","commit_id":"7775c6cd93b8c0ce70144731cbdfaed681f37cf9"}],"cloudkitty/storage/__init__.py":[{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"d6cc711dae21432b925f7662632b4a73fd74ec83","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":"from stevedore import driver"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from cloudkitty.storage import v2 as storage_v2"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"storage_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_1c03a011","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":47},"updated":"2018-08-17 15:00:36.000000000","message":"seems an unused import, no ?","commit_id":"7775c6cd93b8c0ce70144731cbdfaed681f37cf9"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"473b519950062a141951c6891dbc2187acfcfd0e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":"from stevedore import driver"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from cloudkitty.storage import v2 as storage_v2"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"storage_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_69968697","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":47},"in_reply_to":"3f79a3b5_1c03a011","updated":"2018-08-18 11:38:03.000000000","message":"True","commit_id":"7775c6cd93b8c0ce70144731cbdfaed681f37cf9"}],"cloudkitty/storage/v2/__init__.py":[{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"d6cc711dae21432b925f7662632b4a73fd74ec83","unresolved":false,"context_lines":[{"line_number":122,"context_line":"       \"\"\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @abc.abstractmethod"},{"line_number":125,"context_line":"    def total(self, groupby\u003dNone,"},{"line_number":126,"context_line":"              begin\u003dNone, end\u003dNone,"},{"line_number":127,"context_line":"              metric_types\u003dNone,"},{"line_number":128,"context_line":"              filters\u003dNone, group_filters\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_100147b0","line":125,"range":{"start_line":125,"start_character":8,"end_line":125,"end_character":13},"updated":"2018-08-17 15:00:36.000000000","message":"I\u0027m thinking just now: shouldn\u0027t we propose an aggregate function instead, just in case we need something else than just the total ?\n\nA backend should provide at least the sum aggregate to be able to have the total query but may also provide mean, q95, q90, etc. \n\nEven if we only use the sum aggregate today, it will provide a more generic interface for the storage backend","commit_id":"7775c6cd93b8c0ce70144731cbdfaed681f37cf9"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"6a062cbccf3d4ed5acb28683d8776ef779d85009","unresolved":false,"context_lines":[{"line_number":122,"context_line":"       \"\"\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @abc.abstractmethod"},{"line_number":125,"context_line":"    def total(self, groupby\u003dNone,"},{"line_number":126,"context_line":"              begin\u003dNone, end\u003dNone,"},{"line_number":127,"context_line":"              metric_types\u003dNone,"},{"line_number":128,"context_line":"              filters\u003dNone, group_filters\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_368e972e","line":125,"range":{"start_line":125,"start_character":8,"end_line":125,"end_character":13},"in_reply_to":"3f79a3b5_0026b5b8","updated":"2018-08-20 11:43:19.000000000","message":"yep, will add it to the note in the documentation. Should I make the note a warning ?","commit_id":"7775c6cd93b8c0ce70144731cbdfaed681f37cf9"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"473b519950062a141951c6891dbc2187acfcfd0e","unresolved":false,"context_lines":[{"line_number":122,"context_line":"       \"\"\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @abc.abstractmethod"},{"line_number":125,"context_line":"    def total(self, groupby\u003dNone,"},{"line_number":126,"context_line":"              begin\u003dNone, end\u003dNone,"},{"line_number":127,"context_line":"              metric_types\u003dNone,"},{"line_number":128,"context_line":"              filters\u003dNone, group_filters\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_e9d05656","line":125,"range":{"start_line":125,"start_character":8,"end_line":125,"end_character":13},"in_reply_to":"3f79a3b5_100147b0","updated":"2018-08-18 11:38:03.000000000","message":"It would be useful, but every storage backend won\u0027t be able to provide the same aggregation methods. It would imply to documented each backend well. \n\nOther things would be useful too (a sort for example, in order to get the 10 most expensive resources/metric_types etc...).\n\nBut we must also be careful to keep the storage interface simple. Maybe we could implement this in the future after discussion ? Given that the v2 API is not implemented yet, the potential changes won\u0027t be visible for the end user.","commit_id":"7775c6cd93b8c0ce70144731cbdfaed681f37cf9"},{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"dd6b691e38d5d255b6f77ab19aa36e05e46e10e1","unresolved":false,"context_lines":[{"line_number":122,"context_line":"       \"\"\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @abc.abstractmethod"},{"line_number":125,"context_line":"    def total(self, groupby\u003dNone,"},{"line_number":126,"context_line":"              begin\u003dNone, end\u003dNone,"},{"line_number":127,"context_line":"              metric_types\u003dNone,"},{"line_number":128,"context_line":"              filters\u003dNone, group_filters\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_0026b5b8","line":125,"range":{"start_line":125,"start_character":8,"end_line":125,"end_character":13},"in_reply_to":"3f79a3b5_e9d05656","updated":"2018-08-20 10:14:37.000000000","message":"Yeh that\u0027s true. it was just to avoid a function renaming.\n\nI saw some warning about the v2. maybe you could had that both api and implementation are not stable.","commit_id":"7775c6cd93b8c0ce70144731cbdfaed681f37cf9"}],"cloudkitty/storage/v2/gnocchi.py":[{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"d6cc711dae21432b925f7662632b4a73fd74ec83","unresolved":false,"context_lines":[{"line_number":491,"context_line":"            \u0027metadata\u0027: metadata,"},{"line_number":492,"context_line":"            \u0027vol\u0027: vol_dict,"},{"line_number":493,"context_line":"            \u0027rating\u0027: price_dict,"},{"line_number":494,"context_line":"            \u0027tenant_id\u0027: scope_id,"},{"line_number":495,"context_line":"        }"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"    def _to_cloudkitty(self,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_72b43bf3","line":494,"range":{"start_line":494,"start_character":13,"end_line":494,"end_character":22},"updated":"2018-08-17 15:00:36.000000000","message":"There should not be reference to tenant_id, since its openstack specific.","commit_id":"7775c6cd93b8c0ce70144731cbdfaed681f37cf9"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"473b519950062a141951c6891dbc2187acfcfd0e","unresolved":false,"context_lines":[{"line_number":491,"context_line":"            \u0027metadata\u0027: metadata,"},{"line_number":492,"context_line":"            \u0027vol\u0027: vol_dict,"},{"line_number":493,"context_line":"            \u0027rating\u0027: price_dict,"},{"line_number":494,"context_line":"            \u0027tenant_id\u0027: scope_id,"},{"line_number":495,"context_line":"        }"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"    def _to_cloudkitty(self,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_e9829652","line":494,"range":{"start_line":494,"start_character":13,"end_line":494,"end_character":22},"in_reply_to":"3f79a3b5_72b43bf3","updated":"2018-08-18 11:38:03.000000000","message":"I agree, this should be scope_id. It is the currently required format though. I\u0027ll change this to be scope_id and do the scope_id -\u003e tenant_id translation in the API.","commit_id":"7775c6cd93b8c0ce70144731cbdfaed681f37cf9"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"ca2730a4f5c2535b50b3a7e9703474cd2ee69366","unresolved":false,"context_lines":[{"line_number":491,"context_line":"            \u0027metadata\u0027: metadata,"},{"line_number":492,"context_line":"            \u0027vol\u0027: vol_dict,"},{"line_number":493,"context_line":"            \u0027rating\u0027: price_dict,"},{"line_number":494,"context_line":"            \u0027tenant_id\u0027: scope_id,"},{"line_number":495,"context_line":"        }"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"    def _to_cloudkitty(self,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_e2205afa","line":494,"range":{"start_line":494,"start_character":13,"end_line":494,"end_character":22},"in_reply_to":"3f79a3b5_dc498560","updated":"2018-08-20 14:08:40.000000000","message":"I don\u0027t think that it should be specified by the collector. The orchestrator provides the scope_id to the storage backend (when  pushing data).\n\nThe gnocchi collector doesn\u0027t provide a scope_id either. It does only support a \"scope_key\" option. \n\nIn order to avoid conflict with a potential metadata/groupby attribute that would be called \"scope_id\", I\u0027ll update this backend so that the scope_id does not use the same prefix as other attributes.","commit_id":"7775c6cd93b8c0ce70144731cbdfaed681f37cf9"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"6a062cbccf3d4ed5acb28683d8776ef779d85009","unresolved":false,"context_lines":[{"line_number":491,"context_line":"            \u0027metadata\u0027: metadata,"},{"line_number":492,"context_line":"            \u0027vol\u0027: vol_dict,"},{"line_number":493,"context_line":"            \u0027rating\u0027: price_dict,"},{"line_number":494,"context_line":"            \u0027tenant_id\u0027: scope_id,"},{"line_number":495,"context_line":"        }"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"    def _to_cloudkitty(self,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_f6aedf96","line":494,"range":{"start_line":494,"start_character":13,"end_line":494,"end_character":22},"in_reply_to":"3f79a3b5_e07cd973","updated":"2018-08-20 11:43:19.000000000","message":"I disagree with you on that point. I think that the scope_id should be provided to the push() function, and therefore be handled specifically in . Most requests to the API are done by users who aren\u0027t admin, so the information they have access to is limited to their scope (tenant in an openstack context, group/namespace/whatever in another context). Thus, having access to the scope_id in the storage backend makes optimization easier for the developper. \n\nAs an example: If somebody implemented an SQL backend for the v2 storage, a \u0027scope_id\u0027 column with an index on it would be a good idea; given that most SQL requests would contain a \"WHERE scope_id\u003d\u0027xxx\u0027\".\n\nDoes anybody else have a strong opinion on this ? Should we keep a reference to the scope_id or not ?","commit_id":"7775c6cd93b8c0ce70144731cbdfaed681f37cf9"},{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"dd6b691e38d5d255b6f77ab19aa36e05e46e10e1","unresolved":false,"context_lines":[{"line_number":491,"context_line":"            \u0027metadata\u0027: metadata,"},{"line_number":492,"context_line":"            \u0027vol\u0027: vol_dict,"},{"line_number":493,"context_line":"            \u0027rating\u0027: price_dict,"},{"line_number":494,"context_line":"            \u0027tenant_id\u0027: scope_id,"},{"line_number":495,"context_line":"        }"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"    def _to_cloudkitty(self,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_e07cd973","line":494,"range":{"start_line":494,"start_character":13,"end_line":494,"end_character":22},"in_reply_to":"3f79a3b5_e9829652","updated":"2018-08-20 10:14:37.000000000","message":"Your scope is already in the group_by ... on the storage backend side, there should be no reference to scope. Only in the v1 controller to keep compatibility with current behavior.","commit_id":"7775c6cd93b8c0ce70144731cbdfaed681f37cf9"},{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"27b567259d274c1957885fff8efae8ebde6e0089","unresolved":false,"context_lines":[{"line_number":491,"context_line":"            \u0027metadata\u0027: metadata,"},{"line_number":492,"context_line":"            \u0027vol\u0027: vol_dict,"},{"line_number":493,"context_line":"            \u0027rating\u0027: price_dict,"},{"line_number":494,"context_line":"            \u0027tenant_id\u0027: scope_id,"},{"line_number":495,"context_line":"        }"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"    def _to_cloudkitty(self,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_dc498560","line":494,"range":{"start_line":494,"start_character":13,"end_line":494,"end_character":22},"in_reply_to":"3f79a3b5_f6aedf96","updated":"2018-08-20 12:45:11.000000000","message":"I don\u0027t think we should have this distinction at the backend level.\n\nBut if we keep this, we should force any collector to put a scope_id. I\u0027m not sure the monasca collector has a scope_id definition for example","commit_id":"7775c6cd93b8c0ce70144731cbdfaed681f37cf9"}],"doc/source/configuration/configuration.rst":[{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"d6cc711dae21432b925f7662632b4a73fd74ec83","unresolved":false,"context_lines":[{"line_number":90,"context_line":".. code-block:: ini"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"   [storage]"},{"line_number":93,"context_line":"   backend \u003d sqlalchemy"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"As you will see in the following example, collector and storage backends"},{"line_number":96,"context_line":"sometimes need additional configuration sections. (The tenant fetcher works the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_9c5a5028","line":93,"updated":"2018-08-17 15:00:36.000000000","message":"The option to use the v2 storage is missing","commit_id":"7775c6cd93b8c0ce70144731cbdfaed681f37cf9"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"6a062cbccf3d4ed5acb28683d8776ef779d85009","unresolved":false,"context_lines":[{"line_number":90,"context_line":".. code-block:: ini"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"   [storage]"},{"line_number":93,"context_line":"   backend \u003d sqlalchemy"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"As you will see in the following example, collector and storage backends"},{"line_number":96,"context_line":"sometimes need additional configuration sections. (The tenant fetcher works the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_b6794730","line":93,"in_reply_to":"3f79a3b5_45f4bf5b","updated":"2018-08-20 11:43:19.000000000","message":"OK, will add.","commit_id":"7775c6cd93b8c0ce70144731cbdfaed681f37cf9"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"473b519950062a141951c6891dbc2187acfcfd0e","unresolved":false,"context_lines":[{"line_number":90,"context_line":".. code-block:: ini"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"   [storage]"},{"line_number":93,"context_line":"   backend \u003d sqlalchemy"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"As you will see in the following example, collector and storage backends"},{"line_number":96,"context_line":"sometimes need additional configuration sections. (The tenant fetcher works the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_a97c9e72","line":93,"in_reply_to":"3f79a3b5_9c5a5028","updated":"2018-08-18 11:38:03.000000000","message":"This has been left out on purpose, because the v2 storage is not considered stable. I was planning to add it once the v2 storage is mature. But we could add \"version\u003d1\". Thoughts ?","commit_id":"7775c6cd93b8c0ce70144731cbdfaed681f37cf9"},{"author":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"change_message_id":"dd6b691e38d5d255b6f77ab19aa36e05e46e10e1","unresolved":false,"context_lines":[{"line_number":90,"context_line":".. code-block:: ini"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"   [storage]"},{"line_number":93,"context_line":"   backend \u003d sqlalchemy"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"As you will see in the following example, collector and storage backends"},{"line_number":96,"context_line":"sometimes need additional configuration sections. (The tenant fetcher works the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_45f4bf5b","line":93,"in_reply_to":"3f79a3b5_a97c9e72","updated":"2018-08-20 10:14:37.000000000","message":"L\u0027option apparait quand tu généres le sample donc autant le documenter","commit_id":"7775c6cd93b8c0ce70144731cbdfaed681f37cf9"}]}
