)]}'
{"cloudkitty/storage/v1/sqlalchemy/__init__.py":[{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"254868df5f19f2cfd12d7b7461970403934f7b86","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            self.frame_model.end \u003c\u003d end,"},{"line_number":128,"context_line":"            self.frame_model.res_type !\u003d \u0027_NO_DATA_\u0027)"},{"line_number":129,"context_line":"        if groupby:"},{"line_number":130,"context_line":"            q \u003d q.group_by(sqlalchemy.sql.text(groupby))"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # Order by sum(rate)"},{"line_number":133,"context_line":"        q \u003d q.order_by(sqlalchemy.func.sum(self.frame_model.rate))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_1ac3f7ee","line":130,"updated":"2019-06-28 14:12:23.000000000","message":"so, just to circle around to what this is all about, the idea is that \"groupby\" here is *NOT* untrusted input e.g. from a web form or similar.   Can that be confirmed?","commit_id":"df869e4588c937dc0e78680a3b9fe9d0fc937e57"},{"author":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"change_message_id":"167a10bb229c0e13fda63d5c34d74bf0227c9949","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            self.frame_model.end \u003c\u003d end,"},{"line_number":128,"context_line":"            self.frame_model.res_type !\u003d \u0027_NO_DATA_\u0027)"},{"line_number":129,"context_line":"        if groupby:"},{"line_number":130,"context_line":"            q \u003d q.group_by(sqlalchemy.sql.text(groupby))"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # Order by sum(rate)"},{"line_number":133,"context_line":"        q \u003d q.order_by(sqlalchemy.func.sum(self.frame_model.rate))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_455c3418","line":130,"in_reply_to":"9fb8cfa7_1ac3f7ee","updated":"2019-06-28 14:34:36.000000000","message":"Yes, the input is sanitized. Thanks for caring though","commit_id":"df869e4588c937dc0e78680a3b9fe9d0fc937e57"}]}
