)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29503,"name":"Justin Ferrieu","email":"jferrieu@objectif-libre.com","username":"jferrieu"},"change_message_id":"6482d79d1226b1f892c1715985f510eca27ee370","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for the query_function field to the Prometheus collector"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This extend the possibilities for manupilating the data with the Prometheus"},{"line_number":10,"context_line":"collector withouth using custom scripts."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Work items:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3fa7e38b_9b916d56","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":11},"updated":"2020-01-03 09:15:30.000000000","message":"Typo (extends).","commit_id":"c2cbfab35bd3a78d32649fdd79784e6a687893c6"},{"author":{"_account_id":29503,"name":"Justin Ferrieu","email":"jferrieu@objectif-libre.com","username":"jferrieu"},"change_message_id":"6482d79d1226b1f892c1715985f510eca27ee370","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for the query_function field to the Prometheus collector"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This extend the possibilities for manupilating the data with the Prometheus"},{"line_number":10,"context_line":"collector withouth using custom scripts."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Work items:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3fa7e38b_5b977547","line":9,"range":{"start_line":9,"start_character":47,"end_line":9,"end_character":55},"updated":"2020-01-03 09:15:30.000000000","message":"Typo (the data \u003d\u003e data).","commit_id":"c2cbfab35bd3a78d32649fdd79784e6a687893c6"},{"author":{"_account_id":29503,"name":"Justin Ferrieu","email":"jferrieu@objectif-libre.com","username":"jferrieu"},"change_message_id":"6482d79d1226b1f892c1715985f510eca27ee370","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add support for the query_function field to the Prometheus collector"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This extend the possibilities for manupilating the data with the Prometheus"},{"line_number":10,"context_line":"collector withouth using custom scripts."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Work items:"},{"line_number":13,"context_line":" * Implemented the query_function field in the Prometheus collector."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3fa7e38b_7b94b141","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":18},"updated":"2020-01-03 09:15:30.000000000","message":"Typo (without).","commit_id":"c2cbfab35bd3a78d32649fdd79784e6a687893c6"},{"author":{"_account_id":30960,"name":"Quentin Anglade","email":"quentin.anglade@objectif-libre.com","username":"qanglade"},"change_message_id":"f4f295ddd3bc2e3243642357e022ca1287933392","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for the query_function field to the Prometheus collector"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This extends the possibilities for manupilating data with the Prometheus"},{"line_number":10,"context_line":"collector without using custom scripts."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Work items:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"3fa7e38b_39e8137a","line":9,"range":{"start_line":9,"start_character":35,"end_line":9,"end_character":47},"updated":"2020-01-13 09:40:14.000000000","message":"Typo","commit_id":"b80f915f27bb4041b90ceaae7213c2e6aa288212"}],"cloudkitty/collector/prometheus.py":[{"author":{"_account_id":29503,"name":"Justin Ferrieu","email":"jferrieu@objectif-libre.com","username":"jferrieu"},"change_message_id":"d814ab281aeade8c4425d6b59d9c7661b82d99de","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        method \u003d self.conf[metric_name][\u0027extra_args\u0027][\u0027aggregation_method\u0027]"},{"line_number":150,"context_line":"        query_function \u003d self.conf[metric_name][\u0027extra_args\u0027][\u0027query_function\u0027]"},{"line_number":151,"context_line":"        if query_function !\u003d \u0027\u0027:"},{"line_number":152,"context_line":"            query_function \u003d f\"({query_function}\""},{"line_number":153,"context_line":"        groupby \u003d self.conf[metric_name].get(\u0027groupby\u0027, [])"},{"line_number":154,"context_line":"        metadata \u003d self.conf[metric_name].get(\u0027metadata\u0027, [])"},{"line_number":155,"context_line":"        period \u003d tzutils.diff_seconds(end, start)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_91071b1e","line":152,"range":{"start_line":152,"start_character":0,"end_line":152,"end_character":49},"updated":"2019-12-30 09:23:55.000000000","message":"The error reported by the `openstack-tox-pep8` Zuul job is coming from the \u0027f\u0027 in this line. You may want to remove it.","commit_id":"793af0c9a70e13e39b9219259f9fd57248f77470"},{"author":{"_account_id":29503,"name":"Justin Ferrieu","email":"jferrieu@objectif-libre.com","username":"jferrieu"},"change_message_id":"6482d79d1226b1f892c1715985f510eca27ee370","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                \u0027min\u0027, \u0027stddev\u0027, \u0027stdvar\u0027,"},{"line_number":72,"context_line":"                \u0027sum\u0027"},{"line_number":73,"context_line":"            ]),"},{"line_number":74,"context_line":"        Required(\u0027query_function\u0027, default\u003d\u0027\u0027):"},{"line_number":75,"context_line":"            In(["},{"line_number":76,"context_line":"                \u0027abs\u0027, \u0027ceil\u0027, \u0027exp\u0027,"},{"line_number":77,"context_line":"                \u0027floor\u0027, \u0027ln\u0027, \u0027log2\u0027,"},{"line_number":78,"context_line":"                \u0027log10\u0027, \u0027round\u0027, \u0027sqrt\u0027,"},{"line_number":79,"context_line":"                \u0027\u0027"},{"line_number":80,"context_line":"            ])"},{"line_number":81,"context_line":"    }"},{"line_number":82,"context_line":"}"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_dbf8457f","line":80,"range":{"start_line":74,"start_character":1,"end_line":80,"end_character":14},"updated":"2020-01-03 09:15:30.000000000","message":"Since it is an optional schema field with no default, I would prefer you do not use a `Required` object and you could use `self.conf[\u0027extra_args\u0027].get(\u0027query_function\u0027)` to retrieve the key value.","commit_id":"c2cbfab35bd3a78d32649fdd79784e6a687893c6"},{"author":{"_account_id":29503,"name":"Justin Ferrieu","email":"jferrieu@objectif-libre.com","username":"jferrieu"},"change_message_id":"a643a6053b00394417ee72ccc7925ca738939ad7","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                \u0027min\u0027, \u0027stddev\u0027, \u0027stdvar\u0027,"},{"line_number":72,"context_line":"                \u0027sum\u0027"},{"line_number":73,"context_line":"            ]),"},{"line_number":74,"context_line":"        Required(\u0027query_function\u0027, default\u003d\u0027\u0027):"},{"line_number":75,"context_line":"            In(["},{"line_number":76,"context_line":"                \u0027abs\u0027, \u0027ceil\u0027, \u0027exp\u0027,"},{"line_number":77,"context_line":"                \u0027floor\u0027, \u0027ln\u0027, \u0027log2\u0027,"},{"line_number":78,"context_line":"                \u0027log10\u0027, \u0027round\u0027, \u0027sqrt\u0027,"},{"line_number":79,"context_line":"                \u0027\u0027"},{"line_number":80,"context_line":"            ])"},{"line_number":81,"context_line":"    }"},{"line_number":82,"context_line":"}"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_f7650d1d","line":80,"range":{"start_line":74,"start_character":1,"end_line":80,"end_character":14},"in_reply_to":"3fa7e38b_57df410b","updated":"2020-01-03 10:17:54.000000000","message":"The `dict.get(key, default\u003dNone)` method accepts a default value as its second argument that itself defaults to `None` if the key is not found. It is fault tolerant so no try/catch is required.","commit_id":"c2cbfab35bd3a78d32649fdd79784e6a687893c6"},{"author":{"_account_id":30844,"name":"Florian Davasse","email":"florian.davasse@objectif-libre.com","username":"aimbot31"},"change_message_id":"56dd164d4a53e4d381b48192cd2b51b37db2dfe1","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                \u0027min\u0027, \u0027stddev\u0027, \u0027stdvar\u0027,"},{"line_number":72,"context_line":"                \u0027sum\u0027"},{"line_number":73,"context_line":"            ]),"},{"line_number":74,"context_line":"        Required(\u0027query_function\u0027, default\u003d\u0027\u0027):"},{"line_number":75,"context_line":"            In(["},{"line_number":76,"context_line":"                \u0027abs\u0027, \u0027ceil\u0027, \u0027exp\u0027,"},{"line_number":77,"context_line":"                \u0027floor\u0027, \u0027ln\u0027, \u0027log2\u0027,"},{"line_number":78,"context_line":"                \u0027log10\u0027, \u0027round\u0027, \u0027sqrt\u0027,"},{"line_number":79,"context_line":"                \u0027\u0027"},{"line_number":80,"context_line":"            ])"},{"line_number":81,"context_line":"    }"},{"line_number":82,"context_line":"}"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_57df410b","line":80,"range":{"start_line":74,"start_character":1,"end_line":80,"end_character":14},"in_reply_to":"3fa7e38b_dbf8457f","updated":"2020-01-03 09:37:48.000000000","message":"The get should be done in try/except to avoid trouble ?","commit_id":"c2cbfab35bd3a78d32649fdd79784e6a687893c6"},{"author":{"_account_id":29503,"name":"Justin Ferrieu","email":"jferrieu@objectif-libre.com","username":"jferrieu"},"change_message_id":"6482d79d1226b1f892c1715985f510eca27ee370","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        period \u003d tzutils.diff_seconds(end, start)"},{"line_number":155,"context_line":"        time \u003d end"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        query \u003d ("},{"line_number":158,"context_line":"            \u0027{0}{1}({0}_over_time({2}{{{3}\u003d\"{4}\"}}[{5}s])){6} by ({7})\u0027"},{"line_number":159,"context_line":"            .format("},{"line_number":160,"context_line":"                method,"},{"line_number":161,"context_line":"                query_function,"},{"line_number":162,"context_line":"                metric_name,"},{"line_number":163,"context_line":"                scope_key,"},{"line_number":164,"context_line":"                scope_id,"},{"line_number":165,"context_line":"                period,"},{"line_number":166,"context_line":"                \u0027\u0027 if query_function \u003d\u003d \u0027\u0027 else \u0027)\u0027,"},{"line_number":167,"context_line":"                \u0027, \u0027.join(groupby + metadata),"},{"line_number":168,"context_line":"            )"},{"line_number":169,"context_line":"        )"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        try:"},{"line_number":172,"context_line":"            res \u003d self._conn.get_instant("}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_5762e1ae","line":169,"range":{"start_line":157,"start_character":7,"end_line":169,"end_character":9},"updated":"2020-01-03 09:15:30.000000000","message":"The formatting became indigest to read imo. I would suggest to split it in several steps instead of agglutinating everything in one format syntax with a ternary condition.","commit_id":"c2cbfab35bd3a78d32649fdd79784e6a687893c6"},{"author":{"_account_id":30844,"name":"Florian Davasse","email":"florian.davasse@objectif-libre.com","username":"aimbot31"},"change_message_id":"56dd164d4a53e4d381b48192cd2b51b37db2dfe1","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        period \u003d tzutils.diff_seconds(end, start)"},{"line_number":155,"context_line":"        time \u003d end"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        query \u003d ("},{"line_number":158,"context_line":"            \u0027{0}{1}({0}_over_time({2}{{{3}\u003d\"{4}\"}}[{5}s])){6} by ({7})\u0027"},{"line_number":159,"context_line":"            .format("},{"line_number":160,"context_line":"                method,"},{"line_number":161,"context_line":"                query_function,"},{"line_number":162,"context_line":"                metric_name,"},{"line_number":163,"context_line":"                scope_key,"},{"line_number":164,"context_line":"                scope_id,"},{"line_number":165,"context_line":"                period,"},{"line_number":166,"context_line":"                \u0027\u0027 if query_function \u003d\u003d \u0027\u0027 else \u0027)\u0027,"},{"line_number":167,"context_line":"                \u0027, \u0027.join(groupby + metadata),"},{"line_number":168,"context_line":"            )"},{"line_number":169,"context_line":"        )"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        try:"},{"line_number":172,"context_line":"            res \u003d self._conn.get_instant("}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_b7cd555f","line":169,"range":{"start_line":157,"start_character":7,"end_line":169,"end_character":9},"in_reply_to":"3fa7e38b_5762e1ae","updated":"2020-01-03 09:37:48.000000000","message":"Yeah, and it will get even more indigest after the second pr gets merged..\nI\u0027m gonna split it right now, this is a good idea.","commit_id":"c2cbfab35bd3a78d32649fdd79784e6a687893c6"},{"author":{"_account_id":30844,"name":"Florian Davasse","email":"florian.davasse@objectif-libre.com","username":"aimbot31"},"change_message_id":"fcc6f0eddda0e1e64c7e97d354f7b5615f4e1ca3","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        period \u003d tzutils.diff_seconds(end, start)"},{"line_number":155,"context_line":"        time \u003d end"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        query \u003d ("},{"line_number":158,"context_line":"            \u0027{0}{1}({0}_over_time({2}{{{3}\u003d\"{4}\"}}[{5}s])){6} by ({7})\u0027"},{"line_number":159,"context_line":"            .format("},{"line_number":160,"context_line":"                method,"},{"line_number":161,"context_line":"                query_function,"},{"line_number":162,"context_line":"                metric_name,"},{"line_number":163,"context_line":"                scope_key,"},{"line_number":164,"context_line":"                scope_id,"},{"line_number":165,"context_line":"                period,"},{"line_number":166,"context_line":"                \u0027\u0027 if query_function \u003d\u003d \u0027\u0027 else \u0027)\u0027,"},{"line_number":167,"context_line":"                \u0027, \u0027.join(groupby + metadata),"},{"line_number":168,"context_line":"            )"},{"line_number":169,"context_line":"        )"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        try:"},{"line_number":172,"context_line":"            res \u003d self._conn.get_instant("}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_9724d9c4","line":169,"range":{"start_line":157,"start_character":7,"end_line":169,"end_character":9},"in_reply_to":"3fa7e38b_b77315e8","updated":"2020-01-09 14:19:28.000000000","message":"Done","commit_id":"c2cbfab35bd3a78d32649fdd79784e6a687893c6"},{"author":{"_account_id":29503,"name":"Justin Ferrieu","email":"jferrieu@objectif-libre.com","username":"jferrieu"},"change_message_id":"a643a6053b00394417ee72ccc7925ca738939ad7","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        period \u003d tzutils.diff_seconds(end, start)"},{"line_number":155,"context_line":"        time \u003d end"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        query \u003d ("},{"line_number":158,"context_line":"            \u0027{0}{1}({0}_over_time({2}{{{3}\u003d\"{4}\"}}[{5}s])){6} by ({7})\u0027"},{"line_number":159,"context_line":"            .format("},{"line_number":160,"context_line":"                method,"},{"line_number":161,"context_line":"                query_function,"},{"line_number":162,"context_line":"                metric_name,"},{"line_number":163,"context_line":"                scope_key,"},{"line_number":164,"context_line":"                scope_id,"},{"line_number":165,"context_line":"                period,"},{"line_number":166,"context_line":"                \u0027\u0027 if query_function \u003d\u003d \u0027\u0027 else \u0027)\u0027,"},{"line_number":167,"context_line":"                \u0027, \u0027.join(groupby + metadata),"},{"line_number":168,"context_line":"            )"},{"line_number":169,"context_line":"        )"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        try:"},{"line_number":172,"context_line":"            res \u003d self._conn.get_instant("}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_b77315e8","line":169,"range":{"start_line":157,"start_character":7,"end_line":169,"end_character":9},"in_reply_to":"3fa7e38b_b7cd555f","updated":"2020-01-03 10:17:54.000000000","message":"Thank you.","commit_id":"c2cbfab35bd3a78d32649fdd79784e6a687893c6"},{"author":{"_account_id":29503,"name":"Justin Ferrieu","email":"jferrieu@objectif-libre.com","username":"jferrieu"},"change_message_id":"b5d3f32115ef280183ccc859ac6cf17ea64572f1","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                \u0027min\u0027, \u0027stddev\u0027, \u0027stdvar\u0027,"},{"line_number":73,"context_line":"                \u0027sum\u0027"},{"line_number":74,"context_line":"            ]),"},{"line_number":75,"context_line":"        Optional(\u0027query_function\u0027, default\u003d\u0027\u0027):"},{"line_number":76,"context_line":"            In(["},{"line_number":77,"context_line":"                \u0027abs\u0027, \u0027ceil\u0027, \u0027exp\u0027,"},{"line_number":78,"context_line":"                \u0027floor\u0027, \u0027ln\u0027, \u0027log2\u0027,"},{"line_number":79,"context_line":"                \u0027log10\u0027, \u0027round\u0027, \u0027sqrt\u0027,"},{"line_number":80,"context_line":"                \u0027\u0027"},{"line_number":81,"context_line":"            ])"},{"line_number":82,"context_line":"    }"},{"line_number":83,"context_line":"}"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_0615dae5","line":81,"range":{"start_line":75,"start_character":8,"end_line":81,"end_character":14},"updated":"2020-01-09 11:11:42.000000000","message":"Since it is then optional and you call `self.conf[metric_name][\u0027extra_args\u0027].get(\u0027query_function\u0027, \u0027\u0027)` later with the `\u0027\u0027` as a default value, I would suggest you remove the default parameter here and the empty string in the list of accepted values as it is now redundant.","commit_id":"42cecddab44a73839b1ce4b338919ad849902408"},{"author":{"_account_id":30844,"name":"Florian Davasse","email":"florian.davasse@objectif-libre.com","username":"aimbot31"},"change_message_id":"fcc6f0eddda0e1e64c7e97d354f7b5615f4e1ca3","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                \u0027min\u0027, \u0027stddev\u0027, \u0027stdvar\u0027,"},{"line_number":73,"context_line":"                \u0027sum\u0027"},{"line_number":74,"context_line":"            ]),"},{"line_number":75,"context_line":"        Optional(\u0027query_function\u0027, default\u003d\u0027\u0027):"},{"line_number":76,"context_line":"            In(["},{"line_number":77,"context_line":"                \u0027abs\u0027, \u0027ceil\u0027, \u0027exp\u0027,"},{"line_number":78,"context_line":"                \u0027floor\u0027, \u0027ln\u0027, \u0027log2\u0027,"},{"line_number":79,"context_line":"                \u0027log10\u0027, \u0027round\u0027, \u0027sqrt\u0027,"},{"line_number":80,"context_line":"                \u0027\u0027"},{"line_number":81,"context_line":"            ])"},{"line_number":82,"context_line":"    }"},{"line_number":83,"context_line":"}"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_6f8101a0","line":81,"range":{"start_line":75,"start_character":8,"end_line":81,"end_character":14},"in_reply_to":"3fa7e38b_0615dae5","updated":"2020-01-09 14:19:28.000000000","message":"If I do not put the \u0027\u0027 as an allowed value i\u0027ve got this error : voluptuous.error.MultipleInvalid: value is not allowed for dictionary value @ data[\u0027extra_args\u0027][\u0027query_function\u0027]","commit_id":"42cecddab44a73839b1ce4b338919ad849902408"},{"author":{"_account_id":29503,"name":"Justin Ferrieu","email":"jferrieu@objectif-libre.com","username":"jferrieu"},"change_message_id":"b5d3f32115ef280183ccc859ac6cf17ea64572f1","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        period \u003d tzutils.diff_seconds(end, start)"},{"line_number":155,"context_line":"        time \u003d end"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        query \u003d \u0027{0}{{{1}\u003d\"{2}\"}}[{3}s]\u0027.format("},{"line_number":158,"context_line":"            metric_name,"},{"line_number":159,"context_line":"            scope_key,"},{"line_number":160,"context_line":"            scope_id,"},{"line_number":161,"context_line":"            period"},{"line_number":162,"context_line":"        )"},{"line_number":163,"context_line":"        query \u003d \"{0}_over_time({1})\".format("},{"line_number":164,"context_line":"            method,"},{"line_number":165,"context_line":"            query"},{"line_number":166,"context_line":"        )"},{"line_number":167,"context_line":"        if query_function !\u003d \u0027\u0027:"},{"line_number":168,"context_line":"            query \u003d \"{0}({1})\".format("},{"line_number":169,"context_line":"                query_function,"},{"line_number":170,"context_line":"                query"},{"line_number":171,"context_line":"            )"},{"line_number":172,"context_line":"        query \u003d \"{0}({1})\".format("},{"line_number":173,"context_line":"            method,"},{"line_number":174,"context_line":"            query"},{"line_number":175,"context_line":"        )"},{"line_number":176,"context_line":"        query \u003d \"{0} by ({1})\".format("},{"line_number":177,"context_line":"            query,"},{"line_number":178,"context_line":"            \u0027, \u0027.join(groupby + metadata)"},{"line_number":179,"context_line":"        )"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        try:"},{"line_number":182,"context_line":"            res \u003d self._conn.get_instant("}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_c68ca22f","line":179,"range":{"start_line":157,"start_character":0,"end_line":179,"end_character":9},"updated":"2020-01-09 11:11:42.000000000","message":"Way better imo, I would suggest you comment each (or some) step i.e. `# Applying aggregation method`.","commit_id":"42cecddab44a73839b1ce4b338919ad849902408"}],"doc/source/admin/configuration/collector.rst":[{"author":{"_account_id":29503,"name":"Justin Ferrieu","email":"jferrieu@objectif-libre.com","username":"jferrieu"},"change_message_id":"6482d79d1226b1f892c1715985f510eca27ee370","unresolved":false,"context_lines":[{"line_number":303,"context_line":"  when retrieving measures from prometheus. Must be one of ``avg``, ``min``,"},{"line_number":304,"context_line":"  ``max``, ``sum``, ``count``, ``stddev``, ``stdvar``."},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"* ``query_function``: Defaults to ``\u0027\u0027``. The function to apply to an instant"},{"line_number":307,"context_line":"  vector after the ``aggregation_method`` or ``range_function`` has altered the"},{"line_number":308,"context_line":"  data. Must be one of ``abs``, ``ceil``, ``exp``, ``floor``, ``ln``, ``log2``,"},{"line_number":309,"context_line":"  ``log10``, ``round``, ``sqrt``. For more information on these functions,"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3fa7e38b_7766fdbe","line":306,"range":{"start_line":306,"start_character":22,"end_line":306,"end_character":39},"updated":"2020-01-03 09:15:30.000000000","message":"It is an optional key.","commit_id":"c2cbfab35bd3a78d32649fdd79784e6a687893c6"},{"author":{"_account_id":30844,"name":"Florian Davasse","email":"florian.davasse@objectif-libre.com","username":"aimbot31"},"change_message_id":"56dd164d4a53e4d381b48192cd2b51b37db2dfe1","unresolved":false,"context_lines":[{"line_number":303,"context_line":"  when retrieving measures from prometheus. Must be one of ``avg``, ``min``,"},{"line_number":304,"context_line":"  ``max``, ``sum``, ``count``, ``stddev``, ``stdvar``."},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"* ``query_function``: Defaults to ``\u0027\u0027``. The function to apply to an instant"},{"line_number":307,"context_line":"  vector after the ``aggregation_method`` or ``range_function`` has altered the"},{"line_number":308,"context_line":"  data. Must be one of ``abs``, ``ceil``, ``exp``, ``floor``, ``ln``, ``log2``,"},{"line_number":309,"context_line":"  ``log10``, ``round``, ``sqrt``. For more information on these functions,"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3fa7e38b_d79c915c","line":306,"range":{"start_line":306,"start_character":22,"end_line":306,"end_character":39},"in_reply_to":"3fa7e38b_7766fdbe","updated":"2020-01-03 09:37:48.000000000","message":"I agree with you but a guy with no name told me to do that or to put the field as Optional and to try/except.\nYou want me to put it as Optional ?","commit_id":"c2cbfab35bd3a78d32649fdd79784e6a687893c6"},{"author":{"_account_id":29503,"name":"Justin Ferrieu","email":"jferrieu@objectif-libre.com","username":"jferrieu"},"change_message_id":"a643a6053b00394417ee72ccc7925ca738939ad7","unresolved":false,"context_lines":[{"line_number":303,"context_line":"  when retrieving measures from prometheus. Must be one of ``avg``, ``min``,"},{"line_number":304,"context_line":"  ``max``, ``sum``, ``count``, ``stddev``, ``stdvar``."},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"* ``query_function``: Defaults to ``\u0027\u0027``. The function to apply to an instant"},{"line_number":307,"context_line":"  vector after the ``aggregation_method`` or ``range_function`` has altered the"},{"line_number":308,"context_line":"  data. Must be one of ``abs``, ``ceil``, ``exp``, ``floor``, ``ln``, ``log2``,"},{"line_number":309,"context_line":"  ``log10``, ``round``, ``sqrt``. For more information on these functions,"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3fa7e38b_77791dc4","line":306,"range":{"start_line":306,"start_character":22,"end_line":306,"end_character":39},"in_reply_to":"3fa7e38b_d79c915c","updated":"2020-01-03 10:17:54.000000000","message":"I would indeed prefer since it reflects more reality.","commit_id":"c2cbfab35bd3a78d32649fdd79784e6a687893c6"},{"author":{"_account_id":29503,"name":"Justin Ferrieu","email":"jferrieu@objectif-libre.com","username":"jferrieu"},"change_message_id":"6482d79d1226b1f892c1715985f510eca27ee370","unresolved":false,"context_lines":[{"line_number":304,"context_line":"  ``max``, ``sum``, ``count``, ``stddev``, ``stdvar``."},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"* ``query_function``: Defaults to ``\u0027\u0027``. The function to apply to an instant"},{"line_number":307,"context_line":"  vector after the ``aggregation_method`` or ``range_function`` has altered the"},{"line_number":308,"context_line":"  data. Must be one of ``abs``, ``ceil``, ``exp``, ``floor``, ``ln``, ``log2``,"},{"line_number":309,"context_line":"  ``log10``, ``round``, ``sqrt``. For more information on these functions,"},{"line_number":310,"context_line":"  you can check `this page`_"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3fa7e38b_570741ca","line":307,"range":{"start_line":307,"start_character":47,"end_line":307,"end_character":61},"updated":"2020-01-03 09:15:30.000000000","message":"What is referring ``range_function`` in the Prometheus collector configuration ?","commit_id":"c2cbfab35bd3a78d32649fdd79784e6a687893c6"},{"author":{"_account_id":29503,"name":"Justin Ferrieu","email":"jferrieu@objectif-libre.com","username":"jferrieu"},"change_message_id":"a643a6053b00394417ee72ccc7925ca738939ad7","unresolved":false,"context_lines":[{"line_number":304,"context_line":"  ``max``, ``sum``, ``count``, ``stddev``, ``stdvar``."},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"* ``query_function``: Defaults to ``\u0027\u0027``. The function to apply to an instant"},{"line_number":307,"context_line":"  vector after the ``aggregation_method`` or ``range_function`` has altered the"},{"line_number":308,"context_line":"  data. Must be one of ``abs``, ``ceil``, ``exp``, ``floor``, ``ln``, ``log2``,"},{"line_number":309,"context_line":"  ``log10``, ``round``, ``sqrt``. For more information on these functions,"},{"line_number":310,"context_line":"  you can check `this page`_"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3fa7e38b_17446972","line":307,"range":{"start_line":307,"start_character":47,"end_line":307,"end_character":61},"in_reply_to":"3fa7e38b_17b0e9db","updated":"2020-01-03 10:17:54.000000000","message":"I see. Removing it for the moment would be more rigorous but you can leave it for now if you want. It is as you like for this one.","commit_id":"c2cbfab35bd3a78d32649fdd79784e6a687893c6"},{"author":{"_account_id":30844,"name":"Florian Davasse","email":"florian.davasse@objectif-libre.com","username":"aimbot31"},"change_message_id":"56dd164d4a53e4d381b48192cd2b51b37db2dfe1","unresolved":false,"context_lines":[{"line_number":304,"context_line":"  ``max``, ``sum``, ``count``, ``stddev``, ``stdvar``."},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"* ``query_function``: Defaults to ``\u0027\u0027``. The function to apply to an instant"},{"line_number":307,"context_line":"  vector after the ``aggregation_method`` or ``range_function`` has altered the"},{"line_number":308,"context_line":"  data. Must be one of ``abs``, ``ceil``, ``exp``, ``floor``, ``ln``, ``log2``,"},{"line_number":309,"context_line":"  ``log10``, ``round``, ``sqrt``. For more information on these functions,"},{"line_number":310,"context_line":"  you can check `this page`_"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3fa7e38b_17b0e9db","line":307,"range":{"start_line":307,"start_character":47,"end_line":307,"end_character":61},"in_reply_to":"3fa7e38b_570741ca","updated":"2020-01-03 09:37:48.000000000","message":"I didn\u0027t spoke about range_function in this pr because it will be the next one, if you want I can remove the ``range_function`` part for the moment and re-write it after the pr gets merged.","commit_id":"c2cbfab35bd3a78d32649fdd79784e6a687893c6"},{"author":{"_account_id":30960,"name":"Quentin Anglade","email":"quentin.anglade@objectif-libre.com","username":"qanglade"},"change_message_id":"f4f295ddd3bc2e3243642357e022ca1287933392","unresolved":false,"context_lines":[{"line_number":303,"context_line":"  when retrieving measures from prometheus. Must be one of ``avg``, ``min``,"},{"line_number":304,"context_line":"  ``max``, ``sum``, ``count``, ``stddev``, ``stdvar``."},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"* ``query_function``: Defaults to ``\u0027\u0027``. The function to apply to an instant"},{"line_number":307,"context_line":"  vector after the ``aggregation_method`` or ``range_function`` has altered the"},{"line_number":308,"context_line":"  data. Must be one of ``abs``, ``ceil``, ``exp``, ``floor``, ``ln``, ``log2``,"},{"line_number":309,"context_line":"  ``log10``, ``round``, ``sqrt``. For more information on these functions,"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3fa7e38b_b94f238b","line":306,"range":{"start_line":306,"start_character":22,"end_line":306,"end_character":41},"updated":"2020-01-13 09:40:14.000000000","message":"Wouldn\u0027t it be a bit more clear to specify that the arg is optional instead of stating a \u0027\u0027 default value ?","commit_id":"b80f915f27bb4041b90ceaae7213c2e6aa288212"}],"lower-constraints.txt":[{"author":{"_account_id":29503,"name":"Justin Ferrieu","email":"jferrieu@objectif-libre.com","username":"jferrieu"},"change_message_id":"6482d79d1226b1f892c1715985f510eca27ee370","unresolved":false,"context_lines":[{"line_number":40,"context_line":"testscenarios\u003d\u003d0.4 # Apache-2.0/BSD"},{"line_number":41,"context_line":"stestr\u003d\u003d2.0.0 # Apache-2.0"},{"line_number":42,"context_line":"mock\u003d\u003d1.2 # BSD"},{"line_number":43,"context_line":"sphinx\u003d\u003d1.8.0 # BSD"},{"line_number":44,"context_line":"openstackdocstheme\u003d\u003d1.30.0 # Apache-2.0"},{"line_number":45,"context_line":"oslotest\u003d\u003d1.10.0 # Apache-2.0"},{"line_number":46,"context_line":"sphinxcontrib-pecanwsme\u003d\u003d0.8 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":10,"id":"3fa7e38b_37d0852b","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":19},"updated":"2020-01-03 09:15:30.000000000","message":"Same remark, if it is not dependent I would appreciate this as being explicit in a different patch.","commit_id":"c2cbfab35bd3a78d32649fdd79784e6a687893c6"},{"author":{"_account_id":30844,"name":"Florian Davasse","email":"florian.davasse@objectif-libre.com","username":"aimbot31"},"change_message_id":"56dd164d4a53e4d381b48192cd2b51b37db2dfe1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"testscenarios\u003d\u003d0.4 # Apache-2.0/BSD"},{"line_number":41,"context_line":"stestr\u003d\u003d2.0.0 # Apache-2.0"},{"line_number":42,"context_line":"mock\u003d\u003d1.2 # BSD"},{"line_number":43,"context_line":"sphinx\u003d\u003d1.8.0 # BSD"},{"line_number":44,"context_line":"openstackdocstheme\u003d\u003d1.30.0 # Apache-2.0"},{"line_number":45,"context_line":"oslotest\u003d\u003d1.10.0 # Apache-2.0"},{"line_number":46,"context_line":"sphinxcontrib-pecanwsme\u003d\u003d0.8 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":10,"id":"3fa7e38b_b791d555","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":19},"in_reply_to":"3fa7e38b_37d0852b","updated":"2020-01-03 09:37:48.000000000","message":"This appeared when i pulled and merged master to fix my problem with pep8.","commit_id":"c2cbfab35bd3a78d32649fdd79784e6a687893c6"},{"author":{"_account_id":29503,"name":"Justin Ferrieu","email":"jferrieu@objectif-libre.com","username":"jferrieu"},"change_message_id":"a643a6053b00394417ee72ccc7925ca738939ad7","unresolved":false,"context_lines":[{"line_number":40,"context_line":"testscenarios\u003d\u003d0.4 # Apache-2.0/BSD"},{"line_number":41,"context_line":"stestr\u003d\u003d2.0.0 # Apache-2.0"},{"line_number":42,"context_line":"mock\u003d\u003d1.2 # BSD"},{"line_number":43,"context_line":"sphinx\u003d\u003d1.8.0 # BSD"},{"line_number":44,"context_line":"openstackdocstheme\u003d\u003d1.30.0 # Apache-2.0"},{"line_number":45,"context_line":"oslotest\u003d\u003d1.10.0 # Apache-2.0"},{"line_number":46,"context_line":"sphinxcontrib-pecanwsme\u003d\u003d0.8 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":10,"id":"3fa7e38b_77527d38","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":19},"in_reply_to":"3fa7e38b_b791d555","updated":"2020-01-03 10:17:54.000000000","message":"Ok.","commit_id":"c2cbfab35bd3a78d32649fdd79784e6a687893c6"}],"tox.ini":[{"author":{"_account_id":29503,"name":"Justin Ferrieu","email":"jferrieu@objectif-libre.com","username":"jferrieu"},"change_message_id":"6482d79d1226b1f892c1715985f510eca27ee370","unresolved":false,"context_lines":[{"line_number":49,"context_line":"commands \u003d oslopolicy-sample-generator --config-file\u003detc/oslo-policy-generator/cloudkitty.conf"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"[testenv:docs]"},{"line_number":52,"context_line":"commands \u003d sphinx-build -W --keep-going -b html doc/source doc/build/html"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"[testenv:pdf-docs]"},{"line_number":55,"context_line":"envdir \u003d {toxworkdir}/docs"}],"source_content_type":"text/x-properties","patch_set":10,"id":"3fa7e38b_1726a968","line":52,"range":{"start_line":52,"start_character":11,"end_line":52,"end_character":73},"updated":"2020-01-03 09:15:30.000000000","message":"These changes do not appear in the work items. If it nos dependent to this very patch I would suggest that this kind of changes to be explicit in a different patch. This applies to all changes of this nature.","commit_id":"c2cbfab35bd3a78d32649fdd79784e6a687893c6"}]}