)]}'
{"cloudkitty/hacking/checks.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"cf73ed7b0bcc5a7eb54fa0e0d6b0bd4510e28a4c","unresolved":false,"context_lines":[{"line_number":284,"context_line":""},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"@core.flake8ext"},{"line_number":287,"context_line":"def check_oslo_namespace_imports(physical_line, logical_line, filename):"},{"line_number":288,"context_line":"    \"\"\"\u0027oslo_\u0027 should be used instead of \u0027oslo.\u0027"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    C317"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_753451df","line":287,"range":{"start_line":287,"start_character":0,"end_line":287,"end_character":72},"updated":"2020-08-12 21:16:17.000000000","message":"@Andreas: I am curious why you\u0027re changing the order of arguments here.","commit_id":"b9362af82a6c942028cd7ddeba1cc89e7002a04d"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"38d0bde97e35f955fb02fc3bb6d7b218d0557d41","unresolved":false,"context_lines":[{"line_number":284,"context_line":""},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"@core.flake8ext"},{"line_number":287,"context_line":"def check_oslo_namespace_imports(physical_line, logical_line, filename):"},{"line_number":288,"context_line":"    \"\"\"\u0027oslo_\u0027 should be used instead of \u0027oslo.\u0027"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    C317"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_21c45b92","line":287,"range":{"start_line":287,"start_character":0,"end_line":287,"end_character":72},"in_reply_to":"9f560f44_55c5cd5a","updated":"2020-08-13 06:22:09.000000000","message":"The order change was needed to have this working with newer flake8.","commit_id":"b9362af82a6c942028cd7ddeba1cc89e7002a04d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"20c3a7f6d47bae3079ac5a97ebc1e97ba7696b33","unresolved":false,"context_lines":[{"line_number":284,"context_line":""},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"@core.flake8ext"},{"line_number":287,"context_line":"def check_oslo_namespace_imports(physical_line, logical_line, filename):"},{"line_number":288,"context_line":"    \"\"\"\u0027oslo_\u0027 should be used instead of \u0027oslo.\u0027"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    C317"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_55c5cd5a","line":287,"range":{"start_line":287,"start_character":0,"end_line":287,"end_character":72},"in_reply_to":"9f560f44_753451df","updated":"2020-08-12 21:38:51.000000000","message":"Actually looks like logical_line should be dropped.\n\nFrom my understanding, the physical line or the logical line is passed in based on the name of the first arg (kwargs anyone?), but I didn\u0027t think both could be passed in. At least the documentation doesn\u0027t indicate that is an option:\n\nhttps://github.com/PyCQA/pycodestyle/blob/master/docs/developer.rst#contribute\n\nMy guess is with the way it was before, we were getting the logical line passed in. So I\u0027m not sure if we are actually checking what we want to be checking on line 294.\n\nI suspect what we actually want is:\n\ndef check_oslo_namespace_imports(logical_line, noqa):\n    if noqa:\n        return","commit_id":"b9362af82a6c942028cd7ddeba1cc89e7002a04d"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"38d0bde97e35f955fb02fc3bb6d7b218d0557d41","unresolved":false,"context_lines":[{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    C317"},{"line_number":291,"context_line":"    \"\"\""},{"line_number":292,"context_line":"    if pycodestyle.noqa(physical_line):"},{"line_number":293,"context_line":"        return"},{"line_number":294,"context_line":"    if re.match(oslo_namespace_imports, logical_line):"},{"line_number":295,"context_line":"        msg \u003d (\"C317: \u0027%s\u0027 must be used instead of \u0027%s\u0027.\") % ("}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_a1d06b55","line":292,"range":{"start_line":292,"start_character":24,"end_line":292,"end_character":33},"updated":"2020-08-13 06:22:09.000000000","message":"here physical_line is used","commit_id":"b9362af82a6c942028cd7ddeba1cc89e7002a04d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"832587d0c41ba29287e5f582b042f8eb9088d6d2","unresolved":false,"context_lines":[{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    C317"},{"line_number":291,"context_line":"    \"\"\""},{"line_number":292,"context_line":"    if pycodestyle.noqa(physical_line):"},{"line_number":293,"context_line":"        return"},{"line_number":294,"context_line":"    if re.match(oslo_namespace_imports, logical_line):"},{"line_number":295,"context_line":"        msg \u003d (\"C317: \u0027%s\u0027 must be used instead of \u0027%s\u0027.\") % ("}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_dce73d46","line":292,"range":{"start_line":292,"start_character":24,"end_line":292,"end_character":33},"in_reply_to":"9f560f44_a1d06b55","updated":"2020-08-13 12:31:19.000000000","message":"Isn\u0027t the noqa argument available for this?\n\nI couldn\u0027t find anywhere saying both logical and physical lines could be passed in together.","commit_id":"b9362af82a6c942028cd7ddeba1cc89e7002a04d"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"3727bde8a9ed5fcb27fbfafbfceaa73d002bd587","unresolved":false,"context_lines":[{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    C317"},{"line_number":291,"context_line":"    \"\"\""},{"line_number":292,"context_line":"    if pycodestyle.noqa(physical_line):"},{"line_number":293,"context_line":"        return"},{"line_number":294,"context_line":"    if re.match(oslo_namespace_imports, logical_line):"},{"line_number":295,"context_line":"        msg \u003d (\"C317: \u0027%s\u0027 must be used instead of \u0027%s\u0027.\") % ("}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_3c463923","line":292,"range":{"start_line":292,"start_character":24,"end_line":292,"end_character":33},"in_reply_to":"9f560f44_dce73d46","updated":"2020-08-13 12:35:07.000000000","message":"You\u0027re right, let me test and upload a new version if this works...","commit_id":"b9362af82a6c942028cd7ddeba1cc89e7002a04d"}],"contrib/ci/csv_writer.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"7a4bdc032f2260b6cdf55a43aafaf8d685f1e3de","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    \"project_id\": \"f1873b13951542268bf7eed7cf971e52\","},{"line_number":95,"context_line":"    \"resource_id\": \"08017fbc-b13a-4d8d-b002-4eb4eff54cd4\","},{"line_number":96,"context_line":"    \"source\": \"openstack\","},{"line_number":97,"context_line":"    \"user_id\": \"None\"}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"NETWORK_BW_IN \u003d {"},{"line_number":100,"context_line":"    \"type\": \"network.bw.in\","}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_41c0e02a","side":"PARENT","line":97,"range":{"start_line":97,"start_character":4,"end_line":97,"end_character":21},"updated":"2020-03-31 16:25:35.000000000","message":"Not sure but I think this one overrided the previous value previously so surely this one was in use in code and was expected somewhere, thoughts?","commit_id":"56609c46f96e38ddc13c7830d6b32479ddaaa1ac"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"eb33c3bfd87314c5384cec061ea77dfb0bd133a1","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    \"project_id\": \"f1873b13951542268bf7eed7cf971e52\","},{"line_number":95,"context_line":"    \"resource_id\": \"08017fbc-b13a-4d8d-b002-4eb4eff54cd4\","},{"line_number":96,"context_line":"    \"source\": \"openstack\","},{"line_number":97,"context_line":"    \"user_id\": \"None\"}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"NETWORK_BW_IN \u003d {"},{"line_number":100,"context_line":"    \"type\": \"network.bw.in\","}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_6f0ceba4","side":"PARENT","line":97,"range":{"start_line":97,"start_character":4,"end_line":97,"end_character":21},"in_reply_to":"df33271e_41c0e02a","updated":"2020-03-31 18:01:52.000000000","message":"yes, it overrides line 91 - and line 91 looks like what\u0027s intented. So, let\u0027s see whether tests pass.","commit_id":"56609c46f96e38ddc13c7830d6b32479ddaaa1ac"}]}