)]}'
{"cloudkitty/common/policy.py":[{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"a02f52e24b89922772f97f7cf214fa9b29410f96","unresolved":true,"context_lines":[{"line_number":32,"context_line":"# TODO(gmann): Remove setting the default value of config policy_file"},{"line_number":33,"context_line":"# once oslo_policy change the default value to \u0027policy.yaml\u0027."},{"line_number":34,"context_line":"# https://github.com/openstack/oslo.policy/blob/a626ad12fe5a3abd49d70e3e5b95589d279ab578/oslo_policy/opts.py#L49"},{"line_number":35,"context_line":"DEFAULT_POLICY_FILE \u003d \u0027policy.yaml\u0027"},{"line_number":36,"context_line":"policy_opts.set_defaults(cfg.CONF, DEFAULT_POLICY_FILE)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"_ENFORCER \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"e247cdd0_3608bed8","line":35,"updated":"2020-12-23 02:02:32.000000000","message":"Do you need to set this twice? You seem to be doing this already in https://review.opendev.org/c/openstack/cloudkitty/+/766842/4/cloudkitty/common/defaults.py#29","commit_id":"c8370c2ab2a9d97dd61ecfdbe56f1bdf43963d11"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"bb8577a72ddb626cfb37192f997f266d9e6fa8cd","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# TODO(gmann): Remove setting the default value of config policy_file"},{"line_number":33,"context_line":"# once oslo_policy change the default value to \u0027policy.yaml\u0027."},{"line_number":34,"context_line":"# https://github.com/openstack/oslo.policy/blob/a626ad12fe5a3abd49d70e3e5b95589d279ab578/oslo_policy/opts.py#L49"},{"line_number":35,"context_line":"DEFAULT_POLICY_FILE \u003d \u0027policy.yaml\u0027"},{"line_number":36,"context_line":"policy_opts.set_defaults(cfg.CONF, DEFAULT_POLICY_FILE)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"_ENFORCER \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"a9d8b33b_81eca698","line":35,"in_reply_to":"2094a384_6f7cd641","updated":"2020-12-23 02:15:05.000000000","message":"I see. Thanks for the reply!","commit_id":"c8370c2ab2a9d97dd61ecfdbe56f1bdf43963d11"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"814ad93663a8840fbe6c2ed23db79862c3350421","unresolved":true,"context_lines":[{"line_number":32,"context_line":"# TODO(gmann): Remove setting the default value of config policy_file"},{"line_number":33,"context_line":"# once oslo_policy change the default value to \u0027policy.yaml\u0027."},{"line_number":34,"context_line":"# https://github.com/openstack/oslo.policy/blob/a626ad12fe5a3abd49d70e3e5b95589d279ab578/oslo_policy/opts.py#L49"},{"line_number":35,"context_line":"DEFAULT_POLICY_FILE \u003d \u0027policy.yaml\u0027"},{"line_number":36,"context_line":"policy_opts.set_defaults(cfg.CONF, DEFAULT_POLICY_FILE)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"_ENFORCER \u003d None"}],"source_content_type":"text/x-python","patch_set":4,"id":"2094a384_6f7cd641","line":35,"in_reply_to":"e247cdd0_3608bed8","updated":"2020-12-23 02:11:38.000000000","message":"yeah, both serve separate purpose.\n\n1. this one - this is actually change the code path to select the new default value of oslo_policy_policy_file config option in oslo policy engine.\n\n2. cloudkitty/common/defaults.py - this is only needed for confog generator tool so that generated config sample file will reflect the new value - https://docs.openstack.org/oslo.config/latest/cli/generator.html#modifying-defaults-from-other-namespaces","commit_id":"c8370c2ab2a9d97dd61ecfdbe56f1bdf43963d11"}]}