)]}'
{"cloudkitty/utils/__init__.py":[{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"1d2af9de799101cf29e46e33a5716d7d8bfc0f8d","unresolved":true,"context_lines":[{"line_number":259,"context_line":"    if mode \u003d\u003d \u0027NUMBOOL\u0027:"},{"line_number":260,"context_line":"        return float(value !\u003d 0.0)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    if mode \u003d\u003d \u0027NOTNUMBOOL\u0027:"},{"line_number":263,"context_line":"        return float(value \u003d\u003d 0.0)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    if mode \u003d\u003d \u0027FLOOR\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"02475976_a82a86c4","line":262,"updated":"2021-02-08 16:38:51.000000000","message":"If this one is the opposite (the not operation) of the `numbool`, you could also use `return !mutate(value, \u0027NUMBOOL\u0027)`","commit_id":"49330f187769cf18711a5d3ff35aaa4bd437ac7d"},{"author":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"change_message_id":"88fc2d0c6d58a521e1c83a946c4745906cbce7bc","unresolved":true,"context_lines":[{"line_number":259,"context_line":"    if mode \u003d\u003d \u0027NUMBOOL\u0027:"},{"line_number":260,"context_line":"        return float(value !\u003d 0.0)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    if mode \u003d\u003d \u0027NOTNUMBOOL\u0027:"},{"line_number":263,"context_line":"        return float(value \u003d\u003d 0.0)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    if mode \u003d\u003d \u0027FLOOR\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"eaebc87d_c8aa4577","line":262,"in_reply_to":"02475976_a82a86c4","updated":"2021-03-05 17:58:04.000000000","message":"Do you want me to change this or should I leave it as is? I imagine the whole method will get an overhaul soon. ;)","commit_id":"49330f187769cf18711a5d3ff35aaa4bd437ac7d"},{"author":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"change_message_id":"6e177b0db898644de77ec029923551cb44a3a410","unresolved":true,"context_lines":[{"line_number":259,"context_line":"    if mode \u003d\u003d \u0027NUMBOOL\u0027:"},{"line_number":260,"context_line":"        return float(value !\u003d 0.0)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    if mode \u003d\u003d \u0027NOTNUMBOOL\u0027:"},{"line_number":263,"context_line":"        return float(value \u003d\u003d 0.0)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    if mode \u003d\u003d \u0027FLOOR\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"51f5f857_0452fb99","line":262,"in_reply_to":"db6685de_5e27114e","updated":"2021-03-09 13:10:50.000000000","message":"One problem I see with simply negating output from a function returning a float is that the resulting value will be of type bool/int which is different than what\u0027s returned for NUMBOOL. I\u0027ll open the change to reviews and if you guys want me to do something like `float(not mutate(value, \u0027NUMBOOL\u0027))` instead, I will.","commit_id":"49330f187769cf18711a5d3ff35aaa4bd437ac7d"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"2e48a82d095a615c33899c36430d7e2123653754","unresolved":true,"context_lines":[{"line_number":259,"context_line":"    if mode \u003d\u003d \u0027NUMBOOL\u0027:"},{"line_number":260,"context_line":"        return float(value !\u003d 0.0)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    if mode \u003d\u003d \u0027NOTNUMBOOL\u0027:"},{"line_number":263,"context_line":"        return float(value \u003d\u003d 0.0)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    if mode \u003d\u003d \u0027FLOOR\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"db6685de_5e27114e","line":262,"in_reply_to":"eaebc87d_c8aa4577","updated":"2021-03-05 18:52:39.000000000","message":"I guess we can leave it as is. I just pointed this because if an option is the negation of other option, we always need to keep in mind that if we do not code as I mentioned, in future changes of the original method, the \"not\" option that is not using the original method, might start to behave differently, if the original method had its logic changed.","commit_id":"49330f187769cf18711a5d3ff35aaa4bd437ac7d"}]}