)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"6f6906dc2b3e4d0104263e4059ec1ce76fdee83f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"61b26b62_abeb5cb9","updated":"2022-01-26 15:25:06.000000000","message":"I amended the patch as discussed in our meeting this monday","commit_id":"36c8d5381bfc79d41041e5712c6cf1b300368995"},{"author":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"change_message_id":"29456884336d05e1dd0de7a26ebd1cf364ead6c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"879d964e_97f45719","updated":"2022-02-09 08:41:19.000000000","message":"Looks good to me.","commit_id":"aafeea5b37465eb8069f83121253d7b7776ec671"}],"cloudkitty/orchestrator.py":[{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"838411a91feb59bfe5e0905bc25c7ed83a448ef2","unresolved":true,"context_lines":[{"line_number":293,"context_line":"                # system in workers"},{"line_number":294,"context_line":"                sys.exit(1)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        \"\"\""},{"line_number":297,"context_line":"            Proposed fix for story#2006672, task#36940"},{"line_number":298,"context_line":"            (StoryBoard / Opendev - June 2021)"},{"line_number":299,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"c55d6dd4_a2e85bfc","line":296,"updated":"2021-07-12 14:56:00.000000000","message":"If you want to post some details here, you could extract the block to a method, and describe these things in the method. Moreover, unit testing to cover the issue that is being handled here would be welcome.","commit_id":"d099e078797bc6f1cc7f1383f1f25639efcc7955"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"6f6906dc2b3e4d0104263e4059ec1ce76fdee83f","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                # system in workers"},{"line_number":294,"context_line":"                sys.exit(1)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        \"\"\""},{"line_number":297,"context_line":"            Proposed fix for story#2006672, task#36940"},{"line_number":298,"context_line":"            (StoryBoard / Opendev - June 2021)"},{"line_number":299,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"34a03f8c_ec07352c","line":296,"in_reply_to":"c55d6dd4_a2e85bfc","updated":"2022-01-26 15:25:06.000000000","message":"Done","commit_id":"d099e078797bc6f1cc7f1383f1f25639efcc7955"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"c70ef831129f934c3509cacad16dbf23ef669da2","unresolved":true,"context_lines":[{"line_number":293,"context_line":"                # system in workers"},{"line_number":294,"context_line":"                sys.exit(1)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        \"\"\""},{"line_number":297,"context_line":"            Proposed fix for story#2006672, task#36940"},{"line_number":298,"context_line":"            (StoryBoard / Opendev - June 2021)"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"            A try/except block for ZeroDivisionError"},{"line_number":301,"context_line":"        \"\"\""},{"line_number":302,"context_line":"        try:"},{"line_number":303,"context_line":"            with futurist.ThreadPoolExecutor("},{"line_number":304,"context_line":"                    max_workers\u003dCONF.orchestrator.max_threads) as tpool:"}],"source_content_type":"text/x-python","patch_set":5,"id":"b3606e81_e40dec33","line":301,"range":{"start_line":296,"start_character":0,"end_line":301,"end_character":11},"updated":"2021-07-12 14:53:31.000000000","message":"Please remove this comment. Git history is enough ;-)","commit_id":"d099e078797bc6f1cc7f1383f1f25639efcc7955"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"6f6906dc2b3e4d0104263e4059ec1ce76fdee83f","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                # system in workers"},{"line_number":294,"context_line":"                sys.exit(1)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        \"\"\""},{"line_number":297,"context_line":"            Proposed fix for story#2006672, task#36940"},{"line_number":298,"context_line":"            (StoryBoard / Opendev - June 2021)"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"            A try/except block for ZeroDivisionError"},{"line_number":301,"context_line":"        \"\"\""},{"line_number":302,"context_line":"        try:"},{"line_number":303,"context_line":"            with futurist.ThreadPoolExecutor("},{"line_number":304,"context_line":"                    max_workers\u003dCONF.orchestrator.max_threads) as tpool:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab85d0d_700dbf28","line":301,"range":{"start_line":296,"start_character":0,"end_line":301,"end_character":11},"in_reply_to":"b3606e81_e40dec33","updated":"2022-01-26 15:25:06.000000000","message":"Done","commit_id":"d099e078797bc6f1cc7f1383f1f25639efcc7955"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"838411a91feb59bfe5e0905bc25c7ed83a448ef2","unresolved":true,"context_lines":[{"line_number":316,"context_line":"                              tpool.statistics.average_runtime)"},{"line_number":317,"context_line":"                          )"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        except ZeroDivisionError:"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"            # The ZeroDivisionError is raised when no executions have occured"},{"line_number":322,"context_line":"            # when calling the \u0027average_runtime\u0027 method"}],"source_content_type":"text/x-python","patch_set":5,"id":"80729cf7_e5f4721e","line":319,"updated":"2021-07-12 14:56:00.000000000","message":"Whenever we ignore an exception, I think that it is a good practice to log it in DEBUG level, and then telling the story in the message, that this is why we are ignoring the exception `x`\n\n```\n            # The ZeroDivisionError is raised when no executions have occured\n            # when calling the \u0027average_runtime\u0027 method\n            # In such a case, there is no need for further actions\n```","commit_id":"d099e078797bc6f1cc7f1383f1f25639efcc7955"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"6f6906dc2b3e4d0104263e4059ec1ce76fdee83f","unresolved":false,"context_lines":[{"line_number":316,"context_line":"                              tpool.statistics.average_runtime)"},{"line_number":317,"context_line":"                          )"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        except ZeroDivisionError:"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"            # The ZeroDivisionError is raised when no executions have occured"},{"line_number":322,"context_line":"            # when calling the \u0027average_runtime\u0027 method"}],"source_content_type":"text/x-python","patch_set":5,"id":"d0436841_2d2eab56","line":319,"in_reply_to":"80729cf7_e5f4721e","updated":"2022-01-26 15:25:06.000000000","message":"Done","commit_id":"d099e078797bc6f1cc7f1383f1f25639efcc7955"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"767e25bdb1300cc829c33c04712551026fead05c","unresolved":true,"context_lines":[{"line_number":299,"context_line":"        \"\"\"Execute the metric measurement collection"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        When executing this method a ZeroDivisionError might be raised."},{"line_number":302,"context_line":"        This happens when no executions have happend in the"},{"line_number":303,"context_line":"        `futurist.ThreadPoolExecutor`; then, when calling the"},{"line_number":304,"context_line":"        `average_runtime`, the exception is thrown. In such a case, there is"},{"line_number":305,"context_line":"         no need for further actions, and we can ignore the error."}],"source_content_type":"text/x-python","patch_set":9,"id":"715511de_17e66110","line":302,"range":{"start_line":302,"start_character":45,"end_line":302,"end_character":52},"updated":"2022-02-21 14:17:52.000000000","message":"happened","commit_id":"aafeea5b37465eb8069f83121253d7b7776ec671"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"714cb80e683ebeb4ed1fd5ea4e87943a0bfcaf4d","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        \"\"\"Execute the metric measurement collection"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        When executing this method a ZeroDivisionError might be raised."},{"line_number":302,"context_line":"        This happens when no executions have happend in the"},{"line_number":303,"context_line":"        `futurist.ThreadPoolExecutor`; then, when calling the"},{"line_number":304,"context_line":"        `average_runtime`, the exception is thrown. In such a case, there is"},{"line_number":305,"context_line":"         no need for further actions, and we can ignore the error."}],"source_content_type":"text/x-python","patch_set":9,"id":"3a42faf0_f7c350d1","line":302,"range":{"start_line":302,"start_character":45,"end_line":302,"end_character":52},"in_reply_to":"715511de_17e66110","updated":"2022-02-21 14:21:25.000000000","message":"Done","commit_id":"aafeea5b37465eb8069f83121253d7b7776ec671"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"767e25bdb1300cc829c33c04712551026fead05c","unresolved":true,"context_lines":[{"line_number":305,"context_line":"         no need for further actions, and we can ignore the error."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        :param _get_result: the method to execute and get the metrics"},{"line_number":308,"context_line":"        :param metrics: the list os metrics to be collected"},{"line_number":309,"context_line":"        :return: the metrics measurements"},{"line_number":310,"context_line":"        \"\"\""},{"line_number":311,"context_line":"        results \u003d []"}],"source_content_type":"text/x-python","patch_set":9,"id":"bcc7984d_e186110c","line":308,"range":{"start_line":308,"start_character":33,"end_line":308,"end_character":35},"updated":"2022-02-21 14:17:52.000000000","message":"of","commit_id":"aafeea5b37465eb8069f83121253d7b7776ec671"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"714cb80e683ebeb4ed1fd5ea4e87943a0bfcaf4d","unresolved":false,"context_lines":[{"line_number":305,"context_line":"         no need for further actions, and we can ignore the error."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        :param _get_result: the method to execute and get the metrics"},{"line_number":308,"context_line":"        :param metrics: the list os metrics to be collected"},{"line_number":309,"context_line":"        :return: the metrics measurements"},{"line_number":310,"context_line":"        \"\"\""},{"line_number":311,"context_line":"        results \u003d []"}],"source_content_type":"text/x-python","patch_set":9,"id":"d8d06f40_98a4770b","line":308,"range":{"start_line":308,"start_character":33,"end_line":308,"end_character":35},"in_reply_to":"bcc7984d_e186110c","updated":"2022-02-21 14:21:25.000000000","message":"Done","commit_id":"aafeea5b37465eb8069f83121253d7b7776ec671"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"767e25bdb1300cc829c33c04712551026fead05c","unresolved":true,"context_lines":[{"line_number":329,"context_line":"                                             tpool.statistics.average_runtime))"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        except ZeroDivisionError as zeroDivisionError:"},{"line_number":332,"context_line":"            LOG.debug(\"ZeroDivisionError happened for measurement collection \""},{"line_number":333,"context_line":"                      \"for metrics [%s]. Normally, we can ignore this error \""},{"line_number":334,"context_line":"                      \"[%s].\", metrics, zeroDivisionError)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        return dict(filter(lambda x: x[1] is not None, results))"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"0e0fd2d6_55655c54","line":334,"range":{"start_line":332,"start_character":0,"end_line":334,"end_character":58},"updated":"2022-02-21 14:17:52.000000000","message":"Can you make the message shorter? This may be enough:\n\nIgnoring ZeroDivisionError for metrics [%s]","commit_id":"aafeea5b37465eb8069f83121253d7b7776ec671"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"714cb80e683ebeb4ed1fd5ea4e87943a0bfcaf4d","unresolved":false,"context_lines":[{"line_number":329,"context_line":"                                             tpool.statistics.average_runtime))"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        except ZeroDivisionError as zeroDivisionError:"},{"line_number":332,"context_line":"            LOG.debug(\"ZeroDivisionError happened for measurement collection \""},{"line_number":333,"context_line":"                      \"for metrics [%s]. Normally, we can ignore this error \""},{"line_number":334,"context_line":"                      \"[%s].\", metrics, zeroDivisionError)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        return dict(filter(lambda x: x[1] is not None, results))"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7635575c_12397d5c","line":334,"range":{"start_line":332,"start_character":0,"end_line":334,"end_character":58},"in_reply_to":"0e0fd2d6_55655c54","updated":"2022-02-21 14:21:25.000000000","message":"Done","commit_id":"aafeea5b37465eb8069f83121253d7b7776ec671"}]}