)]}'
{"id":"openstack%2Fcloudkitty~797323","triplet_id":"openstack%2Fcloudkitty~master~I4896d4dfaf4836f21263a39c63cf949c6713bc2d","project":"openstack/cloudkitty","branch":"master","topic":"change-797323-4","hashtags":[],"change_id":"I4896d4dfaf4836f21263a39c63cf949c6713bc2d","subject":"Fix code broken by SQLAlchemy 1.4","status":"ABANDONED","created":"2021-06-21 15:09:55.000000000","updated":"2021-06-24 11:11:35.000000000","total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"1a42babab2ee1772728d34d8b36703e942f2f120","_number":797323,"virtual_id_number":797323,"owner":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":7042,"name":"Stéphane Albert","email":"sheeprine@nullplace.com","username":"sheeprine"},{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},{"_account_id":16532,"name":"Luis Ramirez","email":"luis.ramirez@opencloud.es","username":"OpenCloud"},{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-06-24 09:47:31.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},{"_account_id":29503,"name":"Justin Ferrieu","email":"jferrieu@objectif-libre.com","username":"jferrieu"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7042,"name":"Stéphane Albert","email":"sheeprine@nullplace.com","username":"sheeprine"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16532,"name":"Luis Ramirez","email":"luis.ramirez@opencloud.es","username":"OpenCloud"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":29503,"name":"Justin Ferrieu","email":"jferrieu@objectif-libre.com","username":"jferrieu"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":7042,"name":"Stéphane Albert","email":"sheeprine@nullplace.com","username":"sheeprine"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},{"_account_id":16532,"name":"Luis Ramirez","email":"luis.ramirez@opencloud.es","username":"OpenCloud"},{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},{"_account_id":29503,"name":"Justin Ferrieu","email":"jferrieu@objectif-libre.com","username":"jferrieu"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"approved":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"all":[{"_account_id":7042,"name":"Stéphane Albert","email":"sheeprine@nullplace.com","username":"sheeprine"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},{"_account_id":16532,"name":"Luis Ramirez","email":"luis.ramirez@opencloud.es","username":"OpenCloud"},{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},{"value":2,"date":"2021-06-24 11:11:35.000000000","permitted_voting_range":{"min":-1,"max":2},"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},{"_account_id":29503,"name":"Justin Ferrieu","email":"jferrieu@objectif-libre.com","username":"jferrieu"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7042,"name":"Stéphane Albert","email":"sheeprine@nullplace.com","username":"sheeprine"},{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},{"_account_id":16532,"name":"Luis Ramirez","email":"luis.ramirez@opencloud.es","username":"OpenCloud"},{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},{"_account_id":29503,"name":"Justin Ferrieu","email":"jferrieu@objectif-libre.com","username":"jferrieu"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-21 15:27:30.000000000","updated_by":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"reviewer":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"state":"REVIEWER"},{"updated":"2021-06-21 15:50:52.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-22 12:52:49.000000000","updated_by":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"reviewer":{"_account_id":7042,"name":"Stéphane Albert","email":"sheeprine@nullplace.com","username":"sheeprine"},"state":"REVIEWER"},{"updated":"2021-06-22 12:52:49.000000000","updated_by":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"reviewer":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"state":"REVIEWER"},{"updated":"2021-06-22 12:52:49.000000000","updated_by":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"reviewer":{"_account_id":23173,"name":"Maxime Cottret","email":"maxime.cottret@gmail.com","username":"aolwas"},"state":"REVIEWER"},{"updated":"2021-06-22 12:52:49.000000000","updated_by":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"reviewer":{"_account_id":16532,"name":"Luis Ramirez","email":"luis.ramirez@opencloud.es","username":"OpenCloud"},"state":"REVIEWER"},{"updated":"2021-06-22 12:52:49.000000000","updated_by":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"reviewer":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"state":"REVIEWER"},{"updated":"2021-06-22 12:52:49.000000000","updated_by":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"reviewer":{"_account_id":23060,"name":"Luka Peschke","email":"mail@lukapeschke.com","username":"lukapeschke"},"state":"REVIEWER"},{"updated":"2021-06-22 12:52:49.000000000","updated_by":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"reviewer":{"_account_id":29503,"name":"Justin Ferrieu","email":"jferrieu@objectif-libre.com","username":"jferrieu"},"state":"REVIEWER"},{"updated":"2021-06-22 12:52:49.000000000","updated_by":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"reviewer":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"state":"REVIEWER"}],"messages":[{"id":"c7d2527c85776fa3948e1433f7fee830eb3b05ca","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"date":"2021-06-21 15:09:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a6b465964d4d33126b33685fb1450a2ed14328cd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"date":"2021-06-21 15:18:39.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"131d128eed809d763aa609aebbfd1ff37202a2ce","author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"date":"2021-06-21 15:21:10.000000000","message":"Patch Set 2:\n\nThis should also unblock CI which is currently failing on \"AttributeError: \u0027Query\u0027 object has no attribute \u0027with_lockmode\u0027\"","accounts_in_message":[],"_revision_number":2},{"id":"fbdc70d267c66ef20daa94dbc51eb8b022493b51","author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"date":"2021-06-21 15:27:30.000000000","message":"Patch Set 2: Code-Review+1\n\nLooks good assuming it passes Zuul checks.","accounts_in_message":[],"_revision_number":2},{"id":"9812e42f275014d1fb3a47a7bb022c4c7a18a52b","author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"date":"2021-06-21 15:36:02.000000000","message":"Patch Set 2: Review-Priority+2\n\nUnblocks CI","accounts_in_message":[],"_revision_number":2},{"id":"ff81569453110145a306f26af4fdc74e94447fcf","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-21 15:50:52.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f71f16f078d144508c8b60d6eded731a : SUCCESS in 4m 25s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/098097911b334b439b9a05637ae3903c : FAILURE in 4m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/aaad6f854fe7437482dc1a35ab9d3115 : SUCCESS in 3m 57s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e317cfdbc785461eabe9df0fe8cd4074 : FAILURE in 4m 47s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/f01fe79676a14c5eae16448f2af6f4a6 : FAILURE in 4m 30s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/29f32f05fbbb4831b49644e2101d0ad8 : FAILURE in 5m 02s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/85c829bf1b304938bd312436269aa6ff : SUCCESS in 4m 36s\n- cloudkitty-tempest-full-v2-storage-influxdb https://zuul.opendev.org/t/openstack/build/ee07019884aa4090833b3c5542aff370 : SUCCESS in 27m 54s\n- cloudkitty-tempest-full-v2-storage-elasticsearch https://zuul.opendev.org/t/openstack/build/ec48d8d46f144e5387b4bc702ba24aed : SUCCESS in 27m 57s (non-voting)\n- cloudkitty-tempest-full-v1-storage-sqlalchemy https://zuul.opendev.org/t/openstack/build/1d0aa2967d674e4e881249c0a843be76 : SUCCESS in 28m 34s\n- cloudkitty-tempest-full-ipv6-only https://zuul.opendev.org/t/openstack/build/2227c49609b149a38551243e57aa7dbb : SUCCESS in 27m 40s\n- cloudkitty-tox-bandit https://zuul.opendev.org/t/openstack/build/bf9bebc18af943c7a2a60d0b40513008 : FAILURE in 4m 05s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"581adbf6ffedb548c11dda155c3f42cb30074069","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"date":"2021-06-22 07:59:38.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"9907e26c7a67bc8b22ed0b5b421e4994dab4cebf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"date":"2021-06-22 08:03:33.000000000","message":"Uploaded patch set 4: Commit message was updated.","accounts_in_message":[],"_revision_number":4},{"id":"86b427fe8545bd8738a37c7649ca0a49d3dad712","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-22 08:43:03.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5c4a8a979f564a11808b5bfceb17aaeb : SUCCESS in 5m 17s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/2dd9be3132104584b193bdcfdf0fd00b : SUCCESS in 5m 37s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b7643631e41d44e7803b8f48f870e096 : SUCCESS in 4m 20s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/13cbf4c42764455aae4d2a2f61ec2289 : SUCCESS in 4m 58s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/c81dfb63296d4dcdbc4b1829bfd2cfc3 : SUCCESS in 4m 54s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/e781db1500d742d79e7ffe90cf6a382d : SUCCESS in 5m 40s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/91ea36c5f6994d88adc034139c95cadf : SUCCESS in 4m 36s\n- cloudkitty-tempest-full-v2-storage-influxdb https://zuul.opendev.org/t/openstack/build/37cf115a138a47a0a4b26636ef2fcbce : SUCCESS in 35m 35s\n- cloudkitty-tempest-full-v2-storage-elasticsearch https://zuul.opendev.org/t/openstack/build/973eff19ed344b84bdaee943a54b0060 : SUCCESS in 30m 08s (non-voting)\n- cloudkitty-tempest-full-v1-storage-sqlalchemy https://zuul.opendev.org/t/openstack/build/66a4fc8b0ad541cf990d3b1d72034f9a : SUCCESS in 33m 42s\n- cloudkitty-tempest-full-ipv6-only https://zuul.opendev.org/t/openstack/build/af50f58b51e7453983d5d2dd242ad896 : SUCCESS in 37m 32s\n- cloudkitty-tox-bandit https://zuul.opendev.org/t/openstack/build/8145409cb3134e96b67408459c117815 : FAILURE in 4m 44s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"7261b9985fba2f8f8e5ca3b4730408beafa8bdf3","author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"date":"2021-06-22 08:49:55.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"5c588768596bf1992ae77aa08e17a53639718b2e","author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"date":"2021-06-22 09:06:14.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"d911fded403ef7902ef5e10b77ab7901bf22c868","author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"date":"2021-06-22 12:56:43.000000000","message":"Patch Set 4:\n\nI just proposed a patch for that. \n\nThe problem with the Enum is something else. The tests are not working due to SQL alchemy not creating the constraints in the database.","accounts_in_message":[],"_revision_number":4},{"id":"fab579b0de2a10149d387f6609e2724776c2f7f0","author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"date":"2021-06-22 12:58:49.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"36ed48a837b9c29ec1dfbbb8101d73b325ac441c","author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"date":"2021-06-22 13:00:41.000000000","message":"Patch Set 4:\n\nRegarding the constraint, you can check the issue I raised in SQLalchemy: https://github.com/sqlalchemy/sqlalchemy/issues/6662","accounts_in_message":[],"_revision_number":4},{"id":"1cc3f8a4bf43224d744f1f63b3eb53065ca78957","author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"date":"2021-06-22 17:00:39.000000000","message":"Patch Set 4: Workflow+1\n\nI am going to -1 here, until we sort out the best method to handle the SQLalchemy upgrade.\n\nI do prefer the solution I propose, but I might be biased.","accounts_in_message":[],"_revision_number":4},{"id":"17194d67b4a92687c41b42c413e8e6ddfee0648b","author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"date":"2021-06-22 17:00:50.000000000","message":"Patch Set 4: Workflow-1","accounts_in_message":[],"_revision_number":4},{"id":"200ad09e440ea8804ad7ab9947a75252bc78156e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-22 17:00:57.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"8d5750f3aecaf3034b2e6248c33b101f6d2d634f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-22 17:50:15.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3a935f04cdce4a1282487404fe448b1e : SUCCESS in 5m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/edded7d7fd974ecfb8dccbaaff3b31eb : SUCCESS in 5m 33s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d1c4a2f72abb4912866c91aaa98e8524 : SUCCESS in 5m 04s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/fe80ad6c77d3468d96c58f6ca5f6906b : SUCCESS in 5m 08s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c837b10e7de64bae9b6a266b896bacce : SUCCESS in 5m 52s\n- cloudkitty-tempest-full-v2-storage-influxdb https://zuul.opendev.org/t/openstack/build/e9004b31b4c04626b3452912ea5fb4af : SUCCESS in 37m 02s\n- cloudkitty-tempest-full-v1-storage-sqlalchemy https://zuul.opendev.org/t/openstack/build/939b6787a4b94b4da17d0f51e6c9263a : SUCCESS in 35m 37s\n- cloudkitty-tempest-full-ipv6-only https://zuul.opendev.org/t/openstack/build/9fbd9f8605f44ecc86d741199f0d6abd : SUCCESS in 43m 36s","accounts_in_message":[],"_revision_number":4},{"id":"4bd988e22f907578675c39c32f61406ac470539a","author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"date":"2021-06-23 08:21:08.000000000","message":"Patch Set 4:\n\n\u003e Patch Set 4: Workflow+1\n\u003e \n\u003e I am going to -1 here, until we sort out the best method to handle the SQLalchemy upgrade.\n\u003e \n\u003e I do prefer the solution I propose, but I might be biased.\n\nHi Rafael, I can confirm that create_constraint\u003dTrue in all Enums in a code fixing the issue.\nBut is it acceptable to change it in sqlalchemy migrations ? (Sorry , don\u0027t know what is the upstream policy) From my perspective of view it\u0027s not big deal because this option is present in both versions in newer one and also in older versions .. So can we just set this flag to true always ?","accounts_in_message":[],"_revision_number":4},{"id":"bba1b61c5fcf156d1ae2ce2edc67e782d59187dd","author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"date":"2021-06-23 10:20:08.000000000","message":"Patch Set 4:\n\n\u003e Patch Set 4:\n\u003e \n\u003e \u003e Patch Set 4: Workflow+1\n\u003e \u003e \n\u003e \u003e I am going to -1 here, until we sort out the best method to handle the SQLalchemy upgrade.\n\u003e \u003e \n\u003e \u003e I do prefer the solution I propose, but I might be biased.\n\u003e \n\u003e Hi Rafael, I can confirm that create_constraint\u003dTrue in all Enums in a code fixing the issue.\n\u003e But is it acceptable to change it in sqlalchemy migrations ? (Sorry , don\u0027t know what is the upstream policy) From my perspective of view it\u0027s not big deal because this option is present in both versions in newer one and also in older versions .. So can we just set this flag to true always ?\n\nThat is what I did.\n\nI think it is the best solution to maintain everything in sync. Otherwise, we would have different database schemas. The ones with SQLalchemy \u003c 1.4.0, where there are constraints in the database for enums, and the ones that do not have it (when deployed with SQLalchemy 1.4.0+).\n\nCan you review, and if you are ok with the patch I proposed, approve it?","accounts_in_message":[],"_revision_number":4},{"id":"d2b5a72a38a9cb81627145b8a7cf8ad339f6564f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"date":"2021-06-24 07:47:42.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"a01d116972d7c184c92c381f95cc658d48f0c8f7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-24 08:28:55.000000000","message":"Patch Set 5: Verified-1\n\n(3 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f0cb0e9627374908b19b78dedb574ef3 : SUCCESS in 5m 08s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/322ca120ca7b4d9aba422283752d78dc : SUCCESS in 5m 35s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e27f0db5f56c461eb622164904c0cdbc : FAILURE in 4m 56s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8efa4bdab020498b863e52d12a28da87 : SUCCESS in 5m 38s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/fbfdc5bc08624a61849db13955b65c63 : SUCCESS in 5m 48s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/2aad1ad74c924648a811b0753bed7511 : SUCCESS in 6m 43s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/571af37e1872409facd787d6cf507f38 : SUCCESS in 5m 40s\n- cloudkitty-tempest-full-v2-storage-influxdb https://zuul.opendev.org/t/openstack/build/4ff669115d814a8eb961602be22da252 : SUCCESS in 32m 30s\n- cloudkitty-tempest-full-v2-storage-elasticsearch https://zuul.opendev.org/t/openstack/build/1f1ecfbf3fdb436b9b149a7606656026 : SUCCESS in 35m 45s (non-voting)\n- cloudkitty-tempest-full-v1-storage-sqlalchemy https://zuul.opendev.org/t/openstack/build/541760ec188e48178237c33ec60dd33f : SUCCESS in 31m 30s\n- cloudkitty-tempest-full-ipv6-only https://zuul.opendev.org/t/openstack/build/8a2672d975be488e8e649b27c5ed8e65 : SUCCESS in 30m 49s\n- cloudkitty-tox-bandit https://zuul.opendev.org/t/openstack/build/116ed7e7c61b4e279b0fee6ef7b1304d : FAILURE in 5m 33s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"19aa94ee74c9cd371babcd2b345fda50cb37bff9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"date":"2021-06-24 08:59:03.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"689975b3fd3e24497c883567cad37c5aea3a50fd","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-24 09:47:31.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/111f936eb69747f695f46dc0204fae35 : SUCCESS in 5m 39s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/865cd3e7c9e84df28e25db53e66c98d6 : SUCCESS in 6m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/77f0946a0f72487abb3dbddb7ebbdff9 : SUCCESS in 6m 33s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d8f79afd0e544ce7badb1a50120d01b4 : SUCCESS in 5m 05s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/184ea6ac4b51497994327ff85c525404 : SUCCESS in 6m 48s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/9e9d2927d0754f3780dbd5577add1896 : SUCCESS in 5m 22s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/48e999a2335945fb83f205b9859ac8b6 : SUCCESS in 5m 47s\n- cloudkitty-tempest-full-v2-storage-influxdb https://zuul.opendev.org/t/openstack/build/0dcf2a2da9014c8284704e96912a82d0 : SUCCESS in 38m 10s\n- cloudkitty-tempest-full-v2-storage-elasticsearch https://zuul.opendev.org/t/openstack/build/ecec896f26074a00b63090ac8e762583 : SUCCESS in 41m 05s (non-voting)\n- cloudkitty-tempest-full-v1-storage-sqlalchemy https://zuul.opendev.org/t/openstack/build/b3cff36d6220451bb5aade0f4f828ff6 : SUCCESS in 38m 25s\n- cloudkitty-tempest-full-ipv6-only https://zuul.opendev.org/t/openstack/build/6c14236bd96b447c8b2932f36f5c260a : SUCCESS in 33m 37s\n- cloudkitty-tox-bandit https://zuul.opendev.org/t/openstack/build/20178462870349f4b8410d66fa2c33aa : FAILURE in 4m 56s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"cf6fbec53b662ac54b9c31a7459f70ba5e6e12ea","author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"date":"2021-06-24 10:14:39.000000000","message":"Patch Set 6:\n\nMichal, as I said, I proposed, at the same time (I did not see this one) a solution, which is now equals to this one, after my review. You could have just review it (my proposal), instead of applying the same changes here.\n\nI already merged the other solution, and rebased one of the already approved patched on top of it. Therefore, we can abandon this one.","accounts_in_message":[],"_revision_number":6},{"id":"24ea4315af555ff97a153b1d8c7d559a82722f37","author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"date":"2021-06-24 10:54:21.000000000","message":"Patch Set 6:\n\n\u003e Patch Set 6:\n\u003e \n\u003e Michal, as I said, I proposed, at the same time (I did not see this one) a solution, which is now equals to this one, after my review. You could have just review it (my proposal), instead of applying the same changes here.\n\u003e \n\u003e I already merged the other solution, and rebased one of the already approved patched on top of it. Therefore, we can abandon this one.\n\nOh, sorry, I somehow didn\u0027t noticed :)","accounts_in_message":[],"_revision_number":6},{"id":"ae8b661a453e57cfbeaddd11a0cf8b38406d7535","tag":"autogenerated:gerrit:abandon","author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"date":"2021-06-24 10:54:40.000000000","message":"Abandoned\n\nduplicate","accounts_in_message":[],"_revision_number":6},{"id":"d0fa7445e7cbcf955f2cf4de0f49721ec290c563","author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"date":"2021-06-24 10:58:45.000000000","message":"Patch Set 6:\n\n\u003e Patch Set 6:\n\u003e \n\u003e Michal, as I said, I proposed, at the same time (I did not see this one) a solution, which is now equals to this one, after my review. You could have just review it (my proposal), instead of applying the same changes here.\n\u003e \n\u003e I already merged the other solution, and rebased one of the already approved patched on top of it. Therefore, we can abandon this one.\n\nI\u0027ve mainly upload this patch (already abandoned) to pass CI tests in this review https://review.opendev.org/c/openstack/cloudkitty/+/797313 (already rebased on top of your commit)  (wallaby is not working without it).. \n\nSo maybe you can review that change. Thanks.","accounts_in_message":[],"_revision_number":6},{"id":"4c1ed5e6cf89da1d67e5b50b261a9cf969b7b950","author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"date":"2021-06-24 11:11:35.000000000","message":"Patch Set 6:\n\n\u003e Patch Set 6:\n\u003e \n\u003e \u003e Patch Set 6:\n\u003e \u003e \n\u003e \u003e Michal, as I said, I proposed, at the same time (I did not see this one) a solution, which is now equals to this one, after my review. You could have just review it (my proposal), instead of applying the same changes here.\n\u003e \u003e \n\u003e \u003e I already merged the other solution, and rebased one of the already approved patched on top of it. Therefore, we can abandon this one.\n\u003e \n\u003e Oh, sorry, I somehow didn\u0027t noticed :)\n\nNo problem, it happens 😊","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"2139528801880f17d598f862c42debc4251298d5","revisions":{"5a4eb75415f66888131c518c5a4d2bb941435600":{"kind":"REWORK","_number":1,"created":"2021-06-21 15:09:55.000000000","uploader":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"ref":"refs/changes/23/797323/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cloudkitty","ref":"refs/changes/23/797323/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cloudkitty refs/changes/23/797323/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cloudkitty refs/changes/23/797323/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cloudkitty refs/changes/23/797323/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cloudkitty refs/changes/23/797323/1"}}},"commit":{"parents":[{"commit":"510d8bf564e61bc3439c687f82919eb43e826b3e","subject":"Merge \"docs: Update Freenode to OFTC\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty/commit/510d8bf564e61bc3439c687f82919eb43e826b3e"}]}],"author":{"name":"Michal Arbet","email":"michal.arbet@ultimum.io","date":"2021-06-21 15:08:40.000000000","tz":120},"committer":{"name":"Michal Arbet","email":"michal.arbet@ultimum.io","date":"2021-06-21 15:09:52.000000000","tz":120},"subject":"Remove deprecated Code","message":"Remove deprecated Code\n\nquery.with_lockmode has been deprecated, this patch updates\nthis with query.with_for_update()\n\nChange-Id: I4896d4dfaf4836f21263a39c63cf949c6713bc2d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty/commit/5a4eb75415f66888131c518c5a4d2bb941435600"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty/commit/5a4eb75415f66888131c518c5a4d2bb941435600"}]},"branch":"refs/heads/master"},"78c95e5d6611f978ccb7b67d65b71dfecf6d72f0":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-06-21 15:18:39.000000000","uploader":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"ref":"refs/changes/23/797323/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cloudkitty","ref":"refs/changes/23/797323/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cloudkitty refs/changes/23/797323/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cloudkitty refs/changes/23/797323/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cloudkitty refs/changes/23/797323/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cloudkitty refs/changes/23/797323/2"}}},"commit":{"parents":[{"commit":"510d8bf564e61bc3439c687f82919eb43e826b3e","subject":"Merge \"docs: Update Freenode to OFTC\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty/commit/510d8bf564e61bc3439c687f82919eb43e826b3e"}]}],"author":{"name":"Michal Arbet","email":"michal.arbet@ultimum.io","date":"2021-06-21 15:08:40.000000000","tz":120},"committer":{"name":"Pierre Riteau","email":"pierre@stackhpc.com","date":"2021-06-21 15:17:50.000000000","tz":0},"subject":"Remove deprecated sqlalchemy code","message":"Remove deprecated sqlalchemy code\n\nquery.with_lockmode() has been deprecated, this patch updates it with\nquery.with_for_update().\n\nChange-Id: I4896d4dfaf4836f21263a39c63cf949c6713bc2d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty/commit/78c95e5d6611f978ccb7b67d65b71dfecf6d72f0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty/commit/78c95e5d6611f978ccb7b67d65b71dfecf6d72f0"}]},"branch":"refs/heads/master","description":"Edit commit message"},"6591b4f390b4b781b681d416aeac7919a51b5800":{"kind":"REWORK","_number":3,"created":"2021-06-22 07:59:38.000000000","uploader":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"ref":"refs/changes/23/797323/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cloudkitty","ref":"refs/changes/23/797323/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cloudkitty refs/changes/23/797323/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cloudkitty refs/changes/23/797323/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cloudkitty refs/changes/23/797323/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cloudkitty refs/changes/23/797323/3"}}},"commit":{"parents":[{"commit":"510d8bf564e61bc3439c687f82919eb43e826b3e","subject":"Merge \"docs: Update Freenode to OFTC\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty/commit/510d8bf564e61bc3439c687f82919eb43e826b3e"}]}],"author":{"name":"Michal Arbet","email":"michal.arbet@ultimum.io","date":"2021-06-21 15:08:40.000000000","tz":120},"committer":{"name":"Pierre Riteau","email":"pierre@stackhpc.com","date":"2021-06-22 07:56:51.000000000","tz":120},"subject":"Fix code broken by SQLAlchemy 1.4","message":"Fix code broken by SQLAlchemy 1.4\n\nThis change fixes issues triggered by the upgrade to SQLAlchemy 1.4.\n\nquery.with_lockmode() has been deprecated, this patch updates it with\nquery.with_for_update().\n\nThe get_mapping and get_threshold functions now raise the following\nexception when used with the \u0027invalid\u0027 parameter in unit tests:\nLookupError: \u0027invalid\u0027 is not among the defined enum values. Raise the\nexpected exception when this is detected.\n\nChange-Id: I4896d4dfaf4836f21263a39c63cf949c6713bc2d\nCo-Authored-By: Pierre Riteau \u003cpierre@stackhpc.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty/commit/6591b4f390b4b781b681d416aeac7919a51b5800"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty/commit/6591b4f390b4b781b681d416aeac7919a51b5800"}]},"branch":"refs/heads/master"},"c1684ab883b2b34b623071a4ab936aa57f7c1ab9":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2021-06-22 08:03:33.000000000","uploader":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"ref":"refs/changes/23/797323/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cloudkitty","ref":"refs/changes/23/797323/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cloudkitty refs/changes/23/797323/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cloudkitty refs/changes/23/797323/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cloudkitty refs/changes/23/797323/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cloudkitty refs/changes/23/797323/4"}}},"commit":{"parents":[{"commit":"510d8bf564e61bc3439c687f82919eb43e826b3e","subject":"Merge \"docs: Update Freenode to OFTC\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty/commit/510d8bf564e61bc3439c687f82919eb43e826b3e"}]}],"author":{"name":"Michal Arbet","email":"michal.arbet@ultimum.io","date":"2021-06-21 15:08:40.000000000","tz":120},"committer":{"name":"Pierre Riteau","email":"pierre@stackhpc.com","date":"2021-06-22 08:03:21.000000000","tz":120},"subject":"Fix code broken by SQLAlchemy 1.4","message":"Fix code broken by SQLAlchemy 1.4\n\nThis change fixes issues following the upgrade to SQLAlchemy 1.4.\n\nThe deprecated query.with_lockmode() function has been removed, this\npatch updates it with query.with_for_update().\n\nThe get_mapping and get_threshold functions now raise the following\nexception when used with the \u0027invalid\u0027 parameter in unit tests:\nLookupError: \u0027invalid\u0027 is not among the defined enum values. Raise the\nexpected exception when this is detected.\n\nChange-Id: I4896d4dfaf4836f21263a39c63cf949c6713bc2d\nCo-Authored-By: Pierre Riteau \u003cpierre@stackhpc.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty/commit/c1684ab883b2b34b623071a4ab936aa57f7c1ab9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty/commit/c1684ab883b2b34b623071a4ab936aa57f7c1ab9"}]},"branch":"refs/heads/master"},"a5c02585c05375f340c3f2cad914a618a111f9e1":{"kind":"REWORK","_number":5,"created":"2021-06-24 07:47:42.000000000","uploader":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"ref":"refs/changes/23/797323/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cloudkitty","ref":"refs/changes/23/797323/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cloudkitty refs/changes/23/797323/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cloudkitty refs/changes/23/797323/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cloudkitty refs/changes/23/797323/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cloudkitty refs/changes/23/797323/5"}}},"commit":{"parents":[{"commit":"510d8bf564e61bc3439c687f82919eb43e826b3e","subject":"Merge \"docs: Update Freenode to OFTC\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty/commit/510d8bf564e61bc3439c687f82919eb43e826b3e"}]}],"author":{"name":"Michal Arbet","email":"michal.arbet@ultimum.io","date":"2021-06-21 15:08:40.000000000","tz":120},"committer":{"name":"Michal Arbet","email":"michal.arbet@ultimum.io","date":"2021-06-24 07:41:15.000000000","tz":120},"subject":"Fix code broken by SQLAlchemy 1.4","message":"Fix code broken by SQLAlchemy 1.4\n\nThis change fixes issues following the upgrade to SQLAlchemy 1.4.\n\nThe deprecated query.with_lockmode() function has been removed, this\npatch updates it with query.with_for_update().\n\nSQLalchemy 1.4.0 and upwards do not generate contraints\nfor Enums on SQLite databases by default, this patch adds\narg create_constraint\u003dTrue for sqlalchemy.Enum which is\nalso backward compatible as SQLAlchemy \u003c1.4.0 has\ncreate_constraint\u003dTrue by default while \u003e1.4.0 has\ncreate_constraint\u003dFalse by default.\n\nChange-Id: I4896d4dfaf4836f21263a39c63cf949c6713bc2d\nCo-Authored-By: Pierre Riteau \u003cpierre@stackhpc.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty/commit/a5c02585c05375f340c3f2cad914a618a111f9e1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty/commit/a5c02585c05375f340c3f2cad914a618a111f9e1"}]},"branch":"refs/heads/master"},"2139528801880f17d598f862c42debc4251298d5":{"kind":"REWORK","_number":6,"created":"2021-06-24 08:59:03.000000000","uploader":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"ref":"refs/changes/23/797323/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cloudkitty","ref":"refs/changes/23/797323/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cloudkitty refs/changes/23/797323/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cloudkitty refs/changes/23/797323/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cloudkitty refs/changes/23/797323/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cloudkitty refs/changes/23/797323/6"}}},"commit":{"parents":[{"commit":"510d8bf564e61bc3439c687f82919eb43e826b3e","subject":"Merge \"docs: Update Freenode to OFTC\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty/commit/510d8bf564e61bc3439c687f82919eb43e826b3e"}]}],"author":{"name":"Michal Arbet","email":"michal.arbet@ultimum.io","date":"2021-06-21 15:08:40.000000000","tz":120},"committer":{"name":"Michal Arbet","email":"michal.arbet@ultimum.io","date":"2021-06-24 08:58:51.000000000","tz":120},"subject":"Fix code broken by SQLAlchemy 1.4","message":"Fix code broken by SQLAlchemy 1.4\n\nThis change fixes issues following the upgrade to SQLAlchemy 1.4.\n\nThe deprecated query.with_lockmode() function has been removed, this\npatch updates it with query.with_for_update().\n\nSQLalchemy 1.4.0 and upwards do not generate contraints\nfor Enums on SQLite databases by default, this patch adds\narg create_constraint\u003dTrue for sqlalchemy.Enum which is\nalso backward compatible as SQLAlchemy \u003c1.4.0 has\ncreate_constraint\u003dTrue by default while \u003e1.4.0 has\ncreate_constraint\u003dFalse by default.\n\nChange-Id: I4896d4dfaf4836f21263a39c63cf949c6713bc2d\nCo-Authored-By: Pierre Riteau \u003cpierre@stackhpc.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty/commit/2139528801880f17d598f862c42debc4251298d5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cloudkitty/commit/2139528801880f17d598f862c42debc4251298d5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}