)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"0e69880f3a3db7a7d523396b552574c99ce87d3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a07d4c1b_37e802da","updated":"2022-05-31 11:32:41.000000000","message":"Looking at the docs here:https://alecthomas.github.io/voluptuous/docs/_build/html/voluptuous.html\n```\nThe schema is a Python tree-like structure where nodes are pattern matched against corresponding trees of values.\n```\n\nIt gives again the idea that we should not use a function. However, it might be the same case as the `Coerce`. The library probably evolved over time, and started handling other data structures, and therefore, supports a function as well, but the documentation is a bit abstract in this respect.\n\nI am fine with both solutions. We just need to pick one, and then merge it, so I can patch the other patches with this fix.","commit_id":"1f2d25ebfecb570f53760b5a3d4844cd0ac55878"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b345e3ebe8a02e427c0397feff55c36cf41f8f7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f7ed2a00_f155c555","in_reply_to":"a07d4c1b_37e802da","updated":"2022-05-31 16:05:40.000000000","message":"Just under the description you quoted, it says:\n\nNodes can be values, in which case a direct comparison is used, types,\nin which case an isinstance() check is performed, or callables, which will\nvalidate and optionally convert the value.\n\nSo methods, which are callables, are fine?","commit_id":"1f2d25ebfecb570f53760b5a3d4844cd0ac55878"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"4e1c64075b5a9003c160166f7309eebd1b96ef6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f978fd05_feec3f15","in_reply_to":"f7ed2a00_f155c555","updated":"2022-05-31 16:07:18.000000000","message":"We can even remove the lambda.","commit_id":"1f2d25ebfecb570f53760b5a3d4844cd0ac55878"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"2d603c9496fedaf38dc032c30e1f1123d9fc1e69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ef80dcc6_9943edd2","in_reply_to":"f89a18c9_578fd327","updated":"2022-05-31 20:04:05.000000000","message":"I updated again as I realised we didn\u0027t need to call Schema another time…","commit_id":"1f2d25ebfecb570f53760b5a3d4844cd0ac55878"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"1e103f84d14d0fc4c3b75ed0e9d1eb9b5516ff5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f89a18c9_578fd327","in_reply_to":"f978fd05_feec3f15","updated":"2022-05-31 16:09:23.000000000","message":"I stopped reading in the first sentence. My bad.\n\nI guess we can move on with this one then.","commit_id":"1f2d25ebfecb570f53760b5a3d4844cd0ac55878"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"64a379646f5dd0cd303ad920131973bb358810a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"43e7f9ab_b278eaea","updated":"2022-05-31 21:08:45.000000000","message":"Let\u0027s merge to unbreak CI.\n\n@Mariusz: if you have comments, we can follow up with another change.","commit_id":"85da729089655e060f2f36702e9f9fa14de54723"}]}