)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"57320c9da98bc38d0cad4ad9b7502297f16e1ba5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0113719b_575ea42e","updated":"2022-12-02 09:39:16.000000000","message":"According to [1], the mapping type parameter has been removed in the 2.0 release. The 1.3.x series is still maintained, so you could switch to that until CloudKitty is updated [2]? \n\n[1] https://opensearch.org/docs/latest/breaking-changes/#remove-mapping-types-parameter\n[2] https://opensearch.org/releases.html","commit_id":"6707d058e3527b60edd2705941bbb3574a07a216"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"1271f7c2f207a82fc1ee208998fef4027571ccdb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8c0be759_404d5de5","updated":"2022-12-02 10:54:34.000000000","message":"Need to fix:\n\nDec 02 09:56:49.558330 ubuntu-jammy-iweb-mtl01-0032393637 opensearch[46944]: could not find java in bundled jdk at /usr/share/opensearch/jdk/bin/java","commit_id":"329ec6a4cf79b06002df2746791072b42f9486ba"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e1a191e874e3e5f9e74678ff4be4ace8b0b7d2e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3b8b11db_a3b4bc93","updated":"2022-12-02 10:42:43.000000000","message":"recheck\n\nUnable to locate packages","commit_id":"329ec6a4cf79b06002df2746791072b42f9486ba"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"6a7650ccbd6fcd3d793729498211eae5f05d524c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3bb3b779_d46ee0c3","in_reply_to":"04bac169_5c964f94","updated":"2022-12-02 11:47:55.000000000","message":"Perhaps we just need to set the JDK location? It should be bundled:\n\nhttps://opensearch.org/docs/1.3/opensearch/install/compatibility/","commit_id":"329ec6a4cf79b06002df2746791072b42f9486ba"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"0b285842a82aeb08ec75258d4116972b252e37de","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ecd03c39_d198db65","in_reply_to":"3bb3b779_d46ee0c3","updated":"2022-12-02 11:49:54.000000000","message":"Do you see it at `/usr/share/opensearch/jdk/bin/java` ?","commit_id":"329ec6a4cf79b06002df2746791072b42f9486ba"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"2c21768b19aa9b7a83ec4d0954320abf940d80d6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"04bac169_5c964f94","in_reply_to":"8c0be759_404d5de5","updated":"2022-12-02 11:39:34.000000000","message":"I don\u0027t know why we run into this. It isn\u0027t happening on my local devstack using the same code.","commit_id":"329ec6a4cf79b06002df2746791072b42f9486ba"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"4e2f82137d998b539032357faeca307982864e90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b5804901_42f25638","in_reply_to":"dc5d50b5_d28ef49f","updated":"2022-12-05 22:37:30.000000000","message":"I tracked it down to permissions issues: opensearch sources opensearch-env which locates the java binary to use.\n\nIt was failing on:\n\n++ JAVA\u003d/usr/share/opensearch/jdk/bin/java\n++ JAVA_TYPE\u003d\u0027bundled jdk\u0027\n++ \u0027[\u0027 \u0027!\u0027 -x /usr/share/opensearch/jdk/bin/java \u0027]\u0027\n++ echo \u0027could not find java in bundled jdk at /usr/share/opensearch/jdk/bin/java\u0027\ncould not find java in bundled jdk at /usr/share/opensearch/jdk/bin/java","commit_id":"329ec6a4cf79b06002df2746791072b42f9486ba"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"8cd63055d6e1db082cd34ec92dedb87c9676c963","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dc5d50b5_d28ef49f","in_reply_to":"ecd03c39_d198db65","updated":"2022-12-02 14:17:49.000000000","message":"That\u0027s where it is located in my own test environment. It should be the same in CI.","commit_id":"329ec6a4cf79b06002df2746791072b42f9486ba"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"bbdc0923cd7a8c9d4f6172e7464bfa21818272cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f9f664fc_21cf261d","updated":"2022-12-07 10:01:42.000000000","message":"@Rafael: do you have any concerns preventing you from giving a +2?","commit_id":"5fdb65b71a299119ef80e44745deb1974ce90e0a"},{"author":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"change_message_id":"3ff3ce7b8175a75757ad3028e7cd1a2d5f808bd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"bff41f76_8c238030","updated":"2022-12-07 14:31:06.000000000","message":"Thank you for the patch, Pierre. This looks good to me but keep in mind I don\u0027t have a DevStack box handy for testing. Please let me know if you think it would be beneficial for someone else to try this script out.\n\nAlso, shouldn\u0027t we keep both `install_elasticsearch` and `install_opensearch` until we remove support for Elasticsearch?","commit_id":"5fdb65b71a299119ef80e44745deb1974ce90e0a"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"de41e4edf7f0fa565a4393a3b1027c34730ede0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f07ce6d1_ed655a93","in_reply_to":"bff41f76_8c238030","updated":"2022-12-07 14:36:57.000000000","message":"OpenSearch 1.x is a drop-in replacement for Elasticsearch, so we are still testing the same thing: our elasticsearch storage driver. I don\u0027t think we need to keep the elasticsearch installation for this.\n\nThis is CI (devstack plugin) only, it doesn\u0027t impact users in any way, so I don\u0027t think you need to try it out.\n\nThe next step will need more testing: introducing an opensearch storage driver which would support OpenSearch 2.x.","commit_id":"5fdb65b71a299119ef80e44745deb1974ce90e0a"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"4543d4da6f513e448223f4daf941fd8c227f633e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ca7e2fa0_9c53888d","in_reply_to":"f9f664fc_21cf261d","updated":"2022-12-07 17:43:36.000000000","message":"I wanted to have more time to look at the script, before the final approval","commit_id":"5fdb65b71a299119ef80e44745deb1974ce90e0a"}],"devstack/plugin.sh":[{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"4543d4da6f513e448223f4daf941fd8c227f633e","unresolved":true,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"function install_opensearch {"},{"line_number":305,"context_line":"    OPENSEARCH_HOME\u003d/usr/share/opensearch"},{"line_number":306,"context_line":"    local opensearch_file\u003d$(get_extra_file \"https://artifacts.opensearch.org/releases/bundle/opensearch/1.3.6/opensearch-1.3.6-linux-x64.tar.gz\")"},{"line_number":307,"context_line":"    sudo mkdir -p $OPENSEARCH_HOME"},{"line_number":308,"context_line":"    sudo tar -xzpf ${opensearch_file} -C $OPENSEARCH_HOME --strip-components\u003d1"},{"line_number":309,"context_line":"    sudo mkdir -p $OPENSEARCH_HOME/data /var/log/opensearch"}],"source_content_type":"text/x-sh","patch_set":10,"id":"1139e50c_81103fb3","line":306,"range":{"start_line":306,"start_character":104,"end_line":306,"end_character":109},"updated":"2022-12-07 17:43:36.000000000","message":"What if we externalize this version to a variable for users using DEVStack? Then, they can easily upgrade/change between different versions.","commit_id":"5fdb65b71a299119ef80e44745deb1974ce90e0a"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"05bf9a6dc4b206e93dcf0b504241f50387c8280b","unresolved":true,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"function install_opensearch {"},{"line_number":305,"context_line":"    OPENSEARCH_HOME\u003d/usr/share/opensearch"},{"line_number":306,"context_line":"    local opensearch_file\u003d$(get_extra_file \"https://artifacts.opensearch.org/releases/bundle/opensearch/1.3.6/opensearch-1.3.6-linux-x64.tar.gz\")"},{"line_number":307,"context_line":"    sudo mkdir -p $OPENSEARCH_HOME"},{"line_number":308,"context_line":"    sudo tar -xzpf ${opensearch_file} -C $OPENSEARCH_HOME --strip-components\u003d1"},{"line_number":309,"context_line":"    sudo mkdir -p $OPENSEARCH_HOME/data /var/log/opensearch"}],"source_content_type":"text/x-sh","patch_set":10,"id":"8444aaaf_b2581701","line":306,"range":{"start_line":306,"start_character":104,"end_line":306,"end_character":109},"in_reply_to":"1139e50c_81103fb3","updated":"2022-12-07 19:25:25.000000000","message":"You\u0027re overthinking it. DevStack is not meant to be used for anything else than development and CI.","commit_id":"5fdb65b71a299119ef80e44745deb1974ce90e0a"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"53d5fb1953993eb7e3f8057f8f792e55056daa38","unresolved":true,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"function install_opensearch {"},{"line_number":305,"context_line":"    OPENSEARCH_HOME\u003d/usr/share/opensearch"},{"line_number":306,"context_line":"    local opensearch_file\u003d$(get_extra_file \"https://artifacts.opensearch.org/releases/bundle/opensearch/1.3.6/opensearch-1.3.6-linux-x64.tar.gz\")"},{"line_number":307,"context_line":"    sudo mkdir -p $OPENSEARCH_HOME"},{"line_number":308,"context_line":"    sudo tar -xzpf ${opensearch_file} -C $OPENSEARCH_HOME --strip-components\u003d1"},{"line_number":309,"context_line":"    sudo mkdir -p $OPENSEARCH_HOME/data /var/log/opensearch"}],"source_content_type":"text/x-sh","patch_set":10,"id":"0d4ee679_97f62a25","line":306,"range":{"start_line":306,"start_character":104,"end_line":306,"end_character":109},"in_reply_to":"8444aaaf_b2581701","updated":"2022-12-07 19:52:49.000000000","message":"I see what you mean.","commit_id":"5fdb65b71a299119ef80e44745deb1974ce90e0a"}]}