)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6ab2d63069ada416f324208a1f8fe99296f40e3d","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix bug in summary with OpenSearch backend"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: https://storyboard.openstack.org/#!/story/2011128"},{"line_number":10,"context_line":"Change-Id: I144a005c180ed67a16985f93efa930ddf937c989"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"55015b59_9c70989c","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":61},"updated":"2024-05-16 08:19:37.000000000","message":"The syntax is different for Storyboard:\n\nStory: 2011128\nTask: 50106","commit_id":"0dae18b70cedd852e84ad09cdc5e05dafbf6c69b"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"47255170654a624c9b923a01895b5ad57e2364fc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix bug in summary with OpenSearch backend"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: https://storyboard.openstack.org/#!/story/2011128"},{"line_number":10,"context_line":"Change-Id: I144a005c180ed67a16985f93efa930ddf937c989"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fc9226c7_a972706f","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":61},"in_reply_to":"55015b59_9c70989c","updated":"2024-05-16 10:17:48.000000000","message":"Done","commit_id":"0dae18b70cedd852e84ad09cdc5e05dafbf6c69b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"43352485fbf851ef4cff3cbf9e34f9d9fb92bb4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7468f344_295aa4cc","updated":"2024-05-15 15:40:55.000000000","message":"Marked WIP: I know this fixes the bug, but I need to test if it break any behaviour elsewhere.","commit_id":"0dae18b70cedd852e84ad09cdc5e05dafbf6c69b"}],"cloudkitty/api/v1/controllers/report.py":[{"author":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"change_message_id":"3505005d5e33c999e666a856866227b3e23afd8a","unresolved":true,"context_lines":[{"line_number":104,"context_line":"        result \u003d storage.total("},{"line_number":105,"context_line":"            groupby\u003dgroupby,"},{"line_number":106,"context_line":"            begin\u003dbegin, end\u003dend,"},{"line_number":107,"context_line":"            metric_types\u003d[service] if service else None,"},{"line_number":108,"context_line":"            filters\u003dfilters)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        if result[\u0027total\u0027] \u003c 1:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9efe2d9e_4782e0d3","line":107,"range":{"start_line":107,"start_character":12,"end_line":107,"end_character":56},"updated":"2024-05-25 12:32:52.000000000","message":"I think this should be done in the backend-specific implementation of the `total()` method, i.e. in `cloudkitty/storage/v2/opensearch/client.py`, before \"must\" and \"should\" are built.\n\nMy tests suggest the change doesn\u0027t break the InfluxDB backend but this conversion is not needed there and also the same change is applied in two different lines (one for `/v1/report/total` and another for `/v2/summary`), whereas if you moved it to the backend, you\u0027d only have to add a single line.\n\nPlease let me know if this makes sense.","commit_id":"a4015c73aad26866b087e8aa332669e06bffcbdf"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"b16cf3374d30dbe740ef8e2c4465a303f08732f2","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        result \u003d storage.total("},{"line_number":105,"context_line":"            groupby\u003dgroupby,"},{"line_number":106,"context_line":"            begin\u003dbegin, end\u003dend,"},{"line_number":107,"context_line":"            metric_types\u003d[service] if service else None,"},{"line_number":108,"context_line":"            filters\u003dfilters)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        if result[\u0027total\u0027] \u003c 1:"}],"source_content_type":"text/x-python","patch_set":7,"id":"8ca66bf7_44b950ec","line":107,"range":{"start_line":107,"start_character":12,"end_line":107,"end_character":56},"in_reply_to":"9efe2d9e_4782e0d3","updated":"2024-06-10 12:35:11.000000000","message":"Sure, that seems like a better solution. I\u0027ve made the change.","commit_id":"a4015c73aad26866b087e8aa332669e06bffcbdf"}],"releasenotes/notes/fix-v1-summary-and-total-with-opensearch-backend-9540741b80819672.yaml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"93a932430c509cf738605c7c44c417b1e5517ef1","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Fixed a bug where ``openstack rating summary get -s \u003cservice\u003e`` and"},{"line_number":5,"context_line":"    ``openstack rating total get -s \u003cservice\u003e`` would fail when using the"},{"line_number":6,"context_line":"    Elasticsearch or OpenSearch storage backends."},{"line_number":7,"context_line":"    `Story#2011128 \u003chttps://storyboard.openstack.org/#!/story/2011128\u003e`__"},{"line_number":8,"context_line":"    `Task#50106 \u003chttps://storyboard.openstack.org/#!/task/50106\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5e30e98b_e9dc7366","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":67},"updated":"2024-05-16 10:25:40.000000000","message":"We don\u0027t always refer to the storyboard link, but if you want to do so, please use:\n\n```\nSee story 2011128 \u003chttps://storyboard.openstack.org/#!/story/2011128\u003e`_ for more details.\n```","commit_id":"773248096e1948876b0a3eb3cbe4b17bbc036d9b"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"a11c2ff8c3cd5e6dcaae532654ff3c0d18289d33","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Fixed a bug where ``openstack rating summary get -s \u003cservice\u003e`` and"},{"line_number":5,"context_line":"    ``openstack rating total get -s \u003cservice\u003e`` would fail when using the"},{"line_number":6,"context_line":"    Elasticsearch or OpenSearch storage backends."},{"line_number":7,"context_line":"    `Story#2011128 \u003chttps://storyboard.openstack.org/#!/story/2011128\u003e`__"},{"line_number":8,"context_line":"    `Task#50106 \u003chttps://storyboard.openstack.org/#!/task/50106\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"be0fdbc3_b0d102da","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":67},"in_reply_to":"5e30e98b_e9dc7366","updated":"2024-05-16 10:27:22.000000000","message":"Done, is this format documented anywhere?","commit_id":"773248096e1948876b0a3eb3cbe4b17bbc036d9b"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"4d093790b7024e7c10511087da9a94630af5c243","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Fixed a bug where ``openstack rating summary get -s \u003cservice\u003e`` and"},{"line_number":5,"context_line":"    ``openstack rating total get -s \u003cservice\u003e`` would fail when using the"},{"line_number":6,"context_line":"    Elasticsearch or OpenSearch storage backends."},{"line_number":7,"context_line":"    `Story#2011128 \u003chttps://storyboard.openstack.org/#!/story/2011128\u003e`__"},{"line_number":8,"context_line":"    `Task#50106 \u003chttps://storyboard.openstack.org/#!/task/50106\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0ad1414b_15c58577","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":67},"in_reply_to":"a26c8ea6_59c504eb","updated":"2024-05-16 10:44:28.000000000","message":"Acknowledged","commit_id":"773248096e1948876b0a3eb3cbe4b17bbc036d9b"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"06a58cfb1f55ae6bd7ee680191e1ea429c26d2ae","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Fixed a bug where ``openstack rating summary get -s \u003cservice\u003e`` and"},{"line_number":5,"context_line":"    ``openstack rating total get -s \u003cservice\u003e`` would fail when using the"},{"line_number":6,"context_line":"    Elasticsearch or OpenSearch storage backends."},{"line_number":7,"context_line":"    `Story#2011128 \u003chttps://storyboard.openstack.org/#!/story/2011128\u003e`__"},{"line_number":8,"context_line":"    `Task#50106 \u003chttps://storyboard.openstack.org/#!/task/50106\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a26c8ea6_59c504eb","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":67},"in_reply_to":"be0fdbc3_b0d102da","updated":"2024-05-16 10:40:06.000000000","message":"Not really. It\u0027s what we were using in Kayobe before moving back to Launchpad. There are just a couple of cloudkitty release notes using this format.","commit_id":"773248096e1948876b0a3eb3cbe4b17bbc036d9b"}]}