)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e24e6d40c29753393f27ee4577c9ed0ea0228f94","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve devstack plugin configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch:"},{"line_number":10,"context_line":"  - adds possibility to set required configuration for prometheus collector"},{"line_number":11,"context_line":"  - adds possibility to set required configuration for prometheus fetcher"},{"line_number":12,"context_line":"  - adds possibility to use user created metrics.yml"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I05cae8b8e7168883ccb593a51f5aa807bc16b22d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e535b2be_051383e0","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":52},"updated":"2025-04-28 14:12:41.000000000","message":"Please wrap your commit message lines at 72 characters.","commit_id":"7c92dc52a2bac48725dea689820499e79de2dd95"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"dc836a331e7ebc2795af70d065bbf61115087d95","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve devstack plugin configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch:"},{"line_number":10,"context_line":"  - adds possibility to set required configuration for prometheus collector"},{"line_number":11,"context_line":"  - adds possibility to set required configuration for prometheus fetcher"},{"line_number":12,"context_line":"  - adds possibility to use user created metrics.yml"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I05cae8b8e7168883ccb593a51f5aa807bc16b22d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b7807464_e29d77dd","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":52},"in_reply_to":"e535b2be_051383e0","updated":"2025-04-29 11:28:19.000000000","message":"Acknowledged","commit_id":"7c92dc52a2bac48725dea689820499e79de2dd95"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"19ba089becbc61cd39686e1842574222bc474fd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6788b05c_fe7231d1","updated":"2025-04-28 07:48:49.000000000","message":"Rafael, we have found that the devstack pluging is not able to deploy using prometheus as collector and/or fetcher, nor it supports changing the metrics.yml file, which is different for every collector.\n\nCould you lay an eye on this changes?","commit_id":"7c92dc52a2bac48725dea689820499e79de2dd95"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e24e6d40c29753393f27ee4577c9ed0ea0228f94","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"362e61c2_bd3e4800","updated":"2025-04-28 14:12:41.000000000","message":"Thanks for your contribution! It would be good if this came with support for installing and running Prometheus. Without it we can\u0027t use this in OpenStack CI.","commit_id":"7c92dc52a2bac48725dea689820499e79de2dd95"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"92edf3c844c62272f083ab99959181d783701431","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ab3be239_85a02ae0","in_reply_to":"362e61c2_bd3e4800","updated":"2025-04-29 09:50:18.000000000","message":"That actually exists! Recently, devstack-plugin-prometheus was created: https://opendev.org/openstack/devstack-plugin-prometheus","commit_id":"7c92dc52a2bac48725dea689820499e79de2dd95"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"dc836a331e7ebc2795af70d065bbf61115087d95","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"68134f71_7c32f5d6","in_reply_to":"ab3be239_85a02ae0","updated":"2025-04-29 11:28:19.000000000","message":"Indeed, this patch is compatible with the plugin Juan mentioned. There is no need to have every Prometheus-dependent project install the Prometheus it\u0027s own way.","commit_id":"7c92dc52a2bac48725dea689820499e79de2dd95"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"4bbacf36497160015d8fc941ef09a34236b55081","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f23c4971_2559fbf7","updated":"2025-05-26 09:16:20.000000000","message":"Looks good to me. Can we proceed now?","commit_id":"1b723946ef7b5736048cf2d45f3eadb0e2255940"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"9df4dff83fd632ee6e3fc3532aa662f6fa3542dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"583bfa1d_476f62d6","updated":"2025-06-04 09:26:05.000000000","message":"Thank you for the reviews. I see 2 +2 but no +W. Can we get it too?","commit_id":"1b723946ef7b5736048cf2d45f3eadb0e2255940"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"4f2dd8873a759389648332201cde960e12bc104d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b8e634ee_cce47284","updated":"2025-06-04 11:55:42.000000000","message":"Thank you!","commit_id":"1b723946ef7b5736048cf2d45f3eadb0e2255940"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"888d73eb67a74ce4c4a980f03dd80424cbcd2379","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"86983e9d_086fc27e","updated":"2025-05-13 08:19:46.000000000","message":"There was some kind of change regarding removing mod_uwsgi just after 2025.1 release that made devstack fail to adequately deploy the ck-api. \n\nIt is tracked here with also a manual workaround is provided: https://issues.redhat.com/browse/OSPRH-16377\n\nThere are other services that fixed their uwsgi configuration prior to this change, the fix should be something similar to this: http://review.opendev.org/c/openstack/aodh/+/936099 and its relationship chain.","commit_id":"1b723946ef7b5736048cf2d45f3eadb0e2255940"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"e82abf98064fc5870de02f6ad37eca1f8041d5d8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7dae3c15_8a32e82c","updated":"2025-06-02 14:31:49.000000000","message":"These changes work well, but I should highlight that just switching to using the Prometheus fetcher and collector in devstack does not work out the box. We get the following error in the processor logs:\n\n```\nvoluptuous.error.MultipleInvalid: value must be one of [\u0027avg\u0027, \u0027count\u0027, \u0027max\u0027, \u0027min\u0027, \u0027stddev\u0027, \u0027stdvar\u0027, \u0027sum\u0027] for dictionary value @ data[\u0027extra_args\u0027][\u0027aggregation_method\u0027]\n```\n\nThis is because ``aggregation_method: mean`` is set under ``metrics.yml``.\n\nI\u0027ll give +2 to this patch, as it achieves its goals but it would be good to follow-up with a solution so we can eventually test using Prometheus in CI.","commit_id":"1b723946ef7b5736048cf2d45f3eadb0e2255940"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"58bd0c63b392b014d78d45131df0f2092b6a6ade","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bc7d3ce8_c39dc825","updated":"2025-05-13 08:14:22.000000000","message":"What is the issue with the CI here? I see all storage backends fail?","commit_id":"1b723946ef7b5736048cf2d45f3eadb0e2255940"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"cb8555a5af0d49dc86ec64e69200cac5e7a3e15c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"48180f32_880f4382","updated":"2025-04-29 13:30:30.000000000","message":"recheck","commit_id":"1b723946ef7b5736048cf2d45f3eadb0e2255940"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"04a2992f3c063162601ab164ab6e479a0423d58d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6917b965_715f3afd","updated":"2025-05-21 07:30:34.000000000","message":"recheck","commit_id":"1b723946ef7b5736048cf2d45f3eadb0e2255940"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"5bc723f4791eced8d842e8ea11b46bfcde618412","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"86d94323_4fe5d06b","updated":"2025-04-30 09:45:36.000000000","message":"recheck","commit_id":"1b723946ef7b5736048cf2d45f3eadb0e2255940"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"66567582c1553736576db32add551bd54086e8b1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bc88b22d_160fc2b6","in_reply_to":"7dae3c15_8a32e82c","updated":"2025-06-03 08:13:21.000000000","message":"Yes indeed. User needs to provide valid metrics.yml file, which is the reason the possibility to do so has been provided by this patch.","commit_id":"1b723946ef7b5736048cf2d45f3eadb0e2255940"}]}