)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"25ec07de1372ac0c54361ba4d11ae3dd0e1a6d7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e1375532_47d5625c","updated":"2025-09-15 19:25:44.000000000","message":"Except for the pep8 failures this lgtm.","commit_id":"03899072c40fb5fcc35a7d37510d99e665ce36bc"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"ed911907078dd11e6a7dd97410b7de5f43eb5d93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"aa5bb9ad_5df5ad57","updated":"2025-09-23 06:07:24.000000000","message":"For the past 2 weeks, I\u0027ve been playing around with CloudKitty, Prometheus and Loki. I can confirm, that I was able to use this patch to run CloudKitty with Loki with mTLS.","commit_id":"85f2272e27a12f1d88048f01b1fe4138a1b89371"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"1982034080c4252cc1497dfdee7e83f5c2d32bc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"85d974db_831e9475","updated":"2025-10-02 10:57:32.000000000","message":"Thanks! Just some small tweaks needed","commit_id":"85f2272e27a12f1d88048f01b1fe4138a1b89371"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"8fa970484d8edb6a1fc1602622113d15c9cabec8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"56acba16_1b07bc15","updated":"2025-10-09 19:13:28.000000000","message":"I **think** this is caused by pip23.1 and setuptools no longer supporting projects without pyproject.toml.\nI\u0027ve proposed a fix here: https://review.opendev.org/c/openstack/cloudkitty/+/963621","commit_id":"a1ac0761d92836a89ec3feb924d91afcd0e2f10f"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"3815378a965e2f795695625f728c2efb583f91a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4572c4ca_1968288e","updated":"2025-10-06 09:52:54.000000000","message":"Thanks!","commit_id":"a1ac0761d92836a89ec3feb924d91afcd0e2f10f"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"2606af25fb385fe6bddee5ef246afa8d82af3f50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a3b09124_6edcaa00","updated":"2025-10-09 14:42:40.000000000","message":"recheck python setuptools","commit_id":"a1ac0761d92836a89ec3feb924d91afcd0e2f10f"}],"cloudkitty/storage/v2/loki/__init__.py":[{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"25ec07de1372ac0c54361ba4d11ae3dd0e1a6d7f","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        verify \u003d not CONF.storage_loki.insecure"},{"line_number":87,"context_line":"        if verify and CONF.storage_loki.ca_file:"},{"line_number":88,"context_line":"            verify \u003d CONF.storage_loki.ca_file"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        if CONF.storage_loki.cert_file and CONF.storage_loki.key_file:"},{"line_number":91,"context_line":"            cert \u003d (CONF.storage_loki.cert_file, CONF.storage_loki.key_file)"}],"source_content_type":"text/x-python","patch_set":2,"id":"f40f1748_caf8cff1","line":88,"updated":"2025-09-15 19:25:44.000000000","message":"Just want to note here, because I needed to stop and think about this. The verify parameter in requests can be either: False, True (takes CA file from default path depending on distro) or \u003cpath to CA file\u003e.\n\nThis implementation correctly allows all 3 options based on the combination of the `insecure` and `ca_file` parameters.","commit_id":"03899072c40fb5fcc35a7d37510d99e665ce36bc"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"1982034080c4252cc1497dfdee7e83f5c2d32bc9","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        help\u003d\u0027Set to true to allow insecure HTTPS connections to Loki\u0027,"},{"line_number":61,"context_line":"        default\u003dFalse),"},{"line_number":62,"context_line":"    cfg.StrOpt("},{"line_number":63,"context_line":"        \u0027ca_file\u0027,"},{"line_number":64,"context_line":"        help\u003d\u0027Path of the CA certificate to trust for HTTPS connections.\u0027,"},{"line_number":65,"context_line":"        default\u003dNone),"},{"line_number":66,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":3,"id":"d482cb17_f7b13c4e","line":63,"updated":"2025-10-02 10:57:32.000000000","message":"This change should be reflected in the docs here: https://opendev.org/openstack/cloudkitty/src/branch/master/doc/source/admin/configuration/storage.rst?display\u003dsource#L139","commit_id":"85f2272e27a12f1d88048f01b1fe4138a1b89371"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"ec5094cc067d15155327c192ca9777c5cae335b5","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        help\u003d\u0027Set to true to allow insecure HTTPS connections to Loki\u0027,"},{"line_number":61,"context_line":"        default\u003dFalse),"},{"line_number":62,"context_line":"    cfg.StrOpt("},{"line_number":63,"context_line":"        \u0027ca_file\u0027,"},{"line_number":64,"context_line":"        help\u003d\u0027Path of the CA certificate to trust for HTTPS connections.\u0027,"},{"line_number":65,"context_line":"        default\u003dNone),"},{"line_number":66,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":3,"id":"c937718d_d803424e","line":63,"in_reply_to":"d482cb17_f7b13c4e","updated":"2025-10-03 07:30:48.000000000","message":"Done","commit_id":"85f2272e27a12f1d88048f01b1fe4138a1b89371"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"42dc6d8da1642df6450c2d0bc68a2b018a342aad","unresolved":true,"context_lines":[{"line_number":63,"context_line":"        \u0027ca_file\u0027,"},{"line_number":64,"context_line":"        help\u003d\u0027Path of the CA certificate to trust for HTTPS connections.\u0027,"},{"line_number":65,"context_line":"        default\u003dNone),"},{"line_number":66,"context_line":"    cfg.StrOpt("},{"line_number":67,"context_line":"        \u0027cert_file\u0027,"},{"line_number":68,"context_line":"        help\u003d\"Path to a client cert for establishing mTLS connections to \""},{"line_number":69,"context_line":"             \"Loki.\","}],"source_content_type":"text/x-python","patch_set":3,"id":"24e29b06_7e23f0fd","line":66,"updated":"2025-10-02 10:57:56.000000000","message":"Could you document cert_file and key_file too please?","commit_id":"85f2272e27a12f1d88048f01b1fe4138a1b89371"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"ec5094cc067d15155327c192ca9777c5cae335b5","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        \u0027ca_file\u0027,"},{"line_number":64,"context_line":"        help\u003d\u0027Path of the CA certificate to trust for HTTPS connections.\u0027,"},{"line_number":65,"context_line":"        default\u003dNone),"},{"line_number":66,"context_line":"    cfg.StrOpt("},{"line_number":67,"context_line":"        \u0027cert_file\u0027,"},{"line_number":68,"context_line":"        help\u003d\"Path to a client cert for establishing mTLS connections to \""},{"line_number":69,"context_line":"             \"Loki.\","}],"source_content_type":"text/x-python","patch_set":3,"id":"98fb2113_2bd6842c","line":66,"in_reply_to":"24e29b06_7e23f0fd","updated":"2025-10-03 07:30:48.000000000","message":"I was missing this, nice catch.","commit_id":"85f2272e27a12f1d88048f01b1fe4138a1b89371"}]}
