)]}'
{"cloudkitty/storage/v2/loki/__init__.py":[{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"7a35ee20433b627aa153775d0fc4965fddde07aa","unresolved":true,"context_lines":[{"line_number":87,"context_line":"    cfg.FloatOpt("},{"line_number":88,"context_line":"        \u0027timeout\u0027,"},{"line_number":89,"context_line":"        default\u003d60,"},{"line_number":90,"context_line":"        min\u003d0,"},{"line_number":91,"context_line":"        help\u003d\u0027Timeout value for http requests\u0027),"},{"line_number":92,"context_line":"]"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"151289b3_5d3fc290","line":90,"updated":"2026-02-09 10:03:53.000000000","message":"If someone sets a timeout of 0, all http requests will fail, so it does not actually means anything. Are we sure this is the behaviour we want? Maybe 0 cloud be used to disable the timeout?","commit_id":"c76b04e3e44a9da869fbdf37eed047a62321b791"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"71d344530fdb7fb6ed8d38c1b383127d3b147922","unresolved":true,"context_lines":[{"line_number":87,"context_line":"    cfg.FloatOpt("},{"line_number":88,"context_line":"        \u0027timeout\u0027,"},{"line_number":89,"context_line":"        default\u003d60,"},{"line_number":90,"context_line":"        min\u003d0,"},{"line_number":91,"context_line":"        help\u003d\u0027Timeout value for http requests\u0027),"},{"line_number":92,"context_line":"]"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4001d228_6764bca3","line":90,"in_reply_to":"151289b3_5d3fc290","updated":"2026-02-09 14:34:40.000000000","message":"The requests library does not accept timeout\u003d0 and any request call fails with ValueError if the timeout is set to 0.\n\nWhile we can technically disable timeout for 0, I think it still exposes the \"infinite stuck\" problem potentially which we should not really encourage.","commit_id":"c76b04e3e44a9da869fbdf37eed047a62321b791"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"e815f1013512159bb9add4b5d1e43e460dbfb8a2","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    cfg.FloatOpt("},{"line_number":88,"context_line":"        \u0027timeout\u0027,"},{"line_number":89,"context_line":"        default\u003d60,"},{"line_number":90,"context_line":"        min\u003d0,"},{"line_number":91,"context_line":"        help\u003d\u0027Timeout value for http requests\u0027),"},{"line_number":92,"context_line":"]"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff68b39f_ca91648b","line":90,"in_reply_to":"4001d228_6764bca3","updated":"2026-02-09 14:44:14.000000000","message":"ok","commit_id":"c76b04e3e44a9da869fbdf37eed047a62321b791"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"080494838559781232f31a27b4d8a31753cd4a13","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    cfg.FloatOpt("},{"line_number":88,"context_line":"        \u0027timeout\u0027,"},{"line_number":89,"context_line":"        default\u003d60,"},{"line_number":90,"context_line":"        min\u003d0,"},{"line_number":91,"context_line":"        help\u003d\u0027Timeout value for http requests\u0027),"},{"line_number":92,"context_line":"]"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"27b97a55_5513c30b","line":90,"in_reply_to":"e94d99a6_33158f74","updated":"2026-03-09 15:32:04.000000000","message":"That might be an option, but the underling library accepts sub-1 values for timeout so I prefer exposing that full functionality directly.","commit_id":"c76b04e3e44a9da869fbdf37eed047a62321b791"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"f851d701a4ac6e7fc676b5ddaba583076d8f5003","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    cfg.FloatOpt("},{"line_number":88,"context_line":"        \u0027timeout\u0027,"},{"line_number":89,"context_line":"        default\u003d60,"},{"line_number":90,"context_line":"        min\u003d0,"},{"line_number":91,"context_line":"        help\u003d\u0027Timeout value for http requests\u0027),"},{"line_number":92,"context_line":"]"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e94d99a6_33158f74","line":90,"in_reply_to":"ff68b39f_ca91648b","updated":"2026-02-16 14:35:13.000000000","message":"What about defining the minimum as 1?","commit_id":"c76b04e3e44a9da869fbdf37eed047a62321b791"}]}