)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"3caa729e4afd405bb8bd366b4924ddb3107fe28f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"cpu and memory)"},{"line_number":12,"context_line":"* network metrics cannot be enabled while the vm is stopped"},{"line_number":13,"context_line":"* metrics cannot be collected for passthrough disks"},{"line_number":14,"context_line":"* some times, the metric counters are reset when the vms are rebooted."},{"line_number":15,"context_line":"We can\u0027t do much about this Hyper-V bug, which is unfortunately"},{"line_number":16,"context_line":"affecting the reliability of the collected data."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f79a3b5_bcb06ce1","line":14,"updated":"2018-10-31 14:07:27.000000000","message":"hm, this point was already mentioned in the 1st point. I think you might have wanted to make the distinction between an OS reboot and a hypervisor-caused reboot.","commit_id":"af42b9d59512fd00294c4db413280117bf1b79e3"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"f85764af7d701a665cbf062c99dcf335fcf7ab6b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"cpu and memory)"},{"line_number":12,"context_line":"* network metrics cannot be enabled while the vm is stopped"},{"line_number":13,"context_line":"* metrics cannot be collected for passthrough disks"},{"line_number":14,"context_line":"* some times, the metric counters are reset when the vms are rebooted."},{"line_number":15,"context_line":"We can\u0027t do much about this Hyper-V bug, which is unfortunately"},{"line_number":16,"context_line":"affecting the reliability of the collected data."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f79a3b5_9b733350","line":14,"in_reply_to":"3f79a3b5_bcb06ce1","updated":"2018-10-31 15:55:59.000000000","message":"Well, there are 2 things that can get reset: the \u0027option\u0027 to collect metrics as well as the actual counter values. Some times, when you re-enable the metric collection, the counter values are preserved.","commit_id":"af42b9d59512fd00294c4db413280117bf1b79e3"}],"compute_hyperv/nova/vif.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"3caa729e4afd405bb8bd366b4924ddb3107fe28f","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        # for OVS ports, we\u0027re doing it on the Nova side."},{"line_number":125,"context_line":"        vm_state \u003d self._vmutils.get_vm_state(instance_name)"},{"line_number":126,"context_line":"        if vm_state in [os_win_const.HYPERV_VM_STATE_ENABLED,"},{"line_number":127,"context_line":"                        os_win_const.HYPERV_VM_STATE_PAUSED]:"},{"line_number":128,"context_line":"            LOG.debug(\"Enabling instance port metrics. \""},{"line_number":129,"context_line":"                      \"Instance name: %(instance_name)s. \""},{"line_number":130,"context_line":"                      \"Port name: %(port_name)s.\","}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_1c2400c3","line":127,"updated":"2018-10-31 14:07:27.000000000","message":"what about suspended?","commit_id":"af42b9d59512fd00294c4db413280117bf1b79e3"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"f85764af7d701a665cbf062c99dcf335fcf7ab6b","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        # for OVS ports, we\u0027re doing it on the Nova side."},{"line_number":125,"context_line":"        vm_state \u003d self._vmutils.get_vm_state(instance_name)"},{"line_number":126,"context_line":"        if vm_state in [os_win_const.HYPERV_VM_STATE_ENABLED,"},{"line_number":127,"context_line":"                        os_win_const.HYPERV_VM_STATE_PAUSED]:"},{"line_number":128,"context_line":"            LOG.debug(\"Enabling instance port metrics. \""},{"line_number":129,"context_line":"                      \"Instance name: %(instance_name)s. \""},{"line_number":130,"context_line":"                      \"Port name: %(port_name)s.\","}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_bbaaaf6a","line":127,"in_reply_to":"3f79a3b5_1c2400c3","updated":"2018-10-31 15:55:59.000000000","message":"That\u0027s pretty much equivalent to \"stopped\" state in this case.","commit_id":"af42b9d59512fd00294c4db413280117bf1b79e3"}],"compute_hyperv/nova/vmops.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"3caa729e4afd405bb8bd366b4924ddb3107fe28f","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"        # mitigate at the Nova driver level."},{"line_number":1115,"context_line":"        self._metricsutils.enable_vm_metrics_collection(instance_name)"},{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"        # Network metrics are a handled separately. The reason is that the vm"},{"line_number":1118,"context_line":"        # must be running and the ports must be already attached in order to"},{"line_number":1119,"context_line":"        # be able to enable those metrics."},{"line_number":1120,"context_line":"        if enable_network_metrics:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_dc11a8b0","line":1117,"range":{"start_line":1117,"start_character":26,"end_line":1117,"end_character":32},"updated":"2018-10-31 14:07:27.000000000","message":"\"are\" instead of \"are a\"","commit_id":"af42b9d59512fd00294c4db413280117bf1b79e3"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"f85764af7d701a665cbf062c99dcf335fcf7ab6b","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"        # mitigate at the Nova driver level."},{"line_number":1115,"context_line":"        self._metricsutils.enable_vm_metrics_collection(instance_name)"},{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"        # Network metrics are a handled separately. The reason is that the vm"},{"line_number":1118,"context_line":"        # must be running and the ports must be already attached in order to"},{"line_number":1119,"context_line":"        # be able to enable those metrics."},{"line_number":1120,"context_line":"        if enable_network_metrics:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_3bbe9faf","line":1117,"range":{"start_line":1117,"start_character":26,"end_line":1117,"end_character":32},"in_reply_to":"3f79a3b5_dc11a8b0","updated":"2018-10-31 15:55:59.000000000","message":"Whops, thanks.","commit_id":"af42b9d59512fd00294c4db413280117bf1b79e3"}],"compute_hyperv/nova/volumeops.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"3caa729e4afd405bb8bd366b4924ddb3107fe28f","unresolved":false,"context_lines":[{"line_number":502,"context_line":""},{"line_number":503,"context_line":"        LOG.debug(\"Enabling disk metrics: %s.\", disk_path)"},{"line_number":504,"context_line":"        self._metricsutils.enable_disk_metrics_collection("},{"line_number":505,"context_line":"            disk_path, is_physical\u003dself._is_block_dev)"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"    def detach_volume(self, connection_info, instance_name):"},{"line_number":508,"context_line":"        if self._migrutils.planned_vm_exists(instance_name):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_dc5f6872","line":505,"updated":"2018-10-31 14:07:27.000000000","message":"so, is_physical will always be False. Why did we even add that parameter?","commit_id":"af42b9d59512fd00294c4db413280117bf1b79e3"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"f85764af7d701a665cbf062c99dcf335fcf7ab6b","unresolved":false,"context_lines":[{"line_number":502,"context_line":""},{"line_number":503,"context_line":"        LOG.debug(\"Enabling disk metrics: %s.\", disk_path)"},{"line_number":504,"context_line":"        self._metricsutils.enable_disk_metrics_collection("},{"line_number":505,"context_line":"            disk_path, is_physical\u003dself._is_block_dev)"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"    def detach_volume(self, connection_info, instance_name):"},{"line_number":508,"context_line":"        if self._migrutils.planned_vm_exists(instance_name):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_5bd03bf5","line":505,"in_reply_to":"3f79a3b5_dc5f6872","updated":"2018-10-31 15:55:59.000000000","message":"In case this limitation will ever be lifted, we can just update the code above. It\u0027s also making the code a bit easier to follow, IMO.","commit_id":"af42b9d59512fd00294c4db413280117bf1b79e3"}]}