)]}'
{"devstack/README.rst":[{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"fc47b0a163ec690cc2f73ac424cad2d16d5dc5bd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":" Enabling in Devstack"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"1. Download DevStack"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5aef4532_3b8ca534","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":21},"updated":"2016-03-09 03:22:07.000000000","message":"These instructions are already present in ROOT_DIR/README.rst,  we once had in this dir , but decided to move back to root_dir README. Reference: b939b96c00940f9d29a2c0ea594576df135740c6","commit_id":"a8388c54cb3625bc3e79fb0dcaeec58b8ba8b0dd"},{"author":{"_account_id":9285,"name":"Madhu Mohan","email":"mmnelemane@suse.com","username":"snmohan83"},"change_message_id":"5e2b6bcc928bc79998f44f03fb92d3deec386d8c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":" Enabling in Devstack"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"1. Download DevStack"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5aef4532_04c6a147","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":21},"in_reply_to":"5aef4532_3b8ca534","updated":"2016-03-09 08:21:17.000000000","message":"Thanks for the reference. Will remove this in next patch.","commit_id":"a8388c54cb3625bc3e79fb0dcaeec58b8ba8b0dd"}],"devstack/plugin.sh":[{"author":{"_account_id":11278,"name":"Anusha Ramineni","email":"anusha.ramineni@india.nec.com","username":"anusha08"},"change_message_id":"fc47b0a163ec690cc2f73ac424cad2d16d5dc5bd","unresolved":false,"context_lines":[{"line_number":162,"context_line":"}"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"# install_congress() - Collect source and prepare"},{"line_number":165,"context_line":"function install_congress {"},{"line_number":166,"context_line":"    # congress requires java so we install it here"},{"line_number":167,"context_line":"    install_package default-jre"},{"line_number":168,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5aef4532_5b06d1ce","line":165,"range":{"start_line":165,"start_character":9,"end_line":165,"end_character":25},"updated":"2016-03-09 03:22:07.000000000","message":"may be we can change name, as this function doesn\u0027t install congress anymore?","commit_id":"a8388c54cb3625bc3e79fb0dcaeec58b8ba8b0dd"},{"author":{"_account_id":9285,"name":"Madhu Mohan","email":"mmnelemane@suse.com","username":"snmohan83"},"change_message_id":"5e2b6bcc928bc79998f44f03fb92d3deec386d8c","unresolved":false,"context_lines":[{"line_number":162,"context_line":"}"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"# install_congress() - Collect source and prepare"},{"line_number":165,"context_line":"function install_congress {"},{"line_number":166,"context_line":"    # congress requires java so we install it here"},{"line_number":167,"context_line":"    install_package default-jre"},{"line_number":168,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5aef4532_c4f95982","line":165,"range":{"start_line":165,"start_character":9,"end_line":165,"end_character":25},"in_reply_to":"5aef4532_5b06d1ce","updated":"2016-03-09 08:21:17.000000000","message":"May be its better to have them in a single function \"install_congress\" instead of \"install_congressclient\" similar to few other plugins. Updated code in next patch.","commit_id":"a8388c54cb3625bc3e79fb0dcaeec58b8ba8b0dd"},{"author":{"_account_id":8215,"name":"Tim Hinrichs","email":"timothy.l.hinrichs@gmail.com","username":"thinrich"},"change_message_id":"7e73f344a54cca7ba8f52b467a3a1239a07356e7","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"# install_congress() - Collect source and prepare"},{"line_number":165,"context_line":"function install_congress {"},{"line_number":166,"context_line":"    git_clone $CONGRESS_REPO $CONGRESS_DIR $CONGRESS_BRANCH"},{"line_number":167,"context_line":"    # congress requires java so we install it here"},{"line_number":168,"context_line":"    install_package default-jre"},{"line_number":169,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5aef4532_f7118405","side":"PARENT","line":166,"range":{"start_line":166,"start_character":3,"end_line":166,"end_character":59},"updated":"2016-03-09 16:58:28.000000000","message":"Just a question.\n\nDo we not need to clone the Congress repo at all anymore? I take it this means devstack knows how to clone the server.\n\nIf devstack knows how to clone the server, doesn\u0027t it also know how to clone the client repo?  I think in our devstack script in gate, we tell it to pull the client from source.  \n\nJust double-checking that we want to clone the client but not the server.","commit_id":"e3c0813f9cf8d7fd071c7e084d4e42cf11c21f65"},{"author":{"_account_id":9285,"name":"Madhu Mohan","email":"mmnelemane@suse.com","username":"snmohan83"},"change_message_id":"23a4d71a1f6896d149fdc19d31c75b74b8d36cb2","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"# install_congress() - Collect source and prepare"},{"line_number":165,"context_line":"function install_congress {"},{"line_number":166,"context_line":"    git_clone $CONGRESS_REPO $CONGRESS_DIR $CONGRESS_BRANCH"},{"line_number":167,"context_line":"    # congress requires java so we install it here"},{"line_number":168,"context_line":"    install_package default-jre"},{"line_number":169,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5aef4532_7f01bd37","side":"PARENT","line":166,"range":{"start_line":166,"start_character":3,"end_line":166,"end_character":59},"in_reply_to":"5aef4532_f7118405","updated":"2016-03-09 20:36:32.000000000","message":"Looking at the lines around https://github.com/openstack-dev/devstack/blob/master/functions-common#L1737, It seems that the plugin functions only clone the server and client is cloned by referring to the stackrc entries like in https://github.com/openstack-dev/devstack/blob/master/stackrc#L286\n\nSo as of now (until the devstack plugin functions are improved) we need to retain the line to clone the client.","commit_id":"e3c0813f9cf8d7fd071c7e084d4e42cf11c21f65"}]}
