)]}'
{"doc/source/code-and-documentation/index.rst":[{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"98fcef2c3e540f48f29c4ee9c04fc1eb8fe827f4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"   /code-and-documentation/using-gerrit"},{"line_number":14,"context_line":"   /common/task-tracking"},{"line_number":15,"context_line":"   /common/i18n"},{"line_number":16,"context_line":"   "}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa0c359_650ab820","line":16,"updated":"2018-02-22 00:02:25.000000000","message":"whitespace minor if you need to reupload.","commit_id":"af035a0bf5b720eecdcb007e98698b7b18beac09"}],"doc/source/code-and-documentation/using-gerrit.rst":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"93f8f576493a6a83681d2bbf825dccc3eb2c3f75","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"To clone a copy of some repository::"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    git clone git.openstack.org/\u003cPROJECT_NAME\u003e"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"After you\u0027ve completed the Setup and Learn GIT section, the following command"},{"line_number":20,"context_line":"configures the repository to know about Gerrit and installs the ``Change-Id``"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa0c359_c4ba39e0","line":17,"updated":"2018-02-15 13:34:28.000000000","message":"This is wrong in two ways:\n\n* Depending on how you\u0027re defining \u003cPROJECT_NAME\u003e, just \u0027nova\u0027 won\u0027t work, you need \u0027openstack/nova\u0027\n* a protocol is needed (at least with a default git install), one of these:\n\ngit clone git://git.openstack.org/openstack/nova\ngit clone https://git.openstack.org/openstack/nova","commit_id":"2dd12463a03c5e8b2c4d5f27f0a855315f41f45c"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"61e8a5ec40e7a324bef0bac5bb0d64fa3e58639b","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"To clone a copy of some repository::"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    git clone git.openstack.org/\u003cPROJECT_NAME\u003e"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"After you\u0027ve completed the Setup and Learn GIT section, the following command"},{"line_number":20,"context_line":"configures the repository to know about Gerrit and installs the ``Change-Id``"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa0c359_6a292735","line":17,"in_reply_to":"3fa0c359_c4ba39e0","updated":"2018-02-21 23:21:34.000000000","message":"Done","commit_id":"2dd12463a03c5e8b2c4d5f27f0a855315f41f45c"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"93f8f576493a6a83681d2bbf825dccc3eb2c3f75","unresolved":false,"context_lines":[{"line_number":62,"context_line":"Tracking your Changes"},{"line_number":63,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"After proposing changes, you can track them at https://review.openstack.org. After logging in, you will see a dashboard of \"Outgoing reviews\" for changes you have proposed, \"Incoming reviews\" for changes you are reviewing, and \"Recently closed\" changes for which you were either a reviewer or owner."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa0c359_24c51d5c","line":65,"updated":"2018-02-15 13:34:28.000000000","message":"wrap","commit_id":"2dd12463a03c5e8b2c4d5f27f0a855315f41f45c"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"61e8a5ec40e7a324bef0bac5bb0d64fa3e58639b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"Tracking your Changes"},{"line_number":63,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"After proposing changes, you can track them at https://review.openstack.org. After logging in, you will see a dashboard of \"Outgoing reviews\" for changes you have proposed, \"Incoming reviews\" for changes you are reviewing, and \"Recently closed\" changes for which you were either a reviewer or owner."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa0c359_0ad0a31e","line":65,"in_reply_to":"3fa0c359_24c51d5c","updated":"2018-02-21 23:21:34.000000000","message":"Done","commit_id":"2dd12463a03c5e8b2c4d5f27f0a855315f41f45c"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"98fcef2c3e540f48f29c4ee9c04fc1eb8fe827f4","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"To clone a copy of some repository::"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    git clone https://git.openstack.org/openstack/\u003cPROJECT_NAME\u003e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"After you\u0027ve completed the Setup and Learn GIT section, the following command"},{"line_number":24,"context_line":"configures the repository to know about Gerrit and installs the ``Change-Id``"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa0c359_a52d2096","line":21,"updated":"2018-02-22 00:02:25.000000000","message":"Would it be useful to mention you can search for repositories using the search function here? http://git.openstack.org/cgit","commit_id":"af035a0bf5b720eecdcb007e98698b7b18beac09"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"2eea34c576f321590b760932aa9563fe370dac01","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"To clone a copy of some repository::"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    git clone https://git.openstack.org/openstack/\u003cPROJECT_NAME\u003e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"After you\u0027ve completed the Setup and Learn GIT section, the following command"},{"line_number":24,"context_line":"configures the repository to know about Gerrit and installs the ``Change-Id``"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff6b8bd7_7d0f2c2e","line":21,"in_reply_to":"3fa0c359_a52d2096","updated":"2018-03-06 20:25:23.000000000","message":"Done","commit_id":"af035a0bf5b720eecdcb007e98698b7b18beac09"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"98fcef2c3e540f48f29c4ee9c04fc1eb8fe827f4","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    git commit -a"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Read the `Summary of Git commit message structure \u003chttps://wiki.openstack.org/wiki/GitCommitMessages?%22Summary%20of%20Git%20commit%20message%20structure%22#Summary_of_Git_commit_message_structure\u003e`_"},{"line_number":47,"context_line":"for best practices on writing the commit message. When you are ready to send"},{"line_number":48,"context_line":"your changes for review use::"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa0c359_c5462c51","line":46,"updated":"2018-02-22 00:02:25.000000000","message":"Eventually, I think we can foster some of the best practices here so we can move more content off the wiki. What do you think?","commit_id":"af035a0bf5b720eecdcb007e98698b7b18beac09"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"2eea34c576f321590b760932aa9563fe370dac01","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    git commit -a"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Read the `Summary of Git commit message structure \u003chttps://wiki.openstack.org/wiki/GitCommitMessages?%22Summary%20of%20Git%20commit%20message%20structure%22#Summary_of_Git_commit_message_structure\u003e`_"},{"line_number":47,"context_line":"for best practices on writing the commit message. When you are ready to send"},{"line_number":48,"context_line":"your changes for review use::"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff6b8bd7_fd2c9c9a","line":46,"in_reply_to":"3fa0c359_c5462c51","updated":"2018-03-06 20:25:23.000000000","message":"I would agree. Especially since its a lot of information that hasn\u0027t changed in a long time.","commit_id":"af035a0bf5b720eecdcb007e98698b7b18beac09"},{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"2c27b5eec45984706d73abb301d5a0e099fd8f52","unresolved":false,"context_lines":[{"line_number":69,"context_line":"After proposing changes, you can track them at https://review.openstack.org. After logging"},{"line_number":70,"context_line":"in, you will see a dashboard of \"Outgoing reviews\" for changes you have proposed,"},{"line_number":71,"context_line":"\"Incoming reviews\" for changes you are reviewing, and \"Recently closed\" changes for which"},{"line_number":72,"context_line":"you were either a reviewer or owner."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa0c359_219b3d17","line":72,"updated":"2018-02-22 08:42:33.000000000","message":"Regarding the duplicate content we have the same problem with I18n guide. I think it would be a good idea to add a reference here like i18n.rst with link to https://docs.openstack.org/infra/manual/developers.html with additional information. That makes more clear we\u0027re talking about the same topic.","commit_id":"af035a0bf5b720eecdcb007e98698b7b18beac09"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"2eea34c576f321590b760932aa9563fe370dac01","unresolved":false,"context_lines":[{"line_number":69,"context_line":"After proposing changes, you can track them at https://review.openstack.org. After logging"},{"line_number":70,"context_line":"in, you will see a dashboard of \"Outgoing reviews\" for changes you have proposed,"},{"line_number":71,"context_line":"\"Incoming reviews\" for changes you are reviewing, and \"Recently closed\" changes for which"},{"line_number":72,"context_line":"you were either a reviewer or owner."}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff6b8bd7_7d664cf0","line":72,"in_reply_to":"3fa0c359_219b3d17","updated":"2018-03-06 20:25:23.000000000","message":"I would, ideally, like to start removing that info in favor of unifying on the contributor guide and the info there.","commit_id":"af035a0bf5b720eecdcb007e98698b7b18beac09"},{"author":{"_account_id":6088,"name":"Emmet Hikory","email":"persia@shipstone.jp","username":"persia"},"change_message_id":"86b6ea9cd1348463ff64b9f70d8d507c3a7a5ed4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"configures the repository to know about Gerrit and installs the ``Change-Id``"},{"line_number":29,"context_line":"commit hook. You only need to do this once per repository you clone::"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    git review -s"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"To create your development branch (substitute branch_name for a name of your"},{"line_number":34,"context_line":"choice). Its better to create a new branch for each patch than working from master::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff6b8bd7_bd9dc45a","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":17},"updated":"2018-03-06 20:42:44.000000000","message":"I believe I have never run this command, perhaps because it runs automatically if one runs `git review` without having set things up.","commit_id":"887e9df8cc5cdc6388fd4277070335a366a8baf2"},{"author":{"_account_id":6088,"name":"Emmet Hikory","email":"persia@shipstone.jp","username":"persia"},"change_message_id":"c5827efe7bab600237b1ce58c30209679d45e3dc","unresolved":false,"context_lines":[{"line_number":28,"context_line":"configures the repository to know about Gerrit and installs the ``Change-Id``"},{"line_number":29,"context_line":"commit hook. You only need to do this once per repository you clone::"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    git review -s"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"To create your development branch (substitute branch_name for a name of your"},{"line_number":34,"context_line":"choice). Its better to create a new branch for each patch than working from master::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df7087c5_73520d6a","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":17},"in_reply_to":"df7087c5_33c6d569","updated":"2018-03-07 19:36:18.000000000","message":"The only difference in our setups is that you run it in advance of changes and I run it later.  Works both ways.  My thought was that not instructing people to do it would reduce the number of steps in the guide, at the cost of the first review forcing the setup to be run at the time the review is pushed (which might be confusing because the behaviour of the first review differs from the behaviour of subsequent reviews).\n\nNote that instructing people to do it is definitely safe, and doing it is probably being responsible: I take advantage of the fact that it automatically runs when needed to reduce the number of things I have to remember or type.","commit_id":"887e9df8cc5cdc6388fd4277070335a366a8baf2"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"219a83e503bea18c1a68a8ec504ef96d0eed1ec3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"configures the repository to know about Gerrit and installs the ``Change-Id``"},{"line_number":29,"context_line":"commit hook. You only need to do this once per repository you clone::"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    git review -s"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"To create your development branch (substitute branch_name for a name of your"},{"line_number":34,"context_line":"choice). Its better to create a new branch for each patch than working from master::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df7087c5_33c6d569","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":17},"in_reply_to":"ff6b8bd7_bd9dc45a","updated":"2018-03-07 19:20:50.000000000","message":"I run it from every freshly cloned repo. It sets up the commit hook for doing changeID things. Maybe its a difference in our set ups?","commit_id":"887e9df8cc5cdc6388fd4277070335a366a8baf2"},{"author":{"_account_id":6088,"name":"Emmet Hikory","email":"persia@shipstone.jp","username":"persia"},"change_message_id":"86b6ea9cd1348463ff64b9f70d8d507c3a7a5ed4","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"To check the differences between your branch and the repository::"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    git diff"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Assuming you have not added new files, you commit all your changes using::"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff6b8bd7_5d7d881a","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":12},"updated":"2018-03-06 20:42:44.000000000","message":"This should probably be `git diff master`, as a bare `git diff` only shows the differences between the working directory and the staged environment (not even differences between working directory and last commit) which might be unexpected for folk who may have mixed this with another git usage guide on the internet.","commit_id":"887e9df8cc5cdc6388fd4277070335a366a8baf2"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"219a83e503bea18c1a68a8ec504ef96d0eed1ec3","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"To check the differences between your branch and the repository::"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    git diff"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Assuming you have not added new files, you commit all your changes using::"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"df7087c5_d3a0b9a8","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":12},"in_reply_to":"df7087c5_bb93a14f","updated":"2018-03-07 19:20:50.000000000","message":"Done","commit_id":"887e9df8cc5cdc6388fd4277070335a366a8baf2"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"911af231d0eb32a51ba28e4bccd2326d7bdc1d6b","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"To check the differences between your branch and the repository::"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    git diff"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Assuming you have not added new files, you commit all your changes using::"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"df7087c5_bb93a14f","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":12},"in_reply_to":"ff6b8bd7_5d7d881a","updated":"2018-03-07 16:12:57.000000000","message":"Yes I agree, that sentence should be reworded.","commit_id":"887e9df8cc5cdc6388fd4277070335a366a8baf2"},{"author":{"_account_id":6088,"name":"Emmet Hikory","email":"persia@shipstone.jp","username":"persia"},"change_message_id":"86b6ea9cd1348463ff64b9f70d8d507c3a7a5ed4","unresolved":false,"context_lines":[{"line_number":51,"context_line":"for best practices on writing the commit message. When you are ready to send"},{"line_number":52,"context_line":"your changes for review use::"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    git review"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"If successful, Git response message will contain a URL you can use to track your"},{"line_number":57,"context_line":"changes."}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff6b8bd7_fdbc9cbc","line":54,"range":{"start_line":54,"start_character":4,"end_line":54,"end_character":14},"updated":"2018-03-06 20:42:44.000000000","message":"It may be useful to advise folk to use `ssh-add` or similar at this point.  The alternative requires typing the SSH key passphrase multiple times (at least twice).","commit_id":"887e9df8cc5cdc6388fd4277070335a366a8baf2"},{"author":{"_account_id":6088,"name":"Emmet Hikory","email":"persia@shipstone.jp","username":"persia"},"change_message_id":"c5827efe7bab600237b1ce58c30209679d45e3dc","unresolved":false,"context_lines":[{"line_number":51,"context_line":"for best practices on writing the commit message. When you are ready to send"},{"line_number":52,"context_line":"your changes for review use::"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    git review"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"If successful, Git response message will contain a URL you can use to track your"},{"line_number":57,"context_line":"changes."}],"source_content_type":"text/x-rst","patch_set":4,"id":"df7087c5_b3ee6586","line":54,"range":{"start_line":54,"start_character":4,"end_line":54,"end_character":14},"in_reply_to":"df7087c5_7391ad52","updated":"2018-03-07 19:36:18.000000000","message":"To me, \"every time\" implies that I won\u0027t need to do it again.  Maybe because of the lack of setup discussed previously, but for me it requires two ssh authentications to submit a review, so this lets me type it once instead of twice.  git-review seems to behave oddly if only one of the two authentications works.  At least for me, ssh-add only lasts for a while, so entering it before any `git review` call is part of my workflow: with prior environments, I had ssh authentication caching set up to work for a day or longer, making this a less frequent event.","commit_id":"887e9df8cc5cdc6388fd4277070335a366a8baf2"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"219a83e503bea18c1a68a8ec504ef96d0eed1ec3","unresolved":false,"context_lines":[{"line_number":51,"context_line":"for best practices on writing the commit message. When you are ready to send"},{"line_number":52,"context_line":"your changes for review use::"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    git review"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"If successful, Git response message will contain a URL you can use to track your"},{"line_number":57,"context_line":"changes."}],"source_content_type":"text/x-rst","patch_set":4,"id":"df7087c5_7391ad52","line":54,"range":{"start_line":54,"start_character":4,"end_line":54,"end_character":14},"in_reply_to":"ff6b8bd7_fdbc9cbc","updated":"2018-03-07 19:20:50.000000000","message":"Was trying to keep it to a minimum of commands, but I can add that as a step if you\u0027d like. Something like: \n\n\"ssh-add\n\nEnter your password when prompted to avoid having to do it every time you push a patch for review.\n\ngit-review\n\n.....\" ?","commit_id":"887e9df8cc5cdc6388fd4277070335a366a8baf2"}]}