)]}'
{"doc/source/code-and-documentation/using-gerrit.rst":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"5d2d6a5dad93114675d0e2ceca21cd2f6c4c790f","unresolved":false,"context_lines":[{"line_number":83,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Reviewing changes is often suggested as a way to get started on a"},{"line_number":86,"context_line":"project, whether this is how you choose to get started or not, its"},{"line_number":87,"context_line":"an important community activity."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"**Inline Comments**"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_5907ed19","line":86,"range":{"start_line":86,"start_character":7,"end_line":86,"end_character":10},"updated":"2018-04-05 11:35:24.000000000","message":". W","commit_id":"aff508c566f39d5737a24b32f133fd74cd2b5dbb"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"5d2d6a5dad93114675d0e2ceca21cd2f6c4c790f","unresolved":false,"context_lines":[{"line_number":83,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Reviewing changes is often suggested as a way to get started on a"},{"line_number":86,"context_line":"project, whether this is how you choose to get started or not, its"},{"line_number":87,"context_line":"an important community activity."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"**Inline Comments**"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_9926e5ba","line":86,"range":{"start_line":86,"start_character":63,"end_line":86,"end_character":66},"updated":"2018-04-05 11:35:24.000000000","message":"it\u0027s","commit_id":"aff508c566f39d5737a24b32f133fd74cd2b5dbb"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"c672b4dd23fbdd15b8e20f486b18634748526c72","unresolved":false,"context_lines":[{"line_number":83,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Reviewing changes is often suggested as a way to get started on a"},{"line_number":86,"context_line":"project, whether this is how you choose to get started or not, its"},{"line_number":87,"context_line":"an important community activity."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"**Inline Comments**"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_daae8197","line":86,"range":{"start_line":86,"start_character":7,"end_line":86,"end_character":10},"in_reply_to":"bf659307_5907ed19","updated":"2018-04-05 23:18:12.000000000","message":"Done","commit_id":"aff508c566f39d5737a24b32f133fd74cd2b5dbb"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"c672b4dd23fbdd15b8e20f486b18634748526c72","unresolved":false,"context_lines":[{"line_number":83,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Reviewing changes is often suggested as a way to get started on a"},{"line_number":86,"context_line":"project, whether this is how you choose to get started or not, its"},{"line_number":87,"context_line":"an important community activity."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"**Inline Comments**"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_7a93b55d","line":86,"range":{"start_line":86,"start_character":63,"end_line":86,"end_character":66},"in_reply_to":"bf659307_9926e5ba","updated":"2018-04-05 23:18:12.000000000","message":"Done","commit_id":"aff508c566f39d5737a24b32f133fd74cd2b5dbb"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"5d2d6a5dad93114675d0e2ceca21cd2f6c4c790f","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"If you have questions about the way something is phrased or done,"},{"line_number":92,"context_line":"or have found some other issue the easiest way to let the author"},{"line_number":93,"context_line":"of the patch know is to comment on that place inline. When decide"},{"line_number":94,"context_line":"on your vote for the patchset, the comments will be posted"},{"line_number":95,"context_line":"simultaneously."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"**+/- 1 \u0026 0**"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_795af12a","line":94,"range":{"start_line":93,"start_character":54,"end_line":94,"end_character":29},"updated":"2018-04-05 11:35:24.000000000","message":"This doesn\u0027t quite make sense, and not entirely sure what you\u0027re trying to say, so can\u0027t offer a suggestion.","commit_id":"aff508c566f39d5737a24b32f133fd74cd2b5dbb"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"c672b4dd23fbdd15b8e20f486b18634748526c72","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"If you have questions about the way something is phrased or done,"},{"line_number":92,"context_line":"or have found some other issue the easiest way to let the author"},{"line_number":93,"context_line":"of the patch know is to comment on that place inline. When decide"},{"line_number":94,"context_line":"on your vote for the patchset, the comments will be posted"},{"line_number":95,"context_line":"simultaneously."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"**+/- 1 \u0026 0**"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_1a1879d1","line":94,"range":{"start_line":93,"start_character":54,"end_line":94,"end_character":29},"in_reply_to":"bf659307_1923b5c0","updated":"2018-04-05 23:18:12.000000000","message":"Done","commit_id":"aff508c566f39d5737a24b32f133fd74cd2b5dbb"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"c672b4dd23fbdd15b8e20f486b18634748526c72","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"If you have questions about the way something is phrased or done,"},{"line_number":92,"context_line":"or have found some other issue the easiest way to let the author"},{"line_number":93,"context_line":"of the patch know is to comment on that place inline. When decide"},{"line_number":94,"context_line":"on your vote for the patchset, the comments will be posted"},{"line_number":95,"context_line":"simultaneously."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"**+/- 1 \u0026 0**"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_3a20ddf7","line":94,"range":{"start_line":93,"start_character":54,"end_line":94,"end_character":29},"in_reply_to":"bf659307_795af12a","updated":"2018-04-05 23:18:12.000000000","message":"I must have gotten distracted mid sentence or stopped and started or something. Lol.","commit_id":"aff508c566f39d5737a24b32f133fd74cd2b5dbb"},{"author":{"_account_id":21723,"name":"Gergely Csatari","email":"gergely.csatari@nokia.com","username":"csatari"},"change_message_id":"8026e429ba8bcdbdec7cc054e34c8cdee787a968","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"If you have questions about the way something is phrased or done,"},{"line_number":92,"context_line":"or have found some other issue the easiest way to let the author"},{"line_number":93,"context_line":"of the patch know is to comment on that place inline. When decide"},{"line_number":94,"context_line":"on your vote for the patchset, the comments will be posted"},{"line_number":95,"context_line":"simultaneously."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"**+/- 1 \u0026 0**"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_1923b5c0","line":94,"range":{"start_line":93,"start_character":54,"end_line":94,"end_character":29},"in_reply_to":"bf659307_795af12a","updated":"2018-04-05 12:16:36.000000000","message":"Maybe \"The inline comments are posted when you hit the Reply and add your vote on the patchset.\" ?","commit_id":"aff508c566f39d5737a24b32f133fd74cd2b5dbb"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"4c614c8a4137f803bb402d4b23dde267c92e8a27","unresolved":false,"context_lines":[{"line_number":91,"context_line":"If you have questions about the way something is phrased or done,"},{"line_number":92,"context_line":"or have found some other issue the easiest way to let the author"},{"line_number":93,"context_line":"of the patch know is to comment on that place inline. The inline"},{"line_number":94,"context_line":"comments are posted collectively when you hit the Reply and add"},{"line_number":95,"context_line":"your vote on the patchset."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"**+/- 1 \u0026 0**"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_fc422cab","line":94,"range":{"start_line":94,"start_character":46,"end_line":94,"end_character":55},"updated":"2018-04-09 17:08:59.000000000","message":"Either \u0027hit Reply\u0027 or \u0027hit the Reply button\u0027.","commit_id":"4a523ca25a620e4db3f8370b7939b5df7eb3019f"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"a733612c8e06eafe926e19afa2b31d67dcaefc5c","unresolved":false,"context_lines":[{"line_number":91,"context_line":"If you have questions about the way something is phrased or done,"},{"line_number":92,"context_line":"or have found some other issue the easiest way to let the author"},{"line_number":93,"context_line":"of the patch know is to comment on that place inline. The inline"},{"line_number":94,"context_line":"comments are posted collectively when you hit the Reply and add"},{"line_number":95,"context_line":"your vote on the patchset."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"**+/- 1 \u0026 0**"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_72e963b5","line":94,"range":{"start_line":94,"start_character":46,"end_line":94,"end_character":55},"in_reply_to":"bf659307_fc422cab","updated":"2018-04-09 18:06:07.000000000","message":"Done","commit_id":"4a523ca25a620e4db3f8370b7939b5df7eb3019f"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"4c614c8a4137f803bb402d4b23dde267c92e8a27","unresolved":false,"context_lines":[{"line_number":97,"context_line":"**+/- 1 \u0026 0**"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"The basic set of values contributors have to vote with on a patch"},{"line_number":100,"context_line":"are -1, 0, or +1. These values correspond to a relatively simple"},{"line_number":101,"context_line":"system."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"-1: This patch needs further work before it can be merged. A -1 is"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_7c105ca9","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":3},"updated":"2018-04-09 17:08:59.000000000","message":"is:","commit_id":"4a523ca25a620e4db3f8370b7939b5df7eb3019f"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"a733612c8e06eafe926e19afa2b31d67dcaefc5c","unresolved":false,"context_lines":[{"line_number":97,"context_line":"**+/- 1 \u0026 0**"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"The basic set of values contributors have to vote with on a patch"},{"line_number":100,"context_line":"are -1, 0, or +1. These values correspond to a relatively simple"},{"line_number":101,"context_line":"system."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"-1: This patch needs further work before it can be merged. A -1 is"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_7202c371","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":3},"in_reply_to":"bf659307_7c105ca9","updated":"2018-04-09 18:06:07.000000000","message":"Done","commit_id":"4a523ca25a620e4db3f8370b7939b5df7eb3019f"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"4c614c8a4137f803bb402d4b23dde267c92e8a27","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"**+/- 2 \u0026 +W**"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Core approvers have extra voting choices aside from the basic set."},{"line_number":126,"context_line":"Like the basic set, the numbers map to a simple system of meaning"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"-2: Do not merge. This could be for any number of reasons, most often,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_dc75e8fb","line":125,"range":{"start_line":125,"start_character":20,"end_line":125,"end_character":25},"updated":"2018-04-09 17:08:59.000000000","message":"I would say additional.","commit_id":"4a523ca25a620e4db3f8370b7939b5df7eb3019f"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"4c614c8a4137f803bb402d4b23dde267c92e8a27","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"**+/- 2 \u0026 +W**"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Core approvers have extra voting choices aside from the basic set."},{"line_number":126,"context_line":"Like the basic set, the numbers map to a simple system of meaning"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"-2: Do not merge. This could be for any number of reasons, most often,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_cf6c4c9e","line":125,"range":{"start_line":125,"start_character":5,"end_line":125,"end_character":14},"updated":"2018-04-09 17:08:59.000000000","message":"reviewers?","commit_id":"4a523ca25a620e4db3f8370b7939b5df7eb3019f"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"a733612c8e06eafe926e19afa2b31d67dcaefc5c","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"**+/- 2 \u0026 +W**"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Core approvers have extra voting choices aside from the basic set."},{"line_number":126,"context_line":"Like the basic set, the numbers map to a simple system of meaning"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"-2: Do not merge. This could be for any number of reasons, most often,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_b2161ba7","line":125,"range":{"start_line":125,"start_character":5,"end_line":125,"end_character":14},"in_reply_to":"bf659307_cf6c4c9e","updated":"2018-04-09 18:06:07.000000000","message":"Done","commit_id":"4a523ca25a620e4db3f8370b7939b5df7eb3019f"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"a733612c8e06eafe926e19afa2b31d67dcaefc5c","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"**+/- 2 \u0026 +W**"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Core approvers have extra voting choices aside from the basic set."},{"line_number":126,"context_line":"Like the basic set, the numbers map to a simple system of meaning"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"-2: Do not merge. This could be for any number of reasons, most often,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_3239ab3e","line":125,"range":{"start_line":125,"start_character":20,"end_line":125,"end_character":25},"in_reply_to":"bf659307_dc75e8fb","updated":"2018-04-09 18:06:07.000000000","message":"Done","commit_id":"4a523ca25a620e4db3f8370b7939b5df7eb3019f"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"4c614c8a4137f803bb402d4b23dde267c92e8a27","unresolved":false,"context_lines":[{"line_number":123,"context_line":"**+/- 2 \u0026 +W**"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Core approvers have extra voting choices aside from the basic set."},{"line_number":126,"context_line":"Like the basic set, the numbers map to a simple system of meaning"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"-2: Do not merge. This could be for any number of reasons, most often,"},{"line_number":129,"context_line":"some deadline has passed and since no more changes are being accepted"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_1c55a050","line":126,"range":{"start_line":126,"start_character":58,"end_line":126,"end_character":65},"updated":"2018-04-09 17:08:59.000000000","message":"\u0027.\u0027 or \u0027:\u0027 to the end of the sentence?","commit_id":"4a523ca25a620e4db3f8370b7939b5df7eb3019f"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"a733612c8e06eafe926e19afa2b31d67dcaefc5c","unresolved":false,"context_lines":[{"line_number":123,"context_line":"**+/- 2 \u0026 +W**"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Core approvers have extra voting choices aside from the basic set."},{"line_number":126,"context_line":"Like the basic set, the numbers map to a simple system of meaning"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"-2: Do not merge. This could be for any number of reasons, most often,"},{"line_number":129,"context_line":"some deadline has passed and since no more changes are being accepted"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_721083a9","line":126,"range":{"start_line":126,"start_character":58,"end_line":126,"end_character":65},"in_reply_to":"bf659307_1c55a050","updated":"2018-04-09 18:06:07.000000000","message":"Done","commit_id":"4a523ca25a620e4db3f8370b7939b5df7eb3019f"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"4c614c8a4137f803bb402d4b23dde267c92e8a27","unresolved":false,"context_lines":[{"line_number":125,"context_line":"Core approvers have extra voting choices aside from the basic set."},{"line_number":126,"context_line":"Like the basic set, the numbers map to a simple system of meaning"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"-2: Do not merge. This could be for any number of reasons, most often,"},{"line_number":129,"context_line":"some deadline has passed and since no more changes are being accepted"},{"line_number":130,"context_line":"till the new release development begins, the patch is being held."},{"line_number":131,"context_line":"A -2 could also mean that there is an issue with the approach"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_4f0efce5","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":17},"updated":"2018-04-09 17:08:59.000000000","message":"I would add a list here so it\u0027s easier to read through.","commit_id":"4a523ca25a620e4db3f8370b7939b5df7eb3019f"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"4c614c8a4137f803bb402d4b23dde267c92e8a27","unresolved":false,"context_lines":[{"line_number":125,"context_line":"Core approvers have extra voting choices aside from the basic set."},{"line_number":126,"context_line":"Like the basic set, the numbers map to a simple system of meaning"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"-2: Do not merge. This could be for any number of reasons, most often,"},{"line_number":129,"context_line":"some deadline has passed and since no more changes are being accepted"},{"line_number":130,"context_line":"till the new release development begins, the patch is being held."},{"line_number":131,"context_line":"A -2 could also mean that there is an issue with the approach"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_efea70d6","line":128,"range":{"start_line":128,"start_character":18,"end_line":128,"end_character":57},"updated":"2018-04-09 17:08:59.000000000","message":"It suggests a little that this happens often for various reasons.\n\nI would say something like this:\n\nThis score does not appear often and when it does it has a good reason behind, most often one of the following:","commit_id":"4a523ca25a620e4db3f8370b7939b5df7eb3019f"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"a733612c8e06eafe926e19afa2b31d67dcaefc5c","unresolved":false,"context_lines":[{"line_number":125,"context_line":"Core approvers have extra voting choices aside from the basic set."},{"line_number":126,"context_line":"Like the basic set, the numbers map to a simple system of meaning"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"-2: Do not merge. This could be for any number of reasons, most often,"},{"line_number":129,"context_line":"some deadline has passed and since no more changes are being accepted"},{"line_number":130,"context_line":"till the new release development begins, the patch is being held."},{"line_number":131,"context_line":"A -2 could also mean that there is an issue with the approach"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_d2e38fa3","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":17},"in_reply_to":"bf659307_4f0efce5","updated":"2018-04-09 18:06:07.000000000","message":"Done","commit_id":"4a523ca25a620e4db3f8370b7939b5df7eb3019f"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"a733612c8e06eafe926e19afa2b31d67dcaefc5c","unresolved":false,"context_lines":[{"line_number":125,"context_line":"Core approvers have extra voting choices aside from the basic set."},{"line_number":126,"context_line":"Like the basic set, the numbers map to a simple system of meaning"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"-2: Do not merge. This could be for any number of reasons, most often,"},{"line_number":129,"context_line":"some deadline has passed and since no more changes are being accepted"},{"line_number":130,"context_line":"till the new release development begins, the patch is being held."},{"line_number":131,"context_line":"A -2 could also mean that there is an issue with the approach"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_f2ded3d8","line":128,"range":{"start_line":128,"start_character":18,"end_line":128,"end_character":57},"in_reply_to":"bf659307_efea70d6","updated":"2018-04-09 18:06:07.000000000","message":"Done","commit_id":"4a523ca25a620e4db3f8370b7939b5df7eb3019f"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"4c614c8a4137f803bb402d4b23dde267c92e8a27","unresolved":false,"context_lines":[{"line_number":131,"context_line":"A -2 could also mean that there is an issue with the approach"},{"line_number":132,"context_line":"taken in the patch and it needs to be discussed with a larger group,"},{"line_number":133,"context_line":"likely in a meeting. The last common case is that the patch submitted"},{"line_number":134,"context_line":"is a duplicate or at odds with another patch submitted. Only the person"},{"line_number":135,"context_line":"that voted the -2 can remove the vote and it will persist"},{"line_number":136,"context_line":"on all new patchsets."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"+2: Looks good to me (core reviewer). Depending on the project team and"},{"line_number":139,"context_line":"repository, merging a patch will require at least one +2 vote if not"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_cfc8cc75","line":136,"range":{"start_line":134,"start_character":56,"end_line":136,"end_character":21},"updated":"2018-04-09 17:08:59.000000000","message":"I would put this into a note.","commit_id":"4a523ca25a620e4db3f8370b7939b5df7eb3019f"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"a733612c8e06eafe926e19afa2b31d67dcaefc5c","unresolved":false,"context_lines":[{"line_number":131,"context_line":"A -2 could also mean that there is an issue with the approach"},{"line_number":132,"context_line":"taken in the patch and it needs to be discussed with a larger group,"},{"line_number":133,"context_line":"likely in a meeting. The last common case is that the patch submitted"},{"line_number":134,"context_line":"is a duplicate or at odds with another patch submitted. Only the person"},{"line_number":135,"context_line":"that voted the -2 can remove the vote and it will persist"},{"line_number":136,"context_line":"on all new patchsets."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"+2: Looks good to me (core reviewer). Depending on the project team and"},{"line_number":139,"context_line":"repository, merging a patch will require at least one +2 vote if not"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf659307_92ef5786","line":136,"range":{"start_line":134,"start_character":56,"end_line":136,"end_character":21},"in_reply_to":"bf659307_cfc8cc75","updated":"2018-04-09 18:06:07.000000000","message":"Done","commit_id":"4a523ca25a620e4db3f8370b7939b5df7eb3019f"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"65d4571ce56b6bf5118598ed1bc6a53d42faaae8","unresolved":false,"context_lines":[{"line_number":125,"context_line":"Core reviewers have additional voting choices aside from the basic set."},{"line_number":126,"context_line":"Like the basic set, the numbers map to a simple system of meaning:"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"-2: Do not merge. This score does not often appear and whit it does,"},{"line_number":129,"context_line":"it\u0027s for a good reason:"},{"line_number":130,"context_line":"* Most often, some deadline has passed and since no more changes are"},{"line_number":131,"context_line":"being accepted till the new release development begins, the patch"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf659307_48090093","line":128,"range":{"start_line":128,"start_character":55,"end_line":128,"end_character":59},"updated":"2018-04-10 10:59:44.000000000","message":"when?","commit_id":"da6a0e5aaf17e4e0680e393eb745100a45a9c8ab"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"3c0d17f989ffa46e1e4dc6d74641962a4a70b2b6","unresolved":false,"context_lines":[{"line_number":125,"context_line":"Core reviewers have additional voting choices aside from the basic set."},{"line_number":126,"context_line":"Like the basic set, the numbers map to a simple system of meaning:"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"-2: Do not merge. This score does not often appear and whit it does,"},{"line_number":129,"context_line":"it\u0027s for a good reason:"},{"line_number":130,"context_line":"* Most often, some deadline has passed and since no more changes are"},{"line_number":131,"context_line":"being accepted till the new release development begins, the patch"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf659307_c4116d06","line":128,"range":{"start_line":128,"start_character":55,"end_line":128,"end_character":59},"in_reply_to":"bf659307_48090093","updated":"2018-04-10 20:04:28.000000000","message":"Done","commit_id":"da6a0e5aaf17e4e0680e393eb745100a45a9c8ab"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"65d4571ce56b6bf5118598ed1bc6a53d42faaae8","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"-2: Do not merge. This score does not often appear and whit it does,"},{"line_number":129,"context_line":"it\u0027s for a good reason:"},{"line_number":130,"context_line":"* Most often, some deadline has passed and since no more changes are"},{"line_number":131,"context_line":"being accepted till the new release development begins, the patch"},{"line_number":132,"context_line":"is being held."},{"line_number":133,"context_line":"* There is an issue with the approach taken in the patch and it needs"},{"line_number":134,"context_line":"to be discussed with a larger group, likely in a meeting."},{"line_number":135,"context_line":"* The patch submitted is a duplicate or at odds with another patch"},{"line_number":136,"context_line":"submitted."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":".. note::"},{"line_number":139,"context_line":"   Only the person that voted the -2 can remove the vote and it will persist"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf659307_88d5d8e7","line":136,"range":{"start_line":130,"start_character":0,"end_line":136,"end_character":10},"updated":"2018-04-10 10:59:44.000000000","message":"You need to put back the indentation and you also need an empty line between the previous text and the list.","commit_id":"da6a0e5aaf17e4e0680e393eb745100a45a9c8ab"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"3c0d17f989ffa46e1e4dc6d74641962a4a70b2b6","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"-2: Do not merge. This score does not often appear and whit it does,"},{"line_number":129,"context_line":"it\u0027s for a good reason:"},{"line_number":130,"context_line":"* Most often, some deadline has passed and since no more changes are"},{"line_number":131,"context_line":"being accepted till the new release development begins, the patch"},{"line_number":132,"context_line":"is being held."},{"line_number":133,"context_line":"* There is an issue with the approach taken in the patch and it needs"},{"line_number":134,"context_line":"to be discussed with a larger group, likely in a meeting."},{"line_number":135,"context_line":"* The patch submitted is a duplicate or at odds with another patch"},{"line_number":136,"context_line":"submitted."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":".. note::"},{"line_number":139,"context_line":"   Only the person that voted the -2 can remove the vote and it will persist"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bf659307_a40eb9e2","line":136,"range":{"start_line":130,"start_character":0,"end_line":136,"end_character":10},"in_reply_to":"bf659307_88d5d8e7","updated":"2018-04-10 20:04:28.000000000","message":"Done","commit_id":"da6a0e5aaf17e4e0680e393eb745100a45a9c8ab"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"65626070f5f383218bc72f5289d2b81c39fce833","unresolved":false,"context_lines":[{"line_number":128,"context_line":"-2: Do not merge. This score does not often appear and when it does,"},{"line_number":129,"context_line":"it\u0027s for a good reason:"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  * Most often, some deadline has passed and since no more changes are"},{"line_number":132,"context_line":"    being accepted till the new release development begins, the patch"},{"line_number":133,"context_line":"    is being held."},{"line_number":134,"context_line":"  * There is an issue with the approach taken in the patch and it needs"},{"line_number":135,"context_line":"    to be discussed with a larger group, likely in a meeting."},{"line_number":136,"context_line":"  * The patch submitted is a duplicate or at odds with another patch"},{"line_number":137,"context_line":"    submitted."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":".. note::"},{"line_number":140,"context_line":"   Only the person that voted the -2 can remove the vote and it will persist"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf659307_848375a9","line":137,"range":{"start_line":131,"start_character":0,"end_line":137,"end_character":14},"updated":"2018-04-10 20:25:51.000000000","message":"Sorry, I realized I wasn\u0027t clear on what I meant with the indentation. So you don\u0027t need to indent the bullets, only the additional lines. So basically delete two whitespaces from the beginning of all lines in the list and then Sphinx will not generate the grey line in front of it in the rendered version. :)","commit_id":"0e61d348c4ccfc265e09c406f8e389cf61429d4e"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"45e0a5c1ab9b724485ab30efb0188df9e6c6fae7","unresolved":false,"context_lines":[{"line_number":128,"context_line":"-2: Do not merge. This score does not often appear and when it does,"},{"line_number":129,"context_line":"it\u0027s for a good reason:"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  * Most often, some deadline has passed and since no more changes are"},{"line_number":132,"context_line":"    being accepted till the new release development begins, the patch"},{"line_number":133,"context_line":"    is being held."},{"line_number":134,"context_line":"  * There is an issue with the approach taken in the patch and it needs"},{"line_number":135,"context_line":"    to be discussed with a larger group, likely in a meeting."},{"line_number":136,"context_line":"  * The patch submitted is a duplicate or at odds with another patch"},{"line_number":137,"context_line":"    submitted."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":".. note::"},{"line_number":140,"context_line":"   Only the person that voted the -2 can remove the vote and it will persist"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf659307_98cc1136","line":137,"range":{"start_line":131,"start_character":0,"end_line":137,"end_character":14},"in_reply_to":"bf659307_848375a9","updated":"2018-04-12 00:19:34.000000000","message":"Done!","commit_id":"0e61d348c4ccfc265e09c406f8e389cf61429d4e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c271ba145b48b8dc82815a165266ba1d2bd3389f","unresolved":false,"context_lines":[{"line_number":93,"context_line":"of the patch know is to comment on that place inline. The inline"},{"line_number":94,"context_line":"comments are posted collectively when you hit the \u0027Reply\u0027 button"},{"line_number":95,"context_line":"and add your vote on the patchset."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"**+/- 1 \u0026 0**"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"The basic set of values contributors have to vote with on a patch"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bf659307_be9a1d6c","line":96,"range":{"start_line":96,"start_character":0,"end_line":96,"end_character":0},"updated":"2018-04-12 01:45:58.000000000","message":"good to add a NOTE here about \n-Review comments stay as draft state and not visible to anyone till you hit \u0027Reply\u0027 button\". This is common mistake where people forgot to post their comments and late found that comments still in draft state.","commit_id":"4c8535f49d404dde2c54db5a12a3fac8f8448b02"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"c34fd1f4d7d6460b88ee7c05089442164396cdd0","unresolved":false,"context_lines":[{"line_number":93,"context_line":"of the patch know is to comment on that place inline. The inline"},{"line_number":94,"context_line":"comments are posted collectively when you hit the \u0027Reply\u0027 button"},{"line_number":95,"context_line":"and add your vote on the patchset."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"**+/- 1 \u0026 0**"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"The basic set of values contributors have to vote with on a patch"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bf659307_b3cc7a89","line":96,"range":{"start_line":96,"start_character":0,"end_line":96,"end_character":0},"in_reply_to":"bf659307_be9a1d6c","updated":"2018-04-12 19:53:22.000000000","message":"Done","commit_id":"4c8535f49d404dde2c54db5a12a3fac8f8448b02"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c271ba145b48b8dc82815a165266ba1d2bd3389f","unresolved":false,"context_lines":[{"line_number":117,"context_line":"the patchset or doesn\u0027t have a fully formed opinion of the patchset"},{"line_number":118,"context_line":"yet- it requires more time, testing, or investigation."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"+1: Looks good to me, but someone else must approve."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"**+/- 2 \u0026 +W**"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bf659307_7e8fa522","line":120,"range":{"start_line":120,"start_character":51,"end_line":120,"end_character":52},"updated":"2018-04-12 01:45:58.000000000","message":"you can mention here that even you are +1 but you can still add comments for nits or some more optimization can be done but those are not blocking. And good to fix later as follow up patch etc.","commit_id":"4c8535f49d404dde2c54db5a12a3fac8f8448b02"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"c34fd1f4d7d6460b88ee7c05089442164396cdd0","unresolved":false,"context_lines":[{"line_number":117,"context_line":"the patchset or doesn\u0027t have a fully formed opinion of the patchset"},{"line_number":118,"context_line":"yet- it requires more time, testing, or investigation."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"+1: Looks good to me, but someone else must approve."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"**+/- 2 \u0026 +W**"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bf659307_73c26255","line":120,"range":{"start_line":120,"start_character":51,"end_line":120,"end_character":52},"in_reply_to":"bf659307_7e8fa522","updated":"2018-04-12 19:53:22.000000000","message":"Done","commit_id":"4c8535f49d404dde2c54db5a12a3fac8f8448b02"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"ba3579d1ec0fcbd1b90d16878ee40b76b3722e8b","unresolved":false,"context_lines":[{"line_number":125,"context_line":"mean that there is nothing to comment on, just that there aren\u0027t"},{"line_number":126,"context_line":"any issues that would block the merging of the patch. You can still"},{"line_number":127,"context_line":"make comments on nitpicky things the patch owner can address if"},{"line_number":128,"context_line":"others find issue with the patch. These comments might also be"},{"line_number":129,"context_line":"something to address in a followup patch as opposed to another"},{"line_number":130,"context_line":"patchset."},{"line_number":131,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"bf659307_c40fe62b","line":128,"range":{"start_line":128,"start_character":12,"end_line":128,"end_character":17},"updated":"2018-04-12 21:23:05.000000000","message":"an issue or issues","commit_id":"61915b79b759d157b2807cd446d95e81f59ad6e0"}]}