)]}'
{"doc/source/code-and-documentation/review-the-openstack-way.rst":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"821f6dfbd35aa73e56d308b5340f7335c93e86d6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The +2 vote is only available to core reviewers. In general, two +2 votes are"},{"line_number":25,"context_line":"required before a patch can be merged, although some projects relax the"},{"line_number":26,"context_line":"requirements in certain circumstances, such as trivial changes. Confusingly,"},{"line_number":27,"context_line":"two +1s do not equal a +2!"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_c0cb611b","line":25,"updated":"2018-06-12 05:54:31.000000000","message":"patch -\u003e change everywhere to follow the wordings that gerrit uses.","commit_id":"e327af6bbc0839829408101d13e86b93cf62eb4d"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"6e571d3525bacfd1866fd3768a336fd420632f09","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The +2 vote is only available to core reviewers. In general, two +2 votes are"},{"line_number":25,"context_line":"required before a patch can be merged, although some projects relax the"},{"line_number":26,"context_line":"requirements in certain circumstances, such as trivial changes. Confusingly,"},{"line_number":27,"context_line":"two +1s do not equal a +2!"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_360a9689","line":25,"in_reply_to":"5f7c97a3_c0cb611b","updated":"2018-06-12 14:13:22.000000000","message":"Ah, yeah I thought I did this but a search shows that I very much did not succeed :D\n\nWill fix.","commit_id":"e327af6bbc0839829408101d13e86b93cf62eb4d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"86e335350cbd6503a6085a17d705d4bd8389e9ca","unresolved":false,"context_lines":[{"line_number":62,"context_line":"know it means a +2 just around the corner, and this is much better at"},{"line_number":63,"context_line":"encouraging the contributor and preserving goodwill than a -1. It will also"},{"line_number":64,"context_line":"help you re-review any subsequent patch set more quickly, since you\u0027ll see that"},{"line_number":65,"context_line":"you were basically OK with it before and need only to check any changes."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. _code-review-0:"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_1029a288","line":65,"updated":"2018-06-12 12:54:58.000000000","message":"Don\u0027t know if it is worth mentioning, but as a core, I sometimes put a +1 if I am not that familiar with the code but from what I can see, it looks good.","commit_id":"e327af6bbc0839829408101d13e86b93cf62eb4d"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"6e571d3525bacfd1866fd3768a336fd420632f09","unresolved":false,"context_lines":[{"line_number":62,"context_line":"know it means a +2 just around the corner, and this is much better at"},{"line_number":63,"context_line":"encouraging the contributor and preserving goodwill than a -1. It will also"},{"line_number":64,"context_line":"help you re-review any subsequent patch set more quickly, since you\u0027ll see that"},{"line_number":65,"context_line":"you were basically OK with it before and need only to check any changes."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. _code-review-0:"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_f682dec6","line":65,"in_reply_to":"5f7c97a3_1029a288","updated":"2018-06-12 14:13:22.000000000","message":"That\u0027s actually a good one to add, because we want to make it clear to teams that they can add core reviewers without fear that they\u0027ll start +2ing stuff they\u0027re not actually familiar with, instead of waiting until somebody knows every corner of the code base before making them a core.","commit_id":"e327af6bbc0839829408101d13e86b93cf62eb4d"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"da8d49810490ec81ff87f9c1f66ba7f1a106522b","unresolved":false,"context_lines":[{"line_number":85,"context_line":"Use a -1 review to indicate that you have found significant problems with the"},{"line_number":86,"context_line":"patch that you strongly believe should be corrected before the patch is merged."},{"line_number":87,"context_line":"There are many legitimate reasons to do this, ranging from a new bug being"},{"line_number":88,"context_line":"introduced through to even something as small as a typo in the commit message -"},{"line_number":89,"context_line":"*if* (and only if!) it\u0027s in a key word that will make the patch hard to find in"},{"line_number":90,"context_line":"git history. Once again, use your best judgement, but remember that when you"},{"line_number":91,"context_line":"vote -1 you\u0027re obstructing someone else\u0027s work so make sure it\u0027s for a good"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_bcaa05cf","line":88,"range":{"start_line":88,"start_character":11,"end_line":88,"end_character":19},"updated":"2018-06-12 15:01:47.000000000","message":"would change this to \u0027by the patch\u0027","commit_id":"e327af6bbc0839829408101d13e86b93cf62eb4d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b8f6b1ef7b980dc424d8bc32315a19bd664b8707","unresolved":false,"context_lines":[{"line_number":93,"context_line":":ref:`follow-up change \u003cfollow-up-changes\u003e`)."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Remember also that many busy reviewers will not prioritise patches that already"},{"line_number":96,"context_line":"have negative reviews, so by voting -1 you are not only requiring the to"},{"line_number":97,"context_line":"submitter to make another revision, you\u0027re also potentially cutting them off"},{"line_number":98,"context_line":"from more sources of feedback."},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_cb99471f","line":96,"range":{"start_line":96,"start_character":66,"end_line":96,"end_character":72},"updated":"2018-06-12 01:00:02.000000000","message":"s/the to/the/","commit_id":"e327af6bbc0839829408101d13e86b93cf62eb4d"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"6e571d3525bacfd1866fd3768a336fd420632f09","unresolved":false,"context_lines":[{"line_number":93,"context_line":":ref:`follow-up change \u003cfollow-up-changes\u003e`)."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Remember also that many busy reviewers will not prioritise patches that already"},{"line_number":96,"context_line":"have negative reviews, so by voting -1 you are not only requiring the to"},{"line_number":97,"context_line":"submitter to make another revision, you\u0027re also potentially cutting them off"},{"line_number":98,"context_line":"from more sources of feedback."},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_b668e620","line":96,"range":{"start_line":96,"start_character":66,"end_line":96,"end_character":72},"in_reply_to":"5f7c97a3_cb99471f","updated":"2018-06-12 14:13:22.000000000","message":"thanks","commit_id":"e327af6bbc0839829408101d13e86b93cf62eb4d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b8f6b1ef7b980dc424d8bc32315a19bd664b8707","unresolved":false,"context_lines":[{"line_number":108,"context_line":"vote -1, unless the change actually breaks something (in which case, leave a"},{"line_number":109,"context_line":"comment indicating that you understand there is conflicting advice and you are"},{"line_number":110,"context_line":"working to resolve it as soon as possible). It is never the patch submitter\u0027s"},{"line_number":111,"context_line":"responsibility to deal with a disagreement between core reviewers."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":".. _code-review-minus-2:"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_8b9fcf00","line":111,"updated":"2018-06-12 01:00:02.000000000","message":"I think there are exceptions to this last sentence, but fair enough. ;)","commit_id":"e327af6bbc0839829408101d13e86b93cf62eb4d"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"adb5a781f20af03980c9c1596b4b87e27215d52f","unresolved":false,"context_lines":[{"line_number":108,"context_line":"vote -1, unless the change actually breaks something (in which case, leave a"},{"line_number":109,"context_line":"comment indicating that you understand there is conflicting advice and you are"},{"line_number":110,"context_line":"working to resolve it as soon as possible). It is never the patch submitter\u0027s"},{"line_number":111,"context_line":"responsibility to deal with a disagreement between core reviewers."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":".. _code-review-minus-2:"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_94892b27","line":111,"in_reply_to":"5f7c97a3_8b9fcf00","updated":"2018-06-12 09:06:04.000000000","message":"One of the things I like about this document is that it speaks as if we have already achieved an ideal. I think this is good because it helps us to be a bit more aspirational and guiding.\n\nIt also means we don\u0027t have to list all the caveats, disclaimers, special cases, etc.","commit_id":"e327af6bbc0839829408101d13e86b93cf62eb4d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8cf156698b9d6181bdab78b1d08eb59bffc49c6d","unresolved":false,"context_lines":[{"line_number":108,"context_line":"vote -1, unless the change actually breaks something (in which case, leave a"},{"line_number":109,"context_line":"comment indicating that you understand there is conflicting advice and you are"},{"line_number":110,"context_line":"working to resolve it as soon as possible). It is never the patch submitter\u0027s"},{"line_number":111,"context_line":"responsibility to deal with a disagreement between core reviewers."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":".. _code-review-minus-2:"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_d0248a62","line":111,"in_reply_to":"5f7c97a3_94892b27","updated":"2018-06-12 12:52:44.000000000","message":"Very true.","commit_id":"e327af6bbc0839829408101d13e86b93cf62eb4d"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"6e571d3525bacfd1866fd3768a336fd420632f09","unresolved":false,"context_lines":[{"line_number":108,"context_line":"vote -1, unless the change actually breaks something (in which case, leave a"},{"line_number":109,"context_line":"comment indicating that you understand there is conflicting advice and you are"},{"line_number":110,"context_line":"working to resolve it as soon as possible). It is never the patch submitter\u0027s"},{"line_number":111,"context_line":"responsibility to deal with a disagreement between core reviewers."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":".. _code-review-minus-2:"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_76bd6eaf","line":111,"in_reply_to":"5f7c97a3_d0248a62","updated":"2018-06-12 14:13:22.000000000","message":"I\u0027m sure it often becomes their problem, but it\u0027s never their responsibility.","commit_id":"e327af6bbc0839829408101d13e86b93cf62eb4d"}]}