)]}'
{"recipes/cinder-common.rb":[{"author":{"_account_id":12196,"name":"Jun Hong Li","email":"junhongl@cn.ibm.com","username":"Junhongl"},"change_message_id":"3630c6acef855d652e33ef590eb0e59a4301148a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"case node[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027volume\u0027][\u0027driver\u0027]"},{"line_number":49,"context_line":"when \u0027cinder.volume.drivers.ibm.storwize_svc.StorwizeSVCDriver\u0027"},{"line_number":50,"context_line":"  if node[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027storwize\u0027][\u0027san_private_key\u0027].to_s.empty?"},{"line_number":51,"context_line":"    storwize_pass \u003d get_password \u0027user\u0027, node[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027storwize\u0027][\u0027san_login\u0027]"},{"line_number":52,"context_line":"  end"},{"line_number":53,"context_line":"when \u0027cinder.volume.drivers.solidfire.SolidFire\u0027"},{"line_number":54,"context_line":"  solidfire_pass \u003d get_password \u0027user\u0027, node[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027solidfire\u0027][\u0027san_login\u0027]"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5a890539_fe74529d","line":51,"updated":"2014-12-03 04:44:54.000000000","message":"I don\u0027t think getting password from a dynamic databag item according to the value of \"node[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027storwize\u0027][\u0027san_login\u0027]\" is a good idea. Which means if the the value is \u0027admin\u0027 or other values which may be identical with existing databag item in \u0027user\u0027 databag, it will use the password of get_password \u0027user\u0027 \u0027admin\u0027 or other existing databag items. This will make users struggling from having to have identical passwords for these two use cases.\n\nWhy not getting the password from a static databag item like \"san_login\" and adding the default databag item into chef?","commit_id":"e6d89d06894eb97cd907208b35a8d5ff6e8cabf1"},{"author":{"_account_id":12196,"name":"Jun Hong Li","email":"junhongl@cn.ibm.com","username":"Junhongl"},"change_message_id":"3d71c13897d138036974558b2002913fc09253b7","unresolved":false,"context_lines":[{"line_number":48,"context_line":"case node[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027volume\u0027][\u0027driver\u0027]"},{"line_number":49,"context_line":"when \u0027cinder.volume.drivers.ibm.storwize_svc.StorwizeSVCDriver\u0027"},{"line_number":50,"context_line":"  if node[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027storwize\u0027][\u0027san_private_key\u0027].to_s.empty?"},{"line_number":51,"context_line":"    storwize_pass \u003d get_password \u0027user\u0027, node[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027storwize\u0027][\u0027san_login\u0027]"},{"line_number":52,"context_line":"  end"},{"line_number":53,"context_line":"when \u0027cinder.volume.drivers.solidfire.SolidFire\u0027"},{"line_number":54,"context_line":"  solidfire_pass \u003d get_password \u0027user\u0027, node[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027solidfire\u0027][\u0027san_login\u0027]"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5a890539_7243003f","line":51,"in_reply_to":"5a890539_c33de88f","updated":"2014-12-04 02:04:07.000000000","message":"Hi Mark,\n\nI do believe the current way works fine, having a small potential problem of databag item collision is tolerant at the current stage I think. Of course, I can open a new bug to raise this potential problem up.\n\nBut for this bug, I don\u0027t mean to introduce such big change into the way to getting san password.  I think we can make the san databag item static to avoid such kind of databag item name collision problem before the above big change is accepted and addressed. If you still think it\u0027s part of the total change to get the user password, and I\u0027m fine with that to address this in Kilo.\n\nThank you for your consideration for my concern.","commit_id":"e6d89d06894eb97cd907208b35a8d5ff6e8cabf1"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"8cd38e668f707fc3b2c428f010a43320fba9c9c2","unresolved":false,"context_lines":[{"line_number":48,"context_line":"case node[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027volume\u0027][\u0027driver\u0027]"},{"line_number":49,"context_line":"when \u0027cinder.volume.drivers.ibm.storwize_svc.StorwizeSVCDriver\u0027"},{"line_number":50,"context_line":"  if node[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027storwize\u0027][\u0027san_private_key\u0027].to_s.empty?"},{"line_number":51,"context_line":"    storwize_pass \u003d get_password \u0027user\u0027, node[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027storwize\u0027][\u0027san_login\u0027]"},{"line_number":52,"context_line":"  end"},{"line_number":53,"context_line":"when \u0027cinder.volume.drivers.solidfire.SolidFire\u0027"},{"line_number":54,"context_line":"  solidfire_pass \u003d get_password \u0027user\u0027, node[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027solidfire\u0027][\u0027san_login\u0027]"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5a890539_c33de88f","line":51,"in_reply_to":"5a890539_fe74529d","updated":"2014-12-03 15:18:53.000000000","message":"That\u0027s a reasonable concern.   just from looking at this page of code you can see that get_password \u0027user\u0027 \u003ckey\u003e  is used all over the place and is currently the basic way passwords are handled.\n\nSince this is not directly related to this specific patch, please open a bug and this can issue can be tracked.  It would seem like the mq_password, san_login, and many others in the cookbooks could be made static and still give the same flexibility and security.   We might also need to discuss this in the ML or in a blueprint as it\u0027s a different approach from what is happening now.  Maybe something for Kilo?","commit_id":"e6d89d06894eb97cd907208b35a8d5ff6e8cabf1"}]}