)]}'
{"attributes/default.rb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"6fd3c4495be8bd5544fd1a990cf539e2a8dc5e08","unresolved":false,"context_lines":[{"line_number":64,"context_line":"default[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027keystone_service_chef_role\u0027] \u003d \u0027keystone\u0027"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Whether to enable cinder-backup service or not"},{"line_number":67,"context_line":"default[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027enable_backup\u0027] \u003d false"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"# Keystone PKI signing directory"},{"line_number":70,"context_line":"default[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027cache_dir\u0027] \u003d \u0027/var/cache/cinder/api\u0027"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3acd31a7_d91565e5","line":67,"updated":"2015-05-05 09:35:54.000000000","message":"I think this attribute [\u0027openstack\u0027][\u0027block-storage\u0027][\u0027backup\u0027][\u0027enabled\u0027] looks better.","commit_id":"53d1fc44a2b153f44516ba5bcc402b54ac17563a"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"2558b26cb8572dd01417154c1afefd063add9ff9","unresolved":false,"context_lines":[{"line_number":64,"context_line":"default[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027keystone_service_chef_role\u0027] \u003d \u0027keystone\u0027"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Whether to enable cinder-backup service or not"},{"line_number":67,"context_line":"default[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027enable_backup\u0027] \u003d false"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"# Keystone PKI signing directory"},{"line_number":70,"context_line":"default[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027api\u0027][\u0027auth\u0027][\u0027cache_dir\u0027] \u003d \u0027/var/cache/cinder/api\u0027"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3acd31a7_9ce47be1","line":67,"in_reply_to":"3acd31a7_d91565e5","updated":"2015-05-05 10:07:37.000000000","message":"Done","commit_id":"53d1fc44a2b153f44516ba5bcc402b54ac17563a"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"6fd3c4495be8bd5544fd1a990cf539e2a8dc5e08","unresolved":false,"context_lines":[{"line_number":338,"context_line":"    \u0027cinder_volume_service\u0027 \u003d\u003e \u0027openstack-cinder-volume\u0027,"},{"line_number":339,"context_line":"    \u0027cinder_scheduler_packages\u0027 \u003d\u003e [],"},{"line_number":340,"context_line":"    \u0027cinder_scheduler_service\u0027 \u003d\u003e \u0027openstack-cinder-scheduler\u0027,"},{"line_number":341,"context_line":"    \u0027cinder_backup_packages\u0027 \u003d\u003e [],"},{"line_number":342,"context_line":"    \u0027cinder_backup_service\u0027 \u003d\u003e \u0027openstack-cinder-backup\u0027,"},{"line_number":343,"context_line":"    \u0027cinder_iscsitarget_packages\u0027 \u003d\u003e [\u0027targetcli\u0027],"},{"line_number":344,"context_line":"    \u0027cinder_iscsitarget_service\u0027 \u003d\u003e \u0027target\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3acd31a7_d9ec45f5","line":341,"updated":"2015-05-05 09:35:54.000000000","message":"no pkgs for rhel platform family ?","commit_id":"53d1fc44a2b153f44516ba5bcc402b54ac17563a"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"2558b26cb8572dd01417154c1afefd063add9ff9","unresolved":false,"context_lines":[{"line_number":338,"context_line":"    \u0027cinder_volume_service\u0027 \u003d\u003e \u0027openstack-cinder-volume\u0027,"},{"line_number":339,"context_line":"    \u0027cinder_scheduler_packages\u0027 \u003d\u003e [],"},{"line_number":340,"context_line":"    \u0027cinder_scheduler_service\u0027 \u003d\u003e \u0027openstack-cinder-scheduler\u0027,"},{"line_number":341,"context_line":"    \u0027cinder_backup_packages\u0027 \u003d\u003e [],"},{"line_number":342,"context_line":"    \u0027cinder_backup_service\u0027 \u003d\u003e \u0027openstack-cinder-backup\u0027,"},{"line_number":343,"context_line":"    \u0027cinder_iscsitarget_packages\u0027 \u003d\u003e [\u0027targetcli\u0027],"},{"line_number":344,"context_line":"    \u0027cinder_iscsitarget_service\u0027 \u003d\u003e \u0027target\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3acd31a7_7cfcff71","line":341,"in_reply_to":"3acd31a7_d9ec45f5","updated":"2015-05-05 10:07:37.000000000","message":"Cinder-backup service is the same to the cinder-scheduler service, it will be automatically installed by [\u0027cinder_common_packages\u0027] for rhel platform, so no pkgs here.","commit_id":"53d1fc44a2b153f44516ba5bcc402b54ac17563a"}],"metadata.rb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"6fd3c4495be8bd5544fd1a990cf539e2a8dc5e08","unresolved":false,"context_lines":[{"line_number":5,"context_line":"license          \u0027Apache 2.0\u0027"},{"line_number":6,"context_line":"description      \u0027The OpenStack Advanced Volume Management service Cinder.\u0027"},{"line_number":7,"context_line":"long_description IO.read(File.join(File.dirname(__FILE__), \u0027README.md\u0027))"},{"line_number":8,"context_line":"version          \u002711.0.1\u0027"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"recipe           \u0027openstack-block-storage::api\u0027, \u0027Installs the cinder-api, sets up the cinder database, and cinder service/user/endpoints in keystone\u0027"},{"line_number":11,"context_line":"recipe           \u0027openstack-block-storage::client\u0027, \u0027Install packages required for cinder client\u0027"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3acd31a7_d99a056e","line":8,"updated":"2015-05-05 09:35:54.000000000","message":"11.1.0 is reasonable","commit_id":"53d1fc44a2b153f44516ba5bcc402b54ac17563a"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"2558b26cb8572dd01417154c1afefd063add9ff9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"license          \u0027Apache 2.0\u0027"},{"line_number":6,"context_line":"description      \u0027The OpenStack Advanced Volume Management service Cinder.\u0027"},{"line_number":7,"context_line":"long_description IO.read(File.join(File.dirname(__FILE__), \u0027README.md\u0027))"},{"line_number":8,"context_line":"version          \u002711.0.1\u0027"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"recipe           \u0027openstack-block-storage::api\u0027, \u0027Installs the cinder-api, sets up the cinder database, and cinder service/user/endpoints in keystone\u0027"},{"line_number":11,"context_line":"recipe           \u0027openstack-block-storage::client\u0027, \u0027Install packages required for cinder client\u0027"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3acd31a7_3cfb277b","line":8,"in_reply_to":"3acd31a7_d99a056e","updated":"2015-05-05 10:07:37.000000000","message":"Done","commit_id":"53d1fc44a2b153f44516ba5bcc402b54ac17563a"}],"recipes/backup.rb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"968ef78cb2e136093441ac2c6b700121a2d038b7","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  service_name platform_options[\u0027cinder_backup_service\u0027]"},{"line_number":41,"context_line":"  supports status: true, restart: true"},{"line_number":42,"context_line":"  action [:enable, :start]"},{"line_number":43,"context_line":"  subscribes :restart, \u0027template[/etc/cinder/cinder.conf]\u0027"},{"line_number":44,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3acd31a7_39fb397b","line":43,"updated":"2015-05-05 09:36:46.000000000","message":"spec tests need to cover this \"subscribes\"","commit_id":"1536121bd3c1e4dddcaa8a3504e5a16f98647484"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"6e87d66b083e4b86a809a05a0e2fc3a3830b2145","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  service_name platform_options[\u0027cinder_backup_service\u0027]"},{"line_number":41,"context_line":"  supports status: true, restart: true"},{"line_number":42,"context_line":"  action [:enable, :start]"},{"line_number":43,"context_line":"  subscribes :restart, \u0027template[/etc/cinder/cinder.conf]\u0027"},{"line_number":44,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3acd31a7_bcdf370c","line":43,"in_reply_to":"3acd31a7_39fb397b","updated":"2015-05-05 10:07:59.000000000","message":"Done","commit_id":"1536121bd3c1e4dddcaa8a3504e5a16f98647484"}],"spec/backup-redhat_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"250a09ededee1cade7ef22cbbe1dfb6fc1791267","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        node.set[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027backup\u0027][\u0027enabled\u0027] \u003d true"},{"line_number":18,"context_line":"      end"},{"line_number":19,"context_line":"      it \u0027upgrades cinder backup package\u0027 do"},{"line_number":20,"context_line":"        expect(chef_run).to upgrade_package \u0027openstack-cinder\u0027"},{"line_number":21,"context_line":"      end"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"      it \u0027starts cinder backup\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3acd31a7_6057ad58","line":20,"updated":"2015-05-05 13:32:03.000000000","message":"No specific packages listed for redhat, this should be removed at it\u0027s already handled by common spec","commit_id":"75da2a6814db5862c55d025cc4a69574c7159da4"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"3aab0b3646123c1505ff4e2a1c3369d878dfef4c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        node.set[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027backup\u0027][\u0027enabled\u0027] \u003d true"},{"line_number":18,"context_line":"      end"},{"line_number":19,"context_line":"      it \u0027upgrades cinder backup package\u0027 do"},{"line_number":20,"context_line":"        expect(chef_run).to upgrade_package \u0027openstack-cinder\u0027"},{"line_number":21,"context_line":"      end"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"      it \u0027starts cinder backup\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3acd31a7_d6b887ca","line":20,"in_reply_to":"3acd31a7_6057ad58","updated":"2015-05-05 14:15:53.000000000","message":"Done","commit_id":"75da2a6814db5862c55d025cc4a69574c7159da4"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"b7ac19c513a40d343b7bca98a4d85ca6a17af9b3","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      end"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"      it \u0027subscribes to the template change\u0027 do"},{"line_number":29,"context_line":"        expect(chef_run.service(\u0027openstack-cinder-backup\u0027)).to subscribe_to(\u0027template[/etc/cinder/cinder.conf]\u0027)"},{"line_number":30,"context_line":"      end"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"      it \u0027upgrades mysql python package\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"1aca2d91_b96d97ce","line":29,"updated":"2015-05-06 02:11:07.000000000","message":"I think there is no need since it is covered in backup_spec.rb","commit_id":"8082f1220a8e171f834a705338a5f0d2fda9655b"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"e9b96e66237facfcaf4436e5f7af63fafd89ddb4","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      end"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"      it \u0027subscribes to the template change\u0027 do"},{"line_number":29,"context_line":"        expect(chef_run.service(\u0027openstack-cinder-backup\u0027)).to subscribe_to(\u0027template[/etc/cinder/cinder.conf]\u0027)"},{"line_number":30,"context_line":"      end"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"      it \u0027upgrades mysql python package\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"1aca2d91_b9c917af","line":29,"in_reply_to":"1aca2d91_b96d97ce","updated":"2015-05-06 02:16:24.000000000","message":"Done","commit_id":"8082f1220a8e171f834a705338a5f0d2fda9655b"}],"spec/backup-suse_spec.rb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"b7ac19c513a40d343b7bca98a4d85ca6a17af9b3","unresolved":false,"context_lines":[{"line_number":29,"context_line":"      end"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"      it \u0027subscribes to the template change\u0027 do"},{"line_number":32,"context_line":"        expect(chef_run.service(\u0027openstack-cinder-backup\u0027)).to subscribe_to(\u0027template[/etc/cinder/cinder.conf]\u0027)"},{"line_number":33,"context_line":"      end"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"      it \u0027upgrades mysql python package\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"1aca2d91_f9730fb3","line":32,"updated":"2015-05-06 02:11:07.000000000","message":"I think there is no need since it is covered in backup_spec.rb","commit_id":"8082f1220a8e171f834a705338a5f0d2fda9655b"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"e9b96e66237facfcaf4436e5f7af63fafd89ddb4","unresolved":false,"context_lines":[{"line_number":29,"context_line":"      end"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"      it \u0027subscribes to the template change\u0027 do"},{"line_number":32,"context_line":"        expect(chef_run.service(\u0027openstack-cinder-backup\u0027)).to subscribe_to(\u0027template[/etc/cinder/cinder.conf]\u0027)"},{"line_number":33,"context_line":"      end"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"      it \u0027upgrades mysql python package\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"1aca2d91_79c49f91","line":32,"in_reply_to":"1aca2d91_f9730fb3","updated":"2015-05-06 02:16:24.000000000","message":"Done","commit_id":"8082f1220a8e171f834a705338a5f0d2fda9655b"}],"spec/cinder_common_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"250a09ededee1cade7ef22cbbe1dfb6fc1791267","unresolved":false,"context_lines":[{"line_number":196,"context_line":"               backup_swift_retry_attempts\u003d3"},{"line_number":197,"context_line":"               backup_swift_retry_backoff\u003d2"},{"line_number":198,"context_line":"               backup_swift_enable_progress_timer\u003dTrue).each do |attr|"},{"line_number":199,"context_line":"              expect(chef_run).to render_file(file.name).with_content(/^#{attr}$/)"},{"line_number":200,"context_line":"            end"},{"line_number":201,"context_line":"          end"},{"line_number":202,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3acd31a7_002b5995","line":199,"updated":"2015-05-05 13:32:03.000000000","message":"Would like to see all new content checks use the new .with_section_content from Common matcher.","commit_id":"75da2a6814db5862c55d025cc4a69574c7159da4"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"3aab0b3646123c1505ff4e2a1c3369d878dfef4c","unresolved":false,"context_lines":[{"line_number":196,"context_line":"               backup_swift_retry_attempts\u003d3"},{"line_number":197,"context_line":"               backup_swift_retry_backoff\u003d2"},{"line_number":198,"context_line":"               backup_swift_enable_progress_timer\u003dTrue).each do |attr|"},{"line_number":199,"context_line":"              expect(chef_run).to render_file(file.name).with_content(/^#{attr}$/)"},{"line_number":200,"context_line":"            end"},{"line_number":201,"context_line":"          end"},{"line_number":202,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3acd31a7_56a6b7ae","line":199,"in_reply_to":"3acd31a7_002b5995","updated":"2015-05-05 14:15:53.000000000","message":"Done","commit_id":"75da2a6814db5862c55d025cc4a69574c7159da4"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"250a09ededee1cade7ef22cbbe1dfb6fc1791267","unresolved":false,"context_lines":[{"line_number":214,"context_line":"               retry_backoff"},{"line_number":215,"context_line":"               enable_progress_timer).each do |attr|"},{"line_number":216,"context_line":"              node.set[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027backup\u0027][\u0027swift\u0027][attr] \u003d \"backup_swift_#{attr}\""},{"line_number":217,"context_line":"              expect(chef_run).to render_file(file.name).with_content(/^backup_swift_#{attr}\u003dbackup_swift_#{attr}$/)"},{"line_number":218,"context_line":"            end"},{"line_number":219,"context_line":"            node.set[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027backup\u0027][\u0027swift\u0027][\u0027catalog_info\u0027] \u003d \u0027swift_catalog_info\u0027"},{"line_number":220,"context_line":"            expect(chef_run).to render_file(file.name).with_content(/^swift_catalog_info\u003dswift_catalog_info$/)"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3acd31a7_c01fa16a","line":217,"updated":"2015-05-05 13:32:03.000000000","message":"Would like to see all new content checks use the new .with_section_content from Common matcher.","commit_id":"75da2a6814db5862c55d025cc4a69574c7159da4"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"3aab0b3646123c1505ff4e2a1c3369d878dfef4c","unresolved":false,"context_lines":[{"line_number":214,"context_line":"               retry_backoff"},{"line_number":215,"context_line":"               enable_progress_timer).each do |attr|"},{"line_number":216,"context_line":"              node.set[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027backup\u0027][\u0027swift\u0027][attr] \u003d \"backup_swift_#{attr}\""},{"line_number":217,"context_line":"              expect(chef_run).to render_file(file.name).with_content(/^backup_swift_#{attr}\u003dbackup_swift_#{attr}$/)"},{"line_number":218,"context_line":"            end"},{"line_number":219,"context_line":"            node.set[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027backup\u0027][\u0027swift\u0027][\u0027catalog_info\u0027] \u003d \u0027swift_catalog_info\u0027"},{"line_number":220,"context_line":"            expect(chef_run).to render_file(file.name).with_content(/^swift_catalog_info\u003dswift_catalog_info$/)"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3acd31a7_769c135d","line":217,"in_reply_to":"3acd31a7_c01fa16a","updated":"2015-05-05 14:15:53.000000000","message":"Done","commit_id":"75da2a6814db5862c55d025cc4a69574c7159da4"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"250a09ededee1cade7ef22cbbe1dfb6fc1791267","unresolved":false,"context_lines":[{"line_number":217,"context_line":"              expect(chef_run).to render_file(file.name).with_content(/^backup_swift_#{attr}\u003dbackup_swift_#{attr}$/)"},{"line_number":218,"context_line":"            end"},{"line_number":219,"context_line":"            node.set[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027backup\u0027][\u0027swift\u0027][\u0027catalog_info\u0027] \u003d \u0027swift_catalog_info\u0027"},{"line_number":220,"context_line":"            expect(chef_run).to render_file(file.name).with_content(/^swift_catalog_info\u003dswift_catalog_info$/)"},{"line_number":221,"context_line":"          end"},{"line_number":222,"context_line":"        end"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3acd31a7_8015294a","line":220,"updated":"2015-05-05 13:32:03.000000000","message":"Would like to see all new content checks use the new .with_section_content from Common matcher.","commit_id":"75da2a6814db5862c55d025cc4a69574c7159da4"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"3aab0b3646123c1505ff4e2a1c3369d878dfef4c","unresolved":false,"context_lines":[{"line_number":217,"context_line":"              expect(chef_run).to render_file(file.name).with_content(/^backup_swift_#{attr}\u003dbackup_swift_#{attr}$/)"},{"line_number":218,"context_line":"            end"},{"line_number":219,"context_line":"            node.set[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027backup\u0027][\u0027swift\u0027][\u0027catalog_info\u0027] \u003d \u0027swift_catalog_info\u0027"},{"line_number":220,"context_line":"            expect(chef_run).to render_file(file.name).with_content(/^swift_catalog_info\u003dswift_catalog_info$/)"},{"line_number":221,"context_line":"          end"},{"line_number":222,"context_line":"        end"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3acd31a7_36a33b9f","line":220,"in_reply_to":"3acd31a7_8015294a","updated":"2015-05-05 14:15:53.000000000","message":"Done","commit_id":"75da2a6814db5862c55d025cc4a69574c7159da4"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"73ce7c0c659ac60f319fbf7b275091aeecd448b8","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            node.set[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027backup\u0027][\u0027driver\u0027] \u003d \u0027cinder.backup.drivers.swift\u0027"},{"line_number":187,"context_line":"          end"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"          it \u0027has a default attribute\u0027 do"},{"line_number":190,"context_line":"            %w(swift_catalog_info\u003dobject-store:swift:publicURL"},{"line_number":191,"context_line":"               backup_swift_auth\u003dper_user"},{"line_number":192,"context_line":"               backup_swift_auth_version\u003d1"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"1aca2d91_025e54e9","line":189,"updated":"2015-05-06 05:30:50.000000000","message":"I saw many attributes. :)","commit_id":"c956d45ef80280e2a75caca7b71aaaf1206c2f29"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"173ed2096efb6c5d249afdc462435583d6ce38b5","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            node.set[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027backup\u0027][\u0027driver\u0027] \u003d \u0027cinder.backup.drivers.swift\u0027"},{"line_number":187,"context_line":"          end"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"          it \u0027has a default attribute\u0027 do"},{"line_number":190,"context_line":"            %w(swift_catalog_info\u003dobject-store:swift:publicURL"},{"line_number":191,"context_line":"               backup_swift_auth\u003dper_user"},{"line_number":192,"context_line":"               backup_swift_auth_version\u003d1"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"1aca2d91_02ee548b","line":189,"in_reply_to":"1aca2d91_025e54e9","updated":"2015-05-06 05:55:49.000000000","message":"Done","commit_id":"c956d45ef80280e2a75caca7b71aaaf1206c2f29"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"73ce7c0c659ac60f319fbf7b275091aeecd448b8","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            end"},{"line_number":201,"context_line":"          end"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"          it \u0027has a override attribute\u0027 do"},{"line_number":204,"context_line":"            %w(url"},{"line_number":205,"context_line":"               auth"},{"line_number":206,"context_line":"               auth_version"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"1aca2d91_c2573cc9","line":203,"updated":"2015-05-06 05:30:50.000000000","message":"I saw many attributes.","commit_id":"c956d45ef80280e2a75caca7b71aaaf1206c2f29"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"173ed2096efb6c5d249afdc462435583d6ce38b5","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            end"},{"line_number":201,"context_line":"          end"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"          it \u0027has a override attribute\u0027 do"},{"line_number":204,"context_line":"            %w(url"},{"line_number":205,"context_line":"               auth"},{"line_number":206,"context_line":"               auth_version"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"1aca2d91_22e270a0","line":203,"in_reply_to":"1aca2d91_c2573cc9","updated":"2015-05-06 05:55:49.000000000","message":"Done","commit_id":"c956d45ef80280e2a75caca7b71aaaf1206c2f29"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"73ce7c0c659ac60f319fbf7b275091aeecd448b8","unresolved":false,"context_lines":[{"line_number":217,"context_line":"              expect(chef_run).to render_config_file(file.name).with_section_content(\u0027DEFAULT\u0027, /^backup_swift_#{attr}\u003dbackup_swift_#{attr}$/)"},{"line_number":218,"context_line":"            end"},{"line_number":219,"context_line":"            node.set[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027backup\u0027][\u0027swift\u0027][\u0027catalog_info\u0027] \u003d \u0027swift_catalog_info\u0027"},{"line_number":220,"context_line":"            expect(chef_run).to render_config_file(file.name).with_section_content(\u0027DEFAULT\u0027, /^swift_catalog_info\u003dswift_catalog_info$/)"},{"line_number":221,"context_line":"          end"},{"line_number":222,"context_line":"        end"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":6,"id":"1aca2d91_824b842b","line":220,"updated":"2015-05-06 05:30:50.000000000","message":"It\u0027s better to put this expect to it.\n\nit \u0027has a custom catalog_info\u0027 do\n   node.set...\n   expect...\nend","commit_id":"c956d45ef80280e2a75caca7b71aaaf1206c2f29"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"173ed2096efb6c5d249afdc462435583d6ce38b5","unresolved":false,"context_lines":[{"line_number":217,"context_line":"              expect(chef_run).to render_config_file(file.name).with_section_content(\u0027DEFAULT\u0027, /^backup_swift_#{attr}\u003dbackup_swift_#{attr}$/)"},{"line_number":218,"context_line":"            end"},{"line_number":219,"context_line":"            node.set[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027backup\u0027][\u0027swift\u0027][\u0027catalog_info\u0027] \u003d \u0027swift_catalog_info\u0027"},{"line_number":220,"context_line":"            expect(chef_run).to render_config_file(file.name).with_section_content(\u0027DEFAULT\u0027, /^swift_catalog_info\u003dswift_catalog_info$/)"},{"line_number":221,"context_line":"          end"},{"line_number":222,"context_line":"        end"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":6,"id":"1aca2d91_e2f2386f","line":220,"in_reply_to":"1aca2d91_824b842b","updated":"2015-05-06 05:55:49.000000000","message":"Done","commit_id":"c956d45ef80280e2a75caca7b71aaaf1206c2f29"}],"templates/default/cinder.conf.erb":[{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"73ce7c0c659ac60f319fbf7b275091aeecd448b8","unresolved":false,"context_lines":[{"line_number":278,"context_line":"# backup_swift_url\u003d\u003cNone\u003e"},{"line_number":279,"context_line":"\u003c% if node[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027backup\u0027][\u0027swift\u0027][\u0027url\u0027] %\u003e"},{"line_number":280,"context_line":"backup_swift_url\u003d\u003c%\u003d node[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027backup\u0027][\u0027swift\u0027][\u0027url\u0027] %\u003e"},{"line_number":281,"context_line":"\u003c% end %\u003e"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"# Info to match when looking for swift in the service catalog."},{"line_number":284,"context_line":"# Format is: separated values of the form:"}],"source_content_type":"application/x-erb","patch_set":6,"id":"1aca2d91_621d080f","line":281,"updated":"2015-05-06 05:30:50.000000000","message":"Could you add an else condition, and do the same to the following attributes. Thanks.\n\nhttps://github.com/stackforge/cookbook-openstack-network/blob/master/templates/default/neutron.conf.erb#L608-613","commit_id":"c956d45ef80280e2a75caca7b71aaaf1206c2f29"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"173ed2096efb6c5d249afdc462435583d6ce38b5","unresolved":false,"context_lines":[{"line_number":278,"context_line":"# backup_swift_url\u003d\u003cNone\u003e"},{"line_number":279,"context_line":"\u003c% if node[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027backup\u0027][\u0027swift\u0027][\u0027url\u0027] %\u003e"},{"line_number":280,"context_line":"backup_swift_url\u003d\u003c%\u003d node[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027backup\u0027][\u0027swift\u0027][\u0027url\u0027] %\u003e"},{"line_number":281,"context_line":"\u003c% end %\u003e"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"# Info to match when looking for swift in the service catalog."},{"line_number":284,"context_line":"# Format is: separated values of the form:"}],"source_content_type":"application/x-erb","patch_set":6,"id":"1aca2d91_4281ec8e","line":281,"in_reply_to":"1aca2d91_621d080f","updated":"2015-05-06 05:55:49.000000000","message":"Done","commit_id":"c956d45ef80280e2a75caca7b71aaaf1206c2f29"}]}