)]}'
{"attributes/default.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"d46c1b22e24a5259bd6519c2007fbe430a14578d","unresolved":false,"context_lines":[{"line_number":322,"context_line":"default[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027lock_path\u0027] \u003d"},{"line_number":323,"context_line":"  \"#{node[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027volume\u0027][\u0027state_path\u0027]}/lock\""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"# Whether to enable cinder v1 api or not"},{"line_number":326,"context_line":"default[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027enable_v1_api\u0027] \u003d \u0027True\u0027"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"# Whether to enable cinder v2 api or not"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1aca2d91_cdb6038a","line":325,"updated":"2015-05-07 15:59:17.000000000","message":"Not sure we should enable this without have a proper endpoint defined for it in Common.","commit_id":"f22eb968f0b4969695da5acfb73f8b7c6df4db6e"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"b04378a55dd07983bd1ecbff648bc316dcc53e1f","unresolved":false,"context_lines":[{"line_number":322,"context_line":"default[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027lock_path\u0027] \u003d"},{"line_number":323,"context_line":"  \"#{node[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027volume\u0027][\u0027state_path\u0027]}/lock\""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"# Whether to enable cinder v1 api or not"},{"line_number":326,"context_line":"default[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027enable_v1_api\u0027] \u003d \u0027True\u0027"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"# Whether to enable cinder v2 api or not"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1aca2d91_8848e788","line":325,"in_reply_to":"1aca2d91_cdb6038a","updated":"2015-05-08 00:34:14.000000000","message":"You are right, we don\u0027t create cinder v1 endpoint by default:\nhttps://github.com/stackforge/cookbook-openstack-block-storage/blob/master/recipes/identity_registration.rb#L50-L74\n\nWill change it in the next patch, thanks!","commit_id":"f22eb968f0b4969695da5acfb73f8b7c6df4db6e"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"1c362529deb96c8535aabd76344ca774cc632bbe","unresolved":false,"context_lines":[{"line_number":321,"context_line":"# in nova and neutron."},{"line_number":322,"context_line":"default[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027lock_path\u0027] \u003d"},{"line_number":323,"context_line":"  \"#{node[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027volume\u0027][\u0027state_path\u0027]}/lock\""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"# Whether to enable cinder v1 api or not"},{"line_number":326,"context_line":"default[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027enable_v1_api\u0027] \u003d \u0027False\u0027"},{"line_number":327,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"1aca2d91_59ce1f5b","line":324,"updated":"2015-05-08 02:52:37.000000000","message":"can you update the README.md file about these two attributes","commit_id":"2c1fee6d453868c9961ffe22099d3d09fe1ed395"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"3df8136b560cd6b9f51d1ddb8dce64b2ef7a51b4","unresolved":false,"context_lines":[{"line_number":321,"context_line":"# in nova and neutron."},{"line_number":322,"context_line":"default[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027lock_path\u0027] \u003d"},{"line_number":323,"context_line":"  \"#{node[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027volume\u0027][\u0027state_path\u0027]}/lock\""},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"# Whether to enable cinder v1 api or not"},{"line_number":326,"context_line":"default[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027enable_v1_api\u0027] \u003d \u0027False\u0027"},{"line_number":327,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"1aca2d91_f9196b89","line":324,"in_reply_to":"1aca2d91_59ce1f5b","updated":"2015-05-08 03:16:01.000000000","message":"Done","commit_id":"2c1fee6d453868c9961ffe22099d3d09fe1ed395"}],"templates/default/cinder.conf.erb":[{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"a42a25aaee2c644323ea94df588e25356a98ed1a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"#### (StrOpt) File name for the paste.deploy config for cinder-api"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# DEPRECATED: Deploy v1 of the Cinder API. (boolean value)"},{"line_number":56,"context_line":"enable_v1_api\u003dtrue"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# Deploy v2 of the Cinder API. (boolean value)"},{"line_number":59,"context_line":"enable_v2_api\u003dtrue"}],"source_content_type":"application/x-erb","patch_set":1,"id":"1aca2d91_baac2036","line":56,"updated":"2015-05-07 13:50:02.000000000","message":"i don\u0027t think that we should enable both v1 (which is also deprecated) and v2 api. if you need the v1 api, you could set these things via attributes to make them configurable","commit_id":"375f53c5206b34f76206166b272dc5a04e5fb196"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"e5f51eee58a88a84f7e64641ba5b099a9a6d5b3c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"#### (StrOpt) File name for the paste.deploy config for cinder-api"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# DEPRECATED: Deploy v1 of the Cinder API. (boolean value)"},{"line_number":56,"context_line":"enable_v1_api\u003dtrue"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# Deploy v2 of the Cinder API. (boolean value)"},{"line_number":59,"context_line":"enable_v2_api\u003dtrue"}],"source_content_type":"application/x-erb","patch_set":1,"id":"1aca2d91_cef4be88","line":56,"in_reply_to":"1aca2d91_18131c0f","updated":"2015-05-07 15:07:28.000000000","message":"At a minimum these should probably be configurable via attributes and then use the default for the matching release, kilo sounds ok.\n\nOn another note, what does this really mean when we have only a single endpoint for this?  I really don\u0027t like having multiple api endpoints, seems like a waste of time for out-dated code.","commit_id":"375f53c5206b34f76206166b272dc5a04e5fb196"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"117ce2bd56594a881b38227494ebe605df73047f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"#### (StrOpt) File name for the paste.deploy config for cinder-api"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# DEPRECATED: Deploy v1 of the Cinder API. (boolean value)"},{"line_number":56,"context_line":"enable_v1_api\u003dtrue"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# Deploy v2 of the Cinder API. (boolean value)"},{"line_number":59,"context_line":"enable_v2_api\u003dtrue"}],"source_content_type":"application/x-erb","patch_set":1,"id":"1aca2d91_8ec0062c","line":56,"in_reply_to":"1aca2d91_18131c0f","updated":"2015-05-07 15:06:09.000000000","message":"i see, maybe we can just remove both of them since these are the defaults anyways? otherwise i would suggest to make them configurable","commit_id":"375f53c5206b34f76206166b272dc5a04e5fb196"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"68ba365fa9657d1f925584acb255fbd50f57da13","unresolved":false,"context_lines":[{"line_number":53,"context_line":"#### (StrOpt) File name for the paste.deploy config for cinder-api"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# DEPRECATED: Deploy v1 of the Cinder API. (boolean value)"},{"line_number":56,"context_line":"enable_v1_api\u003dtrue"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# Deploy v2 of the Cinder API. (boolean value)"},{"line_number":59,"context_line":"enable_v2_api\u003dtrue"}],"source_content_type":"application/x-erb","patch_set":1,"id":"1aca2d91_c9acb837","line":56,"in_reply_to":"1aca2d91_69dec412","updated":"2015-05-07 15:38:33.000000000","message":"Yeah, we have had a couple of requests and attempts to add multiple endpoints to our existing attr endpoint schema in Common, but I think something like that might take a blueprint discussion to convince community to change.","commit_id":"375f53c5206b34f76206166b272dc5a04e5fb196"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"c2f98984195182b8260dd872972864ca6f1c0d26","unresolved":false,"context_lines":[{"line_number":53,"context_line":"#### (StrOpt) File name for the paste.deploy config for cinder-api"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# DEPRECATED: Deploy v1 of the Cinder API. (boolean value)"},{"line_number":56,"context_line":"enable_v1_api\u003dtrue"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# Deploy v2 of the Cinder API. (boolean value)"},{"line_number":59,"context_line":"enable_v2_api\u003dtrue"}],"source_content_type":"application/x-erb","patch_set":1,"id":"1aca2d91_18131c0f","line":56,"in_reply_to":"1aca2d91_baac2036","updated":"2015-05-07 14:23:35.000000000","message":"But in openstack the v1 api was still enabled by default, please see:\nhttps://github.com/openstack/cinder/blob/stable/kilo/cinder/common/config.py#L103-L105\n\nI think we should keep the same with openstack.","commit_id":"375f53c5206b34f76206166b272dc5a04e5fb196"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"a47729652b628a8d0a4bc6f313916ee293bf9ac8","unresolved":false,"context_lines":[{"line_number":53,"context_line":"#### (StrOpt) File name for the paste.deploy config for cinder-api"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# DEPRECATED: Deploy v1 of the Cinder API. (boolean value)"},{"line_number":56,"context_line":"enable_v1_api\u003dtrue"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# Deploy v2 of the Cinder API. (boolean value)"},{"line_number":59,"context_line":"enable_v2_api\u003dtrue"}],"source_content_type":"application/x-erb","patch_set":1,"id":"1aca2d91_69dec412","line":56,"in_reply_to":"1aca2d91_cef4be88","updated":"2015-05-07 15:32:01.000000000","message":"@Mark, if we have only a single endpoint for this, then only the corresponding api version can work. But user may have multi endpoints for one service.\n\nWill make them configurable in the next patch.","commit_id":"375f53c5206b34f76206166b272dc5a04e5fb196"}]}