)]}'
{"attributes/cinder_conf.rb":[{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"22ee37c81d84733e041cf9158f1f9e284fe4eb2f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  if node[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027syslog\u0027][\u0027use\u0027]"},{"line_number":5,"context_line":"    conf[\u0027DEFAULT\u0027][\u0027log_config\u0027] \u003d \u0027/etc/openstack/logging.conf\u0027"},{"line_number":6,"context_line":"  end"},{"line_number":7,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027transport_url\u0027] \u003d \"rabbit://#{node[\u0027openstack\u0027][\u0027mq\u0027][\u0027user\u0027]}:mypass@#{node[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027mq\u0027][\u0027host\u0027]}\""},{"line_number":8,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027auth_strategy\u0027] \u003d \u0027keystone\u0027"},{"line_number":9,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027control_exchange\u0027] \u003d \u0027cinder\u0027"},{"line_number":10,"context_line":"  conf[\u0027DEFAULT\u0027][\u0027volume_group\u0027] \u003d \u0027cinder-volumes\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5a74a57a_6f141af5","line":7,"updated":"2016-11-23 11:48:55.000000000","message":"the \"mypass@\" part does not look right, shouldn\u0027t this be loaded from a secret in the recipe?","commit_id":"b2f63d08d0692b64d470553ce179461c264e6044"}],"recipes/cinder-common.rb":[{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"22ee37c81d84733e041cf9158f1f9e284fe4eb2f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    db_uri(\u0027block-storage\u0027, db_user, db_pass, true)"},{"line_number":42,"context_line":"end"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"unless node[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027conf\u0027][\u0027DEFAULT\u0027][\u0027transport_url\u0027].nil?"},{"line_number":45,"context_line":"  user \u003d node[\u0027openstack\u0027][\u0027mq\u0027][\u0027block-storage\u0027][\u0027rabbit\u0027][\u0027userid\u0027]"},{"line_number":46,"context_line":"  node.default[\u0027openstack\u0027][\u0027block-storage\u0027][\u0027conf_secrets\u0027]"},{"line_number":47,"context_line":"    .[](\u0027oslo_messaging_rabbit\u0027)[\u0027rabbit_userid\u0027] \u003d user"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5a74a57a_ef52eadc","line":44,"updated":"2016-11-23 11:48:55.000000000","message":"we should allow other rpc backends, so i think the if statement should not change and allow other users to still use this recipe, but specify something else as an rpc_backend","commit_id":"b2f63d08d0692b64d470553ce179461c264e6044"}]}