)]}'
{"id":"openstack%2Fcookbook-openstack-block-storage~517297","triplet_id":"openstack%2Fcookbook-openstack-block-storage~master~I0842c60f37f465c2d91ef6e308197c80ef2f37be","project":"openstack/cookbook-openstack-block-storage","branch":"master","topic":"admin_role","hashtags":[],"change_id":"I0842c60f37f465c2d91ef6e308197c80ef2f37be","subject":"Give cinder user admin role","status":"ABANDONED","created":"2017-11-02 12:55:27.000000000","updated":"2017-11-03 09:25:26.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"866f5d1dcc8f2f365481f73144db4a5cac37998e","_number":517297,"virtual_id_number":517297,"owner":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"date":"2017-11-02 15:16:11.000000000","_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},{"value":1,"date":"2017-11-02 15:19:35.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2017-11-02 15:47:06.000000000","_account_id":24734,"name":"cloudbau Chef OpenStack CI","email":"ci@cloudbau.de","username":"cloudbau-chef-openstack-ci"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":-1,"date":"2017-11-02 15:11:15.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":24734,"name":"cloudbau Chef OpenStack CI","email":"ci@cloudbau.de","username":"cloudbau-chef-openstack-ci"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":24734,"name":"cloudbau Chef OpenStack CI","email":"ci@cloudbau.de","username":"cloudbau-chef-openstack-ci"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":24734,"name":"cloudbau Chef OpenStack CI","email":"ci@cloudbau.de","username":"cloudbau-chef-openstack-ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-11-02 15:11:15.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2017-11-02 15:19:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2017-11-02 15:47:06.000000000","updated_by":{"_account_id":24734,"name":"cloudbau Chef OpenStack CI","email":"ci@cloudbau.de","username":"cloudbau-chef-openstack-ci"},"reviewer":{"_account_id":24734,"name":"cloudbau Chef OpenStack CI","email":"ci@cloudbau.de","username":"cloudbau-chef-openstack-ci"},"state":"REVIEWER"}],"messages":[{"id":"5c7468c5e65b2670e3b517f8258c9addfd44722f","author":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"date":"2017-11-02 12:55:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"69a7da01bbd8f100b7f2302ea912d3c0764b6c14","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-02 13:30:27.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- legacy-chef-rake http://logs.openstack.org/97/517297/1/check/legacy-chef-rake/fd0a385/ : FAILURE in 11m 57s\n- legacy-chef-rake-integration http://logs.openstack.org/97/517297/1/check/legacy-chef-rake-integration/f54f9fb/ : SUCCESS in 31m 44s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"d9c28fe903a30a2f1df9c7744d09fb6dc78f68b1","author":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"date":"2017-11-02 14:48:47.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2c5d3febb5751b2f2227c4aeccb9c63bf8f4f019","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2017-11-02 15:11:15.000000000","message":"Patch Set 2: Code-Review-1\n\nI don\u0027t have enough trust in upstream docs in order to do this. Since we seem to be running just fine without the cinder user having admin role, I\u0027d rather stick to that and propose a fix for the upstream docs.","accounts_in_message":[],"_revision_number":2},{"id":"4cc03fc06d449e1d95adbb1458270dc2f4ec6e2c","author":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"date":"2017-11-02 15:16:11.000000000","message":"Patch Set 2:\n\nThat works for me, too. We do need to close the gap to the documentation, one way or another. Differences such as this one may break functionality in subtle ways that are not immediately apparent.","accounts_in_message":[],"_revision_number":2},{"id":"b34460b5b26c963936160c09e7e247d7bbd64374","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-02 15:19:35.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- legacy-chef-rake http://logs.openstack.org/97/517297/2/check/legacy-chef-rake/42f2bf7/ : SUCCESS in 10m 39s\n- legacy-chef-rake-integration http://logs.openstack.org/97/517297/2/check/legacy-chef-rake-integration/4c52a1f/ : SUCCESS in 29m 14s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"70a309fa2632980b6639d037ff8af2e083b32c30","author":{"_account_id":24734,"name":"cloudbau Chef OpenStack CI","email":"ci@cloudbau.de","username":"cloudbau-chef-openstack-ci"},"date":"2017-11-02 15:47:06.000000000","message":"Patch Set 2:\n\n* cloudbau-Chef-OpenStack-CI http://ci.cloudbau.de/ci-logs/refs-changes-97-517297-2 : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"1115c15c261202bcc23426efe4bd04dddbd919fd","author":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"date":"2017-11-03 09:25:26.000000000","message":"Abandoned\n\nBug filed against installguide as suggested.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c4031c34845c6c7390df375ca60b94393710895d","revisions":{"b72f7a2b470e6282f2fc79b217b2ee8fbffe9370":{"kind":"REWORK","_number":1,"created":"2017-11-02 12:55:27.000000000","uploader":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"ref":"refs/changes/97/517297/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cookbook-openstack-block-storage","ref":"refs/changes/97/517297/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cookbook-openstack-block-storage refs/changes/97/517297/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cookbook-openstack-block-storage refs/changes/97/517297/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cookbook-openstack-block-storage refs/changes/97/517297/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cookbook-openstack-block-storage refs/changes/97/517297/1"}}},"commit":{"parents":[{"commit":"a0ad02e3966440c525eefc632ccc11b840ac2140","subject":"Replace platform_family method and use attribute instead","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-block-storage/commit/a0ad02e3966440c525eefc632ccc11b840ac2140"}]}],"author":{"name":"Roger Luethi","email":"rl@patchworkscience.org","date":"2017-11-02 12:08:52.000000000","tz":60},"committer":{"name":"Roger Luethi","email":"rl@patchworkscience.org","date":"2017-11-02 12:54:51.000000000","tz":60},"subject":"Give cinder user admin role","message":"Give cinder user admin role\n\nAccording to the documentation [1], the cinder user should be given the\nadmin role rather than the service role in the service project, just\nlike the other OpenStack services.\n\n[1] https://docs.openstack.org/cinder/pike/install/cinder-controller-install-ubuntu.html\n\nChange-Id: I0842c60f37f465c2d91ef6e308197c80ef2f37be\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-block-storage/commit/b72f7a2b470e6282f2fc79b217b2ee8fbffe9370"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-block-storage/commit/b72f7a2b470e6282f2fc79b217b2ee8fbffe9370"}]},"branch":"refs/heads/master"},"c4031c34845c6c7390df375ca60b94393710895d":{"kind":"REWORK","_number":2,"created":"2017-11-02 14:48:47.000000000","uploader":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"ref":"refs/changes/97/517297/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cookbook-openstack-block-storage","ref":"refs/changes/97/517297/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cookbook-openstack-block-storage refs/changes/97/517297/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cookbook-openstack-block-storage refs/changes/97/517297/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cookbook-openstack-block-storage refs/changes/97/517297/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cookbook-openstack-block-storage refs/changes/97/517297/2"}}},"commit":{"parents":[{"commit":"a0ad02e3966440c525eefc632ccc11b840ac2140","subject":"Replace platform_family method and use attribute instead","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-block-storage/commit/a0ad02e3966440c525eefc632ccc11b840ac2140"}]}],"author":{"name":"Roger Luethi","email":"rl@patchworkscience.org","date":"2017-11-02 12:08:52.000000000","tz":60},"committer":{"name":"Roger Luethi","email":"rl@patchworkscience.org","date":"2017-11-02 14:48:31.000000000","tz":60},"subject":"Give cinder user admin role","message":"Give cinder user admin role\n\nAccording to the documentation [1], the cinder user should be given the\nadmin role rather than the service role in the service project, just\nlike the other OpenStack services.\n\n[1] https://docs.openstack.org/cinder/pike/install/cinder-controller-install-ubuntu.html\n\nChange-Id: I0842c60f37f465c2d91ef6e308197c80ef2f37be\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-block-storage/commit/c4031c34845c6c7390df375ca60b94393710895d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-block-storage/commit/c4031c34845c6c7390df375ca60b94393710895d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}