)]}'
{"id":"openstack%2Fcookbook-openstack-block-storage~663086","triplet_id":"openstack%2Fcookbook-openstack-block-storage~master~I82c60b7c4efaa19459a3a0ab835eb4e48f8ee991","project":"openstack/cookbook-openstack-block-storage","branch":"master","topic":"attribute_fix","hashtags":[],"change_id":"I82c60b7c4efaa19459a3a0ab835eb4e48f8ee991","subject":"Removes admin endpoint references","status":"MERGED","created":"2019-06-04 16:19:11.000000000","updated":"2019-06-05 10:50:48.000000000","submitted":"2019-06-05 10:02:52.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"663086-1559728972624-4bf1be21","meta_rev_id":"eaa81bba0aebb1312a6368fb91a657e0702cc56f","_number":663086,"virtual_id_number":663086,"owner":{"_account_id":30309,"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","username":"t0rrant"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-06-05 10:02:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":30309,"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","username":"t0rrant"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},{"value":2,"date":"2019-06-05 08:14:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":30309,"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","username":"t0rrant"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},{"value":1,"date":"2019-06-05 08:14:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":30309,"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","username":"t0rrant"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30309,"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","username":"t0rrant"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-05 07:23:42.000000000","updated_by":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"reviewer":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"state":"REVIEWER"},{"updated":"2019-06-05 08:14:34.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2019-06-05 10:02:52.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"29cfd9c9d3da75bc4438a693b34ce7b59ed48ab2","author":{"_account_id":30309,"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","username":"t0rrant"},"date":"2019-06-04 16:19:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"935f8700c6aa02f09d5ec94b571a8b365ccf360f","author":{"_account_id":30309,"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","username":"t0rrant"},"date":"2019-06-04 16:20:55.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"123fa1ddd6458c022d073df11826323f3bce45d9","author":{"_account_id":30309,"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","username":"t0rrant"},"date":"2019-06-04 16:22:47.000000000","message":"Patch Set 1:\n\nThe previous commit which only changed the banner issue failed with Zuul.\nIt complained about the admin_endpoint which was removed at this time.\nThis patch tries to fix both of those issues, maybe this label isn\u0027t the best.","accounts_in_message":[],"_revision_number":1},{"id":"6d3da51654f5b7d4c287b21e255210ce55debe61","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-04 17:14:56.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-chef-delivery http://logs.openstack.org/86/663086/1/check/openstack-chef-delivery/cfa9e0e/ : SUCCESS in 4m 43s\n- openstack-chef-integration http://logs.openstack.org/86/663086/1/check/openstack-chef-integration/6e52e2d/ : SUCCESS in 45m 54s","accounts_in_message":[],"_revision_number":1},{"id":"a46c0a990bc1bd6ee1d8456561dfecc1151127a3","author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"date":"2019-06-05 07:23:42.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3225c759f0c20c111e8b710d8a092c86f30f9148","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-06-05 08:12:10.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"ed27722479d705d8274e2f6deef25d8e65f45fd4","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-06-05 08:14:34.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n@Manuel: Thanks for your contribution. It is however not necessary for you to review your own patch, we assume that you are o.k. with what you submit.\n\nAlso please take a look at https://docs.openstack.org/infra/manual/developers.html#updating-a-change for how to update a patch, that would have been easier than abandoning your other patch.\n\nFinally I amended the commit message for you, you need to have an empty line between the header and the remaining description.\n\nRe-using previous +2 to approve.","accounts_in_message":[],"_revision_number":2},{"id":"d92e0c157d6673f19bb42fae8874e7ca86da5aef","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-05 09:08:20.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-chef-delivery http://logs.openstack.org/86/663086/2/check/openstack-chef-delivery/8613462/ : SUCCESS in 4m 50s\n- openstack-chef-integration http://logs.openstack.org/86/663086/2/check/openstack-chef-integration/223b38b/ : SUCCESS in 47m 51s","accounts_in_message":[],"_revision_number":2},{"id":"992261936e8af8fa0b6938abcd4056ac8a08661b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-05 09:08:32.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"6c1c427db41802b1edf26b3e827a66235c33634e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-05 10:02:52.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"c5025c0bef0748d2eda225b74973fc5f596fbf41","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-05 10:02:52.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-chef-delivery http://logs.openstack.org/86/663086/2/gate/openstack-chef-delivery/21757c0/ : SUCCESS in 5m 27s\n- openstack-chef-integration http://logs.openstack.org/86/663086/2/gate/openstack-chef-integration/c10639f/ : SUCCESS in 49m 42s","accounts_in_message":[],"_revision_number":2},{"id":"f296b8ff1d7c296d5ef2ff96b25467a66ce512fe","author":{"_account_id":30309,"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","username":"t0rrant"},"date":"2019-06-05 10:44:42.000000000","message":"Patch Set 1:\n\n\u003e @Manuel: Thanks for your contribution. It is however not necessary\n \u003e for you to review your own patch, we assume that you are o.k. with\n \u003e what you submit.\n \u003e \n \u003e Also please take a look at https://docs.openstack.org/infra/manual/developers.html#updating-a-change\n \u003e for how to update a patch, that would have been easier than\n \u003e abandoning your other patch.\n \u003e \n \u003e Finally I amended the commit message for you, you need to have an\n \u003e empty line between the header and the remaining description.\n \u003e \n \u003e Re-using previous +2 to approve.\n\nThank you for your pointers! Still relatively new to this workflow.\n\nDo I need to do anything further for this to be merged into stable/queens branch?","accounts_in_message":[],"_revision_number":1},{"id":"0c1a8a7576bca6a5176ff8da160d81e1ee67c79b","author":{"_account_id":30309,"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","username":"t0rrant"},"date":"2019-06-05 10:50:48.000000000","message":"Patch Set 1:\n\nI\u0027ve seen that the admin endpoint drop has not been merged to any of the branches, however I would like the banner fix to be merged to stable/queens in the meantime, as it is not related to endpoint registration and the api recipe will always fail when running on a node which is not running the compute cookbook also.\n\nWhat would be a proper way of doing this?","accounts_in_message":[],"_revision_number":1}],"current_revision_number":2,"current_revision":"9c2757e528b273275b78cbdd13bd0af0842e8da8","revisions":{"6ca4d080636ebf528af5a94089c94c0d3173c2aa":{"kind":"REWORK","_number":1,"created":"2019-06-04 16:19:11.000000000","uploader":{"_account_id":30309,"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","username":"t0rrant"},"ref":"refs/changes/86/663086/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cookbook-openstack-block-storage","ref":"refs/changes/86/663086/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cookbook-openstack-block-storage refs/changes/86/663086/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cookbook-openstack-block-storage refs/changes/86/663086/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cookbook-openstack-block-storage refs/changes/86/663086/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cookbook-openstack-block-storage refs/changes/86/663086/1"}}},"commit":{"parents":[{"commit":"6b92f6968cf053e9764044b3fda1f446be481970","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-block-storage/commit/6b92f6968cf053e9764044b3fda1f446be481970"}]}],"author":{"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","date":"2019-06-04 16:18:58.000000000","tz":60},"committer":{"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","date":"2019-06-04 16:18:58.000000000","tz":60},"subject":"Removes admin endpoint references Also fixes wrong service type reference in for wsgi banner","message":"Removes admin endpoint references\nAlso fixes wrong service type reference in for wsgi banner\n\nChange-Id: I82c60b7c4efaa19459a3a0ab835eb4e48f8ee991\nSigned-off-by: Manuel Torrinha \u003cmanuel.torrinha@tecnico.ulisboa.pt\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-block-storage/commit/6ca4d080636ebf528af5a94089c94c0d3173c2aa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-block-storage/commit/6ca4d080636ebf528af5a94089c94c0d3173c2aa"}]},"branch":"refs/heads/master"},"9c2757e528b273275b78cbdd13bd0af0842e8da8":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-06-05 08:12:10.000000000","uploader":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"ref":"refs/changes/86/663086/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cookbook-openstack-block-storage","ref":"refs/changes/86/663086/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cookbook-openstack-block-storage refs/changes/86/663086/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cookbook-openstack-block-storage refs/changes/86/663086/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cookbook-openstack-block-storage refs/changes/86/663086/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cookbook-openstack-block-storage refs/changes/86/663086/2"}}},"commit":{"parents":[{"commit":"6b92f6968cf053e9764044b3fda1f446be481970","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-block-storage/commit/6b92f6968cf053e9764044b3fda1f446be481970"}]}],"author":{"name":"Manuel Torrinha","email":"manuel.torrinha@tecnico.ulisboa.pt","date":"2019-06-04 16:18:58.000000000","tz":60},"committer":{"name":"Jens Harbott (frickler)","email":"j.harbott@x-ion.de","date":"2019-06-05 08:12:06.000000000","tz":0},"subject":"Removes admin endpoint references","message":"Removes admin endpoint references\n\nAlso fixes wrong service type reference in for wsgi banner\n\nChange-Id: I82c60b7c4efaa19459a3a0ab835eb4e48f8ee991\nSigned-off-by: Manuel Torrinha \u003cmanuel.torrinha@tecnico.ulisboa.pt\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-block-storage/commit/9c2757e528b273275b78cbdd13bd0af0842e8da8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-block-storage/commit/9c2757e528b273275b78cbdd13bd0af0842e8da8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}