)]}'
{"id":"openstack%2Fcookbook-openstack-block-storage~672653","triplet_id":"openstack%2Fcookbook-openstack-block-storage~master~I225a30379820e6e033bcea987fbf1a4db33dbd3a","project":"openstack/cookbook-openstack-block-storage","branch":"master","topic":"prevent_vanilla_conf","hashtags":[],"change_id":"I225a30379820e6e033bcea987fbf1a4db33dbd3a","subject":"api: prevent installation of invalid apache2 conf file","status":"MERGED","created":"2019-07-25 07:44:08.000000000","updated":"2019-08-06 15:31:18.000000000","submitted":"2019-08-06 15:31:18.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"672653-1565105478559-dbce2513","meta_rev_id":"8d9522cfefd6e9230860f6a466accf1e23ebc86c","_number":672653,"virtual_id_number":672653,"owner":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},{"value":0,"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},{"value":2,"date":"2019-08-06 15:31:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":2,"date":"2019-08-06 12:54:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},{"value":0,"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},{"value":1,"date":"2019-08-06 14:31:39.000000000","_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-06 12:54:38.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2019-08-06 14:31:39.000000000","updated_by":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"reviewer":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"state":"REVIEWER"},{"updated":"2019-08-06 15:31:14.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"57fb4fe11b99b1568e5629a24cecd42e166c9a69","author":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"date":"2019-07-25 07:44:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b327db3af679b6485fa039750c7fd510ad6b48d8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-25 07:52:45.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-chef-delivery http://logs.openstack.org/53/672653/1/check/openstack-chef-delivery/ea7316e/ : FAILURE in 2m 45s\n- openstack-chef-integration http://logs.openstack.org/53/672653/1/check/openstack-chef-integration/12c1b24/ : POST_FAILURE in 2m 49s","accounts_in_message":[],"_revision_number":1},{"id":"f7530c6b7d390823673d22987fd8b003ff61bb71","author":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"date":"2019-07-25 14:56:53.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"024da3947c09a16d0d82f7562278c65dc48ab361","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-25 15:46:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-chef-delivery http://logs.openstack.org/53/672653/1/check/openstack-chef-delivery/cb557fc/ : SUCCESS in 6m 12s\n- openstack-chef-integration http://logs.openstack.org/53/672653/1/check/openstack-chef-integration/bf14213/ : SUCCESS in 47m 56s","accounts_in_message":[],"_revision_number":1},{"id":"c21e9eba28e34f91133fcbb15b8f5ce00d7d1be3","author":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"date":"2019-07-31 08:39:13.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"043cb09cc328f433f7787b5d00a8ca4943f0851d","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-08-06 11:13:44.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"d1ad13f9f9682358b189e9b12d3615acb6c3187d","author":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"date":"2019-08-06 11:16:58.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"939de022161665eb7f80ff5e71bfc48701bde8a2","author":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"date":"2019-08-06 11:21:18.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"b2bfcc1fa74db806f58f0242a600992f4636c84e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-06 12:30:02.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-chef-delivery https://logs.opendev.org/53/672653/2/check/openstack-chef-delivery/68359a1/ : SUCCESS in 6m 30s\n- openstack-chef-integration-ubuntu https://logs.opendev.org/53/672653/2/check/openstack-chef-integration-ubuntu/3bbfb8a/ : SUCCESS in 43m 31s\n- openstack-chef-integration-centos https://logs.opendev.org/53/672653/2/check/openstack-chef-integration-centos/b30c29f/ : SUCCESS in 59m 46s","accounts_in_message":[],"_revision_number":2},{"id":"ec23e92335ae83989c796e0051327b4258f9183b","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-08-06 12:54:38.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"c5e352139519ee01836a419664e05237e7dcba02","author":{"_account_id":19193,"name":"Christoph Albers","email":"c.albers@x-ion.de","username":"calbers"},"date":"2019-08-06 14:31:39.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"695d3975be14ff88cc9c4de3e68b12bdac28ad64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-06 14:31:53.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"dac5fef1b567155eb90cfa4452d9fe3d4d7052dc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-06 15:31:14.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-chef-delivery https://logs.opendev.org/53/672653/2/gate/openstack-chef-delivery/fb0c5cc/ : SUCCESS in 4m 31s\n- openstack-chef-integration-ubuntu https://logs.opendev.org/53/672653/2/gate/openstack-chef-integration-ubuntu/2c93def/ : SUCCESS in 56m 41s\n- openstack-chef-integration-centos https://logs.opendev.org/53/672653/2/gate/openstack-chef-integration-centos/6ddee3d/ : SUCCESS in 53m 16s","accounts_in_message":[],"_revision_number":2},{"id":"e56346aacd07b7999b8ba9bab4158d604fd3a775","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-06 15:31:18.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8c0d728d13dffeed1c6a9f51d0422230f2a24671","revisions":{"860d2c5d894bb28a10acef8108489e3a615e5046":{"kind":"REWORK","_number":1,"created":"2019-07-25 07:44:08.000000000","uploader":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"ref":"refs/changes/53/672653/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cookbook-openstack-block-storage","ref":"refs/changes/53/672653/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cookbook-openstack-block-storage refs/changes/53/672653/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cookbook-openstack-block-storage refs/changes/53/672653/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cookbook-openstack-block-storage refs/changes/53/672653/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cookbook-openstack-block-storage refs/changes/53/672653/1"}}},"commit":{"parents":[{"commit":"f2a4e0c7ee8d217a49ff82acd527bf1e2b10c600","subject":"Fixes to support fog-openstack-1.x","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-block-storage/commit/f2a4e0c7ee8d217a49ff82acd527bf1e2b10c600"}]}],"author":{"name":"Roger Luethi","email":"rl@patchworkscience.org","date":"2019-07-17 07:07:51.000000000","tz":120},"committer":{"name":"Roger Luethi","email":"rl@patchworkscience.org","date":"2019-07-25 07:43:53.000000000","tz":120},"subject":"api: prevent installation of invalid apache2 conf file","message":"api: prevent installation of invalid apache2 conf file\n\nIf apache is (re)starting while the chef-client installs the cinder-api\npackage, it may pick up the package-supplied cinder-wsgi apache2 conf\nfile before chef-client gets around to disabling it which may result in\napache2 failing due to a non-working configuration.\n\nThis changeset eliminates the race by creating an empty configuration\nfile before installing the software. The solution is based on the\nassumption that no reasonably configured package manager will overwrite\nan existing, user-created configuration file. The empty configuration\nfile is removed after package installation.\n\nbackport: queens\n\nChange-Id: I225a30379820e6e033bcea987fbf1a4db33dbd3a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-block-storage/commit/860d2c5d894bb28a10acef8108489e3a615e5046"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-block-storage/commit/860d2c5d894bb28a10acef8108489e3a615e5046"}]},"branch":"refs/heads/master"},"8c0d728d13dffeed1c6a9f51d0422230f2a24671":{"kind":"REWORK","_number":2,"created":"2019-08-06 11:16:58.000000000","uploader":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"ref":"refs/changes/53/672653/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cookbook-openstack-block-storage","ref":"refs/changes/53/672653/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cookbook-openstack-block-storage refs/changes/53/672653/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cookbook-openstack-block-storage refs/changes/53/672653/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cookbook-openstack-block-storage refs/changes/53/672653/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cookbook-openstack-block-storage refs/changes/53/672653/2"}}},"commit":{"parents":[{"commit":"f2a4e0c7ee8d217a49ff82acd527bf1e2b10c600","subject":"Fixes to support fog-openstack-1.x","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-block-storage/commit/f2a4e0c7ee8d217a49ff82acd527bf1e2b10c600"}]}],"author":{"name":"Roger Luethi","email":"rl@patchworkscience.org","date":"2019-07-17 07:07:51.000000000","tz":120},"committer":{"name":"Roger Luethi","email":"rl@patchworkscience.org","date":"2019-08-06 11:14:21.000000000","tz":120},"subject":"api: prevent installation of invalid apache2 conf file","message":"api: prevent installation of invalid apache2 conf file\n\nIf apache is (re)starting while the chef-client installs the cinder-api\npackage, it may pick up the package-supplied cinder-wsgi apache2 conf\nfile before chef-client gets around to disabling it which may result in\napache2 failing due to a non-working configuration.\n\nThis changeset eliminates the race by creating an empty configuration\nfile before installing the software. The solution is based on the\nassumption that no reasonably configured package manager will overwrite\nan existing, user-created configuration file. The empty configuration\nfile is left in place to avoid its creation and removal during every\nrecipe run.\n\nbackport: queens\n\nChange-Id: I225a30379820e6e033bcea987fbf1a4db33dbd3a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-block-storage/commit/8c0d728d13dffeed1c6a9f51d0422230f2a24671"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cookbook-openstack-block-storage/commit/8c0d728d13dffeed1c6a9f51d0422230f2a24671"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}