)]}'
{"libraries/matchers.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"fae3ed1ab7f6bd2bb4153f30eafb17b1ca1400b2","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        match \u003d false"},{"line_number":43,"context_line":"        section_content \u003d \u0027\u0027"},{"line_number":44,"context_line":"        content.split(\"\\n\").each do |line|"},{"line_number":45,"context_line":"          if line \u003d~ /^[ \\t]*\\[#{section}\\]/"},{"line_number":46,"context_line":"            match \u003d true"},{"line_number":47,"context_line":"            next"},{"line_number":48,"context_line":"          end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3a961159_03d3b2d6","line":45,"updated":"2014-12-10 17:56:04.000000000","message":"Maybe some DRY here.  This basic regx is used 3 times.  Maybe define a helper method that would handle this, is_section.    Since we don\u0027t allow tabs in our source/template, it should be ok to not worry about that here.\n\ndef is_section?( line, section \u003d \u0027.*\u0027)\n   line \u003d~ /^[ \\t]*\\[#{section}\\]/","commit_id":"fc2004c7986240b407d443ee323f5dc1bebb8e29"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"00e93b23aec4dabaf6f538f722c42202a7ccae0e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  # render_config_file(path).with_section_content("},{"line_number":20,"context_line":"  #   \u0027section1\u0027, \u0027option1 \u003d value1\u0027)"},{"line_number":21,"context_line":"  # render_config_file(path).with_section_content("},{"line_number":22,"context_line":"  #   \u0027section1\u0027, /^option2 \u003d value2$/)"},{"line_number":23,"context_line":"  #"},{"line_number":24,"context_line":"  def render_config_file(path)"},{"line_number":25,"context_line":"    RenderConfigFileMatcher.new(path)"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3a961159_29bf81ab","line":22,"updated":"2014-12-11 17:22:04.000000000","message":"Just a thought.  but having callers need to put in the basic   begin line and end line  /~ xxxx  $/  is very ugly and makes the specs harder to read.     Maybe we should consider that the default case here?\n\nbut make it override-able like:   \ndef with_section_content(section, expected_content,  line_boundary\u003dtrue)\n\nexpected_content \u003d /^#expected_content$/ if line_boundary\n@expected_content \u003d expected_content","commit_id":"e5b6310ee8df70f5f2870fdbab2bcbde091d4212"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"7ef3b6d3096f5ce207e66be0ce837a5b8f8af04b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  # render_config_file(path).with_section_content("},{"line_number":20,"context_line":"  #   \u0027section1\u0027, \u0027option1 \u003d value1\u0027)"},{"line_number":21,"context_line":"  # render_config_file(path).with_section_content("},{"line_number":22,"context_line":"  #   \u0027section1\u0027, /^option2 \u003d value2$/)"},{"line_number":23,"context_line":"  #"},{"line_number":24,"context_line":"  def render_config_file(path)"},{"line_number":25,"context_line":"    RenderConfigFileMatcher.new(path)"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3a961159_d5dbe04c","line":22,"in_reply_to":"3a961159_29bf81ab","updated":"2014-12-12 01:41:10.000000000","message":"Mark, I think with_section_content should follow the with_content method, I don\u0027t think  this is necessary since the regx lines already in some of the spec files. And it will be more clear when users want to match lines like this `/^option\u003dvalue[1-9]+$/`.","commit_id":"e5b6310ee8df70f5f2870fdbab2bcbde091d4212"}],"metadata.rb":[{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"1d9e79b70dff2534278a5add10df60e164d0d3c3","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"depends          \u0027apt\u0027, \u0027\u003e\u003d 2.3.8\u0027"},{"line_number":20,"context_line":"depends          \u0027database\u0027, \u0027\u003e\u003d 2.0.0\u0027"},{"line_number":21,"context_line":"depends          \u0027mysql\u0027, \u0027\u003c\u003d 5.6.1\u0027"},{"line_number":22,"context_line":"depends          \u0027yum\u0027, \u0027\u003e\u003d 3.1.4\u0027"},{"line_number":23,"context_line":"depends          \u0027yum-epel\u0027, \u0027\u003e\u003d 0.3.4\u0027"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3a961159_4aeedf8c","line":21,"updated":"2014-12-17 09:50:12.000000000","message":"maybe it would be better to lock this to \u0027\u003c 6.0.0\u0027 to get all bugfix updates for 5?","commit_id":"ae7b608016b7e956b1823adb9ff3e4c6f44596fd"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"68eda91068127409314fc6853b87c84b0a7dfa52","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"depends          \u0027apt\u0027, \u0027\u003e\u003d 2.3.8\u0027"},{"line_number":20,"context_line":"depends          \u0027database\u0027, \u0027\u003e\u003d 2.0.0\u0027"},{"line_number":21,"context_line":"depends          \u0027mysql\u0027, \u0027\u003c\u003d 5.6.1\u0027"},{"line_number":22,"context_line":"depends          \u0027yum\u0027, \u0027\u003e\u003d 3.1.4\u0027"},{"line_number":23,"context_line":"depends          \u0027yum-epel\u0027, \u0027\u003e\u003d 0.3.4\u0027"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3a961159_ad12fd06","line":21,"in_reply_to":"3a961159_4aeedf8c","updated":"2014-12-17 10:05:53.000000000","message":"yes, you are right.","commit_id":"ae7b608016b7e956b1823adb9ff3e4c6f44596fd"}]}