)]}'
{"libraries/endpoints.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"98e33714c58eccfde25ef512a95715a08addf171","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    nil"},{"line_number":136,"context_line":"  end"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"  def specific_endpoint(type, name)"},{"line_number":139,"context_line":"    node[\u0027openstack\u0027][\u0027endpoints\u0027][type][name]"},{"line_number":140,"context_line":"  rescue"},{"line_number":141,"context_line":"    endpoint_for(name)"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1a930d6b_6eef46b1","line":138,"updated":"2015-01-21 20:23:18.000000000","message":"Please add some function comments here, include the valid possible types.","commit_id":"bcb3f48ec265283b4427ab3fd71b9b992ce69a2b"},{"author":{"_account_id":1298,"name":"Ken Thomas","email":"krt@yahoo-inc.com","username":"krt"},"change_message_id":"7d3a048e66d75c6a0fed1e9381db396e7841c0d0","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    nil"},{"line_number":136,"context_line":"  end"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"  def specific_endpoint(type, name)"},{"line_number":139,"context_line":"    node[\u0027openstack\u0027][\u0027endpoints\u0027][type][name]"},{"line_number":140,"context_line":"  rescue"},{"line_number":141,"context_line":"    endpoint_for(name)"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1a930d6b_0e25e2c1","line":138,"in_reply_to":"1a930d6b_6eef46b1","updated":"2015-01-21 20:31:16.000000000","message":"Will do.","commit_id":"bcb3f48ec265283b4427ab3fd71b9b992ce69a2b"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"98e33714c58eccfde25ef512a95715a08addf171","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"  def specific_endpoint(type, name)"},{"line_number":139,"context_line":"    node[\u0027openstack\u0027][\u0027endpoints\u0027][type][name]"},{"line_number":140,"context_line":"  rescue"},{"line_number":141,"context_line":"    endpoint_for(name)"},{"line_number":142,"context_line":"  end"},{"line_number":143,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1a930d6b_0ef8827b","line":140,"updated":"2015-01-21 20:23:18.000000000","message":"would using   an \"unless  node[....][type].key?\"  check  be cleaner then a rescue approach?","commit_id":"bcb3f48ec265283b4427ab3fd71b9b992ce69a2b"},{"author":{"_account_id":1298,"name":"Ken Thomas","email":"krt@yahoo-inc.com","username":"krt"},"change_message_id":"7d3a048e66d75c6a0fed1e9381db396e7841c0d0","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"  def specific_endpoint(type, name)"},{"line_number":139,"context_line":"    node[\u0027openstack\u0027][\u0027endpoints\u0027][type][name]"},{"line_number":140,"context_line":"  rescue"},{"line_number":141,"context_line":"    endpoint_for(name)"},{"line_number":142,"context_line":"  end"},{"line_number":143,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1a930d6b_ce3bdae9","line":140,"in_reply_to":"1a930d6b_0ef8827b","updated":"2015-01-21 20:31:16.000000000","message":"I\u0027m open to suggestions. I\u0027m new to ruby and I was just following the convention used in endpoint_for name.","commit_id":"bcb3f48ec265283b4427ab3fd71b9b992ce69a2b"},{"author":{"_account_id":1298,"name":"Ken Thomas","email":"krt@yahoo-inc.com","username":"krt"},"change_message_id":"b54b93572a0a28c6389a7ff093cf5d0aaa11bb75","unresolved":false,"context_lines":[{"line_number":140,"context_line":"  # general endpoint."},{"line_number":141,"context_line":"  def specific_endpoint(type, name)"},{"line_number":142,"context_line":"    node[\u0027openstack\u0027][\u0027endpoints\u0027][type][name]"},{"line_number":143,"context_line":"  rescue"},{"line_number":144,"context_line":"    endpoint_for(name)"},{"line_number":145,"context_line":"  end"},{"line_number":146,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1a930d6b_8cf9da4f","line":143,"updated":"2015-01-21 21:42:46.000000000","message":"I\u0027m still open to using \"unless node...\" here although I kind of like using the rescue though for two reasons.\n\n1. I don\u0027t have to specify node[\u0027openstack\u0027][\u0027endpoints\u0027][type] twice. Once for the unless .. key? and once for the return value.\n\n2. It matches the approach in endpoint_for above.\n\nThat said, I\u0027m a ruby newbie so I\u0027m happy to follow your suggestions.","commit_id":"71d70da7f768a288bc585ad9af3e462be3568370"},{"author":{"_account_id":1298,"name":"Ken Thomas","email":"krt@yahoo-inc.com","username":"krt"},"change_message_id":"87746414206197bb880f1e8a66affbd0be7328f3","unresolved":false,"context_lines":[{"line_number":140,"context_line":"  # general endpoint."},{"line_number":141,"context_line":"  def specific_endpoint(type, name)"},{"line_number":142,"context_line":"    node[\u0027openstack\u0027][\u0027endpoints\u0027][type][name]"},{"line_number":143,"context_line":"  rescue"},{"line_number":144,"context_line":"    endpoint_for(name)"},{"line_number":145,"context_line":"  end"},{"line_number":146,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1a930d6b_42933ba3","line":143,"updated":"2015-01-21 22:31:43.000000000","message":"I\u0027m still open to using \"unless node...\" here although I kind of like using the rescue though for two reasons.\n\n1. I don\u0027t have to specify node[\u0027openstack\u0027][\u0027endpoints\u0027][type] twice. Once for the unless .. key? and once for the return value.\n\n2. It matches the approach in endpoint_for above.\n\nThat said, I\u0027m a ruby newbie so I\u0027m happy to follow your suggestions.","commit_id":"0bd89832123afa196fe1c5fbd5a6e560616fe128"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"aa484a31ae620f3dfe139737902e656bf13d1f75","unresolved":false,"context_lines":[{"line_number":140,"context_line":"  # general endpoint."},{"line_number":141,"context_line":"  def specific_endpoint(type, name)"},{"line_number":142,"context_line":"    node[\u0027openstack\u0027][\u0027endpoints\u0027][type][name]"},{"line_number":143,"context_line":"  rescue"},{"line_number":144,"context_line":"    endpoint_for(name)"},{"line_number":145,"context_line":"  end"},{"line_number":146,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1a930d6b_2272af7c","line":143,"in_reply_to":"1a930d6b_42933ba3","updated":"2015-01-21 22:40:08.000000000","message":"yeah, I\u0027m no ruby expert, so using what\u0027s been working for a long time sounds ok to me.","commit_id":"0bd89832123afa196fe1c5fbd5a6e560616fe128"}]}