)]}'
{"libraries/endpoints.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"0701141f8035d42b0dfac5a7a8c18e512adc937c","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    nil"},{"line_number":136,"context_line":"  end"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"  # Attempt to find the specific endpoint (\u0027internal\u0027, \u0027admin\u0027, or"},{"line_number":139,"context_line":"  # \u0027public\u0027) for the given name.  If it\u0027s not found, then return the"},{"line_number":140,"context_line":"  # general endpoint."},{"line_number":141,"context_line":"  def specific_endpoint(type, name)"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa81d914_9371267a","line":138,"updated":"2015-01-27 19:39:49.000000000","message":"maybe  \"... specific endpoint type (.....\"   to tie that to the parm better.","commit_id":"4f68cb09a70d06273b73427eb0268c10eeedb18e"},{"author":{"_account_id":1298,"name":"Ken Thomas","email":"krt@yahoo-inc.com","username":"krt"},"change_message_id":"9c59de2e3ebce8f758bf8b13f7e2cd3494459d83","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    nil"},{"line_number":136,"context_line":"  end"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"  # Attempt to find the specific endpoint (\u0027internal\u0027, \u0027admin\u0027, or"},{"line_number":139,"context_line":"  # \u0027public\u0027) for the given name.  If it\u0027s not found, then return the"},{"line_number":140,"context_line":"  # general endpoint."},{"line_number":141,"context_line":"  def specific_endpoint(type, name)"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa81d914_73b592cc","line":138,"in_reply_to":"fa81d914_9371267a","updated":"2015-01-27 19:49:55.000000000","message":"Can do","commit_id":"4f68cb09a70d06273b73427eb0268c10eeedb18e"},{"author":{"_account_id":1298,"name":"Ken Thomas","email":"krt@yahoo-inc.com","username":"krt"},"change_message_id":"7f388863dee157d4d9882357a68d5c0bab717be8","unresolved":false,"context_lines":[{"line_number":139,"context_line":"  # \u0027public\u0027) for the given name.  If it\u0027s not found, then return the"},{"line_number":140,"context_line":"  # general endpoint."},{"line_number":141,"context_line":"  def specific_endpoint(type, name)"},{"line_number":142,"context_line":"    if node[\u0027openstack\u0027][\u0027endpoints\u0027][type].include? name"},{"line_number":143,"context_line":"      return node[\u0027openstack\u0027][\u0027endpoints\u0027][type][name]"},{"line_number":144,"context_line":"    end"},{"line_number":145,"context_line":"    # There may have been a subhash for the specified type, but it"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa81d914_b091c054","line":142,"updated":"2015-01-27 19:15:00.000000000","message":"I tried a couple of ways to fix this and this is what seemed to be the most straight forward. As a ruby newbie, I would appreciate any advice on how to improve this.","commit_id":"4f68cb09a70d06273b73427eb0268c10eeedb18e"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"0701141f8035d42b0dfac5a7a8c18e512adc937c","unresolved":false,"context_lines":[{"line_number":140,"context_line":"  # general endpoint."},{"line_number":141,"context_line":"  def specific_endpoint(type, name)"},{"line_number":142,"context_line":"    if node[\u0027openstack\u0027][\u0027endpoints\u0027][type].include? name"},{"line_number":143,"context_line":"      return node[\u0027openstack\u0027][\u0027endpoints\u0027][type][name]"},{"line_number":144,"context_line":"    end"},{"line_number":145,"context_line":"    # There may have been a subhash for the specified type, but it"},{"line_number":146,"context_line":"    # didn\u0027t have the name we were looking for (and didn\u0027t throw"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa81d914_b07380e6","line":143,"updated":"2015-01-27 19:39:49.000000000","message":"I think this could be done with a simple \"else\"\n\nif node....\n\n     node....[type][name]\n\nelse\n\n    endpoint_for(name)\n\nend\n\nthe last value used will be returned","commit_id":"4f68cb09a70d06273b73427eb0268c10eeedb18e"},{"author":{"_account_id":1298,"name":"Ken Thomas","email":"krt@yahoo-inc.com","username":"krt"},"change_message_id":"9c59de2e3ebce8f758bf8b13f7e2cd3494459d83","unresolved":false,"context_lines":[{"line_number":140,"context_line":"  # general endpoint."},{"line_number":141,"context_line":"  def specific_endpoint(type, name)"},{"line_number":142,"context_line":"    if node[\u0027openstack\u0027][\u0027endpoints\u0027][type].include? name"},{"line_number":143,"context_line":"      return node[\u0027openstack\u0027][\u0027endpoints\u0027][type][name]"},{"line_number":144,"context_line":"    end"},{"line_number":145,"context_line":"    # There may have been a subhash for the specified type, but it"},{"line_number":146,"context_line":"    # didn\u0027t have the name we were looking for (and didn\u0027t throw"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa81d914_93d046f9","line":143,"in_reply_to":"fa81d914_b07380e6","updated":"2015-01-27 19:49:55.000000000","message":"Can do. The rescue will still need to be there since the if conditional can throw an error.","commit_id":"4f68cb09a70d06273b73427eb0268c10eeedb18e"}]}