)]}'
{"attributes/messaging.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"d9611e2056389192be92747877ab02893be55482","unresolved":false,"context_lines":[{"line_number":80,"context_line":"}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"rabbit_defaults \u003d {"},{"line_number":83,"context_line":"  rabbit_max_retries: 0,"},{"line_number":84,"context_line":"  rabbit_retry_interval: 1,"},{"line_number":85,"context_line":"  userid: node[\u0027openstack\u0027][\u0027mq\u0027][\u0027user\u0027],"},{"line_number":86,"context_line":"  vhost: node[\u0027openstack\u0027][\u0027mq\u0027][\u0027vhost\u0027],"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9aa53dc9_e179f4fd","line":83,"updated":"2015-04-07 14:27:39.000000000","message":"I guess if your going to add these, unless good case against it, I would rather see attributes for these values.\n\nAnd then think about adding a simple spec test to check they are setup correctly in the rabbit case.","commit_id":"d2625ce58b2ab86dd13a5b50e98e2e44cf5e3688"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"b30666b7244a2214c27617a29a57c4e31d77cc25","unresolved":false,"context_lines":[{"line_number":80,"context_line":"}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"rabbit_defaults \u003d {"},{"line_number":83,"context_line":"  rabbit_max_retries: 0,"},{"line_number":84,"context_line":"  rabbit_retry_interval: 1,"},{"line_number":85,"context_line":"  userid: node[\u0027openstack\u0027][\u0027mq\u0027][\u0027user\u0027],"},{"line_number":86,"context_line":"  vhost: node[\u0027openstack\u0027][\u0027mq\u0027][\u0027vhost\u0027],"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9aa53dc9_4c5679d3","line":83,"in_reply_to":"9aa53dc9_e179f4fd","updated":"2015-04-08 02:35:19.000000000","message":"Yep. At first, I added some attributes for them. But after I see qpid relate options(line 68), I changed to like this. I will add some UT for those change.","commit_id":"d2625ce58b2ab86dd13a5b50e98e2e44cf5e3688"}],"metadata.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"d9611e2056389192be92747877ab02893be55482","unresolved":false,"context_lines":[{"line_number":4,"context_line":"license          \u0027Apache 2.0\u0027"},{"line_number":5,"context_line":"description      \u0027Common OpenStack attributes, libraries and recipes.\u0027"},{"line_number":6,"context_line":"long_description IO.read(File.join(File.dirname(__FILE__), \u0027README.md\u0027))"},{"line_number":7,"context_line":"version          \u002711.1.1\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"recipe           \u0027openstack-common\u0027, \u0027Installs/Configures common recipes\u0027"},{"line_number":10,"context_line":"recipe           \u0027openstack-common::set_endpoints_by_interface\u0027, \u0027Set endpoints by interface\u0027"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9aa53dc9_41d9c0f2","line":7,"updated":"2015-04-07 14:27:39.000000000","message":"Since this is not a fix, but an enhancement that another cookbook will want, should probably bump the minor instead. \n11.2.0.\n\nBumping the fix level does not really make sense for the master development release, it\u0027s mainly used for the stable branches.","commit_id":"d2625ce58b2ab86dd13a5b50e98e2e44cf5e3688"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"6c4382c98a2b8a590852ab38e5c4dadd2b9a8b9d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"license          \u0027Apache 2.0\u0027"},{"line_number":5,"context_line":"description      \u0027Common OpenStack attributes, libraries and recipes.\u0027"},{"line_number":6,"context_line":"long_description IO.read(File.join(File.dirname(__FILE__), \u0027README.md\u0027))"},{"line_number":7,"context_line":"version          \u002711.1.1\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"recipe           \u0027openstack-common\u0027, \u0027Installs/Configures common recipes\u0027"},{"line_number":10,"context_line":"recipe           \u0027openstack-common::set_endpoints_by_interface\u0027, \u0027Set endpoints by interface\u0027"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9aa53dc9_0f906342","line":7,"in_reply_to":"9aa53dc9_41d9c0f2","updated":"2015-04-08 03:46:16.000000000","message":"Done","commit_id":"d2625ce58b2ab86dd13a5b50e98e2e44cf5e3688"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"a1a0e5a79ccbef91d8d7e66c70b825a5a321eda1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"license          \u0027Apache 2.0\u0027"},{"line_number":5,"context_line":"description      \u0027Common OpenStack attributes, libraries and recipes.\u0027"},{"line_number":6,"context_line":"long_description IO.read(File.join(File.dirname(__FILE__), \u0027README.md\u0027))"},{"line_number":7,"context_line":"version          \u002711.1.1\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"recipe           \u0027openstack-common\u0027, \u0027Installs/Configures common recipes\u0027"},{"line_number":10,"context_line":"recipe           \u0027openstack-common::set_endpoints_by_interface\u0027, \u0027Set endpoints by interface\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9aa53dc9_0f5f43e6","line":7,"updated":"2015-04-08 03:26:43.000000000","message":"you not address Mark\u0027s comments","commit_id":"85454a28f83dcb10f63d795fea9ba5e8c06b8e15"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"3f2afa220d41709a707a76ce8457ef846a4d336e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"license          \u0027Apache 2.0\u0027"},{"line_number":5,"context_line":"description      \u0027Common OpenStack attributes, libraries and recipes.\u0027"},{"line_number":6,"context_line":"long_description IO.read(File.join(File.dirname(__FILE__), \u0027README.md\u0027))"},{"line_number":7,"context_line":"version          \u002711.1.1\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"recipe           \u0027openstack-common\u0027, \u0027Installs/Configures common recipes\u0027"},{"line_number":10,"context_line":"recipe           \u0027openstack-common::set_endpoints_by_interface\u0027, \u0027Set endpoints by interface\u0027"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9aa53dc9_cf995b70","line":7,"in_reply_to":"9aa53dc9_0f5f43e6","updated":"2015-04-08 03:43:23.000000000","message":"Done","commit_id":"85454a28f83dcb10f63d795fea9ba5e8c06b8e15"}],"spec/default_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"0d5a59ccd1b2962d3fcf8e47a28107a916c04f7a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    it \u0027enables rabbit ssl version for all services\u0027 do"},{"line_number":81,"context_line":"      node.set[\u0027openstack\u0027][\u0027mq\u0027][\u0027rabbitmq\u0027][\u0027kombu_ssl_version\u0027] \u003d \u0027TLSv1.2\u0027"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"      %w{bare-metal block-storage compute database image telemetry network orchestration}.each do |svc|"},{"line_number":84,"context_line":"        expect(chef_run.node[\u0027openstack\u0027][\u0027mq\u0027][svc][\u0027rabbit\u0027][\u0027kombu_ssl_version\u0027]).to eq(\u0027TLSv1.2\u0027)"},{"line_number":85,"context_line":"      end"},{"line_number":86,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"7aaa499b_35a9297c","line":83,"updated":"2015-04-14 15:36:52.000000000","message":"dry","commit_id":"197a4fbf59a9268f1e0818ba79cd29c609e98fb9"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"0d5a59ccd1b2962d3fcf8e47a28107a916c04f7a","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    end"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    it \u0027set rabbit_max_retries to 0 for all services\u0027 do"},{"line_number":89,"context_line":"      %w{bare-metal block-storage compute database image telemetry network orchestration}.each do |svc|"},{"line_number":90,"context_line":"        expect(chef_run.node[\u0027openstack\u0027][\u0027mq\u0027][svc][\u0027rabbit\u0027][\u0027rabbit_max_retries\u0027]).to eq(0)"},{"line_number":91,"context_line":"      end"},{"line_number":92,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"7aaa499b_55aef585","line":89,"updated":"2015-04-14 15:36:52.000000000","message":"DRY, please create a constant to test the https://github.com/stackforge/cookbook-openstack-common/blob/master/attributes/messaging.rb#L37 in the \ntop of this spec:\n\nlet(:mq_services) { %w{bare-metal block-storage compute database image telemetry network orchestration} }","commit_id":"197a4fbf59a9268f1e0818ba79cd29c609e98fb9"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"be978866a845966468b0eb41d35dddf0682e4066","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    end"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    it \u0027set rabbit_max_retries to 0 for all services\u0027 do"},{"line_number":89,"context_line":"      %w{bare-metal block-storage compute database image telemetry network orchestration}.each do |svc|"},{"line_number":90,"context_line":"        expect(chef_run.node[\u0027openstack\u0027][\u0027mq\u0027][svc][\u0027rabbit\u0027][\u0027rabbit_max_retries\u0027]).to eq(0)"},{"line_number":91,"context_line":"      end"},{"line_number":92,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"7aaa499b_e5cad36d","line":89,"in_reply_to":"7aaa499b_55aef585","updated":"2015-04-15 09:20:10.000000000","message":"Do you mean use this constant(mq_service) to replace those list ?","commit_id":"197a4fbf59a9268f1e0818ba79cd29c609e98fb9"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"0d5a59ccd1b2962d3fcf8e47a28107a916c04f7a","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    end"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    it \u0027set rabbit_retry_interval to 1 for all services\u0027 do"},{"line_number":95,"context_line":"      %w{bare-metal block-storage compute database image telemetry network orchestration}.each do |svc|"},{"line_number":96,"context_line":"        expect(chef_run.node[\u0027openstack\u0027][\u0027mq\u0027][svc][\u0027rabbit\u0027][\u0027rabbit_retry_interval\u0027]).to eq(1)"},{"line_number":97,"context_line":"      end"},{"line_number":98,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"7aaa499b_15b74dd9","line":95,"updated":"2015-04-14 15:36:52.000000000","message":"dry","commit_id":"197a4fbf59a9268f1e0818ba79cd29c609e98fb9"}]}