)]}'
{".rubocop.yml":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"a67ebac2aa60755d77543bbef1b6462caa46bab6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  MinSize: 3"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"MethodLength:"},{"line_number":33,"context_line":"  Max: 15"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5afe65bd_c64fb269","line":33,"updated":"2015-06-04 14:29:16.000000000","message":"what is the change here?  It might be my fault in that I might have checked in the todo with win cr/lf line endings.","commit_id":"7091b3da4edf45431b7f87a38e6384539c463dc0"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"d51870be1d30b4f26ae040e9771a5ab03d5bfbe9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  MinSize: 3"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"MethodLength:"},{"line_number":33,"context_line":"  Max: 15"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5afe65bd_e644eeb7","line":33,"in_reply_to":"5afe65bd_c64fb269","updated":"2015-06-04 14:45:57.000000000","message":"the change is just the newline","commit_id":"7091b3da4edf45431b7f87a38e6384539c463dc0"}],".rubocop_todo.yml":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"a67ebac2aa60755d77543bbef1b6462caa46bab6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# This configuration was generated by `rubocop --auto-gen-config`"},{"line_number":2,"context_line":"# on 2015-06-04 12:04:40 +0200 using RuboCop version 0.28.0."},{"line_number":3,"context_line":"# The point is for the user to remove these configuration records"},{"line_number":4,"context_line":"# one by one as the offenses are removed from the code base."},{"line_number":5,"context_line":"# Note that changes in the inspected code, or installation of new"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5afe65bd_c31a047d","line":2,"updated":"2015-06-04 14:29:16.000000000","message":"humm your not using 0.29.1 for rubocop?","commit_id":"7091b3da4edf45431b7f87a38e6384539c463dc0"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"d51870be1d30b4f26ae040e9771a5ab03d5bfbe9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# This configuration was generated by `rubocop --auto-gen-config`"},{"line_number":2,"context_line":"# on 2015-06-04 12:04:40 +0200 using RuboCop version 0.28.0."},{"line_number":3,"context_line":"# The point is for the user to remove these configuration records"},{"line_number":4,"context_line":"# one by one as the offenses are removed from the code base."},{"line_number":5,"context_line":"# Note that changes in the inspected code, or installation of new"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5afe65bd_266d6631","line":2,"in_reply_to":"5afe65bd_c31a047d","updated":"2015-06-04 14:45:57.000000000","message":"i used the rubocop from chefdk 0.6.0 which contains rubocop 0.28.0 for me (on mac)","commit_id":"7091b3da4edf45431b7f87a38e6384539c463dc0"}],"Berksfile":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"a67ebac2aa60755d77543bbef1b6462caa46bab6","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"metadata"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# cookbook for testing database provider: "},{"line_number":6,"context_line":"cookbook \u0027test-openstack-common-database\u0027,"},{"line_number":7,"context_line":"  path: \u0027spec/cookbooks/test-openstack-common-database\u0027"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"5afe65bd_230c3840","line":5,"updated":"2015-06-04 14:29:16.000000000","message":"space?","commit_id":"7091b3da4edf45431b7f87a38e6384539c463dc0"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"d51870be1d30b4f26ae040e9771a5ab03d5bfbe9","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"metadata"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# cookbook for testing database provider: "},{"line_number":6,"context_line":"cookbook \u0027test-openstack-common-database\u0027,"},{"line_number":7,"context_line":"  path: \u0027spec/cookbooks/test-openstack-common-database\u0027"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"5afe65bd_a95487fe","line":5,"in_reply_to":"5afe65bd_230c3840","updated":"2015-06-04 14:45:57.000000000","message":":(","commit_id":"7091b3da4edf45431b7f87a38e6384539c463dc0"}],"attributes/database.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"a67ebac2aa60755d77543bbef1b6462caa46bab6","unresolved":false,"context_lines":[{"line_number":73,"context_line":"# ******************** Database Endpoint **************************************"},{"line_number":74,"context_line":"# For mysql specify \u0027localhost\u0027 instead of 127.0.0.1 b/c first of all when"},{"line_number":75,"context_line":"# 127.0.0.1 is specified, the client will try to create a TCP"},{"line_number":76,"context_line":"# connection to 127.0.0.1:3306 and mysql doesn\u0027t have to listen"},{"line_number":77,"context_line":"# on 127.0.0.1 but with \u0027localhost\u0027 mysql will be using unix sock"},{"line_number":78,"context_line":"# to connect to server."},{"line_number":79,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027host\u0027] \u003d \u0027127.0.0.1\u0027"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"5afe65bd_068f0a76","line":76,"updated":"2015-06-04 14:29:16.000000000","message":"I guess I still a bit confused.  Doesn\u0027t our ops-database cookbook tell mysql server to listen on 127.0.0.1 by default?   So, the default path is fine.  But your talking about a more complex setup?   Maybe these types of good comments need to be pushed up into the ReadMe?","commit_id":"7091b3da4edf45431b7f87a38e6384539c463dc0"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"d51870be1d30b4f26ae040e9771a5ab03d5bfbe9","unresolved":false,"context_lines":[{"line_number":73,"context_line":"# ******************** Database Endpoint **************************************"},{"line_number":74,"context_line":"# For mysql specify \u0027localhost\u0027 instead of 127.0.0.1 b/c first of all when"},{"line_number":75,"context_line":"# 127.0.0.1 is specified, the client will try to create a TCP"},{"line_number":76,"context_line":"# connection to 127.0.0.1:3306 and mysql doesn\u0027t have to listen"},{"line_number":77,"context_line":"# on 127.0.0.1 but with \u0027localhost\u0027 mysql will be using unix sock"},{"line_number":78,"context_line":"# to connect to server."},{"line_number":79,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027host\u0027] \u003d \u0027127.0.0.1\u0027"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"5afe65bd_e6018e07","line":76,"in_reply_to":"5afe65bd_068f0a76","updated":"2015-06-04 14:45:57.000000000","message":"you are right, this is quite confusing without any context. will remove it for now and add it in context with my percona patch","commit_id":"7091b3da4edf45431b7f87a38e6384539c463dc0"}],"providers/database.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9edf8af52b0820a6d180ee3c43cf26dfa02273ce","unresolved":false,"context_lines":[{"line_number":24,"context_line":"private"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def info"},{"line_number":27,"context_line":"  info \u003d node[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027]"},{"line_number":28,"context_line":"  service_info \u003d db new_resource.service"},{"line_number":29,"context_line":"  @host \u003d address(service_info) || address(info)"},{"line_number":30,"context_line":"  @port \u003d service_info[\u0027port\u0027].to_s || info[\u0027port\u0027].to_s"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1aca2d91_70cb1b1f","line":27,"updated":"2015-05-08 15:49:06.000000000","message":"I don\u0027t think we should be using this parent directly, it\u0027s just there to fill the child attributes for each service.","commit_id":"bb775b6f7248ab44a2facdd7eaf5e78054ae7880"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"429cc5a1bee9e0428c89f0adc308d47d5a649a5b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"private"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def info"},{"line_number":27,"context_line":"  info \u003d node[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027]"},{"line_number":28,"context_line":"  service_info \u003d db new_resource.service"},{"line_number":29,"context_line":"  @host \u003d address(service_info) || address(info)"},{"line_number":30,"context_line":"  @port \u003d service_info[\u0027port\u0027].to_s || info[\u0027port\u0027].to_s"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1aca2d91_6e169ca8","line":27,"in_reply_to":"1aca2d91_70cb1b1f","updated":"2015-05-08 16:26:42.000000000","message":"my idea was to use this attribute as a default fallback for host and port (like shown below) if not specified otherwise for the special service. this would allow the use of this attribute in recipes to set the host and port for a database for all services.","commit_id":"bb775b6f7248ab44a2facdd7eaf5e78054ae7880"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9edf8af52b0820a6d180ee3c43cf26dfa02273ce","unresolved":false,"context_lines":[{"line_number":26,"context_line":"def info"},{"line_number":27,"context_line":"  info \u003d node[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027]"},{"line_number":28,"context_line":"  service_info \u003d db new_resource.service"},{"line_number":29,"context_line":"  @host \u003d address(service_info) || address(info)"},{"line_number":30,"context_line":"  @port \u003d service_info[\u0027port\u0027].to_s || info[\u0027port\u0027].to_s"},{"line_number":31,"context_line":"  user_key \u003d node[\u0027openstack\u0027][\u0027db\u0027][\u0027root_user_key\u0027]"},{"line_number":32,"context_line":"  @super_password \u003d get_password \u0027user\u0027, user_key"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1aca2d91_707d5be6","line":29,"updated":"2015-05-08 15:49:06.000000000","message":"Is this fall back needed?  I don\u0027t think it was there before.\n\nIn old code this was just:\n\nhost \u003d info[\u0027host\u0027]","commit_id":"bb775b6f7248ab44a2facdd7eaf5e78054ae7880"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9edf8af52b0820a6d180ee3c43cf26dfa02273ce","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  info \u003d node[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027]"},{"line_number":28,"context_line":"  service_info \u003d db new_resource.service"},{"line_number":29,"context_line":"  @host \u003d address(service_info) || address(info)"},{"line_number":30,"context_line":"  @port \u003d service_info[\u0027port\u0027].to_s || info[\u0027port\u0027].to_s"},{"line_number":31,"context_line":"  user_key \u003d node[\u0027openstack\u0027][\u0027db\u0027][\u0027root_user_key\u0027]"},{"line_number":32,"context_line":"  @super_password \u003d get_password \u0027user\u0027, user_key"},{"line_number":33,"context_line":"  @type \u003d info[\u0027service_type\u0027]"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1aca2d91_907a37f0","line":30,"updated":"2015-05-08 15:49:06.000000000","message":"Is this fall back needed?  I don\u0027t think it was there before.\n\nport \u003d info[\u0027port\u0027].to_s      don\u0027t think the .to_s is needed it\u0027s already a string.","commit_id":"bb775b6f7248ab44a2facdd7eaf5e78054ae7880"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9edf8af52b0820a6d180ee3c43cf26dfa02273ce","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  @port \u003d service_info[\u0027port\u0027].to_s || info[\u0027port\u0027].to_s"},{"line_number":31,"context_line":"  user_key \u003d node[\u0027openstack\u0027][\u0027db\u0027][\u0027root_user_key\u0027]"},{"line_number":32,"context_line":"  @super_password \u003d get_password \u0027user\u0027, user_key"},{"line_number":33,"context_line":"  @type \u003d info[\u0027service_type\u0027]"},{"line_number":34,"context_line":"  @db_name \u003d info[\u0027db_name\u0027]"},{"line_number":35,"context_line":"  @user \u003d new_resource.user"},{"line_number":36,"context_line":"  @pass \u003d new_resource.pass"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1aca2d91_f0f4cb87","line":33,"updated":"2015-05-08 15:49:06.000000000","message":"Should be service_info?","commit_id":"bb775b6f7248ab44a2facdd7eaf5e78054ae7880"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9edf8af52b0820a6d180ee3c43cf26dfa02273ce","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  user_key \u003d node[\u0027openstack\u0027][\u0027db\u0027][\u0027root_user_key\u0027]"},{"line_number":32,"context_line":"  @super_password \u003d get_password \u0027user\u0027, user_key"},{"line_number":33,"context_line":"  @type \u003d info[\u0027service_type\u0027]"},{"line_number":34,"context_line":"  @db_name \u003d info[\u0027db_name\u0027]"},{"line_number":35,"context_line":"  @user \u003d new_resource.user"},{"line_number":36,"context_line":"  @pass \u003d new_resource.pass"},{"line_number":37,"context_line":"  db_types"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1aca2d91_9005977b","line":34,"updated":"2015-05-08 15:49:06.000000000","message":"should be service_info?","commit_id":"bb775b6f7248ab44a2facdd7eaf5e78054ae7880"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"1a3ed8780bf52adde02907f083d7b18e0040e5a0","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  when \u0027mysql\u0027, \u0027mariadb\u0027"},{"line_number":49,"context_line":"    @db_prov \u003d ::Chef::Provider::Database::Mysql"},{"line_number":50,"context_line":"    @user_prov \u003d ::Chef::Provider::Database::MysqlUser"},{"line_number":51,"context_line":"    @super_user \u003d \u0027root\u0027"},{"line_number":52,"context_line":"  else"},{"line_number":53,"context_line":"    fail \"Unsupported database type #{@type}\""},{"line_number":54,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"5ad58531_30ad2689","line":51,"updated":"2015-05-11 19:48:20.000000000","message":"There is a bug https://bugs.launchpad.net/openstack-chef/+bug/1381115 on the book to allow the super_user to be configured.  Seems like this refactoring is a good time to maybe also do that?  Just add as an optional resource variable and when not specified, use these defaults (root and postgres)","commit_id":"bb775b6f7248ab44a2facdd7eaf5e78054ae7880"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"e16f0eccc1429acc0802c9c6c01c325111293eae","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"action :create do"},{"line_number":15,"context_line":"  info"},{"line_number":16,"context_line":"  ### db2 can only be used with a IBM internal cookbook"},{"line_number":17,"context_line":"  if @db_type \u003d\u003d \u0027db2\u0027"},{"line_number":18,"context_line":"    create_db2(@db_name) # create database"},{"line_number":19,"context_line":"    create_db2_user(@user, @pass, @db_name) # create user"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"5afe65bd_24120c0a","line":16,"updated":"2015-06-04 09:55:13.000000000","message":"a -\u003e an","commit_id":"7f8a00f8902c304f5fef765850bc3c63f0b2d7de"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"a87644252711e628dfa179d577b2468a02e79860","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    # connection to 127.0.0.1:3306 and mysql doesn\u0027t have to listen"},{"line_number":63,"context_line":"    # on 127.0.0.1 but with \u0027localhost\u0027 mysql will be using unix sock"},{"line_number":64,"context_line":"    # to connect to server."},{"line_number":65,"context_line":"    host: \u0027localhost\u0027,"},{"line_number":66,"context_line":"    port: @port.to_i,"},{"line_number":67,"context_line":"    username: @super_user,"},{"line_number":68,"context_line":"    password: @super_password"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"5afe65bd_54fa7e76","line":65,"updated":"2015-06-03 14:44:05.000000000","message":"Humm, don\u0027t like that this is hardcoded in here and hides the existing attribute override. I think if we want this changed, we should change the attribute default here: https://github.com/stackforge/cookbook-openstack-common/blob/master/attributes/database.rb#L74  and that should probably be a separate patch.","commit_id":"7f8a00f8902c304f5fef765850bc3c63f0b2d7de"},{"author":{"_account_id":12323,"name":"JJ Asghar","email":"jjasghar@gmail.com","username":"jj"},"change_message_id":"88927fbd18ad20f365ae501ab5382126cee0158e","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"action :create do"},{"line_number":15,"context_line":"  info"},{"line_number":16,"context_line":"  ### db2 can only be used with an IBM internal cookbook"},{"line_number":17,"context_line":"  if @db_type \u003d\u003d \u0027db2\u0027"},{"line_number":18,"context_line":"    create_db2(@db_name) # create database"},{"line_number":19,"context_line":"    create_db2_user(@user, @pass, @db_name) # create user"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"5afe65bd_38cd7f66","line":16,"updated":"2015-06-04 16:29:33.000000000","message":"So does this mean it shouldn\u0027t be here?","commit_id":"01270f69fb1ab4ecb43417c3238533c0eac9ea69"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"89c61c4454c8f8a2d6b75b384a234daa2e2550dc","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"action :create do"},{"line_number":15,"context_line":"  info"},{"line_number":16,"context_line":"  ### db2 can only be used with an IBM internal cookbook"},{"line_number":17,"context_line":"  if @db_type \u003d\u003d \u0027db2\u0027"},{"line_number":18,"context_line":"    create_db2(@db_name) # create database"},{"line_number":19,"context_line":"    create_db2_user(@user, @pass, @db_name) # create user"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"5afe65bd_0c47244c","line":16,"in_reply_to":"5afe65bd_38cd7f66","updated":"2015-06-04 16:46:16.000000000","message":"Yup, the DB2 cookbook never made it out the door...so I\u0027ll create a bug to clean this up in liberty.\n\nhttps://bugs.launchpad.net/openstack-chef/+bug/1462028","commit_id":"01270f69fb1ab4ecb43417c3238533c0eac9ea69"},{"author":{"_account_id":12323,"name":"JJ Asghar","email":"jjasghar@gmail.com","username":"jj"},"change_message_id":"88927fbd18ad20f365ae501ab5382126cee0158e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  }"},{"line_number":66,"context_line":"end"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"### this db2 resource does only exist in an IBM internal cookbook"},{"line_number":69,"context_line":"def create_db2(db_name)"},{"line_number":70,"context_line":"  db2_database \"create database #{db_name}\" do"},{"line_number":71,"context_line":"    db_name db_name"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"5afe65bd_b8b84fc9","line":68,"updated":"2015-06-04 16:29:33.000000000","message":"So does this mean it shouldn\u0027t be here?","commit_id":"01270f69fb1ab4ecb43417c3238533c0eac9ea69"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"89c61c4454c8f8a2d6b75b384a234daa2e2550dc","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  }"},{"line_number":66,"context_line":"end"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"### this db2 resource does only exist in an IBM internal cookbook"},{"line_number":69,"context_line":"def create_db2(db_name)"},{"line_number":70,"context_line":"  db2_database \"create database #{db_name}\" do"},{"line_number":71,"context_line":"    db_name db_name"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"5afe65bd_6c6b38b8","line":68,"in_reply_to":"5afe65bd_b8b84fc9","updated":"2015-06-04 16:46:16.000000000","message":"see above, to clean up in liberty","commit_id":"01270f69fb1ab4ecb43417c3238533c0eac9ea69"},{"author":{"_account_id":12323,"name":"JJ Asghar","email":"jjasghar@gmail.com","username":"jj"},"change_message_id":"88927fbd18ad20f365ae501ab5382126cee0158e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  end"},{"line_number":74,"context_line":"end"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"### this db2 resource does only exist in an IBM internal cookbook"},{"line_number":77,"context_line":"def create_db2_user(user, pass, db_name)"},{"line_number":78,"context_line":"  db2_user \"create database user #{user}\" do"},{"line_number":79,"context_line":"    db_user user"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"5afe65bd_78ae5782","line":76,"updated":"2015-06-04 16:29:33.000000000","message":"So does this mean it shouldn\u0027t be here?","commit_id":"01270f69fb1ab4ecb43417c3238533c0eac9ea69"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"89c61c4454c8f8a2d6b75b384a234daa2e2550dc","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  end"},{"line_number":74,"context_line":"end"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"### this db2 resource does only exist in an IBM internal cookbook"},{"line_number":77,"context_line":"def create_db2_user(user, pass, db_name)"},{"line_number":78,"context_line":"  db2_user \"create database user #{user}\" do"},{"line_number":79,"context_line":"    db_user user"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"5afe65bd_2c61c0d3","line":76,"in_reply_to":"5afe65bd_78ae5782","updated":"2015-06-04 16:46:16.000000000","message":"see above, to clean up in liberty","commit_id":"01270f69fb1ab4ecb43417c3238533c0eac9ea69"}],"recipes/_openstack_common_database_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"a87644252711e628dfa179d577b2468a02e79860","unresolved":false,"context_lines":[{"line_number":1,"context_line":"## this recipe is just for the spec of the lwrp openstack_common_database"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"openstack_common_database(\u0027service\u0027) do"},{"line_number":4,"context_line":"  user \u0027db_user\u0027"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"5afe65bd_f7304cea","line":1,"updated":"2015-06-03 14:44:05.000000000","message":"usually these are buried under the spec dir as a test cookbook.\n/spec/cookbooks/test-openstack-common-database/recipes/default. And this recipe move into the default recipe for the test cookbook.\n\nthen in the Berks you have this so it can be found:\n\n# Test cookbook for testing database provider:\ncookbook \u0027test-openstack-common-database\u0027, :path \u003d\u003e \u0027spec/cookbooks/test-openstack-common-database\u0027","commit_id":"7f8a00f8902c304f5fef765850bc3c63f0b2d7de"}],"resources/database.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"9edf8af52b0820a6d180ee3c43cf26dfa02273ce","unresolved":false,"context_lines":[{"line_number":1,"context_line":"actions :create"},{"line_number":2,"context_line":"default_action :create"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"attribute :service, kind_of: String, name_attribute: true, required: true"},{"line_number":5,"context_line":"attribute :user, kind_of: String, required: true"},{"line_number":6,"context_line":"attribute :pass, kind_of: String, required: true"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1aca2d91_f0784b2d","line":4,"updated":"2015-05-08 15:49:06.000000000","message":"Since these are mapped to a set of attributes, maybe have list of valid values?\n\nlike for images \n\nkind_of: String, default: \u0027unknown\u0027, equal_to: %w(unknown ami qcow vhd vmdk vdi iso raw)","commit_id":"bb775b6f7248ab44a2facdd7eaf5e78054ae7880"}],"spec/cookbooks/test-openstack-common-database/metadata.rb":[{"author":{"_account_id":12323,"name":"JJ Asghar","email":"jjasghar@gmail.com","username":"jj"},"change_message_id":"88927fbd18ad20f365ae501ab5382126cee0158e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"name \u0027test-openstack-common-database\u0027"},{"line_number":2,"context_line":"maintainer \u0027openstack-chef\u0027"},{"line_number":3,"context_line":"maintainer_email \u0027opscode-chef-openstack@googlegroups.com\u0027"},{"line_number":4,"context_line":"license \u0027Apache 2.0\u0027"},{"line_number":5,"context_line":"description \u0027Test LWRP openstack_common_databse\u0027"},{"line_number":6,"context_line":"version \u00271.0.0\u0027"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"5afe65bd_18d1a3fa","line":3,"updated":"2015-06-04 16:29:33.000000000","message":"We need to change this to something else, not sure what but something.","commit_id":"01270f69fb1ab4ecb43417c3238533c0eac9ea69"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"0f499e8c8dc27546dc85587d52d7f58b9c291196","unresolved":false,"context_lines":[{"line_number":1,"context_line":"name \u0027test-openstack-common-database\u0027"},{"line_number":2,"context_line":"maintainer \u0027openstack-chef\u0027"},{"line_number":3,"context_line":"maintainer_email \u0027opscode-chef-openstack@googlegroups.com\u0027"},{"line_number":4,"context_line":"license \u0027Apache 2.0\u0027"},{"line_number":5,"context_line":"description \u0027Test LWRP openstack_common_databse\u0027"},{"line_number":6,"context_line":"version \u00271.0.0\u0027"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3afb71cf_e21d6667","line":3,"in_reply_to":"3afb71cf_cb8737d6","updated":"2015-06-05 16:03:45.000000000","message":"Yup, I agree, this update should be in separate patch.  Maybe even ask Alan M to include it with the ReadMe updates.","commit_id":"01270f69fb1ab4ecb43417c3238533c0eac9ea69"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"89c61c4454c8f8a2d6b75b384a234daa2e2550dc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"name \u0027test-openstack-common-database\u0027"},{"line_number":2,"context_line":"maintainer \u0027openstack-chef\u0027"},{"line_number":3,"context_line":"maintainer_email \u0027opscode-chef-openstack@googlegroups.com\u0027"},{"line_number":4,"context_line":"license \u0027Apache 2.0\u0027"},{"line_number":5,"context_line":"description \u0027Test LWRP openstack_common_databse\u0027"},{"line_number":6,"context_line":"version \u00271.0.0\u0027"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"5afe65bd_acc810a9","line":3,"in_reply_to":"5afe65bd_18d1a3fa","updated":"2015-06-04 16:46:16.000000000","message":"Need to point to new ML?\n\nhttp://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev","commit_id":"01270f69fb1ab4ecb43417c3238533c0eac9ea69"},{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"2612b7dd5f4e9009d057795b5fc65b0d8bb7546b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"name \u0027test-openstack-common-database\u0027"},{"line_number":2,"context_line":"maintainer \u0027openstack-chef\u0027"},{"line_number":3,"context_line":"maintainer_email \u0027opscode-chef-openstack@googlegroups.com\u0027"},{"line_number":4,"context_line":"license \u0027Apache 2.0\u0027"},{"line_number":5,"context_line":"description \u0027Test LWRP openstack_common_databse\u0027"},{"line_number":6,"context_line":"version \u00271.0.0\u0027"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3afb71cf_cb8737d6","line":3,"in_reply_to":"5afe65bd_a056d1cb","updated":"2015-06-05 10:04:48.000000000","message":"i agree, but we should probably do this in a different patch together with the one in the main metadata file and also for the other cookbooks","commit_id":"01270f69fb1ab4ecb43417c3238533c0eac9ea69"},{"author":{"_account_id":12323,"name":"JJ Asghar","email":"jjasghar@gmail.com","username":"jj"},"change_message_id":"4b31e59ccfba1cf3cd9b36776afe341cebb579bf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"name \u0027test-openstack-common-database\u0027"},{"line_number":2,"context_line":"maintainer \u0027openstack-chef\u0027"},{"line_number":3,"context_line":"maintainer_email \u0027opscode-chef-openstack@googlegroups.com\u0027"},{"line_number":4,"context_line":"license \u0027Apache 2.0\u0027"},{"line_number":5,"context_line":"description \u0027Test LWRP openstack_common_databse\u0027"},{"line_number":6,"context_line":"version \u00271.0.0\u0027"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"5afe65bd_a056d1cb","line":3,"in_reply_to":"5afe65bd_acc810a9","updated":"2015-06-04 18:32:34.000000000","message":"I have no idea. Maybe we could create an openstack list specifically for the cookbooks? https://wiki.openstack.org/wiki/Mailing_Lists#How_to_request_your_own_list","commit_id":"01270f69fb1ab4ecb43417c3238533c0eac9ea69"}]}