)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"24753e94e7208905530df3d62633a64189d0fbaf","unresolved":false,"context_lines":[{"line_number":9,"context_line":"registry_host in glance-api.conf need equal"},{"line_number":10,"context_line":"bind_host in glance-registry.conf"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related-Bug: #1459169"},{"line_number":13,"context_line":"Change-Id: Iff29ea06d7dc3cb51020b06a65d011c307f8e31b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a016987_c077ad00","line":12,"updated":"2015-05-28 14:24:47.000000000","message":"maybe \"Closes-Bug: #\"  instead?","commit_id":"acc7dfcce99c21a834e7926b2d5d6ec792ac2088"},{"author":{"_account_id":6983,"name":"YangLei","email":"iamhappg@aliyun.com","username":"YangLei"},"change_message_id":"dea23b2b4c487836af6e505437541a963142970e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"registry_host in glance-api.conf need equal"},{"line_number":10,"context_line":"bind_host in glance-registry.conf"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related-Bug: #1459169"},{"line_number":13,"context_line":"Change-Id: Iff29ea06d7dc3cb51020b06a65d011c307f8e31b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a016987_98d9175a","line":12,"in_reply_to":"7a016987_c077ad00","updated":"2015-05-29 01:53:48.000000000","message":"done","commit_id":"acc7dfcce99c21a834e7926b2d5d6ec792ac2088"}],"spec/default_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"172c19147ada42c80df9c35bfe9da383d1707042","unresolved":false,"context_lines":[{"line_number":67,"context_line":"      end"},{"line_number":68,"context_line":"    end"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    it \u0027set image-registry host with bind host\u0027 do"},{"line_number":71,"context_line":"      node.setnode[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027bind-host\u0027] \u003d \u0027127.0.0.1\u0027"},{"line_number":72,"context_line":"      expect(chef_run.node[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027image-registry\u0027][\u0027host\u0027]).to eq(\u0027127.0.0.1\u0027)"},{"line_number":73,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"7a016987_5f2cec49","line":70,"updated":"2015-05-27 15:16:38.000000000","message":"Instead of this specific approach, maybe something like the above  59-68 to cover all the component that use bind-host would be better and cleaner.\n\nand would not need the node.set (71) as that is already the default value.","commit_id":"3f7e52acdbd22f16dfc6f211e47264e44d6b7cff"},{"author":{"_account_id":6983,"name":"YangLei","email":"iamhappg@aliyun.com","username":"YangLei"},"change_message_id":"eaefc2c6845f0e6e938f4bc981439867a9dc76c4","unresolved":false,"context_lines":[{"line_number":67,"context_line":"      end"},{"line_number":68,"context_line":"    end"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    it \u0027set image-registry host with bind host\u0027 do"},{"line_number":71,"context_line":"      node.setnode[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027bind-host\u0027] \u003d \u0027127.0.0.1\u0027"},{"line_number":72,"context_line":"      expect(chef_run.node[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027image-registry\u0027][\u0027host\u0027]).to eq(\u0027127.0.0.1\u0027)"},{"line_number":73,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"7a016987_ac09632e","line":70,"in_reply_to":"7a016987_5f2cec49","updated":"2015-05-28 03:04:24.000000000","message":"I just add the unit testcase for the code change in attributes/default.rb in this code review.\nI will submit an other code review to add unit testcase for bind host for all component.(and maybe we need think about adding more unit testcase according to attributes/default.rb.)","commit_id":"3f7e52acdbd22f16dfc6f211e47264e44d6b7cff"}]}