)]}'
{"attributes/database.rb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"87593a691996f273e3f7c1ea5bc3545ebdc67e1f","unresolved":false,"context_lines":[{"line_number":77,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027path\u0027] \u003d nil"},{"line_number":78,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027bind_interface\u0027] \u003d nil"},{"line_number":79,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027enabled_salve\u0027] \u003d false"},{"line_number":80,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027slave_host\u0027] \u003d nil"},{"line_number":81,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027slave_port\u0027] \u003d nil"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# Default database attributes"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a41bdd9_d4465e7a","line":80,"updated":"2015-07-15 02:30:41.000000000","message":"this attribute should have a default value, like 127.0.0.1.","commit_id":"4a5937f8829f8f5ec1687184d8e43fb571ba6c6c"},{"author":{"_account_id":8037,"name":"renminmin","email":"rmm0811@gmail.com","username":"renminmin"},"change_message_id":"2444c51399be4c2c90862cbeb2214382c6667950","unresolved":false,"context_lines":[{"line_number":77,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027path\u0027] \u003d nil"},{"line_number":78,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027bind_interface\u0027] \u003d nil"},{"line_number":79,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027enabled_salve\u0027] \u003d false"},{"line_number":80,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027slave_host\u0027] \u003d nil"},{"line_number":81,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027slave_port\u0027] \u003d nil"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# Default database attributes"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a41bdd9_cc948544","line":80,"in_reply_to":"9a41bdd9_d4465e7a","updated":"2015-07-16 08:26:00.000000000","message":"Done","commit_id":"4a5937f8829f8f5ec1687184d8e43fb571ba6c6c"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"87593a691996f273e3f7c1ea5bc3545ebdc67e1f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027bind_interface\u0027] \u003d nil"},{"line_number":79,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027enabled_salve\u0027] \u003d false"},{"line_number":80,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027slave_host\u0027] \u003d nil"},{"line_number":81,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027slave_port\u0027] \u003d nil"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# Default database attributes"},{"line_number":84,"context_line":"default[\u0027openstack\u0027][\u0027db\u0027][\u0027server_role\u0027] \u003d \u0027os-ops-database\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a41bdd9_14512636","line":81,"updated":"2015-07-15 02:30:41.000000000","message":"this attribute should have a default value, like 3316","commit_id":"4a5937f8829f8f5ec1687184d8e43fb571ba6c6c"},{"author":{"_account_id":8037,"name":"renminmin","email":"rmm0811@gmail.com","username":"renminmin"},"change_message_id":"2444c51399be4c2c90862cbeb2214382c6667950","unresolved":false,"context_lines":[{"line_number":78,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027bind_interface\u0027] \u003d nil"},{"line_number":79,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027enabled_salve\u0027] \u003d false"},{"line_number":80,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027slave_host\u0027] \u003d nil"},{"line_number":81,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027slave_port\u0027] \u003d nil"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# Default database attributes"},{"line_number":84,"context_line":"default[\u0027openstack\u0027][\u0027db\u0027][\u0027server_role\u0027] \u003d \u0027os-ops-database\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a41bdd9_ac97c146","line":81,"in_reply_to":"9a41bdd9_14512636","updated":"2015-07-16 08:26:00.000000000","message":"Done","commit_id":"4a5937f8829f8f5ec1687184d8e43fb571ba6c6c"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"454559442957ef562727db39928f5887de815fe1","unresolved":false,"context_lines":[{"line_number":144,"context_line":"  default[\u0027openstack\u0027][\u0027db\u0027][service][\u0027username\u0027] \u003d project"},{"line_number":145,"context_line":"  default[\u0027openstack\u0027][\u0027db\u0027][service][\u0027options\u0027] \u003d node[\u0027openstack\u0027][\u0027db\u0027][\u0027options\u0027]"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"  if node[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027enabled_salve\u0027]"},{"line_number":148,"context_line":"    default[\u0027openstack\u0027][\u0027db\u0027][service][\u0027slave_host\u0027] \u003d node[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027slave_host\u0027]"},{"line_number":149,"context_line":"    default[\u0027openstack\u0027][\u0027db\u0027][service][\u0027slave_port\u0027] \u003d node[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027slave_port\u0027]"},{"line_number":150,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a41bdd9_b39bd571","line":147,"updated":"2015-07-14 13:39:08.000000000","message":"is this logic really needed?   I don\u0027t think so, it;s already handled in the recipe logic.","commit_id":"4a5937f8829f8f5ec1687184d8e43fb571ba6c6c"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"1af054b0d61e8ad5b2423d3b2921a7a9a2a78e83","unresolved":false,"context_lines":[{"line_number":144,"context_line":"  default[\u0027openstack\u0027][\u0027db\u0027][service][\u0027username\u0027] \u003d project"},{"line_number":145,"context_line":"  default[\u0027openstack\u0027][\u0027db\u0027][service][\u0027options\u0027] \u003d node[\u0027openstack\u0027][\u0027db\u0027][\u0027options\u0027]"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"  if node[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027enabled_salve\u0027]"},{"line_number":148,"context_line":"    default[\u0027openstack\u0027][\u0027db\u0027][service][\u0027slave_host\u0027] \u003d node[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027slave_host\u0027]"},{"line_number":149,"context_line":"    default[\u0027openstack\u0027][\u0027db\u0027][service][\u0027slave_port\u0027] \u003d node[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027slave_port\u0027]"},{"line_number":150,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a41bdd9_45a6be54","line":147,"in_reply_to":"9a41bdd9_8c467d4d","updated":"2015-07-16 14:40:48.000000000","message":"miss communication...I was referring to the \"if\" logic here in the attributes file, I don\u0027t think that is needed, just always have these attributes.","commit_id":"4a5937f8829f8f5ec1687184d8e43fb571ba6c6c"},{"author":{"_account_id":8037,"name":"renminmin","email":"rmm0811@gmail.com","username":"renminmin"},"change_message_id":"2444c51399be4c2c90862cbeb2214382c6667950","unresolved":false,"context_lines":[{"line_number":144,"context_line":"  default[\u0027openstack\u0027][\u0027db\u0027][service][\u0027username\u0027] \u003d project"},{"line_number":145,"context_line":"  default[\u0027openstack\u0027][\u0027db\u0027][service][\u0027options\u0027] \u003d node[\u0027openstack\u0027][\u0027db\u0027][\u0027options\u0027]"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"  if node[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027enabled_salve\u0027]"},{"line_number":148,"context_line":"    default[\u0027openstack\u0027][\u0027db\u0027][service][\u0027slave_host\u0027] \u003d node[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027slave_host\u0027]"},{"line_number":149,"context_line":"    default[\u0027openstack\u0027][\u0027db\u0027][service][\u0027slave_port\u0027] \u003d node[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027slave_port\u0027]"},{"line_number":150,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a41bdd9_8c467d4d","line":147,"in_reply_to":"9a41bdd9_b39bd571","updated":"2015-07-16 08:26:00.000000000","message":"The variable node[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027enabled_salve\u0027] cloud be used as the switch of slave connection enable/disable.\nThis bool variable cloud be used by others openstack components cookbooks. e.g. cookbook-openstack-network cloud decide to get slave connetion url and add the slave_connection config option in neutron config file, if this variable is true.","commit_id":"4a5937f8829f8f5ec1687184d8e43fb571ba6c6c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"47c635298973e575ee0fe5ff0775e57fa121d6fb","unresolved":false,"context_lines":[{"line_number":76,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027port\u0027] \u003d \u00273306\u0027"},{"line_number":77,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027path\u0027] \u003d nil"},{"line_number":78,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027bind_interface\u0027] \u003d nil"},{"line_number":79,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027enabled_slave\u0027] \u003d false"},{"line_number":80,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027slave_host\u0027] \u003d \u0027127.0.0.1\u0027"},{"line_number":81,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027slave_port\u0027] \u003d \u00273316\u0027"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":6,"id":"9a41bdd9_c4e14b9c","line":79,"updated":"2015-07-17 08:02:19.000000000","message":"Calling this attribute \u0027enable_slave\u0027 would look nicer to me.","commit_id":"375cdcde148a827e84b7e8db4bda4a06337834ce"},{"author":{"_account_id":9488,"name":"chenzhiwei","email":"zhiweik@gmail.com","username":"chenzhiwei"},"change_message_id":"66d6bf7d7f007fb1b20c322ac493e5d88325b5b8","unresolved":false,"context_lines":[{"line_number":76,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027port\u0027] \u003d \u00273306\u0027"},{"line_number":77,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027path\u0027] \u003d nil"},{"line_number":78,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027bind_interface\u0027] \u003d nil"},{"line_number":79,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027enabled_slave\u0027] \u003d false"},{"line_number":80,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027slave_host\u0027] \u003d \u0027127.0.0.1\u0027"},{"line_number":81,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027slave_port\u0027] \u003d \u00273316\u0027"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":6,"id":"3a50d1a3_e614af4e","line":79,"in_reply_to":"9a41bdd9_c4e14b9c","updated":"2015-07-30 04:58:12.000000000","message":"Maybe slave_enabled, to keep consist with below two attributes.","commit_id":"375cdcde148a827e84b7e8db4bda4a06337834ce"}],"libraries/endpoints.rb":[{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"c21e9b5fcbc2b16d6adeed38306ccf24845eeb62","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    # Build uri"},{"line_number":88,"context_line":"    case type"},{"line_number":89,"context_line":"    when \u0027mysql\u0027, \u0027postgresql\u0027, \u0027db2\u0027, \u0027ibm_db_sa\u0027"},{"line_number":90,"context_line":"      \"#{type}://#{user}:#{pass}@#{host}:#{port}/#{name}#{options}\""},{"line_number":91,"context_line":"    when \u0027sqlite\u0027"},{"line_number":92,"context_line":"      # SQLite uses filepaths not db name"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"9a41bdd9_06cc60b9","line":89,"updated":"2015-07-16 02:02:41.000000000","message":"host and port don\u0027t take effect for the wrong scope","commit_id":"ba559958ed8c8b6c7805698726a52642a2a38ea8"}],"spec/endpoints_spec.rb":[{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"454559442957ef562727db39928f5887de815fe1","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027enpoints\u0027][\u0027enabled_slave\u0027] \u003d true"},{"line_number":409,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027endpoints\u0027][\u0027slave_host\u0027] \u003d \u0027127.0.0.1\u0027"},{"line_number":410,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027endpoints\u0027][\u0027slave_port\u0027] \u003d \u00273316\u0027"},{"line_number":411,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027compute\u0027][\u0027slave_host\u0027] \u003d \u0027127.0.0.1\u0027"},{"line_number":412,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027compute\u0027][\u0027slave_port\u0027] \u003d \u00273316\u0027"},{"line_number":413,"context_line":"        allow(subject).to receive(:node).and_return(chef_run.node)"},{"line_number":414,"context_line":"        expected \u003d \u0027mysql://user:pass@127.0.0.1:3316/nova?charset\u003dutf8\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a41bdd9_f3c63d48","line":411,"updated":"2015-07-14 13:39:08.000000000","message":"These 2 sets should not be needed right?  they are already handled by the attribute code.","commit_id":"4a5937f8829f8f5ec1687184d8e43fb571ba6c6c"},{"author":{"_account_id":8037,"name":"renminmin","email":"rmm0811@gmail.com","username":"renminmin"},"change_message_id":"2444c51399be4c2c90862cbeb2214382c6667950","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027enpoints\u0027][\u0027enabled_slave\u0027] \u003d true"},{"line_number":409,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027endpoints\u0027][\u0027slave_host\u0027] \u003d \u0027127.0.0.1\u0027"},{"line_number":410,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027endpoints\u0027][\u0027slave_port\u0027] \u003d \u00273316\u0027"},{"line_number":411,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027compute\u0027][\u0027slave_host\u0027] \u003d \u0027127.0.0.1\u0027"},{"line_number":412,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027compute\u0027][\u0027slave_port\u0027] \u003d \u00273316\u0027"},{"line_number":413,"context_line":"        allow(subject).to receive(:node).and_return(chef_run.node)"},{"line_number":414,"context_line":"        expected \u003d \u0027mysql://user:pass@127.0.0.1:3316/nova?charset\u003dutf8\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a41bdd9_e5136963","line":411,"in_reply_to":"9a41bdd9_f3c63d48","updated":"2015-07-16 08:26:00.000000000","message":"Done","commit_id":"4a5937f8829f8f5ec1687184d8e43fb571ba6c6c"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"454559442957ef562727db39928f5887de815fe1","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027enpoints\u0027][\u0027enabled_slave\u0027] \u003d true"},{"line_number":422,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027endpoints\u0027][\u0027slave_host\u0027] \u003d \u0027127.0.0.1\u0027"},{"line_number":423,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027endpoints\u0027][\u0027slave_port\u0027] \u003d \u00273316\u0027"},{"line_number":424,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027block-storage\u0027][\u0027slave_host\u0027] \u003d \u0027127.0.0.1\u0027"},{"line_number":425,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027block-storage\u0027][\u0027slave_port\u0027] \u003d \u00273316\u0027"},{"line_number":426,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027service_type\u0027] \u003d \u0027db2\u0027"},{"line_number":427,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027options\u0027] \u003d { \u0027db2\u0027 \u003d\u003e \u0027?options\u0027 }"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a41bdd9_33eb45b2","line":424,"updated":"2015-07-14 13:39:08.000000000","message":"not needed?","commit_id":"4a5937f8829f8f5ec1687184d8e43fb571ba6c6c"},{"author":{"_account_id":8037,"name":"renminmin","email":"rmm0811@gmail.com","username":"renminmin"},"change_message_id":"2444c51399be4c2c90862cbeb2214382c6667950","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027enpoints\u0027][\u0027enabled_slave\u0027] \u003d true"},{"line_number":422,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027endpoints\u0027][\u0027slave_host\u0027] \u003d \u0027127.0.0.1\u0027"},{"line_number":423,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027endpoints\u0027][\u0027slave_port\u0027] \u003d \u00273316\u0027"},{"line_number":424,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027block-storage\u0027][\u0027slave_host\u0027] \u003d \u0027127.0.0.1\u0027"},{"line_number":425,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027block-storage\u0027][\u0027slave_port\u0027] \u003d \u00273316\u0027"},{"line_number":426,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027service_type\u0027] \u003d \u0027db2\u0027"},{"line_number":427,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027options\u0027] \u003d { \u0027db2\u0027 \u003d\u003e \u0027?options\u0027 }"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a41bdd9_850ffd35","line":424,"in_reply_to":"9a41bdd9_33eb45b2","updated":"2015-07-16 08:26:00.000000000","message":"Done","commit_id":"4a5937f8829f8f5ec1687184d8e43fb571ba6c6c"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"454559442957ef562727db39928f5887de815fe1","unresolved":false,"context_lines":[{"line_number":437,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027enpoints\u0027][\u0027enabled_slave\u0027] \u003d true"},{"line_number":438,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027endpoints\u0027][\u0027slave_host\u0027] \u003d \u0027127.0.0.1\u0027"},{"line_number":439,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027endpoints\u0027][\u0027slave_port\u0027] \u003d \u00273316\u0027"},{"line_number":440,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027image\u0027][\u0027slave_host\u0027] \u003d \u0027127.0.0.1\u0027"},{"line_number":441,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027image\u0027][\u0027slave_port\u0027] \u003d \u00273316\u0027"},{"line_number":442,"context_line":"        allow(subject).to receive(:node).and_return(chef_run.node)"},{"line_number":443,"context_line":"        expected \u003d \u0027mysql://user:pass@127.0.0.1:3316/glance?charset\u003dutf8\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a41bdd9_13ff2168","line":440,"updated":"2015-07-14 13:39:08.000000000","message":"not needed?","commit_id":"4a5937f8829f8f5ec1687184d8e43fb571ba6c6c"},{"author":{"_account_id":8037,"name":"renminmin","email":"rmm0811@gmail.com","username":"renminmin"},"change_message_id":"2444c51399be4c2c90862cbeb2214382c6667950","unresolved":false,"context_lines":[{"line_number":437,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027enpoints\u0027][\u0027enabled_slave\u0027] \u003d true"},{"line_number":438,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027endpoints\u0027][\u0027slave_host\u0027] \u003d \u0027127.0.0.1\u0027"},{"line_number":439,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027endpoints\u0027][\u0027slave_port\u0027] \u003d \u00273316\u0027"},{"line_number":440,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027image\u0027][\u0027slave_host\u0027] \u003d \u0027127.0.0.1\u0027"},{"line_number":441,"context_line":"        node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027image\u0027][\u0027slave_port\u0027] \u003d \u00273316\u0027"},{"line_number":442,"context_line":"        allow(subject).to receive(:node).and_return(chef_run.node)"},{"line_number":443,"context_line":"        expected \u003d \u0027mysql://user:pass@127.0.0.1:3316/glance?charset\u003dutf8\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a41bdd9_a50a4124","line":440,"in_reply_to":"9a41bdd9_13ff2168","updated":"2015-07-16 08:26:00.000000000","message":"Done","commit_id":"4a5937f8829f8f5ec1687184d8e43fb571ba6c6c"},{"author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"change_message_id":"454559442957ef562727db39928f5887de815fe1","unresolved":false,"context_lines":[{"line_number":452,"context_line":"          node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027enpoints\u0027][\u0027enabled_slave\u0027] \u003d true"},{"line_number":453,"context_line":"          node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027endpoints\u0027][\u0027slave_host\u0027] \u003d \u0027127.0.0.1\u0027"},{"line_number":454,"context_line":"          node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027endpoints\u0027][\u0027slave_port\u0027] \u003d \u00273316\u0027"},{"line_number":455,"context_line":"          node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027network\u0027][\u0027slave_host\u0027] \u003d \u0027127.0.0.1\u0027"},{"line_number":456,"context_line":"          node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027network\u0027][\u0027slave_port\u0027] \u003d \u00273316\u0027"},{"line_number":457,"context_line":"          allow(subject).to receive(:node).and_return(chef_run.node)"},{"line_number":458,"context_line":"          expected \u003d \u0027mysql://user:pass@127.0.0.1:3316/neutron?charset\u003dutf8\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a41bdd9_7308ed91","line":455,"updated":"2015-07-14 13:39:08.000000000","message":"not needed?","commit_id":"4a5937f8829f8f5ec1687184d8e43fb571ba6c6c"},{"author":{"_account_id":8037,"name":"renminmin","email":"rmm0811@gmail.com","username":"renminmin"},"change_message_id":"2444c51399be4c2c90862cbeb2214382c6667950","unresolved":false,"context_lines":[{"line_number":452,"context_line":"          node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027enpoints\u0027][\u0027enabled_slave\u0027] \u003d true"},{"line_number":453,"context_line":"          node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027endpoints\u0027][\u0027slave_host\u0027] \u003d \u0027127.0.0.1\u0027"},{"line_number":454,"context_line":"          node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027endpoints\u0027][\u0027slave_port\u0027] \u003d \u00273316\u0027"},{"line_number":455,"context_line":"          node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027network\u0027][\u0027slave_host\u0027] \u003d \u0027127.0.0.1\u0027"},{"line_number":456,"context_line":"          node.set[\u0027openstack\u0027][\u0027db\u0027][\u0027network\u0027][\u0027slave_port\u0027] \u003d \u00273316\u0027"},{"line_number":457,"context_line":"          allow(subject).to receive(:node).and_return(chef_run.node)"},{"line_number":458,"context_line":"          expected \u003d \u0027mysql://user:pass@127.0.0.1:3316/neutron?charset\u003dutf8\u0027"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a41bdd9_45057511","line":455,"in_reply_to":"9a41bdd9_7308ed91","updated":"2015-07-16 08:26:00.000000000","message":"Done","commit_id":"4a5937f8829f8f5ec1687184d8e43fb571ba6c6c"},{"author":{"_account_id":8112,"name":"Ma Wen Cheng","email":"wenchma@cn.ibm.com","username":"wenchma"},"change_message_id":"979b436ff5a8083b157252688fd0733b46cfb905","unresolved":false,"context_lines":[{"line_number":403,"context_line":"          ).to eq(expected)"},{"line_number":404,"context_line":"        end"},{"line_number":405,"context_line":"      end"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"      it \u0027returns compute slave db info hash when service found for default mysql\u0027 do"},{"line_number":408,"context_line":"        node.set[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027db\u0027][\u0027enabled_slave\u0027] \u003d true"},{"line_number":409,"context_line":"        allow(subject).to receive(:node).and_return(chef_run.node)"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"9a41bdd9_3b085b28","line":406,"updated":"2015-07-17 03:01:34.000000000","message":"also have a question: the slave attributes are assigned to [\u0027openstack\u0027][\u0027commom\u0027][\u0027service\u0027], but here only cover compute block-storage, image, and why not other services ?","commit_id":"375cdcde148a827e84b7e8db4bda4a06337834ce"}]}