)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ca7b1871814732da1a1f92615ba5e5856d5322ea","unresolved":false,"context_lines":[{"line_number":9,"context_line":"- corrects the rabbitmq \u0027guest\u0027 user to \u0027openstack\u0027 to allow convergence"},{"line_number":10,"context_line":"- adds yum_clean attribute to conditionally include the yum recipe, removing"},{"line_number":11,"context_line":"  the hardcoded entries from the run lists. This prevents yum.conf from"},{"line_number":12,"context_line":"  showing up on Debian-based machines."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1272bd0b4564097ebac35fe2b28a6e709cc75db4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a30ddce_96e41b0e","line":12,"updated":"2017-03-07 12:29:08.000000000","message":"This doesn\u0027t work for me, i.e. I\u0027m still getting /etc/yum.conf in my tests on Ubuntu with this. Seems to be a bug in the yum cookbook.","commit_id":"275a4f05386e3150734c48ba4c94d4b12b6d2822"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"ba1138aa4f95e53b5f92d5657e46238190dd93d4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"- corrects the rabbitmq \u0027guest\u0027 user to \u0027openstack\u0027 to allow convergence"},{"line_number":10,"context_line":"- adds yum_clean attribute to conditionally include the yum recipe, removing"},{"line_number":11,"context_line":"  the hardcoded entries from the run lists. This prevents yum.conf from"},{"line_number":12,"context_line":"  showing up on Debian-based machines."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1272bd0b4564097ebac35fe2b28a6e709cc75db4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a30ddce_8cede78d","line":12,"in_reply_to":"9a30ddce_96e41b0e","updated":"2017-03-07 14:34:29.000000000","message":"The change was incomplete. See https://review.openstack.org/442521","commit_id":"275a4f05386e3150734c48ba4c94d4b12b6d2822"}],"attributes/default.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ca7b1871814732da1a1f92615ba5e5856d5322ea","unresolved":false,"context_lines":[{"line_number":136,"context_line":"default[\u0027openstack\u0027][\u0027yum\u0027][\u0027rdo_enabled\u0027] \u003d true"},{"line_number":137,"context_line":"default[\u0027openstack\u0027][\u0027yum\u0027][\u0027uri\u0027] \u003d \"http://mirror.centos.org/centos/$releasever/cloud/$basearch/openstack-#{node[\u0027openstack\u0027][\u0027release\u0027]}\""},{"line_number":138,"context_line":"default[\u0027openstack\u0027][\u0027yum\u0027][\u0027repo-key\u0027] \u003d \"https://github.com/redhat-openstack/rdo-release/raw/#{node[\u0027openstack\u0027][\u0027release\u0027]}/RPM-GPG-KEY-CentOS-SIG-Cloud\""},{"line_number":139,"context_line":"# Enforcing GnuPG signature check for RDO repo. Set this to false if you want to disable the check."},{"line_number":140,"context_line":"default[\u0027openstack\u0027][\u0027yum\u0027][\u0027gpgcheck\u0027] \u003d false"},{"line_number":141,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027family\u0027] \u003d \u0027inet\u0027"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9a30ddce_1b3cd492","side":"PARENT","line":139,"updated":"2017-03-07 12:29:08.000000000","message":"This comment doesn\u0027t seem to match what is done in the line below anymore, maybe fix it, while you are in this area?","commit_id":"08521342b1ccf5f89ecf6fca2fd4aff9df84bc32"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"ba1138aa4f95e53b5f92d5657e46238190dd93d4","unresolved":false,"context_lines":[{"line_number":136,"context_line":"default[\u0027openstack\u0027][\u0027yum\u0027][\u0027rdo_enabled\u0027] \u003d true"},{"line_number":137,"context_line":"default[\u0027openstack\u0027][\u0027yum\u0027][\u0027uri\u0027] \u003d \"http://mirror.centos.org/centos/$releasever/cloud/$basearch/openstack-#{node[\u0027openstack\u0027][\u0027release\u0027]}\""},{"line_number":138,"context_line":"default[\u0027openstack\u0027][\u0027yum\u0027][\u0027repo-key\u0027] \u003d \"https://github.com/redhat-openstack/rdo-release/raw/#{node[\u0027openstack\u0027][\u0027release\u0027]}/RPM-GPG-KEY-CentOS-SIG-Cloud\""},{"line_number":139,"context_line":"# Enforcing GnuPG signature check for RDO repo. Set this to false if you want to disable the check."},{"line_number":140,"context_line":"default[\u0027openstack\u0027][\u0027yum\u0027][\u0027gpgcheck\u0027] \u003d false"},{"line_number":141,"context_line":"default[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027family\u0027] \u003d \u0027inet\u0027"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9a30ddce_acb0eb8c","side":"PARENT","line":139,"in_reply_to":"9a30ddce_1b3cd492","updated":"2017-03-07 14:34:29.000000000","message":"Done","commit_id":"08521342b1ccf5f89ecf6fca2fd4aff9df84bc32"}],"attributes/messaging.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ca7b1871814732da1a1f92615ba5e5856d5322ea","unresolved":false,"context_lines":[{"line_number":44,"context_line":"###################################################################"},{"line_number":45,"context_line":"default[\u0027openstack\u0027][\u0027mq\u0027][\u0027server_role\u0027] \u003d \u0027os-ops-messaging\u0027"},{"line_number":46,"context_line":"default[\u0027openstack\u0027][\u0027mq\u0027][\u0027service_type\u0027] \u003d \u0027rabbit\u0027"},{"line_number":47,"context_line":"default[\u0027openstack\u0027][\u0027mq\u0027][\u0027user\u0027] \u003d \u0027openstack\u0027"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"default[\u0027openstack\u0027][\u0027mq\u0027][\u0027vhost\u0027] \u003d \u0027/\u0027"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9a30ddce_560e2335","line":47,"updated":"2017-03-07 12:29:08.000000000","message":"Why does this need to change? I think it will be pretty disruptive to existing installations if you simply modify the default.","commit_id":"275a4f05386e3150734c48ba4c94d4b12b6d2822"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"ba1138aa4f95e53b5f92d5657e46238190dd93d4","unresolved":false,"context_lines":[{"line_number":44,"context_line":"###################################################################"},{"line_number":45,"context_line":"default[\u0027openstack\u0027][\u0027mq\u0027][\u0027server_role\u0027] \u003d \u0027os-ops-messaging\u0027"},{"line_number":46,"context_line":"default[\u0027openstack\u0027][\u0027mq\u0027][\u0027service_type\u0027] \u003d \u0027rabbit\u0027"},{"line_number":47,"context_line":"default[\u0027openstack\u0027][\u0027mq\u0027][\u0027user\u0027] \u003d \u0027openstack\u0027"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"default[\u0027openstack\u0027][\u0027mq\u0027][\u0027vhost\u0027] \u003d \u0027/\u0027"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9a30ddce_57045814","line":47,"in_reply_to":"9a30ddce_560e2335","updated":"2017-03-07 14:34:29.000000000","message":"\u0027guest\u0027 is explicitly deleted in Puppet, as it is less secure than a dedicated user. Though disruptive it is, \u0027guest\u0027 is an anti-pattern.","commit_id":"275a4f05386e3150734c48ba4c94d4b12b6d2822"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ca7b1871814732da1a1f92615ba5e5856d5322ea","unresolved":false,"context_lines":[{"line_number":45,"context_line":"default[\u0027openstack\u0027][\u0027mq\u0027][\u0027server_role\u0027] \u003d \u0027os-ops-messaging\u0027"},{"line_number":46,"context_line":"default[\u0027openstack\u0027][\u0027mq\u0027][\u0027service_type\u0027] \u003d \u0027rabbit\u0027"},{"line_number":47,"context_line":"default[\u0027openstack\u0027][\u0027mq\u0027][\u0027user\u0027] \u003d \u0027openstack\u0027"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"default[\u0027openstack\u0027][\u0027mq\u0027][\u0027vhost\u0027] \u003d \u0027/\u0027"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# defined in oslo/messaging/_drivers/amqp.py"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9a30ddce_5bcf2cb0","line":48,"updated":"2017-03-07 12:29:08.000000000","message":"No need for a blank line here","commit_id":"275a4f05386e3150734c48ba4c94d4b12b6d2822"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"ba1138aa4f95e53b5f92d5657e46238190dd93d4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"default[\u0027openstack\u0027][\u0027mq\u0027][\u0027server_role\u0027] \u003d \u0027os-ops-messaging\u0027"},{"line_number":46,"context_line":"default[\u0027openstack\u0027][\u0027mq\u0027][\u0027service_type\u0027] \u003d \u0027rabbit\u0027"},{"line_number":47,"context_line":"default[\u0027openstack\u0027][\u0027mq\u0027][\u0027user\u0027] \u003d \u0027openstack\u0027"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"default[\u0027openstack\u0027][\u0027mq\u0027][\u0027vhost\u0027] \u003d \u0027/\u0027"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# defined in oslo/messaging/_drivers/amqp.py"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"9a30ddce_77095c2c","line":48,"in_reply_to":"9a30ddce_5bcf2cb0","updated":"2017-03-07 14:34:29.000000000","message":"Done","commit_id":"275a4f05386e3150734c48ba4c94d4b12b6d2822"}]}