)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f608fbb6655850e7192064973713ef82cfa12a84","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  packages are fresh enough"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I7a67ba2520b8e44efec6edd8506f96b0e0dc913b"},{"line_number":20,"context_line":"Depends-On: I37f182f8f3e7715c41e1ed0e0799386766bc8d66"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f2577a7_9402d8b3","line":20,"updated":"2017-09-12 05:56:14.000000000","message":"When you have two changes for the same repo, you usually do not use Depends-On, but just stack them on top of each other in git.","commit_id":"3589bf9b826d82c07e3cbdff1c7f66617217826e"}],"Rakefile":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a1341445e3722fca61b1c29abe9342771e76fab4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"task default: [\"test\"]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"task :test \u003d\u003e [:syntax, :lint, :unit]"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"desc \"Vendor the cookbooks in the Berksfile\""},{"line_number":6,"context_line":"task :berks_prep do"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"5f2577a7_d4e62017","line":3,"updated":"2017-09-12 06:04:39.000000000","message":"IMO this is wrong, lint is the syntax checker for C, so\n\nsyntax, style, unit\n\nwould seem better","commit_id":"3589bf9b826d82c07e3cbdff1c7f66617217826e"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"233405ac576c593fdbee8eee4cbfe17ad83a8bdc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"task default: [\"test\"]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"task :test \u003d\u003e [:syntax, :lint, :unit]"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"desc \"Vendor the cookbooks in the Berksfile\""},{"line_number":6,"context_line":"task :berks_prep do"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"5f2577a7_14002867","line":3,"in_reply_to":"5f2577a7_d4e62017","updated":"2017-09-12 06:38:06.000000000","message":"I\u0027m following the Automate nomenclature here. it\u0027s not arbitrary: https://docs.chef.io/delivery_cli.html#delivery-local","commit_id":"3589bf9b826d82c07e3cbdff1c7f66617217826e"}],"recipes/client.rb":[{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"b39a58c345e6c7fd51f150cb9faa3010ac6a303f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  %w(libffi-devel openssl-devel).each do |pkg|"},{"line_number":29,"context_line":"    package pkg"},{"line_number":30,"context_line":"  end"},{"line_number":31,"context_line":"end"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"python_runtime \u00272\u0027"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"7f287b81_3dd9627e","line":31,"updated":"2017-08-28 14:58:40.000000000","message":"shouldn\u0027t this block be handled like in the other recipes (attributes for platform specific packages ? ) Why are these packages needed and not installed as dependencies ?","commit_id":"f329b718aa991d7ba49c7dbf2ce28b02d8c7fa87"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"0ad32a1bac02d043a2a443f4c19968036af2850d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  %w(libffi-devel openssl-devel).each do |pkg|"},{"line_number":29,"context_line":"    package pkg"},{"line_number":30,"context_line":"  end"},{"line_number":31,"context_line":"end"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"python_runtime \u00272\u0027"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"7f287b81_e8a9d37b","line":31,"in_reply_to":"7f287b81_3dd9627e","updated":"2017-08-28 17:48:15.000000000","message":"this is needed because python-openstackclient is installed via pip. it will attempt to compile and fail if those headers do not exist","commit_id":"f329b718aa991d7ba49c7dbf2ce28b02d8c7fa87"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a1341445e3722fca61b1c29abe9342771e76fab4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# limitations under the License."},{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"package \u0027python-openstackclient\u0027"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"5f2577a7_14ab8889","line":22,"updated":"2017-09-12 06:04:39.000000000","message":"I\u0027m wondering how long it will be true that we can stick with the packaged version. OSC has a bad record when it gets to fixing stable versions.\n\nMaybe better keep both options and a flag to switch?","commit_id":"3589bf9b826d82c07e3cbdff1c7f66617217826e"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"233405ac576c593fdbee8eee4cbfe17ad83a8bdc","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# limitations under the License."},{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"package \u0027python-openstackclient\u0027"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"5f2577a7_547910fa","line":22,"in_reply_to":"5f2577a7_14ab8889","updated":"2017-09-12 06:38:06.000000000","message":"getting poise to behave with both neutron-lbaas-dashboard and python-openstackclient led to this change, with many hours of my spare time fruitlessly wasted trying to prove out a concept where things installed under disparate virtualenvs would coexist.\n\nwhat poise offers and what openstack-from-RDO/UCA provide do not align well, and shouldn\u0027t be expected to completely, if ever, align. if this were a matter of installing openstack entirely through pip, then, yes, poise would be the ideal tool to further extend. as it stands, the less one forces out of poise, the easier it is to work with.\n\nwith the pip-installed method, before this change was made, some eggs wound up in the system python, and some wound up in random virtualenv of chef\u0027s choosing, with nothing working. perhaps the pip incantation can live on as a local recipe. however, I really wasn\u0027t able to make it work with Pike and packaged openstack, so it didn\u0027t seem viable enough to maintain. if packagers are still falling behind even with better automated testing, then we may need to revisit the workaround and see if poise can be contorted against its will","commit_id":"3589bf9b826d82c07e3cbdff1c7f66617217826e"}],"recipes/python.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a1341445e3722fca61b1c29abe9342771e76fab4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# encoding: UTF-8"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Cookbook Name:: openstack-common"},{"line_number":4,"context_line":"# library:: default"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# Copyright 2017 Workday Inc."},{"line_number":7,"context_line":"#"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"5f2577a7_348fa42b","line":4,"updated":"2017-09-12 06:04:39.000000000","message":"Shouldn\u0027t that be \"recipe:: python\"?","commit_id":"3589bf9b826d82c07e3cbdff1c7f66617217826e"},{"author":{"_account_id":14790,"name":"Samuel Cassiba","email":"samuel@cassi.ba","username":"scassiba"},"change_message_id":"004f83e72eb52b0ca8aaeb865ceb8d9e0029e4ee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# encoding: UTF-8"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Cookbook Name:: openstack-common"},{"line_number":4,"context_line":"# library:: default"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# Copyright 2017 Workday Inc."},{"line_number":7,"context_line":"#"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"5f2577a7_f43fdcd3","line":4,"in_reply_to":"5f2577a7_348fa42b","updated":"2017-09-12 06:38:58.000000000","message":"Done","commit_id":"3589bf9b826d82c07e3cbdff1c7f66617217826e"}]}