)]}'
{"libraries/search.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a1af097642d716262742a0b17041248d1873b6cb","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    role_query \u003d \"(chef_environment:#{node.chef_environment} AND roles:#{r})\""},{"line_number":29,"context_line":"    recipe_query \u003d \"(chef_environment:#{node.chef_environment} AND recipes:#{r})\".sub(\u0027::\u0027, \u0027\\:\\:\u0027)"},{"line_number":30,"context_line":"    query \u003d \"#{role_query} OR #{recipe_query}\""},{"line_number":31,"context_line":"    count \u003d 1"},{"line_number":32,"context_line":"    sum \u003d 7"},{"line_number":33,"context_line":"    while count \u003c sum"},{"line_number":34,"context_line":"      resp \u003d search(:node, query, \u0026block)"},{"line_number":35,"context_line":"      break unless resp.nil?"},{"line_number":36,"context_line":"      sleep 2**count"},{"line_number":37,"context_line":"      count +\u003d 1"},{"line_number":38,"context_line":"    end"},{"line_number":39,"context_line":"    resp ? resp : []"},{"line_number":40,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3fa7e38b_9307ff81","side":"PARENT","line":37,"range":{"start_line":31,"start_character":4,"end_line":37,"end_character":16},"updated":"2020-01-06 11:01:01.000000000","message":"I think that this is getting too complicated, would being able to configure the max count be enough?\n\nAlso I don\u0027t see where the speedup for the tests would come from. If the sleep really gets executed with search_sleep\u003dtrue, the tests should be failing when one sets search_sleep\u003dfalse.","commit_id":"d5e2d175cd08ceb2985d8311887f7901847d9bd8"},{"author":{"_account_id":21961,"name":"Lance Albertson","email":"lance@osuosl.org","username":"ramereth"},"change_message_id":"3f357489b5d79cd99121fe5565bf8fcb809dfcc4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    role_query \u003d \"(chef_environment:#{node.chef_environment} AND roles:#{r})\""},{"line_number":29,"context_line":"    recipe_query \u003d \"(chef_environment:#{node.chef_environment} AND recipes:#{r})\".sub(\u0027::\u0027, \u0027\\:\\:\u0027)"},{"line_number":30,"context_line":"    query \u003d \"#{role_query} OR #{recipe_query}\""},{"line_number":31,"context_line":"    count \u003d 1"},{"line_number":32,"context_line":"    sum \u003d 7"},{"line_number":33,"context_line":"    while count \u003c sum"},{"line_number":34,"context_line":"      resp \u003d search(:node, query, \u0026block)"},{"line_number":35,"context_line":"      break unless resp.nil?"},{"line_number":36,"context_line":"      sleep 2**count"},{"line_number":37,"context_line":"      count +\u003d 1"},{"line_number":38,"context_line":"    end"},{"line_number":39,"context_line":"    resp ? resp : []"},{"line_number":40,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3fa7e38b_7eeb2310","side":"PARENT","line":37,"range":{"start_line":31,"start_character":4,"end_line":37,"end_character":16},"in_reply_to":"3fa7e38b_9307ff81","updated":"2020-01-06 19:11:53.000000000","message":"\u003e I think that this is getting too complicated, would being able to\n \u003e configure the max count be enough?\n \nYes, creating an attribute setting the max would be work as well. I\u0027ll make that change.\n\n \u003e Also I don\u0027t see where the speedup for the tests would come from.\n \u003e If the sleep really gets executed with search_sleep\u003dtrue, the tests\n \u003e should be failing when one sets search_sleep\u003dfalse.\n\nThe sleep does gets executed however I don\u0027t think we actually have a test which covers this specific block.","commit_id":"d5e2d175cd08ceb2985d8311887f7901847d9bd8"}],"spec/network_spec.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a1af097642d716262742a0b17041248d1873b6cb","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    describe \u0027#address_for ipv6\u0027 do"},{"line_number":83,"context_line":"      it \u0027returns ipv6 address\u0027 do"},{"line_number":84,"context_line":"        node.override[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027family\u0027] \u003d \u0027inet6\u0027"},{"line_number":85,"context_line":"        expect("},{"line_number":86,"context_line":"          subject.address_for(\u0027lo\u0027)"},{"line_number":87,"context_line":"        ).to eq(\u00272001:db8::1\u0027)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3fa7e38b_b3bd5bb3","line":84,"range":{"start_line":84,"start_character":8,"end_line":84,"end_character":67},"updated":"2020-01-06 11:01:01.000000000","message":"Wouldn\u0027t this need to go into a dedicated context and have it\u0027s own converge call?","commit_id":"7d6a2ec578f88da561f2369d557ab993cac8b1c9"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a1af097642d716262742a0b17041248d1873b6cb","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    describe \u0027bind_address\u0027 do"},{"line_number":109,"context_line":"      describe \u0027mq\u0027 do"},{"line_number":110,"context_line":"        it \u0027returns the host\u0027 do"},{"line_number":111,"context_line":"          node.override[\u0027openstack\u0027][\u0027endpoints\u0027][\u0027family\u0027] \u003d \u0027inet\u0027"},{"line_number":112,"context_line":"          expect("},{"line_number":113,"context_line":"            subject.bind_address(node[\u0027openstack\u0027][\u0027bind_service\u0027][\u0027mq\u0027])"},{"line_number":114,"context_line":"          ).to eq(\u0027127.0.0.1\u0027)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3fa7e38b_d3ba57b8","line":111,"updated":"2020-01-06 11:01:01.000000000","message":"Then you might not need this one, as it should be the default.","commit_id":"7d6a2ec578f88da561f2369d557ab993cac8b1c9"}],"spec/spec_helper.rb":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a1af097642d716262742a0b17041248d1873b6cb","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"UBUNTU_OPTS \u003d {"},{"line_number":12,"context_line":"  platform: \u0027ubuntu\u0027,"},{"line_number":13,"context_line":"  version: \u002716.04\u0027,"},{"line_number":14,"context_line":"}.freeze"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"REDHAT_OPTS \u003d {"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"3fa7e38b_f3cc3363","line":13,"range":{"start_line":13,"start_character":12,"end_line":13,"end_character":17},"updated":"2020-01-06 11:01:01.000000000","message":"This likely should be 18.04 since Rocky.","commit_id":"7d6a2ec578f88da561f2369d557ab993cac8b1c9"}]}